)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"94bc78e16a84b2ee9925467bed95925416139b68","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     raghavendrat \u003craghavendra.tilay@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-07-25 07:13:36 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"HPE 3PAR: Umanaged volumes \u0026 snapshots missing from cinder manageable-list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added below two functions:"},{"line_number":10,"context_line":"get_manageable_volumes()"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"603acdde_5016cdc7","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":74},"updated":"2022-08-02 14:19:54.000000000","message":"The first line should be 50 chars\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"6c72c7575dc7c8075966c6c7ccdb2fa4c6d29844"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"8040cea5e2f4c9ade0af93f12b8328f814c2a9fe","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     raghavendrat \u003craghavendra.tilay@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-07-25 07:13:36 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"HPE 3PAR: Umanaged volumes \u0026 snapshots missing from cinder manageable-list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added below two functions:"},{"line_number":10,"context_line":"get_manageable_volumes()"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"cae37137_89a3a900","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":74},"in_reply_to":"603acdde_5016cdc7","updated":"2022-08-03 11:59:19.000000000","message":"Done","commit_id":"6c72c7575dc7c8075966c6c7ccdb2fa4c6d29844"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3a45177f230a6ff4f1844a8b28aab933399d4558","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"75a1374f_156271b6","updated":"2022-08-02 14:16:58.000000000","message":"Overall looks good, few things noted inline.","commit_id":"6c72c7575dc7c8075966c6c7ccdb2fa4c6d29844"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"de71597dc71cf9db3c6c36263eb5331fa50110ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f3afaa7a_5d873dc8","updated":"2022-08-03 04:10:05.000000000","message":"Thanks Rajat.\nI will work on review comments.\n","commit_id":"6c72c7575dc7c8075966c6c7ccdb2fa4c6d29844"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"6538cf16383af4ee7072c6588d9d85235bab2549","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"86ef68d8_1b8a2dbc","updated":"2022-08-02 12:27:58.000000000","message":"The \"HPE STORAGE CI\" passed on July 25.","commit_id":"6c72c7575dc7c8075966c6c7ccdb2fa4c6d29844"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"99e9b499401d08df555b0ee83cd2bb517dd5c77c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cbbaa4b6_4f2da86e","updated":"2022-07-26 06:42:58.000000000","message":"recheck grenade, tempest-integrated-storage and cinder-plugin-ceph-tempest","commit_id":"6c72c7575dc7c8075966c6c7ccdb2fa4c6d29844"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"8040cea5e2f4c9ade0af93f12b8328f814c2a9fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ac72cc10_903482b0","updated":"2022-08-03 11:59:19.000000000","message":"Addressed comments.","commit_id":"4db6f619ef36ee5f6ada1fcfbd467c43af5a1942"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"59d98d5dd67ac53dd10f1a8e75595ef860180cd3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3d650942_a8af2620","updated":"2022-08-04 06:38:31.000000000","message":"run-HPE Storage CI\n","commit_id":"3f8a3c870b0a5d1a9296325e6af867f309017c58"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"93d743611a886e82de6d0e4d28801832d3feecd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"872d615d_1590b3cd","updated":"2022-08-05 04:40:05.000000000","message":"run-HPE Storage CI\n","commit_id":"3f8a3c870b0a5d1a9296325e6af867f309017c58"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"4e4ac1d346285ad2051200221ba077ea8d1a28f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"134aeb6b_37caac1f","updated":"2022-08-11 07:16:47.000000000","message":"Hi Rajat,\nIf you get time, could you please have a look.\n\nThe HPE STORAGE CI passed on 08aug and Zuul on 10aug.\nThanks.\n","commit_id":"a721158aa1e867ee1cf2eb525b612710cf6731d3"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"9ae31fdc0b80e9c96c383e532fa1b1b0057ac89f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e2f0118a_a37971d2","updated":"2022-08-19 15:53:26.000000000","message":"Thanks.","commit_id":"a721158aa1e867ee1cf2eb525b612710cf6731d3"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"2e7fdc764a6197d49a6d43d6aba650e39d65402b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ba164925_2751ad81","updated":"2022-08-10 09:20:52.000000000","message":"recheck cinder-plugin-ceph-tempest\n","commit_id":"a721158aa1e867ee1cf2eb525b612710cf6731d3"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"550e05164e8ce45ce35c479031124195cdc2893f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b6dea624_438b9d90","updated":"2022-08-10 04:09:51.000000000","message":"recheck tempest-integrated-storage","commit_id":"a721158aa1e867ee1cf2eb525b612710cf6731d3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3729dcde20729636710114c9d6528f75517cb436","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f7c3f331_2404ab13","updated":"2022-09-01 14:37:26.000000000","message":"Code looks good, I\u0027m not happy with the way tests are defined, ddt could condense things and reduce LOC.","commit_id":"7d483ad49e9b438b01e1639664b1d77a74edcf45"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"ff04f230c85d90e32167367010a4574407416ec4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5372f00d_1c1f0719","updated":"2022-09-02 04:51:39.000000000","message":"Thanks Rajat. I will work on review comments.\n","commit_id":"7d483ad49e9b438b01e1639664b1d77a74edcf45"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"7e91b4be821da7381cc5dea22c550b2d01cd6076","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"93c82059_af08bc30","updated":"2022-08-22 11:51:28.000000000","message":"Updated release notes.\n","commit_id":"7d483ad49e9b438b01e1639664b1d77a74edcf45"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"4a87e1dadbe91bef26c2db8a1b7a989f39553e6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9bbdf402_bd8eb23b","updated":"2022-09-06 12:09:53.000000000","message":"Addressed the review comments. Thanks.","commit_id":"c112542cf5471641a47a94c89b9b80dfa14d701d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"81549e9f332a5f9289277ee117b77fa3ffe7f8f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"41fbc45e_1586f1f6","updated":"2022-09-12 16:18:50.000000000","message":"All my comments have been addressed and CI is green. Thanks Raghavendra. LGTM.","commit_id":"c112542cf5471641a47a94c89b9b80dfa14d701d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"840ebd6ca6ed66a2cf57888ce762ff36fddb0b20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"75873258_e62075e1","updated":"2022-09-14 13:38:11.000000000","message":"Code and tests look good; CI is green.","commit_id":"c112542cf5471641a47a94c89b9b80dfa14d701d"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"d4bb0e34ab8266aca4290f7d01b487023e086bc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1a5f4b67_d8a73f46","updated":"2022-09-13 03:42:53.000000000","message":"Thank you Rajat.","commit_id":"c112542cf5471641a47a94c89b9b80dfa14d701d"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"31e8a29161c0b41b291aa2bd5c884ab97dceffb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1b435acc_3738188b","updated":"2022-09-16 04:06:25.000000000","message":"Thanks Rajat \u0026 Brian. The patch got merged.\n","commit_id":"c112542cf5471641a47a94c89b9b80dfa14d701d"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"71e13f68b995a775d7021722438c9fd8537fe01d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"87bb5e94_5a9dcc97","updated":"2022-09-15 03:55:24.000000000","message":"recheck cinder-plugin-ceph-tempest","commit_id":"c112542cf5471641a47a94c89b9b80dfa14d701d"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"71da5a8321cd94d11dfeb89d9e3c73482ef5da2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2673206c_c956c8d1","updated":"2022-09-15 11:43:30.000000000","message":"recheck grenade urllib3.exceptions.ReadTimeoutError","commit_id":"c112542cf5471641a47a94c89b9b80dfa14d701d"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"252df3bc4f58053c7830bc01558c9bc694c20103","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"964021a8_94713191","updated":"2022-09-15 08:38:27.000000000","message":"recheck openstack-tox-py38 TimeoutException","commit_id":"c112542cf5471641a47a94c89b9b80dfa14d701d"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"5ea86d77c5ec8d4bfc1c3f0e75029654b182de44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0f9783f4_84d40a22","updated":"2022-09-07 11:39:30.000000000","message":"run-HPE Storage CI\n","commit_id":"c112542cf5471641a47a94c89b9b80dfa14d701d"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"6c8f470ef3ce7fe75a2e533d1f3c9c884add0bb1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"db1cedf1_3f35c68b","updated":"2022-09-12 05:56:02.000000000","message":"run-HPE Storage CI\n","commit_id":"c112542cf5471641a47a94c89b9b80dfa14d701d"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"3645b38d932c2e9e12935db1f6254931341c7746","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f8a68446_9b2b9429","updated":"2022-09-09 12:47:39.000000000","message":"run-HPE Storage CI\n","commit_id":"c112542cf5471641a47a94c89b9b80dfa14d701d"}],"cinder/tests/unit/volume/drivers/hpe/test_hpe3par.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3729dcde20729636710114c9d6528f75517cb436","unresolved":true,"context_lines":[{"line_number":4900,"context_line":"            mock_client.assert_has_calls(expected_calls)"},{"line_number":4901,"context_line":"            self.assertEqual(expected_output, actual_output)"},{"line_number":4902,"context_line":""},{"line_number":4903,"context_line":"    def test_get_manageable_volumes_1(self):"},{"line_number":4904,"context_line":"        # already managed volume"},{"line_number":4905,"context_line":"        cinder_vol \u003d [self.volume]"},{"line_number":4906,"context_line":"        vol_name \u003d \u0027osv-0DM4qZEVSKON-DXN-NwVpw\u0027"},{"line_number":4907,"context_line":""},{"line_number":4908,"context_line":"        expected_output \u003d ["},{"line_number":4909,"context_line":"            {\u0027reference\u0027: {\u0027name\u0027: vol_name},"},{"line_number":4910,"context_line":"             \u0027size\u0027: 2,"},{"line_number":4911,"context_line":"             \u0027safe_to_manage\u0027: False,"},{"line_number":4912,"context_line":"             \u0027reason_not_safe\u0027: \u0027Already managed\u0027,"},{"line_number":4913,"context_line":"             \u0027cinder_id\u0027: \u0027d03338a9-9115-48a3-8dfc-35cdfcdc15a7\u0027}"},{"line_number":4914,"context_line":"        ]"},{"line_number":4915,"context_line":"        self._test_get_manageable(cinder_vol, expected_output, vol_name)"},{"line_number":4916,"context_line":""},{"line_number":4917,"context_line":"    def test_get_manageable_volumes_2(self):"},{"line_number":4918,"context_line":"        # volume currently not managed; but attached to some other host"},{"line_number":4919,"context_line":"        vol_name \u003d \u0027volume_2\u0027"},{"line_number":4920,"context_line":""},{"line_number":4921,"context_line":"        expected_output \u003d ["},{"line_number":4922,"context_line":"            {\u0027reference\u0027: {\u0027name\u0027: vol_name},"},{"line_number":4923,"context_line":"             \u0027size\u0027: 2,"},{"line_number":4924,"context_line":"             \u0027safe_to_manage\u0027: False,"},{"line_number":4925,"context_line":"             \u0027reason_not_safe\u0027: \u0027Volume attached to host cssosbe02-b04\u0027,"},{"line_number":4926,"context_line":"             \u0027cinder_id\u0027: None}"},{"line_number":4927,"context_line":"        ]"},{"line_number":4928,"context_line":"        self._test_get_manageable([], expected_output, vol_name, attached\u003dTrue)"},{"line_number":4929,"context_line":""},{"line_number":4930,"context_line":"    def test_get_manageable_volumes_3(self):"},{"line_number":4931,"context_line":"        # volume currently not managed"},{"line_number":4932,"context_line":"        vol_name \u003d \u0027volume_2\u0027"},{"line_number":4933,"context_line":""},{"line_number":4934,"context_line":"        expected_output \u003d ["},{"line_number":4935,"context_line":"            {\u0027reference\u0027: {\u0027name\u0027: vol_name},"},{"line_number":4936,"context_line":"             \u0027size\u0027: 2,"},{"line_number":4937,"context_line":"             \u0027safe_to_manage\u0027: True,"},{"line_number":4938,"context_line":"             \u0027reason_not_safe\u0027: None,"},{"line_number":4939,"context_line":"             \u0027cinder_id\u0027: None}"},{"line_number":4940,"context_line":"        ]"},{"line_number":4941,"context_line":"        self._test_get_manageable([], expected_output, vol_name)"},{"line_number":4942,"context_line":""},{"line_number":4943,"context_line":"    def test_get_manageable_snapshots_1(self):"},{"line_number":4944,"context_line":"        # already managed snapshot"},{"line_number":4945,"context_line":"        cinder_snapshot \u003d [self.snapshot_obj]"},{"line_number":4946,"context_line":""},{"line_number":4947,"context_line":"        snap_name \u003d \u0027oss-L4I73ONuTci9Fd4ceij-MQ\u0027"},{"line_number":4948,"context_line":"        vol_name \u003d \u0027osv-CX7Ilh.dQ2.XdNpmqW408A\u0027"},{"line_number":4949,"context_line":""},{"line_number":4950,"context_line":"        expected_output \u003d ["},{"line_number":4951,"context_line":"            {\u0027reference\u0027: {\u0027name\u0027: snap_name},"},{"line_number":4952,"context_line":"             \u0027size\u0027: 2,"},{"line_number":4953,"context_line":"             \u0027safe_to_manage\u0027: False,"},{"line_number":4954,"context_line":"             \u0027reason_not_safe\u0027: \u0027Already managed\u0027,"},{"line_number":4955,"context_line":"             \u0027cinder_id\u0027: \u00272f823bdc-e36e-4dc8-bd15-de1c7a28ff31\u0027,"},{"line_number":4956,"context_line":"             \u0027source_reference\u0027: {\u0027name\u0027: vol_name}}"},{"line_number":4957,"context_line":"        ]"},{"line_number":4958,"context_line":"        self._test_get_manageable(cinder_snapshot, expected_output, vol_name,"},{"line_number":4959,"context_line":"                                  False, snap_name)"},{"line_number":4960,"context_line":""},{"line_number":4961,"context_line":"    def test_get_manageable_snapshots_2(self):"},{"line_number":4962,"context_line":"        # snapshot currently not managed"},{"line_number":4963,"context_line":"        snap_name \u003d \u0027snap_2\u0027"},{"line_number":4964,"context_line":"        vol_name \u003d \u0027volume_2\u0027"},{"line_number":4965,"context_line":""},{"line_number":4966,"context_line":"        expected_output \u003d ["},{"line_number":4967,"context_line":"            {\u0027reference\u0027: {\u0027name\u0027: snap_name},"},{"line_number":4968,"context_line":"             \u0027size\u0027: 2,"},{"line_number":4969,"context_line":"             \u0027safe_to_manage\u0027: True,"},{"line_number":4970,"context_line":"             \u0027reason_not_safe\u0027: None,"},{"line_number":4971,"context_line":"             \u0027cinder_id\u0027: None,"},{"line_number":4972,"context_line":"             \u0027source_reference\u0027: {\u0027name\u0027: vol_name}},"},{"line_number":4973,"context_line":"        ]"},{"line_number":4974,"context_line":"        self._test_get_manageable([], expected_output, vol_name,"},{"line_number":4975,"context_line":"                                  False, snap_name)"},{"line_number":4976,"context_line":""},{"line_number":4977,"context_line":"    @ddt.data(True, False)"},{"line_number":4978,"context_line":"    def test__safe_hostname(self, in_shared):"}],"source_content_type":"text/x-python","patch_set":6,"id":"d222ce50_16b6f5a2","line":4975,"range":{"start_line":4903,"start_character":0,"end_line":4975,"end_character":51},"updated":"2022-09-01 14:37:26.000000000","message":"it would be good to use ddt for these cases rather than defining different tests","commit_id":"7d483ad49e9b438b01e1639664b1d77a74edcf45"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"4a87e1dadbe91bef26c2db8a1b7a989f39553e6d","unresolved":false,"context_lines":[{"line_number":4900,"context_line":"            mock_client.assert_has_calls(expected_calls)"},{"line_number":4901,"context_line":"            self.assertEqual(expected_output, actual_output)"},{"line_number":4902,"context_line":""},{"line_number":4903,"context_line":"    def test_get_manageable_volumes_1(self):"},{"line_number":4904,"context_line":"        # already managed volume"},{"line_number":4905,"context_line":"        cinder_vol \u003d [self.volume]"},{"line_number":4906,"context_line":"        vol_name \u003d \u0027osv-0DM4qZEVSKON-DXN-NwVpw\u0027"},{"line_number":4907,"context_line":""},{"line_number":4908,"context_line":"        expected_output \u003d ["},{"line_number":4909,"context_line":"            {\u0027reference\u0027: {\u0027name\u0027: vol_name},"},{"line_number":4910,"context_line":"             \u0027size\u0027: 2,"},{"line_number":4911,"context_line":"             \u0027safe_to_manage\u0027: False,"},{"line_number":4912,"context_line":"             \u0027reason_not_safe\u0027: \u0027Already managed\u0027,"},{"line_number":4913,"context_line":"             \u0027cinder_id\u0027: \u0027d03338a9-9115-48a3-8dfc-35cdfcdc15a7\u0027}"},{"line_number":4914,"context_line":"        ]"},{"line_number":4915,"context_line":"        self._test_get_manageable(cinder_vol, expected_output, vol_name)"},{"line_number":4916,"context_line":""},{"line_number":4917,"context_line":"    def test_get_manageable_volumes_2(self):"},{"line_number":4918,"context_line":"        # volume currently not managed; but attached to some other host"},{"line_number":4919,"context_line":"        vol_name \u003d \u0027volume_2\u0027"},{"line_number":4920,"context_line":""},{"line_number":4921,"context_line":"        expected_output \u003d ["},{"line_number":4922,"context_line":"            {\u0027reference\u0027: {\u0027name\u0027: vol_name},"},{"line_number":4923,"context_line":"             \u0027size\u0027: 2,"},{"line_number":4924,"context_line":"             \u0027safe_to_manage\u0027: False,"},{"line_number":4925,"context_line":"             \u0027reason_not_safe\u0027: \u0027Volume attached to host cssosbe02-b04\u0027,"},{"line_number":4926,"context_line":"             \u0027cinder_id\u0027: None}"},{"line_number":4927,"context_line":"        ]"},{"line_number":4928,"context_line":"        self._test_get_manageable([], expected_output, vol_name, attached\u003dTrue)"},{"line_number":4929,"context_line":""},{"line_number":4930,"context_line":"    def test_get_manageable_volumes_3(self):"},{"line_number":4931,"context_line":"        # volume currently not managed"},{"line_number":4932,"context_line":"        vol_name \u003d \u0027volume_2\u0027"},{"line_number":4933,"context_line":""},{"line_number":4934,"context_line":"        expected_output \u003d ["},{"line_number":4935,"context_line":"            {\u0027reference\u0027: {\u0027name\u0027: vol_name},"},{"line_number":4936,"context_line":"             \u0027size\u0027: 2,"},{"line_number":4937,"context_line":"             \u0027safe_to_manage\u0027: True,"},{"line_number":4938,"context_line":"             \u0027reason_not_safe\u0027: None,"},{"line_number":4939,"context_line":"             \u0027cinder_id\u0027: None}"},{"line_number":4940,"context_line":"        ]"},{"line_number":4941,"context_line":"        self._test_get_manageable([], expected_output, vol_name)"},{"line_number":4942,"context_line":""},{"line_number":4943,"context_line":"    def test_get_manageable_snapshots_1(self):"},{"line_number":4944,"context_line":"        # already managed snapshot"},{"line_number":4945,"context_line":"        cinder_snapshot \u003d [self.snapshot_obj]"},{"line_number":4946,"context_line":""},{"line_number":4947,"context_line":"        snap_name \u003d \u0027oss-L4I73ONuTci9Fd4ceij-MQ\u0027"},{"line_number":4948,"context_line":"        vol_name \u003d \u0027osv-CX7Ilh.dQ2.XdNpmqW408A\u0027"},{"line_number":4949,"context_line":""},{"line_number":4950,"context_line":"        expected_output \u003d ["},{"line_number":4951,"context_line":"            {\u0027reference\u0027: {\u0027name\u0027: snap_name},"},{"line_number":4952,"context_line":"             \u0027size\u0027: 2,"},{"line_number":4953,"context_line":"             \u0027safe_to_manage\u0027: False,"},{"line_number":4954,"context_line":"             \u0027reason_not_safe\u0027: \u0027Already managed\u0027,"},{"line_number":4955,"context_line":"             \u0027cinder_id\u0027: \u00272f823bdc-e36e-4dc8-bd15-de1c7a28ff31\u0027,"},{"line_number":4956,"context_line":"             \u0027source_reference\u0027: {\u0027name\u0027: vol_name}}"},{"line_number":4957,"context_line":"        ]"},{"line_number":4958,"context_line":"        self._test_get_manageable(cinder_snapshot, expected_output, vol_name,"},{"line_number":4959,"context_line":"                                  False, snap_name)"},{"line_number":4960,"context_line":""},{"line_number":4961,"context_line":"    def test_get_manageable_snapshots_2(self):"},{"line_number":4962,"context_line":"        # snapshot currently not managed"},{"line_number":4963,"context_line":"        snap_name \u003d \u0027snap_2\u0027"},{"line_number":4964,"context_line":"        vol_name \u003d \u0027volume_2\u0027"},{"line_number":4965,"context_line":""},{"line_number":4966,"context_line":"        expected_output \u003d ["},{"line_number":4967,"context_line":"            {\u0027reference\u0027: {\u0027name\u0027: snap_name},"},{"line_number":4968,"context_line":"             \u0027size\u0027: 2,"},{"line_number":4969,"context_line":"             \u0027safe_to_manage\u0027: True,"},{"line_number":4970,"context_line":"             \u0027reason_not_safe\u0027: None,"},{"line_number":4971,"context_line":"             \u0027cinder_id\u0027: None,"},{"line_number":4972,"context_line":"             \u0027source_reference\u0027: {\u0027name\u0027: vol_name}},"},{"line_number":4973,"context_line":"        ]"},{"line_number":4974,"context_line":"        self._test_get_manageable([], expected_output, vol_name,"},{"line_number":4975,"context_line":"                                  False, snap_name)"},{"line_number":4976,"context_line":""},{"line_number":4977,"context_line":"    @ddt.data(True, False)"},{"line_number":4978,"context_line":"    def test__safe_hostname(self, in_shared):"}],"source_content_type":"text/x-python","patch_set":6,"id":"84fc9e38_2b8baebd","line":4975,"range":{"start_line":4903,"start_character":0,"end_line":4975,"end_character":51},"in_reply_to":"d222ce50_16b6f5a2","updated":"2022-09-06 12:09:53.000000000","message":"Done","commit_id":"7d483ad49e9b438b01e1639664b1d77a74edcf45"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"840ebd6ca6ed66a2cf57888ce762ff36fddb0b20","unresolved":true,"context_lines":[{"line_number":4900,"context_line":"            mock_client.assert_has_calls(expected_calls)"},{"line_number":4901,"context_line":"            self.assertEqual(expected_output, actual_output)"},{"line_number":4902,"context_line":""},{"line_number":4903,"context_line":"    # (i) volume already managed"},{"line_number":4904,"context_line":"    # (ii) volume currently not managed; but attached to some other host"},{"line_number":4905,"context_line":"    # (iii) volume currently not managed"},{"line_number":4906,"context_line":"    @ddt.data({\u0027cinder_vol\u0027: [HPE3PARBaseDriver.volume],"},{"line_number":4907,"context_line":"               \u0027vol_name\u0027: \u0027osv-0DM4qZEVSKON-DXN-NwVpw\u0027,"},{"line_number":4908,"context_line":"               \u0027safe\u0027: False,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1896226a_a2c288d0","line":4905,"range":{"start_line":4903,"start_character":0,"end_line":4905,"end_character":40},"updated":"2022-09-14 13:38:11.000000000","message":"Thanks for your comments on the ddt data, it makes it a lot easier to understand what each data set is supposed to test.","commit_id":"c112542cf5471641a47a94c89b9b80dfa14d701d"}],"cinder/volume/drivers/hpe/hpe_3par_common.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3a45177f230a6ff4f1844a8b28aab933399d4558","unresolved":true,"context_lines":[{"line_number":298,"context_line":"        4.0.14 - Added Peer Persistence feature"},{"line_number":299,"context_line":"        4.0.15 - Support duplicated FQDN in network. Bug #1834695"},{"line_number":300,"context_line":"        4.0.16 - In multi host env, fix multi-detach operation. Bug #1958122"},{"line_number":301,"context_line":"        4.0.17 - Added get_manageable_volumes and get_manageable_snapshots ."},{"line_number":302,"context_line":"                 Bug #1819903"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"c8be524e_32851890","line":301,"range":{"start_line":301,"start_character":74,"end_line":301,"end_character":75},"updated":"2022-08-02 14:16:58.000000000","message":"nit: remove space","commit_id":"6c72c7575dc7c8075966c6c7ccdb2fa4c6d29844"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"8040cea5e2f4c9ade0af93f12b8328f814c2a9fe","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        4.0.14 - Added Peer Persistence feature"},{"line_number":299,"context_line":"        4.0.15 - Support duplicated FQDN in network. Bug #1834695"},{"line_number":300,"context_line":"        4.0.16 - In multi host env, fix multi-detach operation. Bug #1958122"},{"line_number":301,"context_line":"        4.0.17 - Added get_manageable_volumes and get_manageable_snapshots ."},{"line_number":302,"context_line":"                 Bug #1819903"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"d3ca39c9_0447ffbd","line":301,"range":{"start_line":301,"start_character":74,"end_line":301,"end_character":75},"in_reply_to":"c8be524e_32851890","updated":"2022-08-03 11:59:19.000000000","message":"Done","commit_id":"6c72c7575dc7c8075966c6c7ccdb2fa4c6d29844"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3a45177f230a6ff4f1844a8b28aab933399d4558","unresolved":true,"context_lines":[{"line_number":1229,"context_line":"                               sort_keys, sort_dirs):"},{"line_number":1230,"context_line":"        already_managed \u003d {}"},{"line_number":1231,"context_line":"        for vol_obj in cinder_volumes:"},{"line_number":1232,"context_line":"            cinder_id \u003d vol_obj[\u0027id\u0027]"},{"line_number":1233,"context_line":"            volume_name \u003d self._get_3par_vol_name(cinder_id)"},{"line_number":1234,"context_line":"            already_managed[volume_name] \u003d cinder_id"},{"line_number":1235,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"b3e16422_cb193994","line":1232,"range":{"start_line":1232,"start_character":24,"end_line":1232,"end_character":37},"updated":"2022-08-02 14:16:58.000000000","message":"since it\u0027s a volume object, we should use vol_obj.id here","commit_id":"6c72c7575dc7c8075966c6c7ccdb2fa4c6d29844"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"8040cea5e2f4c9ade0af93f12b8328f814c2a9fe","unresolved":false,"context_lines":[{"line_number":1229,"context_line":"                               sort_keys, sort_dirs):"},{"line_number":1230,"context_line":"        already_managed \u003d {}"},{"line_number":1231,"context_line":"        for vol_obj in cinder_volumes:"},{"line_number":1232,"context_line":"            cinder_id \u003d vol_obj[\u0027id\u0027]"},{"line_number":1233,"context_line":"            volume_name \u003d self._get_3par_vol_name(cinder_id)"},{"line_number":1234,"context_line":"            already_managed[volume_name] \u003d cinder_id"},{"line_number":1235,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"202b7754_92ea8a90","line":1232,"range":{"start_line":1232,"start_character":24,"end_line":1232,"end_character":37},"in_reply_to":"b3e16422_cb193994","updated":"2022-08-03 11:59:19.000000000","message":"Done","commit_id":"6c72c7575dc7c8075966c6c7ccdb2fa4c6d29844"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3a45177f230a6ff4f1844a8b28aab933399d4558","unresolved":true,"context_lines":[{"line_number":1259,"context_line":"                    \u0027safe_to_manage\u0027: is_safe,"},{"line_number":1260,"context_line":"                    \u0027reason_not_safe\u0027: reason_not_safe,"},{"line_number":1261,"context_line":"                    \u0027cinder_id\u0027: cinder_id,"},{"line_number":1262,"context_line":"                    \u0027extra_info\u0027: None,"},{"line_number":1263,"context_line":"                })"},{"line_number":1264,"context_line":""},{"line_number":1265,"context_line":"        return volume_utils.paginate_entries_list("}],"source_content_type":"text/x-python","patch_set":1,"id":"87d6393f_c16951d8","line":1262,"range":{"start_line":1262,"start_character":20,"end_line":1262,"end_character":39},"updated":"2022-08-02 14:16:58.000000000","message":"Is this needed? any plan to update this? else all entries will have extra_info as None which isn\u0027t useful.","commit_id":"6c72c7575dc7c8075966c6c7ccdb2fa4c6d29844"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"8040cea5e2f4c9ade0af93f12b8328f814c2a9fe","unresolved":false,"context_lines":[{"line_number":1259,"context_line":"                    \u0027safe_to_manage\u0027: is_safe,"},{"line_number":1260,"context_line":"                    \u0027reason_not_safe\u0027: reason_not_safe,"},{"line_number":1261,"context_line":"                    \u0027cinder_id\u0027: cinder_id,"},{"line_number":1262,"context_line":"                    \u0027extra_info\u0027: None,"},{"line_number":1263,"context_line":"                })"},{"line_number":1264,"context_line":""},{"line_number":1265,"context_line":"        return volume_utils.paginate_entries_list("}],"source_content_type":"text/x-python","patch_set":1,"id":"877d5ad7_4963220a","line":1262,"range":{"start_line":1262,"start_character":20,"end_line":1262,"end_character":39},"in_reply_to":"87d6393f_c16951d8","updated":"2022-08-03 11:59:19.000000000","message":"Done","commit_id":"6c72c7575dc7c8075966c6c7ccdb2fa4c6d29844"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3a45177f230a6ff4f1844a8b28aab933399d4558","unresolved":true,"context_lines":[{"line_number":1269,"context_line":"                                 sort_keys, sort_dirs):"},{"line_number":1270,"context_line":"        already_managed \u003d {}"},{"line_number":1271,"context_line":"        for snap_obj in cinder_snapshots:"},{"line_number":1272,"context_line":"            cinder_snap_id \u003d snap_obj[\u0027id\u0027]"},{"line_number":1273,"context_line":"            snap_name \u003d self._get_3par_snap_name(cinder_snap_id)"},{"line_number":1274,"context_line":"            already_managed[snap_name] \u003d cinder_snap_id"},{"line_number":1275,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"61002659_11403555","line":1272,"range":{"start_line":1272,"start_character":29,"end_line":1272,"end_character":43},"updated":"2022-08-02 14:16:58.000000000","message":"snap_obj.id","commit_id":"6c72c7575dc7c8075966c6c7ccdb2fa4c6d29844"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"8040cea5e2f4c9ade0af93f12b8328f814c2a9fe","unresolved":false,"context_lines":[{"line_number":1269,"context_line":"                                 sort_keys, sort_dirs):"},{"line_number":1270,"context_line":"        already_managed \u003d {}"},{"line_number":1271,"context_line":"        for snap_obj in cinder_snapshots:"},{"line_number":1272,"context_line":"            cinder_snap_id \u003d snap_obj[\u0027id\u0027]"},{"line_number":1273,"context_line":"            snap_name \u003d self._get_3par_snap_name(cinder_snap_id)"},{"line_number":1274,"context_line":"            already_managed[snap_name] \u003d cinder_snap_id"},{"line_number":1275,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"cde37611_ebb1ceef","line":1272,"range":{"start_line":1272,"start_character":29,"end_line":1272,"end_character":43},"in_reply_to":"61002659_11403555","updated":"2022-08-03 11:59:19.000000000","message":"Done","commit_id":"6c72c7575dc7c8075966c6c7ccdb2fa4c6d29844"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3a45177f230a6ff4f1844a8b28aab933399d4558","unresolved":true,"context_lines":[{"line_number":1307,"context_line":"                        \u0027safe_to_manage\u0027: is_safe,"},{"line_number":1308,"context_line":"                        \u0027reason_not_safe\u0027: reason_not_safe,"},{"line_number":1309,"context_line":"                        \u0027cinder_id\u0027: cinder_snap_id,"},{"line_number":1310,"context_line":"                        \u0027extra_info\u0027: None,"},{"line_number":1311,"context_line":"                        \u0027source_reference\u0027: {\u0027name\u0027: vol[\u0027name\u0027]},"},{"line_number":1312,"context_line":"                    })"},{"line_number":1313,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"58e1f39a_08d0bb7a","line":1310,"range":{"start_line":1310,"start_character":24,"end_line":1310,"end_character":43},"updated":"2022-08-02 14:16:58.000000000","message":"same, is this needed?","commit_id":"6c72c7575dc7c8075966c6c7ccdb2fa4c6d29844"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"8040cea5e2f4c9ade0af93f12b8328f814c2a9fe","unresolved":false,"context_lines":[{"line_number":1307,"context_line":"                        \u0027safe_to_manage\u0027: is_safe,"},{"line_number":1308,"context_line":"                        \u0027reason_not_safe\u0027: reason_not_safe,"},{"line_number":1309,"context_line":"                        \u0027cinder_id\u0027: cinder_snap_id,"},{"line_number":1310,"context_line":"                        \u0027extra_info\u0027: None,"},{"line_number":1311,"context_line":"                        \u0027source_reference\u0027: {\u0027name\u0027: vol[\u0027name\u0027]},"},{"line_number":1312,"context_line":"                    })"},{"line_number":1313,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ec8da51a_0ee16291","line":1310,"range":{"start_line":1310,"start_character":24,"end_line":1310,"end_character":43},"in_reply_to":"58e1f39a_08d0bb7a","updated":"2022-08-03 11:59:19.000000000","message":"Done","commit_id":"6c72c7575dc7c8075966c6c7ccdb2fa4c6d29844"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3729dcde20729636710114c9d6528f75517cb436","unresolved":true,"context_lines":[{"line_number":1250,"context_line":"                    cinder_id \u003d already_managed[vol_name]"},{"line_number":1251,"context_line":"                else:"},{"line_number":1252,"context_line":"                    # Check if the unmanaged volume is attached to any host"},{"line_number":1253,"context_line":"                    try:"},{"line_number":1254,"context_line":"                        vlun \u003d self.client.getVLUN(vol_name)"},{"line_number":1255,"context_line":"                        hostname \u003d vlun[\u0027hostname\u0027]"},{"line_number":1256,"context_line":"                        is_safe \u003d False"},{"line_number":1257,"context_line":"                        reason_not_safe \u003d \u0027Volume attached to host \u0027 + hostname"},{"line_number":1258,"context_line":"                        cinder_id \u003d None"},{"line_number":1259,"context_line":"                    except hpe3parclient.exceptions.HTTPNotFound:"},{"line_number":1260,"context_line":"                        # not attached to any host"},{"line_number":1261,"context_line":"                        is_safe \u003d True"},{"line_number":1262,"context_line":"                        reason_not_safe \u003d None"},{"line_number":1263,"context_line":"                        cinder_id \u003d None"},{"line_number":1264,"context_line":""},{"line_number":1265,"context_line":"                manageable_vols.append({"},{"line_number":1266,"context_line":"                    \u0027reference\u0027: {\u0027name\u0027: vol_name},"}],"source_content_type":"text/x-python","patch_set":6,"id":"58736769_b287fcc0","line":1263,"range":{"start_line":1253,"start_character":20,"end_line":1263,"end_character":40},"updated":"2022-09-01 14:37:26.000000000","message":"I\u0027m not really a fan of using try except as if else blocks but won\u0027t block for this\nI would suggest something like\n\n    is_safe \u003d False\n    hostname \u003d None\n    cinder_id \u003d None\n    try:\n        vlun \u003d self.client.getVLUN(vol_name)\n        hostname \u003d vlun[\u0027hostname\u0027]\n    except hpe3parclient.exceptions.HTTPNotFound:\n        is_safe \u003d True\n    if is_safe:\n        reason_not_safe \u003d None\n    else:\n        reason_not_safe \u003d \u0027Volume attached to host \u0027 + hostname","commit_id":"7d483ad49e9b438b01e1639664b1d77a74edcf45"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"4a87e1dadbe91bef26c2db8a1b7a989f39553e6d","unresolved":false,"context_lines":[{"line_number":1250,"context_line":"                    cinder_id \u003d already_managed[vol_name]"},{"line_number":1251,"context_line":"                else:"},{"line_number":1252,"context_line":"                    # Check if the unmanaged volume is attached to any host"},{"line_number":1253,"context_line":"                    try:"},{"line_number":1254,"context_line":"                        vlun \u003d self.client.getVLUN(vol_name)"},{"line_number":1255,"context_line":"                        hostname \u003d vlun[\u0027hostname\u0027]"},{"line_number":1256,"context_line":"                        is_safe \u003d False"},{"line_number":1257,"context_line":"                        reason_not_safe \u003d \u0027Volume attached to host \u0027 + hostname"},{"line_number":1258,"context_line":"                        cinder_id \u003d None"},{"line_number":1259,"context_line":"                    except hpe3parclient.exceptions.HTTPNotFound:"},{"line_number":1260,"context_line":"                        # not attached to any host"},{"line_number":1261,"context_line":"                        is_safe \u003d True"},{"line_number":1262,"context_line":"                        reason_not_safe \u003d None"},{"line_number":1263,"context_line":"                        cinder_id \u003d None"},{"line_number":1264,"context_line":""},{"line_number":1265,"context_line":"                manageable_vols.append({"},{"line_number":1266,"context_line":"                    \u0027reference\u0027: {\u0027name\u0027: vol_name},"}],"source_content_type":"text/x-python","patch_set":6,"id":"e5236c81_22a9026d","line":1263,"range":{"start_line":1253,"start_character":20,"end_line":1263,"end_character":40},"in_reply_to":"58736769_b287fcc0","updated":"2022-09-06 12:09:53.000000000","message":"Done","commit_id":"7d483ad49e9b438b01e1639664b1d77a74edcf45"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3729dcde20729636710114c9d6528f75517cb436","unresolved":true,"context_lines":[{"line_number":1298,"context_line":"            size_gb \u003d int(vol[\u0027sizeMiB\u0027] / 1024)"},{"line_number":1299,"context_line":"            snapshots \u003d self.client.getSnapshotsOfVolume(cinder_cpg,"},{"line_number":1300,"context_line":"                                                         vol[\u0027name\u0027])"},{"line_number":1301,"context_line":"            if snapshots:"},{"line_number":1302,"context_line":"                for snap_name in snapshots:"},{"line_number":1303,"context_line":"                    if snap_name in already_managed:"},{"line_number":1304,"context_line":"                        is_safe \u003d False"}],"source_content_type":"text/x-python","patch_set":6,"id":"ec30d991_25e18c02","line":1301,"range":{"start_line":1301,"start_character":12,"end_line":1301,"end_character":25},"updated":"2022-09-01 14:37:26.000000000","message":"this is not needed, if snapshots is an empty list, the for loop on next line will never run","commit_id":"7d483ad49e9b438b01e1639664b1d77a74edcf45"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"4a87e1dadbe91bef26c2db8a1b7a989f39553e6d","unresolved":false,"context_lines":[{"line_number":1298,"context_line":"            size_gb \u003d int(vol[\u0027sizeMiB\u0027] / 1024)"},{"line_number":1299,"context_line":"            snapshots \u003d self.client.getSnapshotsOfVolume(cinder_cpg,"},{"line_number":1300,"context_line":"                                                         vol[\u0027name\u0027])"},{"line_number":1301,"context_line":"            if snapshots:"},{"line_number":1302,"context_line":"                for snap_name in snapshots:"},{"line_number":1303,"context_line":"                    if snap_name in already_managed:"},{"line_number":1304,"context_line":"                        is_safe \u003d False"}],"source_content_type":"text/x-python","patch_set":6,"id":"e3e9e2f0_02ed7a5d","line":1301,"range":{"start_line":1301,"start_character":12,"end_line":1301,"end_character":25},"in_reply_to":"ec30d991_25e18c02","updated":"2022-09-06 12:09:53.000000000","message":"Done","commit_id":"7d483ad49e9b438b01e1639664b1d77a74edcf45"}],"releasenotes/notes/hpe-3par-add-get-manageable-2926f21116c98599.yaml":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3a45177f230a6ff4f1844a8b28aab933399d4558","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0dc07f8b_42aceeb3","line":6,"updated":"2022-08-02 14:16:58.000000000","message":"I think we also require a features section here since the 3par driver didn\u0027t support showing manageable volumes and snapshots which it supports now.","commit_id":"6c72c7575dc7c8075966c6c7ccdb2fa4c6d29844"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"8040cea5e2f4c9ade0af93f12b8328f814c2a9fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c7e36c3e_349a2ee9","line":6,"in_reply_to":"0dc07f8b_42aceeb3","updated":"2022-08-03 11:59:19.000000000","message":"Done","commit_id":"6c72c7575dc7c8075966c6c7ccdb2fa4c6d29844"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ef4dd9b95742cc12091a69833b79e2ed2e3d0636","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    HPE 3PAR driver `Bug #1819903 \u003chttps://bugs.launchpad.net/cinder/+bug/1819903\u003e`_:"},{"line_number":5,"context_line":"    Fixed: umanaged volumes \u0026 snapshots missing from cinder manageable-list."},{"line_number":6,"context_line":"features:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    HPE 3PAR driver: Added support to display manageable volumes \u0026 snapshots."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"26643a8e_27070f16","line":8,"range":{"start_line":6,"start_character":0,"end_line":8,"end_character":77},"updated":"2022-08-19 14:29:33.000000000","message":"I discussed this with Brian and Eric and the consensus is inclined to consider it as a bugfix.\nAlthough it is a new functionality from driver end, it can be seen as a missing implementation while implementing manage/unmanage code. Also in the base driver, it returns an empty list so from user perspective, it can be considered a bugfix to show correct list of volumes/snapshots that can be managed.\nIn summary, I would suggest removing this now so we can also backport it if needed.","commit_id":"a721158aa1e867ee1cf2eb525b612710cf6731d3"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"7e91b4be821da7381cc5dea22c550b2d01cd6076","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    HPE 3PAR driver `Bug #1819903 \u003chttps://bugs.launchpad.net/cinder/+bug/1819903\u003e`_:"},{"line_number":5,"context_line":"    Fixed: umanaged volumes \u0026 snapshots missing from cinder manageable-list."},{"line_number":6,"context_line":"features:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    HPE 3PAR driver: Added support to display manageable volumes \u0026 snapshots."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d2f1979c_f01a1aaa","line":8,"range":{"start_line":6,"start_character":0,"end_line":8,"end_character":77},"in_reply_to":"26643a8e_27070f16","updated":"2022-08-22 11:51:28.000000000","message":"Done","commit_id":"a721158aa1e867ee1cf2eb525b612710cf6731d3"}]}