)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"277ed9163f551609195d2fce587ae03ce7d12e5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f9ba4721_3606f305","updated":"2022-07-27 19:09:54.000000000","message":"See prior review at:\n    https://review.opendev.org/c/openstack/cinder/+/797608","commit_id":"c1444bc3ad575ba21e54bd0c58279622fb279d23"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"3371a7c7120be5b72fbb495cc2e756fedca9b224","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d268d36f_205cd004","updated":"2022-07-27 20:56:04.000000000","message":"run-DellEMC PowerStore CI","commit_id":"c1444bc3ad575ba21e54bd0c58279622fb279d23"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"302ee90ef0310072ddc0649dd1f3b0c131793265","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"01379fad_9a464f66","updated":"2022-07-28 06:56:16.000000000","message":"run-DellEMC PowerStore CI","commit_id":"fb44d8d87170fd7b0fa48a9daebcc61fac6e9d04"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"851bb4926b37fb37b645ac2cd354caa5a294343e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a450f39f_d1e5612c","updated":"2022-07-29 09:06:34.000000000","message":"I discussed this with Alexander on IRC, they have a conflict with their CIs due to which if they update a patchset, the CI won\u0027t respond here. Given the situation and upcoming deadline, I\u0027m OK if my comments get addressed in a followup.","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"63556007c18073b39164d1c8148ba901f61ffaae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e2c0bb28_39d4d8b4","updated":"2022-07-29 14:27:35.000000000","message":"I\u0027m OK with all the changes given the comments will be addressed in a followup due to the CI issue.\nThe last run of CI was successful\nBuild succeed.\nDellEMC_PowerStore_NFS https://elab-os-logsrv.delllabs.net/49/851249/5/check/DellEMC_PowerStore_NFS/f4e282d/DellEMC_PowerStore_NFS/192 : SUCCESS in 1h 18m 44s\n\nLGTM.","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8af615ab50a6324accc7a86d4caa5189c3a75597","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9693efb0_5dc6f3e6","updated":"2022-07-29 07:50:31.000000000","message":"Since this driver supports both raw and qcow2 volumes, we should handle the case in extend and pass file format.","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"c6b419ddd7ca9e8bb366ae970740d21e1adc1e06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"20c9f082_98818cd8","updated":"2022-07-29 14:12:05.000000000","message":"Sounds good to me!","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"67f8a7c3dcea741cf35a6dbf81d63e9f6c66ab24","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f123930c_d26b2c5e","updated":"2022-07-28 21:31:38.000000000","message":"Thank you for working on this!\nThe driver looks good to me, I have some minimal comments. \n\n:-1: mypy, but I think you can add them in a follow up.","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"93e5fa64f08720ba658dc0caf91db66847500611","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"29fa3eb4_57cb9ed2","updated":"2022-07-28 19:32:09.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"d9c519eec544c52b6895af2630756340c9b58785","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"95847884_1694ac38","updated":"2022-07-29 08:42:55.000000000","message":"the need for a followup","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"a5401b74cf005cabd9b1f59f5cfcee221062a786","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9ba6a8ff_16c3cecd","in_reply_to":"95847884_1694ac38","updated":"2022-07-29 09:01:59.000000000","message":"We have a block in a CI team with powerstore nvme_otcp driver.","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"7540f9a6ec9c29178c330ad6c894e6e1360c4a10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1f98f8f6_13bfa1dd","in_reply_to":"9693efb0_5dc6f3e6","updated":"2022-07-29 08:43:46.000000000","message":"Thanks for comments! I will update your comments in a follow up","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"0ea406c3a7ca1453a080e03892c895913ca40867","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"16ec8718_1905d2c0","in_reply_to":"f123930c_d26b2c5e","updated":"2022-07-29 07:38:32.000000000","message":"Sofia, thanks for the comments!\nAs today is the last day of the driver freeze deadline, I am ready to correct all comments in the follow up patch.","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"}],"cinder/volume/drivers/dell_emc/powerstore/nfs.py":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"67f8a7c3dcea741cf35a6dbf81d63e9f6c66ab24","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2020 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"8a5ac733_36972d52","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2022-07-28 21:31:38.000000000","message":":nit: just a question, shouldn\u0027t this be 2021?","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"0ea406c3a7ca1453a080e03892c895913ca40867","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2020 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"ca3ce6c0_b338f201","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"8a5ac733_36972d52","updated":"2022-07-29 07:38:32.000000000","message":"in our other drivers 2020, but I will update this information.","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"67f8a7c3dcea741cf35a6dbf81d63e9f6c66ab24","unresolved":true,"context_lines":[{"line_number":27,"context_line":"from cinder.image import image_utils"},{"line_number":28,"context_line":"from cinder import interface"},{"line_number":29,"context_line":"from cinder.volume import configuration"},{"line_number":30,"context_line":"from cinder.volume.drivers.nfs import nfs_opts"},{"line_number":31,"context_line":"from cinder.volume.drivers.nfs import NfsDriver"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":5,"id":"2b4acfb2_5d99dfd7","line":31,"range":{"start_line":30,"start_character":0,"end_line":31,"end_character":47},"updated":"2022-07-28 21:31:38.000000000","message":":nit: why not just importing in the same line?","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8af615ab50a6324accc7a86d4caa5189c3a75597","unresolved":true,"context_lines":[{"line_number":28,"context_line":"from cinder import interface"},{"line_number":29,"context_line":"from cinder.volume import configuration"},{"line_number":30,"context_line":"from cinder.volume.drivers.nfs import nfs_opts"},{"line_number":31,"context_line":"from cinder.volume.drivers.nfs import NfsDriver"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":5,"id":"45a7cf84_40989fe0","line":31,"range":{"start_line":31,"start_character":38,"end_line":31,"end_character":47},"updated":"2022-07-29 07:50:31.000000000","message":"we don\u0027t import classes but modules, this should be\nfrom cinder.volume.drivers import nfs","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"6735590df5769fb08e7dea4a70b9ea93df5d4f9d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from cinder.image import image_utils"},{"line_number":28,"context_line":"from cinder import interface"},{"line_number":29,"context_line":"from cinder.volume import configuration"},{"line_number":30,"context_line":"from cinder.volume.drivers.nfs import nfs_opts"},{"line_number":31,"context_line":"from cinder.volume.drivers.nfs import NfsDriver"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":5,"id":"19baa5b3_92fb290a","line":31,"range":{"start_line":30,"start_character":0,"end_line":31,"end_character":47},"in_reply_to":"2b4acfb2_5d99dfd7","updated":"2022-07-28 21:41:37.000000000","message":"Done\nAll the drivers do it in this way","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8af615ab50a6324accc7a86d4caa5189c3a75597","unresolved":true,"context_lines":[{"line_number":38,"context_line":"CONF.register_opts(nfs_opts, group\u003dconfiguration.SHARED_CONF_GROUP)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class PowerStoreNFSDriverInitialization(NfsDriver):"},{"line_number":42,"context_line":"    \"\"\"Implementation of PowerStoreNFSDriver initialization."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    Added multiattach support option and checking that the required"}],"source_content_type":"text/x-python","patch_set":5,"id":"c229f437_316e5208","line":41,"range":{"start_line":41,"start_character":40,"end_line":41,"end_character":49},"updated":"2022-07-29 07:50:31.000000000","message":"after making the import change, this will be nfs.NfsDriver","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8af615ab50a6324accc7a86d4caa5189c3a75597","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    Added multiattach support option and checking that the required"},{"line_number":45,"context_line":"    packages are installed."},{"line_number":46,"context_line":"    \"\"\""},{"line_number":47,"context_line":"    driver_volume_type \u003d \u0027nfs\u0027"},{"line_number":48,"context_line":"    driver_prefix \u003d \u0027nfs\u0027"},{"line_number":49,"context_line":"    volume_backend_name \u003d \u0027PowerStore_NFS\u0027"},{"line_number":50,"context_line":"    VERSION \u003d \u00271.0.0\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"3802449a_85546c84","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":22},"updated":"2022-07-29 07:50:31.000000000","message":"nit: constants should be uppercase, just a standard we follow in our code","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"67f8a7c3dcea741cf35a6dbf81d63e9f6c66ab24","unresolved":true,"context_lines":[{"line_number":102,"context_line":"    \"\"\""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @coordination.synchronized(\u0027{self.driver_prefix}-{volume[id]}\u0027)"},{"line_number":105,"context_line":"    def delete_volume(self, volume):"},{"line_number":106,"context_line":"        \"\"\"Deletes a logical volume.\"\"\""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        if not volume.provider_location:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fb00c466_1517ec15","line":105,"range":{"start_line":105,"start_character":8,"end_line":105,"end_character":21},"updated":"2022-07-28 21:31:38.000000000","message":":nit: I don\u0027t see any significant change from the one in NfsDriver.","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"0ea406c3a7ca1453a080e03892c895913ca40867","unresolved":true,"context_lines":[{"line_number":102,"context_line":"    \"\"\""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @coordination.synchronized(\u0027{self.driver_prefix}-{volume[id]}\u0027)"},{"line_number":105,"context_line":"    def delete_volume(self, volume):"},{"line_number":106,"context_line":"        \"\"\"Deletes a logical volume.\"\"\""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        if not volume.provider_location:"}],"source_content_type":"text/x-python","patch_set":5,"id":"b1ef4072_54a35b5a","line":105,"range":{"start_line":105,"start_character":8,"end_line":105,"end_character":21},"in_reply_to":"fb00c466_1517ec15","updated":"2022-07-29 07:38:32.000000000","message":"when I developed the driver there were cases when removing the volume were snapshots in a system and not registered in cinder and unlike the basic implementation I remove the snapshot if it exist in the system.","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"67f8a7c3dcea741cf35a6dbf81d63e9f6c66ab24","unresolved":true,"context_lines":[{"line_number":124,"context_line":"        base_volume_path \u003d self._local_path_volume(volume)"},{"line_number":125,"context_line":"        self._delete(base_volume_path)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def extend_volume(self, volume, new_size):"},{"line_number":128,"context_line":"        \"\"\"Extend an existing volume to the new size.\"\"\""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        if self._is_volume_attached(volume):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1eb0d2c4_34fd53dc","line":127,"range":{"start_line":127,"start_character":8,"end_line":127,"end_character":21},"updated":"2022-07-28 21:31:38.000000000","message":":nit: I don\u0027t see any significant change from the one in NfsDriver.","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"0ea406c3a7ca1453a080e03892c895913ca40867","unresolved":true,"context_lines":[{"line_number":124,"context_line":"        base_volume_path \u003d self._local_path_volume(volume)"},{"line_number":125,"context_line":"        self._delete(base_volume_path)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def extend_volume(self, volume, new_size):"},{"line_number":128,"context_line":"        \"\"\"Extend an existing volume to the new size.\"\"\""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        if self._is_volume_attached(volume):"}],"source_content_type":"text/x-python","patch_set":5,"id":"49143231_e91dfaa1","line":127,"range":{"start_line":127,"start_character":8,"end_line":127,"end_character":21},"in_reply_to":"1eb0d2c4_34fd53dc","updated":"2022-07-29 07:38:32.000000000","message":"agree, i will remove in follow up patch.","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8af615ab50a6324accc7a86d4caa5189c3a75597","unresolved":true,"context_lines":[{"line_number":149,"context_line":"            msg \u003d _(\"Unrecognized backing format: %s\") % backing_fmt"},{"line_number":150,"context_line":"            raise exception.InvalidVolume(msg)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        image_utils.resize_image(path, new_size)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def _do_fast_clone_file(self, volume_path, new_volume_path):"},{"line_number":155,"context_line":"        \"\"\"Fast clone a file using a dellfcopy package.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"066f2e87_14f13edb","line":152,"range":{"start_line":152,"start_character":8,"end_line":152,"end_character":48},"updated":"2022-07-29 07:50:31.000000000","message":"-1: we\u0027ve a known issue when we are using a raw volume and nova/glance writes a qcow2 file in it, cinder assumes it\u0027s a qcow2 volume (because of the qcow2 header of image file in the raw volume)\nwe pass file_format to this call telling cinder if the volume we\u0027re extending is raw or qcow2 and extend accordingly\nSee [1] for changes to fetch the file format from volume admin metadata\n\n[1] https://review.opendev.org/c/openstack/cinder/+/761152/12/cinder/volume/drivers/netapp/dataontap/nfs_base.py","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"67f8a7c3dcea741cf35a6dbf81d63e9f6c66ab24","unresolved":true,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        LOG.debug(\"Creating volume %(vol)s from snapshot %(snap)s\","},{"line_number":171,"context_line":"                  {\u0027vol\u0027: volume.name_id, \u0027snap\u0027: snapshot.id})"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        volume.provider_location \u003d self._find_share(volume)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        self._copy_volume_from_snapshot(snapshot, volume, volume.size)"}],"source_content_type":"text/x-python","patch_set":5,"id":"959fc018_fe9ce3d2","line":172,"updated":"2022-07-28 21:31:38.000000000","message":":-1: What about adding acceptable_states? You can create a volume from an error snapshot.","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f250261927a207cdf22104879ca55fab19fecb3c","unresolved":true,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        LOG.debug(\"Creating volume %(vol)s from snapshot %(snap)s\","},{"line_number":171,"context_line":"                  {\u0027vol\u0027: volume.name_id, \u0027snap\u0027: snapshot.id})"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        volume.provider_location \u003d self._find_share(volume)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        self._copy_volume_from_snapshot(snapshot, volume, volume.size)"}],"source_content_type":"text/x-python","patch_set":5,"id":"edff96ae_236788ac","line":172,"in_reply_to":"959fc018_fe9ce3d2","updated":"2022-07-28 21:59:35.000000000","message":"The API won\u0027t allow creating a volume from a snapshot in \"error\" state.","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"67f8a7c3dcea741cf35a6dbf81d63e9f6c66ab24","unresolved":true,"context_lines":[{"line_number":193,"context_line":"        img_info \u003d self._qemu_img_info(forward_path, snapshot.volume.name)"},{"line_number":194,"context_line":"        path_to_snap_img \u003d os.path.join(vol_path, img_info.backing_file)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        path_to_new_vol \u003d self._local_path_volume(volume)"},{"line_number":197,"context_line":"        if img_info.backing_file_format \u003d\u003d \u0027raw\u0027:"},{"line_number":198,"context_line":"            image_utils.convert_image(path_to_snap_img,"},{"line_number":199,"context_line":"                                      path_to_new_vol,"}],"source_content_type":"text/x-python","patch_set":5,"id":"903d85b8_fc874c81","line":196,"range":{"start_line":196,"start_character":0,"end_line":196,"end_character":9},"updated":"2022-07-28 21:31:38.000000000","message":":nit: Sorry for this question but I wasn\u0027t able to find the tests run by Tempest  in  https://elab-os-logsrv.delllabs.net/49/851249/4/check/DellEMC_PowerStore_NFS/3d7d6cc/DellEMC_PowerStore_NFS/188/logs/tempest.txt.gz\n\nI think this could raise an error since the file doesn\u0027t exist yet. I think (please correct me if I\u0027m wrong) that self._do_create_volume(volume) needs to be called before calling this method.","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"0ea406c3a7ca1453a080e03892c895913ca40867","unresolved":true,"context_lines":[{"line_number":193,"context_line":"        img_info \u003d self._qemu_img_info(forward_path, snapshot.volume.name)"},{"line_number":194,"context_line":"        path_to_snap_img \u003d os.path.join(vol_path, img_info.backing_file)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        path_to_new_vol \u003d self._local_path_volume(volume)"},{"line_number":197,"context_line":"        if img_info.backing_file_format \u003d\u003d \u0027raw\u0027:"},{"line_number":198,"context_line":"            image_utils.convert_image(path_to_snap_img,"},{"line_number":199,"context_line":"                                      path_to_new_vol,"}],"source_content_type":"text/x-python","patch_set":5,"id":"182d315d_34267023","line":196,"range":{"start_line":196,"start_character":0,"end_line":196,"end_character":9},"in_reply_to":"903d85b8_fc874c81","updated":"2022-07-29 07:38:32.000000000","message":"In our realization we don\u0027t create temp snapshot and don\u0027t write info from one volume to new volume. Just cloning volume via dellfcopy tool.","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"67f8a7c3dcea741cf35a6dbf81d63e9f6c66ab24","unresolved":true,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        self._set_rw_permissions(path_to_new_vol)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    def _create_cloned_volume(self, volume, src_vref, context):"},{"line_number":211,"context_line":"        \"\"\"Clone src volume to destination volume.\"\"\""},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        LOG.debug(\u0027Cloning volume %(src)s to volume %(dst)s\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"888670bd_be2d883c","line":210,"range":{"start_line":210,"start_character":8,"end_line":210,"end_character":29},"updated":"2022-07-28 21:31:38.000000000","message":":-1: One concern that I\u0027m seeing here it\u0027s that the user is able to create a clone from an error-state volume. It could be nice to check the state of the volume before attempting creation.","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f250261927a207cdf22104879ca55fab19fecb3c","unresolved":true,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        self._set_rw_permissions(path_to_new_vol)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    def _create_cloned_volume(self, volume, src_vref, context):"},{"line_number":211,"context_line":"        \"\"\"Clone src volume to destination volume.\"\"\""},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        LOG.debug(\u0027Cloning volume %(src)s to volume %(dst)s\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"f2a1a893_d7728e79","line":210,"range":{"start_line":210,"start_character":8,"end_line":210,"end_character":29},"in_reply_to":"888670bd_be2d883c","updated":"2022-07-28 21:59:35.000000000","message":"The API blocks this?","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"67f8a7c3dcea741cf35a6dbf81d63e9f6c66ab24","unresolved":true,"context_lines":[{"line_number":229,"context_line":"        src_volue_path \u003d self._local_path_volume(src_vref)"},{"line_number":230,"context_line":"        dst_volume \u003d self._local_path_volume(volume_info)"},{"line_number":231,"context_line":"        self._do_fast_clone_file(src_volue_path, dst_volume)"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        if src_vref.admin_metadata and \u0027format\u0027 in src_vref.admin_metadata:"},{"line_number":234,"context_line":"            volume.admin_metadata[\u0027format\u0027] \u003d ("},{"line_number":235,"context_line":"                src_vref.admin_metadata[\u0027format\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"fdc98a14_5e7502c3","line":232,"updated":"2022-07-28 21:31:38.000000000","message":":-1: What happens if the user would like to extend the dst_volume? I think you should check that here.\n\nself._extend_volume(volume_info, volume.size)","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"0ea406c3a7ca1453a080e03892c895913ca40867","unresolved":true,"context_lines":[{"line_number":229,"context_line":"        src_volue_path \u003d self._local_path_volume(src_vref)"},{"line_number":230,"context_line":"        dst_volume \u003d self._local_path_volume(volume_info)"},{"line_number":231,"context_line":"        self._do_fast_clone_file(src_volue_path, dst_volume)"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        if src_vref.admin_metadata and \u0027format\u0027 in src_vref.admin_metadata:"},{"line_number":234,"context_line":"            volume.admin_metadata[\u0027format\u0027] \u003d ("},{"line_number":235,"context_line":"                src_vref.admin_metadata[\u0027format\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"f69636c3_9458fb47","line":232,"in_reply_to":"b0ce9e25_8f1a8a00","updated":"2022-07-29 07:38:32.000000000","message":"Manager/create_volume flow doesn\u0027t extend volume after create_cloned_volume. And in base realization in remotefs create_cloned_volume operation has extend_volume after creating volume from temp snapshot. I will add extend volume.","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f250261927a207cdf22104879ca55fab19fecb3c","unresolved":true,"context_lines":[{"line_number":229,"context_line":"        src_volue_path \u003d self._local_path_volume(src_vref)"},{"line_number":230,"context_line":"        dst_volume \u003d self._local_path_volume(volume_info)"},{"line_number":231,"context_line":"        self._do_fast_clone_file(src_volue_path, dst_volume)"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        if src_vref.admin_metadata and \u0027format\u0027 in src_vref.admin_metadata:"},{"line_number":234,"context_line":"            volume.admin_metadata[\u0027format\u0027] \u003d ("},{"line_number":235,"context_line":"                src_vref.admin_metadata[\u0027format\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"b0ce9e25_8f1a8a00","line":232,"in_reply_to":"fdc98a14_5e7502c3","updated":"2022-07-28 21:59:35.000000000","message":"Isn\u0027t this handled by the manager/create flow?","commit_id":"a5ce771687894de02f3f068c73c779a8027a8a9d"}],"doc/source/reference/support-matrix.ini":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"4b9dc032b7746f4e741e610e441f6d1082371aa8","unresolved":true,"context_lines":[{"line_number":302,"context_line":"driver.datera\u003dcomplete"},{"line_number":303,"context_line":"driver.dell_emc_powermax\u003dcomplete"},{"line_number":304,"context_line":"driver.dell_emc_powerstore\u003dcomplete"},{"line_number":305,"context_line":"driver.dell_emc_powerstore_nfs\u003dcomplete"},{"line_number":306,"context_line":"driver.dell_emc_powervault\u003dcomplete"},{"line_number":307,"context_line":"driver.dell_emc_sc\u003dcomplete"},{"line_number":308,"context_line":"driver.dell_emc_unity\u003dcomplete"}],"source_content_type":"text/x-properties","patch_set":1,"id":"c696bcba_7401ccd0","line":305,"updated":"2022-07-27 21:17:55.000000000","message":"There is a check in extend_volume() [1] to prevent extending a attached volume. I believe that the correct status should be missing.\n\n    def extend_volume(self, volume, new_size):\n        \"\"\"Extend an existing volume to the new size.\"\"\"\n        if self._is_volume_attached(volume):\n            msg \u003d (_(\"Cannot extend volume %s while it is attached\")\n                   % volume.name_id)\n            raise exception.ExtendVolumeError(msg)\n            \nhttps://review.opendev.org/c/openstack/cinder/+/851249/1/cinder/volume/drivers/dell_emc/powerstore/nfs.py#130","commit_id":"c1444bc3ad575ba21e54bd0c58279622fb279d23"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"797fa9966076049afdc6dac4ff9be8dfb1753a00","unresolved":false,"context_lines":[{"line_number":302,"context_line":"driver.datera\u003dcomplete"},{"line_number":303,"context_line":"driver.dell_emc_powermax\u003dcomplete"},{"line_number":304,"context_line":"driver.dell_emc_powerstore\u003dcomplete"},{"line_number":305,"context_line":"driver.dell_emc_powerstore_nfs\u003dcomplete"},{"line_number":306,"context_line":"driver.dell_emc_powervault\u003dcomplete"},{"line_number":307,"context_line":"driver.dell_emc_sc\u003dcomplete"},{"line_number":308,"context_line":"driver.dell_emc_unity\u003dcomplete"}],"source_content_type":"text/x-properties","patch_set":1,"id":"28ede0f1_c9f498d9","line":305,"in_reply_to":"c696bcba_7401ccd0","updated":"2022-07-27 22:27:48.000000000","message":"Done","commit_id":"c1444bc3ad575ba21e54bd0c58279622fb279d23"}]}