)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0ed584edc5e37e25588c70b267d0ef938ab84f18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"853cf0d9_7fc328de","updated":"2022-09-07 05:46:02.000000000","message":"I would suggest you to break the dependency chain from bugfixes since features and bugfixes have different deadlines. If the bug is blocked, your feature won\u0027t get into the Zed release.","commit_id":"3def6f1fb770d947477d03ae17d632a9026375e1"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e386c9eff30816f3923621536f2ed3f8924959e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3d525ea6_707608ef","updated":"2022-09-05 20:43:40.000000000","message":"code and tests LGTM.\n\nCI is passing.\n\nBuild succeeded.\nInfinidat-FC http://openstack-ci-logs.aws.infinidat.com/#logs/refs-changes-96-851996-8/FC/ : SUCCESS in 1h 0m 57s\nInfinidat-iSCSI http://openstack-ci-logs.aws.infinidat.com/#logs/refs-changes-96-851996-8/iSCSI/ : SUCCESS in 1h 54m 4s","commit_id":"3def6f1fb770d947477d03ae17d632a9026375e1"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"4fbc6173daa90aea7ae12195f28b732f9bbb1dfb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f72a18d1_ed09f35c","updated":"2022-08-26 17:40:56.000000000","message":"recheck grenade","commit_id":"3def6f1fb770d947477d03ae17d632a9026375e1"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"c85f562838a842726252e0677785b3312d73734d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"45ba839f_d58df4f5","in_reply_to":"853cf0d9_7fc328de","updated":"2022-09-10 20:39:07.000000000","message":"Hello Rajat,\n\nThank you very much for the review!\nYes - I agree with you.\nFixed by patch set 9 - please review.\n\nThank you!","commit_id":"3def6f1fb770d947477d03ae17d632a9026375e1"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7374d1d663a237add0e84460c167d5c61224db25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a071f0ba_344bf2a2","updated":"2022-09-12 05:18:36.000000000","message":"the code looks good however the tests need to have more checks, currently it seems we\u0027re just relying on mocks to do the work and not asserting properly.","commit_id":"8861d15b12cb6add2d9ffeb358f092dd5459d36e"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"7ca7f69ff46a17205fe40c03358bc2d1200fc8e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5ab07b3f_d52905ff","in_reply_to":"a071f0ba_344bf2a2","updated":"2022-09-12 11:18:33.000000000","message":"Hello Rajat,\n\nThank you very much for the review!\nAll comments have been addressed in the patch set 10, please review.\n\nThank you!","commit_id":"8861d15b12cb6add2d9ffeb358f092dd5459d36e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"cbb17a62971373780b6da4d8d28c0ba7c87fea28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"046b9348_9c213061","updated":"2022-09-12 20:47:04.000000000","message":"Code and tests look good; CI is passing.","commit_id":"2c25e2259e61ae4dffc3b1970e44eeeda36b1d10"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3baf6b1015a0da79fbc814275875ae0629e6175c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"dafc4934_86520c58","updated":"2022-09-12 19:41:48.000000000","message":"my comments have been addressed. Infinidat CI reported success. LGTM.\n\nBuild succeeded.\nInfinidat-FC http://openstack-ci-logs.aws.infinidat.com/#logs/refs-changes-96-851996-10/FC/ : SUCCESS in 1h 25m 16s\nInfinidat-iSCSI http://openstack-ci-logs.aws.infinidat.com/#logs/refs-changes-96-851996-10/iSCSI/ : SUCCESS in 1h 27m 55s","commit_id":"2c25e2259e61ae4dffc3b1970e44eeeda36b1d10"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"9c27281e460c9b5d4fc3a54785f574bfdc4ae0e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1e6b16ff_5b31a9f2","updated":"2022-09-12 14:55:23.000000000","message":"recheck tempest-integrated-storage","commit_id":"2c25e2259e61ae4dffc3b1970e44eeeda36b1d10"}],"cinder/tests/unit/volume/drivers/test_infinidat.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7374d1d663a237add0e84460c167d5c61224db25","unresolved":true,"context_lines":[{"line_number":602,"context_line":"        self.assertFalse(result)"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"    def test_revert_to_snapshot(self):"},{"line_number":605,"context_line":"        self._mock_volume.restore.side_effect \u003d None"},{"line_number":606,"context_line":"        self.driver.revert_to_snapshot(None, test_volume, test_snapshot)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"    def test_revert_to_snapshot_resize(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1658a765_f9825f18","line":605,"range":{"start_line":605,"start_character":13,"end_line":605,"end_character":25},"updated":"2022-09-12 05:18:36.000000000","message":"why are we are using _mock_volume here but passing test_volume to the revert call?","commit_id":"8861d15b12cb6add2d9ffeb358f092dd5459d36e"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"7ca7f69ff46a17205fe40c03358bc2d1200fc8e8","unresolved":false,"context_lines":[{"line_number":602,"context_line":"        self.assertFalse(result)"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"    def test_revert_to_snapshot(self):"},{"line_number":605,"context_line":"        self._mock_volume.restore.side_effect \u003d None"},{"line_number":606,"context_line":"        self.driver.revert_to_snapshot(None, test_volume, test_snapshot)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"    def test_revert_to_snapshot_resize(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"297e54e8_31435fb3","line":605,"range":{"start_line":605,"start_character":13,"end_line":605,"end_character":25},"in_reply_to":"1658a765_f9825f18","updated":"2022-09-12 11:18:33.000000000","message":"Hello Rajat,\n\nThank you very much for the review!\n\nThe _mock_volume is a Infinidat internal representation for the Cinder volume.\nAnd we are using test_volume for the Cinder revert call and _mock_volume for the get_size Infinidat call.\n\nThank you!","commit_id":"8861d15b12cb6add2d9ffeb358f092dd5459d36e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7374d1d663a237add0e84460c167d5c61224db25","unresolved":true,"context_lines":[{"line_number":603,"context_line":""},{"line_number":604,"context_line":"    def test_revert_to_snapshot(self):"},{"line_number":605,"context_line":"        self._mock_volume.restore.side_effect \u003d None"},{"line_number":606,"context_line":"        self.driver.revert_to_snapshot(None, test_volume, test_snapshot)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"    def test_revert_to_snapshot_resize(self):"},{"line_number":609,"context_line":"        test_snapshot.volume.size \u003d 2"}],"source_content_type":"text/x-python","patch_set":9,"id":"66b2a560_4857be66","line":606,"range":{"start_line":606,"start_character":8,"end_line":606,"end_character":72},"updated":"2022-09-12 05:18:36.000000000","message":"we should assert that the restore was called with desired arguments\n\ntest_volume.restore.assert_called_once_with(test_snapshot)","commit_id":"8861d15b12cb6add2d9ffeb358f092dd5459d36e"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"7ca7f69ff46a17205fe40c03358bc2d1200fc8e8","unresolved":false,"context_lines":[{"line_number":603,"context_line":""},{"line_number":604,"context_line":"    def test_revert_to_snapshot(self):"},{"line_number":605,"context_line":"        self._mock_volume.restore.side_effect \u003d None"},{"line_number":606,"context_line":"        self.driver.revert_to_snapshot(None, test_volume, test_snapshot)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"    def test_revert_to_snapshot_resize(self):"},{"line_number":609,"context_line":"        test_snapshot.volume.size \u003d 2"}],"source_content_type":"text/x-python","patch_set":9,"id":"ebed273b_3d5bf124","line":606,"range":{"start_line":606,"start_character":8,"end_line":606,"end_character":72},"in_reply_to":"66b2a560_4857be66","updated":"2022-09-12 11:18:33.000000000","message":"Hello Rajat,\n\nThank you very much for the review!\nAll comments have been addressed in the patch set 10, please review.\n\nThank you!","commit_id":"8861d15b12cb6add2d9ffeb358f092dd5459d36e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7374d1d663a237add0e84460c167d5c61224db25","unresolved":true,"context_lines":[{"line_number":608,"context_line":"    def test_revert_to_snapshot_resize(self):"},{"line_number":609,"context_line":"        test_snapshot.volume.size \u003d 2"},{"line_number":610,"context_line":"        self.driver.revert_to_snapshot(None, test_volume, test_snapshot)"},{"line_number":611,"context_line":"        self._mock_volume.resize.assert_called_with(units.Gi)"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"class InfiniboxDriverTestCaseFC(InfiniboxDriverTestCaseBase):"}],"source_content_type":"text/x-python","patch_set":9,"id":"e478d7aa_a95ab2f8","line":611,"range":{"start_line":611,"start_character":26,"end_line":611,"end_character":32},"updated":"2022-09-12 05:18:36.000000000","message":"shouldn\u0027t this be extend?","commit_id":"8861d15b12cb6add2d9ffeb358f092dd5459d36e"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"7ca7f69ff46a17205fe40c03358bc2d1200fc8e8","unresolved":false,"context_lines":[{"line_number":608,"context_line":"    def test_revert_to_snapshot_resize(self):"},{"line_number":609,"context_line":"        test_snapshot.volume.size \u003d 2"},{"line_number":610,"context_line":"        self.driver.revert_to_snapshot(None, test_volume, test_snapshot)"},{"line_number":611,"context_line":"        self._mock_volume.resize.assert_called_with(units.Gi)"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"class InfiniboxDriverTestCaseFC(InfiniboxDriverTestCaseBase):"}],"source_content_type":"text/x-python","patch_set":9,"id":"408eb004_f3ba5055","line":611,"range":{"start_line":611,"start_character":26,"end_line":611,"end_character":32},"in_reply_to":"e478d7aa_a95ab2f8","updated":"2022-09-12 11:18:33.000000000","message":"Hello Rajat,\n\nThank you very much for the review!\nAll comments have been addressed in the patch set 10 - please review!\n\nThank you!","commit_id":"8861d15b12cb6add2d9ffeb358f092dd5459d36e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3baf6b1015a0da79fbc814275875ae0629e6175c","unresolved":true,"context_lines":[{"line_number":622,"context_line":"            self._mock_volume.resize.assert_not_called()"},{"line_number":623,"context_line":"        else:"},{"line_number":624,"context_line":"            delta \u003d (snapshot_size - volume_size) * units.Gi"},{"line_number":625,"context_line":"            self._mock_volume.resize.assert_called_with(delta)"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"class InfiniboxDriverTestCaseFC(InfiniboxDriverTestCaseBase):"}],"source_content_type":"text/x-python","patch_set":10,"id":"73638a62_47265d55","line":625,"range":{"start_line":625,"start_character":37,"end_line":625,"end_character":55},"updated":"2022-09-12 19:41:48.000000000","message":"nit: assert_called_once_with","commit_id":"2c25e2259e61ae4dffc3b1970e44eeeda36b1d10"}],"cinder/volume/drivers/infinidat.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e386c9eff30816f3923621536f2ed3f8924959e9","unresolved":true,"context_lines":[{"line_number":123,"context_line":"            - added update migrated volume"},{"line_number":124,"context_line":"            - fixed volume multi-attach"},{"line_number":125,"context_line":"            - fixed backup for attached volume"},{"line_number":126,"context_line":"            - added revert to snapshot"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    \"\"\""},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"8c872c17_1ccff7bf","line":126,"range":{"start_line":126,"start_character":12,"end_line":126,"end_character":38},"updated":"2022-09-05 20:43:40.000000000","message":"any reason for stopping using version numbers?","commit_id":"3def6f1fb770d947477d03ae17d632a9026375e1"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"00dd1b7128ce536632b4b070795840d329edc016","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            - added update migrated volume"},{"line_number":124,"context_line":"            - fixed volume multi-attach"},{"line_number":125,"context_line":"            - fixed backup for attached volume"},{"line_number":126,"context_line":"            - added revert to snapshot"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    \"\"\""},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"32217979_949a3856","line":126,"range":{"start_line":126,"start_character":12,"end_line":126,"end_character":38},"in_reply_to":"1b983223_965d5b31","updated":"2022-09-10 20:22:10.000000000","message":"Hello Rajat,\n\nThank you very much for the review!\nYes - I agree with you.\nFixed by patch set 9 - please review.\n\nThank you!","commit_id":"3def6f1fb770d947477d03ae17d632a9026375e1"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0ed584edc5e37e25588c70b267d0ef938ab84f18","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            - added update migrated volume"},{"line_number":124,"context_line":"            - fixed volume multi-attach"},{"line_number":125,"context_line":"            - fixed backup for attached volume"},{"line_number":126,"context_line":"            - added revert to snapshot"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    \"\"\""},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1b983223_965d5b31","line":126,"range":{"start_line":126,"start_character":12,"end_line":126,"end_character":38},"in_reply_to":"450ca6a9_4b9b5aea","updated":"2022-09-07 05:46:02.000000000","message":"Since cinder doesn\u0027t bother much with driver versions but other drivers use different version for every bugfix or feature.\nEven if you would like to keep bugfixes with the same version, I think for features it makes sense to bump the version unless there is a reason to keep everything similar.","commit_id":"3def6f1fb770d947477d03ae17d632a9026375e1"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"404e39de27161a224bc751ca8fbbbdc1df535776","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            - added update migrated volume"},{"line_number":124,"context_line":"            - fixed volume multi-attach"},{"line_number":125,"context_line":"            - fixed backup for attached volume"},{"line_number":126,"context_line":"            - added revert to snapshot"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    \"\"\""},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"450ca6a9_4b9b5aea","line":126,"range":{"start_line":126,"start_character":12,"end_line":126,"end_character":38},"in_reply_to":"8c872c17_1ccff7bf","updated":"2022-09-05 20:50:57.000000000","message":"Hello Rajat,\n\nThank you very much for the review!\n\nWe use version 1.7 for all these dependent changes:\n- https://review.opendev.org/c/openstack/cinder/+/849022\n- https://review.opendev.org/c/openstack/cinder/+/849846\n- https://review.opendev.org/c/openstack/cinder/+/850320\n- https://review.opendev.org/c/openstack/cinder/+/850321\n- https://review.opendev.org/c/openstack/cinder/+/851640\n- https://review.opendev.org/c/openstack/cinder/+/852369\n- https://review.opendev.org/c/openstack/cinder/+/851996\n- https://review.opendev.org/c/openstack/cinder/+/852009\n\nIf it possible - please review these changes.\n\nThank you!","commit_id":"3def6f1fb770d947477d03ae17d632a9026375e1"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7374d1d663a237add0e84460c167d5c61224db25","unresolved":false,"context_lines":[{"line_number":848,"context_line":"        \"\"\"Revert volume to snapshot."},{"line_number":849,"context_line":""},{"line_number":850,"context_line":"        Note: the revert process should not change the volume\u0027s"},{"line_number":851,"context_line":"        current size, that means if the driver shrank"},{"line_number":852,"context_line":"        the volume during the process, it should extend the"},{"line_number":853,"context_line":"        volume internally."},{"line_number":854,"context_line":"        \"\"\""},{"line_number":855,"context_line":"        infinidat_snapshot \u003d self._get_infinidat_snapshot(snapshot)"}],"source_content_type":"text/x-python","patch_set":9,"id":"8c6f19a6_5c34a020","line":852,"range":{"start_line":851,"start_character":33,"end_line":852,"end_character":37},"updated":"2022-09-12 05:18:36.000000000","message":"This seems to be a strange case to be happening but since it is internal to the driver and we\u0027re handling it, I\u0027m OK with this.","commit_id":"8861d15b12cb6add2d9ffeb358f092dd5459d36e"}],"releasenotes/notes/bp-infinidat-add-snapshot-revert-1bab97e85ff10780.yaml":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e386c9eff30816f3923621536f2ed3f8924959e9","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Infinidat driver: add support for revert to snapshot operation."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"90867260_c1afcda8","line":4,"range":{"start_line":4,"start_character":22,"end_line":4,"end_character":25},"updated":"2022-09-05 20:43:40.000000000","message":"nit: Added","commit_id":"3def6f1fb770d947477d03ae17d632a9026375e1"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"00dd1b7128ce536632b4b070795840d329edc016","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Infinidat driver: add support for revert to snapshot operation."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"84a9c250_675e01b7","line":4,"range":{"start_line":4,"start_character":22,"end_line":4,"end_character":25},"in_reply_to":"90867260_c1afcda8","updated":"2022-09-10 20:22:10.000000000","message":"Hello Rajat,\n\nThank you very much for the review!\nFixed by patch set 9 - please review.\n\nThank you!","commit_id":"3def6f1fb770d947477d03ae17d632a9026375e1"}]}