)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"3344d573de3c1391cc20f48688f8a21a57267d44","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     inori \u003cxuq.fnstxz@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-03-30 22:05:04 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fujitsu Driver: Add volume format when deleting volume."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If parameter \u0027type:delete_with_volume_format\u0027 is specified in the volume type when creating a volume, formatting will be performed before deleting the volume"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"8ded15fe_bcc0cf9c","line":7,"updated":"2023-04-04 12:49:29.000000000","message":"nit: The first line should be limited to 50 characters and should not end with a period.\n\nKindly refer: https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"288c9ee114154dabf043d5afe9092345f909a339"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"3e3c65e1738b6e4a73facd6db4252f1132403fd7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     inori \u003cxuq.fnstxz@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-03-30 22:05:04 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fujitsu Driver: Add volume format when deleting volume."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If parameter \u0027type:delete_with_volume_format\u0027 is specified in the volume type when creating a volume, formatting will be performed before deleting the volume"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"f1b68d76_f8950bac","line":7,"in_reply_to":"8ded15fe_bcc0cf9c","updated":"2023-04-07 08:53:28.000000000","message":"Thanks for your review. I\u0027ve modified it.","commit_id":"288c9ee114154dabf043d5afe9092345f909a339"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"3344d573de3c1391cc20f48688f8a21a57267d44","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fujitsu Driver: Add volume format when deleting volume."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If parameter \u0027type:delete_with_volume_format\u0027 is specified in the volume type when creating a volume, formatting will be performed before deleting the volume"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Add the following file:"},{"line_number":12,"context_line":"eternus_dx_utils"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"109875dd_9ec06af3","line":9,"updated":"2023-04-04 12:49:29.000000000","message":"nit: Subsequent lines should be wrapped at 72 characters.","commit_id":"288c9ee114154dabf043d5afe9092345f909a339"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"3e3c65e1738b6e4a73facd6db4252f1132403fd7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fujitsu Driver: Add volume format when deleting volume."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If parameter \u0027type:delete_with_volume_format\u0027 is specified in the volume type when creating a volume, formatting will be performed before deleting the volume"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Add the following file:"},{"line_number":12,"context_line":"eternus_dx_utils"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"881931e0_fd816f51","line":9,"in_reply_to":"109875dd_9ec06af3","updated":"2023-04-07 08:53:28.000000000","message":"Thanks for your review. I\u0027ve modified it.","commit_id":"288c9ee114154dabf043d5afe9092345f909a339"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7046b3081a33cf030197a4b34230ae089fa93193","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bbfdcf24_872230d6","updated":"2023-03-24 13:14:51.000000000","message":"Question inline.","commit_id":"200c80ea989b489e56e94134781b75d60f4c070f"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"e74d9c1a4ae6dfe43f5a336afff0119c44288890","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"560e293f_b1ecd53f","updated":"2023-03-27 03:51:56.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"35a0c0d46b92950b2cdcd291b4a78cf638b8a598"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"ca393262530d3fb4dfe15feb758dea4462ec7f90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d3b7eca1_9ee11b0c","updated":"2023-03-28 01:21:40.000000000","message":"recheck cinder-mypy","commit_id":"d3e1af9574e01e96baeb095867862966f03a5b1a"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"fd4c7f2fe46aa6fbb317d686c49454ea0fdb8bed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a97282c9_ed077141","updated":"2023-03-27 09:56:29.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"d3e1af9574e01e96baeb095867862966f03a5b1a"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"3344d573de3c1391cc20f48688f8a21a57267d44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"413b0141_0b32504b","updated":"2023-04-04 12:49:29.000000000","message":"Overall code changes look good.\nMinor comments inline.\n","commit_id":"288c9ee114154dabf043d5afe9092345f909a339"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e1ceca26d403df85bbf384beb6abfcd296ff5bec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"cefaddbe_76db24a4","updated":"2023-09-14 19:27:00.000000000","message":"Just want to add, it\u0027s important to keep an eye on your proposed patches and keep them out of merge conflict.  People are unlikely to review a patch in merge conflict.","commit_id":"f576c31603cbc6826bd9263f24bfa6a95dd2d57b"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"9aff136347bb9e213afc385feb73c244b7df4730","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9be7d530_375ee9f4","updated":"2023-04-10 11:18:48.000000000","message":"My comments from previous patchset got addressed.\nFujitsu ETERNUS CI and Zuul have passed. So +1.\n\nCouple of minor comments (which could be addressed later).","commit_id":"f576c31603cbc6826bd9263f24bfa6a95dd2d57b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6cec2f4c6e2a365f7b2244a9f6c79a233242585c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7c8280f4_7ec92350","updated":"2023-09-14 19:24:17.000000000","message":"This is a comment about the commit message and release note.  It would be good to explain clearly exactly what this feature does.  For instance, there\u0027s a difference between quick format, format, and zeroing-out.  Additionally, it would be good to say something about the use case for this with your backend.  What I mean is, is it possible with your backend for someone to get a new volume and be able to recover data from it?  I hope not, but adding this feature sounds like that could be a possibility, so it would be helpful to say what the purpose of this feature is.","commit_id":"f576c31603cbc6826bd9263f24bfa6a95dd2d57b"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"ac3c0c3add377119cab043502e879912898f3949","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"17ed36f7_7b952c0b","updated":"2023-07-05 04:02:11.000000000","message":"lgtm","commit_id":"f576c31603cbc6826bd9263f24bfa6a95dd2d57b"}],"cinder/tests/unit/volume/drivers/test_fujitsu_dx.py":[{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"614f06725457962bbb05f970c47510c1ac430c8c","unresolved":true,"context_lines":[{"line_number":197,"context_line":"FAKE_LOCATION1 \u003d {"},{"line_number":198,"context_line":"    \u0027classname\u0027: \u0027FUJITSU_StorageVolume\u0027,"},{"line_number":199,"context_line":"    \u0027keybindings\u0027: FAKE_KEYBIND1,"},{"line_number":200,"context_line":"    \u0027vol_name\u0027: u\u0027FJosv_0qJ4rpOHgFE8ipcJOMfBmg\u003d\u003d\u0027"},{"line_number":201,"context_line":"}"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"# Clone Volume"}],"source_content_type":"text/x-python","patch_set":3,"id":"be44b4c4_98701fb6","line":200,"updated":"2023-03-22 03:23:09.000000000","message":"unicode plz remove it","commit_id":"8f6ace6878ef37ded8143221fa0aab73af61d13e"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"0e15f773b85b8810801ab52202c0c78d78c427a5","unresolved":false,"context_lines":[{"line_number":197,"context_line":"FAKE_LOCATION1 \u003d {"},{"line_number":198,"context_line":"    \u0027classname\u0027: \u0027FUJITSU_StorageVolume\u0027,"},{"line_number":199,"context_line":"    \u0027keybindings\u0027: FAKE_KEYBIND1,"},{"line_number":200,"context_line":"    \u0027vol_name\u0027: u\u0027FJosv_0qJ4rpOHgFE8ipcJOMfBmg\u003d\u003d\u0027"},{"line_number":201,"context_line":"}"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"# Clone Volume"}],"source_content_type":"text/x-python","patch_set":3,"id":"9e1b3558_411e3d05","line":200,"in_reply_to":"be44b4c4_98701fb6","updated":"2023-03-27 06:57:07.000000000","message":"Thanks for your review. I\u0027ve modified it.","commit_id":"8f6ace6878ef37ded8143221fa0aab73af61d13e"}],"cinder/volume/drivers/fujitsu/eternus_dx/constants.py":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"3344d573de3c1391cc20f48688f8a21a57267d44","unresolved":true,"context_lines":[{"line_number":41,"context_line":"STOR_CONF \u003d \"FUJITSU_StorageConfigurationService\""},{"line_number":42,"context_line":"CTRL_CONF \u003d \"FUJITSU_ControllerConfigurationService\""},{"line_number":43,"context_line":"UNDEF_MSG \u003d \u0027Undefined Error!!\u0027"},{"line_number":44,"context_line":"FJ_VOL_FORMAT_KEY \u003d \"type:delete_with_volume_format\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"QOS_VERSION \u003d \u0027V11L30-0000\u0027"},{"line_number":47,"context_line":"POOL_TYPE_dic \u003d {"}],"source_content_type":"text/x-python","patch_set":7,"id":"6da0aff9_d50883b0","line":44,"updated":"2023-04-04 12:49:29.000000000","message":"nit: can we name this constant as \"FJ_DEL_VOL_FORMAT_KEY\",\nso that it is more obvious that this constant is used during delete operation.","commit_id":"288c9ee114154dabf043d5afe9092345f909a339"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"3e3c65e1738b6e4a73facd6db4252f1132403fd7","unresolved":false,"context_lines":[{"line_number":41,"context_line":"STOR_CONF \u003d \"FUJITSU_StorageConfigurationService\""},{"line_number":42,"context_line":"CTRL_CONF \u003d \"FUJITSU_ControllerConfigurationService\""},{"line_number":43,"context_line":"UNDEF_MSG \u003d \u0027Undefined Error!!\u0027"},{"line_number":44,"context_line":"FJ_VOL_FORMAT_KEY \u003d \"type:delete_with_volume_format\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"QOS_VERSION \u003d \u0027V11L30-0000\u0027"},{"line_number":47,"context_line":"POOL_TYPE_dic \u003d {"}],"source_content_type":"text/x-python","patch_set":7,"id":"6964c705_da904001","line":44,"in_reply_to":"6da0aff9_d50883b0","updated":"2023-04-07 08:53:28.000000000","message":"Thanks for your review. I\u0027ve modified it.","commit_id":"288c9ee114154dabf043d5afe9092345f909a339"}],"cinder/volume/drivers/fujitsu/eternus_dx/eternus_dx_common.py":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"3344d573de3c1391cc20f48688f8a21a57267d44","unresolved":true,"context_lines":[{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"\"\"\"Cinder Volume driver for Fujitsu ETERNUS DX S3 series.\"\"\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import base64"},{"line_number":22,"context_line":"import time"}],"source_content_type":"text/x-python","patch_set":7,"id":"23d70648_e3bb96d4","line":19,"range":{"start_line":19,"start_character":44,"end_line":19,"end_character":56},"updated":"2023-04-04 12:49:29.000000000","message":"In fujitsu-eternus-dx-driver.rst file, it is updated as \"DX series\".\nCan we do same update here also ?","commit_id":"288c9ee114154dabf043d5afe9092345f909a339"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"3e3c65e1738b6e4a73facd6db4252f1132403fd7","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"\"\"\"Cinder Volume driver for Fujitsu ETERNUS DX S3 series.\"\"\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import base64"},{"line_number":22,"context_line":"import time"}],"source_content_type":"text/x-python","patch_set":7,"id":"18fa5470_e9e2cfaa","line":19,"range":{"start_line":19,"start_character":44,"end_line":19,"end_character":56},"in_reply_to":"23d70648_e3bb96d4","updated":"2023-04-07 08:53:28.000000000","message":"Thanks for your review. I\u0027ve modified it.","commit_id":"288c9ee114154dabf043d5afe9092345f909a339"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"3344d573de3c1391cc20f48688f8a21a57267d44","unresolved":true,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    \"\"\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    VERSION \u003d \"1.3.0.1\""},{"line_number":72,"context_line":"    stats \u003d {"},{"line_number":73,"context_line":"        \u0027driver_version\u0027: VERSION,"},{"line_number":74,"context_line":"        \u0027storage_protocol\u0027: None,"}],"source_content_type":"text/x-python","patch_set":7,"id":"db224152_f73aad36","line":71,"updated":"2023-04-04 12:49:29.000000000","message":"nit: Can new VERSION be just \"1.3.1\" ?\nAny reason for \"1.3.0.1\" ?","commit_id":"288c9ee114154dabf043d5afe9092345f909a339"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"3e3c65e1738b6e4a73facd6db4252f1132403fd7","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    \"\"\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    VERSION \u003d \"1.3.0.1\""},{"line_number":72,"context_line":"    stats \u003d {"},{"line_number":73,"context_line":"        \u0027driver_version\u0027: VERSION,"},{"line_number":74,"context_line":"        \u0027storage_protocol\u0027: None,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aea8fe5_12f2dbaa","line":71,"in_reply_to":"db224152_f73aad36","updated":"2023-04-07 08:53:28.000000000","message":"Thanks for your review. This is a transitional version, and now I changed it to \"1.4.0\".","commit_id":"288c9ee114154dabf043d5afe9092345f909a339"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"3344d573de3c1391cc20f48688f8a21a57267d44","unresolved":true,"context_lines":[{"line_number":1484,"context_line":"        ret \u003d None"},{"line_number":1485,"context_line":"        try:"},{"line_number":1486,"context_line":"            ret \u003d self.conn.GetInstance(classname, **param_dict)"},{"line_number":1487,"context_line":"        except Exception as e:"},{"line_number":1488,"context_line":"            if e.args[0] \u003d\u003d 6 and allownone:"},{"line_number":1489,"context_line":"                return ret"},{"line_number":1490,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"613a5d35_35bacf3f","line":1487,"range":{"start_line":1487,"start_character":28,"end_line":1487,"end_character":29},"updated":"2023-04-04 12:49:29.000000000","message":"nit: Better to use atleast two character variable name.\nEg. \"ex\" instead of just \"e\".","commit_id":"288c9ee114154dabf043d5afe9092345f909a339"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"3e3c65e1738b6e4a73facd6db4252f1132403fd7","unresolved":false,"context_lines":[{"line_number":1484,"context_line":"        ret \u003d None"},{"line_number":1485,"context_line":"        try:"},{"line_number":1486,"context_line":"            ret \u003d self.conn.GetInstance(classname, **param_dict)"},{"line_number":1487,"context_line":"        except Exception as e:"},{"line_number":1488,"context_line":"            if e.args[0] \u003d\u003d 6 and allownone:"},{"line_number":1489,"context_line":"                return ret"},{"line_number":1490,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"ce0cf262_2ef8e4cb","line":1487,"range":{"start_line":1487,"start_character":28,"end_line":1487,"end_character":29},"in_reply_to":"613a5d35_35bacf3f","updated":"2023-04-07 08:53:28.000000000","message":"Thanks for your review. I\u0027ve modified it.","commit_id":"288c9ee114154dabf043d5afe9092345f909a339"}],"cinder/volume/drivers/fujitsu/eternus_dx/eternus_dx_utils.py":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"9aff136347bb9e213afc385feb73c244b7df4730","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    metadata \u003d volume.get(\u0027volume_metadata\u0027)\r"},{"line_number":34,"context_line":"\r"},{"line_number":35,"context_line":"    # value \u003d {} enters the if branch, value \u003d None enters the else.\r"},{"line_number":36,"context_line":"    if metadata is not None:\r"},{"line_number":37,"context_line":"        d_metadata \u003d {\r"},{"line_number":38,"context_line":"            data[\u0027key\u0027]: data[\u0027value\u0027] for data in metadata\r"},{"line_number":39,"context_line":"        }\r"}],"source_content_type":"text/x-python","patch_set":9,"id":"83826dc6_951e6a52","line":36,"updated":"2023-04-10 11:18:48.000000000","message":"nit: this could be simply written as:\nif metadata","commit_id":"f576c31603cbc6826bd9263f24bfa6a95dd2d57b"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"9aff136347bb9e213afc385feb73c244b7df4730","unresolved":true,"context_lines":[{"line_number":52,"context_line":"def get_format_property(volume, format_key):\r"},{"line_number":53,"context_line":"    format_in_type \u003d get_extra_specs(volume,\r"},{"line_number":54,"context_line":"                                     key\u003dformat_key,\r"},{"line_number":55,"context_line":"                                     default\u003d\u0027False\u0027)\r"},{"line_number":56,"context_line":"    format_in_vol \u003d get_metadata(volume).get(format_key, \u0027False\u0027)\r"},{"line_number":57,"context_line":"\r"},{"line_number":58,"context_line":"    if \u0027true\u0027 in [format_in_type.lower(), format_in_vol.lower()]:\r"},{"line_number":59,"context_line":"        return \u0027True\u0027\r"},{"line_number":60,"context_line":"    else:\r"},{"line_number":61,"context_line":"        return \u0027False\u0027\r"},{"line_number":62,"context_line":"\r"},{"line_number":63,"context_line":"\r"},{"line_number":64,"context_line":"def get_extra_specs(volume, key\u003dNone, default\u003dNone):\r"}],"source_content_type":"text/x-python","patch_set":9,"id":"8c37c8ac_cf7df402","line":61,"range":{"start_line":55,"start_character":0,"end_line":61,"end_character":22},"updated":"2023-04-10 11:18:48.000000000","message":"nit: If possible, can we use boolean values True / False instead of\nstrings \u0027True\u0027 / \u0027False\u0027?","commit_id":"f576c31603cbc6826bd9263f24bfa6a95dd2d57b"}],"doc/source/configuration/block-storage/drivers/fujitsu-eternus-dx-driver.rst":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"3344d573de3c1391cc20f48688f8a21a57267d44","unresolved":true,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"   For \u003cvolume_type_id\u003e, specify the ID of the volume type that is to be deleted."},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"#. Deleted the volume."},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"   Overwrite the areas that are being used with zeros and deleted the volume."},{"line_number":278,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3f6ec9b6_9c0fc635","line":275,"range":{"start_line":275,"start_character":3,"end_line":275,"end_character":10},"updated":"2023-04-04 12:49:29.000000000","message":"nit: Delete","commit_id":"288c9ee114154dabf043d5afe9092345f909a339"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"3e3c65e1738b6e4a73facd6db4252f1132403fd7","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"   For \u003cvolume_type_id\u003e, specify the ID of the volume type that is to be deleted."},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"#. Deleted the volume."},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"   Overwrite the areas that are being used with zeros and deleted the volume."},{"line_number":278,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"58136db6_0c2821e2","line":275,"range":{"start_line":275,"start_character":3,"end_line":275,"end_character":10},"in_reply_to":"3f6ec9b6_9c0fc635","updated":"2023-04-07 08:53:28.000000000","message":"Thanks for your review. I\u0027ve modified it.","commit_id":"288c9ee114154dabf043d5afe9092345f909a339"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"3344d573de3c1391cc20f48688f8a21a57267d44","unresolved":true,"context_lines":[{"line_number":294,"context_line":"it may take time to format."},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"#. Snapshot volumes cannot be"},{"line_number":297,"context_line":"overwritten with zeros."}],"source_content_type":"text/x-rst","patch_set":7,"id":"f277f4f2_7799c791","line":297,"updated":"2023-04-04 12:49:29.000000000","message":"nit: this line can be written in continuation above i.e at line 296","commit_id":"288c9ee114154dabf043d5afe9092345f909a339"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"3e3c65e1738b6e4a73facd6db4252f1132403fd7","unresolved":false,"context_lines":[{"line_number":294,"context_line":"it may take time to format."},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"#. Snapshot volumes cannot be"},{"line_number":297,"context_line":"overwritten with zeros."}],"source_content_type":"text/x-rst","patch_set":7,"id":"bf580c93_0db4b20a","line":297,"in_reply_to":"f277f4f2_7799c791","updated":"2023-04-07 08:53:28.000000000","message":"Thanks for your review. I\u0027ve modified it.","commit_id":"288c9ee114154dabf043d5afe9092345f909a339"}],"releasenotes/notes/fujitsu-add-volume-format-40ec9cc8ef9ba8f6.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7046b3081a33cf030197a4b34230ae089fa93193","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"804cc383_a3e7659f","line":9,"updated":"2023-03-24 13:14:51.000000000","message":"Can you be more explicit about what this does?  I\u0027m assuming that it\u0027s not enabled by default because it puts more stress on the backend when volumes are deleted.  But if you don\u0027t do this, are there circumstances under which a volume could be deleted but the data could be recovered?  The backend is supposed to guarantee that when a new volume is served it doesn\u0027t contain a previous user\u0027s data.  So does the Fujitsu backend just mark deleted volumes as out-of-use, and only destroys the data when a new volume is created (so until that point, the data is \"out there\" in the backend and could be recovered somehow)?","commit_id":"200c80ea989b489e56e94134781b75d60f4c070f"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"0e15f773b85b8810801ab52202c0c78d78c427a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cd452658_18fc6749","line":9,"in_reply_to":"804cc383_a3e7659f","updated":"2023-03-27 06:57:07.000000000","message":"Thanks for your review. When deleting a volume from the backend, we do delete volume from our storage. Although the deleted volume cannot be restored from the storage, we still provide this function for users who want to format volume by themselves before delete volume.","commit_id":"200c80ea989b489e56e94134781b75d60f4c070f"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"3344d573de3c1391cc20f48688f8a21a57267d44","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Fujitsu driver: Add volume format when deleting volume."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    If parameter \"``type:delete_with_volume_format``\" is set to ``True`` in"},{"line_number":7,"context_line":"    the volume type extra specs, and then create a volume bythis type."},{"line_number":8,"context_line":"    When deleting the volume, volume will be formatted and the used areas"},{"line_number":9,"context_line":"    will be overwritten with zeros."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5e94a391_0da9bed9","line":7,"range":{"start_line":7,"start_character":58,"end_line":7,"end_character":64},"updated":"2023-04-04 12:49:29.000000000","message":"nit: space is required","commit_id":"288c9ee114154dabf043d5afe9092345f909a339"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"3e3c65e1738b6e4a73facd6db4252f1132403fd7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Fujitsu driver: Add volume format when deleting volume."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    If parameter \"``type:delete_with_volume_format``\" is set to ``True`` in"},{"line_number":7,"context_line":"    the volume type extra specs, and then create a volume bythis type."},{"line_number":8,"context_line":"    When deleting the volume, volume will be formatted and the used areas"},{"line_number":9,"context_line":"    will be overwritten with zeros."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"b11dc7b3_1bd997ba","line":7,"range":{"start_line":7,"start_character":58,"end_line":7,"end_character":64},"in_reply_to":"5e94a391_0da9bed9","updated":"2023-04-07 08:53:28.000000000","message":"Thanks for your review. I\u0027ve modified it.","commit_id":"288c9ee114154dabf043d5afe9092345f909a339"}]}