)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"3c12b891f944d863b008722b8a3763ad28c0af4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"df1bf66f_afd7935f","updated":"2022-08-29 01:14:24.000000000","message":"I realized that you\u0027ve just missed the release notes.","commit_id":"b61a0d6ae07a12d13913cacb25ca146b4ee67990"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"cca0529ce1aae4b08fa0af7251a432a49ac9de39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"141003f1_75a5fc5b","updated":"2022-08-29 01:10:42.000000000","message":"thank you Nahim and Luisa. See my comments inline.","commit_id":"b61a0d6ae07a12d13913cacb25ca146b4ee67990"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"0ca9bce968fd7899435903e1077d95d52190391d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f4e0ece3_cd40415c","updated":"2022-09-01 15:11:17.000000000","message":"Thanks for the review, Felipe. I uploaded a new patch set with the fixes.","commit_id":"bdac2329a0248b15b36fd44a9c3282a15463ca53"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"69c02f09e798131f244e5844125b8c8fb5ef556d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"829b88fe_c05f8773","updated":"2022-09-02 12:40:25.000000000","message":"lgtm","commit_id":"fdabad9f80d04d9aa2c6d35e643511e286df3740"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"3e3292dae2ba93d1489abd567020a89e16f85052","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f285dbd2_4e651970","updated":"2022-09-06 15:33:05.000000000","message":"recheck: failure is unrelated to the patch","commit_id":"b05dae1123bf6dbe8a83e078578e87aa35822e6a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"50e51edb77e3cbb3ab779574633712f90ea561bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f93a8be9_b62b6a96","updated":"2022-09-09 11:11:15.000000000","message":"pep8 failure needs to be addressed","commit_id":"76a42d74b91ea7cf50482c00f8e531b3c025e09c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"33d8b4ec37b12161f1034b80155508abf2c3f6eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"d7d84513_28dd91b1","updated":"2022-09-09 16:58:02.000000000","message":"two questions inline.","commit_id":"5d3c81afa7436a8979a910de24097ba010985261"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"ef1afbe9edcc7399005fa72b43386d82cb54324d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"ff8b7516_0c305121","updated":"2022-09-09 17:30:14.000000000","message":"thanks Rajat. Fixed in the newest patchset.","commit_id":"9757260cc9007e5090d3377b8d2d569768689799"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a62a3edb592558094d6212e372538558cb5ad510","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"7761a612_cb726ad2","updated":"2022-09-10 02:24:17.000000000","message":"All CI is now green, so upgrading to +2.","commit_id":"1c3972752f5f75b24a2a89b0b57f327a0ad343f6"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c8373affacf3d311cd34c049a5d068e3a589e094","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"c364bd99_776240d5","updated":"2022-09-09 20:49:36.000000000","message":"Code looks good and really good test coverage.  Only a +1 while waiting for Zuul (cinder-plugin-ceph-tempest failure is unrelated), and also waiting for NetApp CI (hasn\u0027t responded on PS 15 yet).","commit_id":"1c3972752f5f75b24a2a89b0b57f327a0ad343f6"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"92d63bba0065a8c52c456633a53919722c981129","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"cbac352b_0b295742","updated":"2022-09-09 17:59:45.000000000","message":"My comments have been addressed, Thanks. LGTM.","commit_id":"1c3972752f5f75b24a2a89b0b57f327a0ad343f6"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"85b36f718ccaa41856f71bb4961d106b477dc8a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"f5e9ea31_cfda85c8","updated":"2022-09-09 20:44:37.000000000","message":"recheck cinder-plugin-ceph-tempest - job timed out","commit_id":"1c3972752f5f75b24a2a89b0b57f327a0ad343f6"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e21cc8adf1c88af5fc2b43cdc2003c568678d9d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"09842d2f_1b730830","updated":"2022-09-09 21:22:06.000000000","message":"run-NetApp CI","commit_id":"1c3972752f5f75b24a2a89b0b57f327a0ad343f6"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"af8dd20b470f417c700c2870530d44f8d1809b81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"7861c850_7750f611","updated":"2022-09-09 23:14:07.000000000","message":"run-NetApp CI","commit_id":"1c3972752f5f75b24a2a89b0b57f327a0ad343f6"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"46e2a806ab2409623cb6830098c1154fd03a180f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"f74add4f_2482994e","updated":"2022-09-09 18:54:15.000000000","message":"run-NetApp CI","commit_id":"1c3972752f5f75b24a2a89b0b57f327a0ad343f6"}],"cinder/tests/unit/volume/drivers/netapp/dataontap/client/test_client_cmode_rest.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"33d8b4ec37b12161f1034b80155508abf2c3f6eb","unresolved":true,"context_lines":[{"line_number":3432,"context_line":""},{"line_number":3433,"context_line":"        self.client.send_request.assert_called_once_with("},{"line_number":3434,"context_line":"            \u0027/svm/peers\u0027, \u0027get\u0027, query\u003dquery, enable_tunneling\u003dFalse)"},{"line_number":3435,"context_line":"        self.assertEqual(result, expected_result)"},{"line_number":3436,"context_line":""},{"line_number":3437,"context_line":"    def test_get_vserver_peers_empty(self):"},{"line_number":3438,"context_line":"        vserver_peers_response \u003d copy.deepcopy("}],"source_content_type":"text/x-python","patch_set":13,"id":"c49c72e3_1e9df892","line":3435,"range":{"start_line":3435,"start_character":25,"end_line":3435,"end_character":48},"updated":"2022-09-09 16:58:02.000000000","message":"the format should be expected, result\nthat\u0027s the convention we follow throughout OpenStack","commit_id":"5d3c81afa7436a8979a910de24097ba010985261"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"ef1afbe9edcc7399005fa72b43386d82cb54324d","unresolved":false,"context_lines":[{"line_number":3432,"context_line":""},{"line_number":3433,"context_line":"        self.client.send_request.assert_called_once_with("},{"line_number":3434,"context_line":"            \u0027/svm/peers\u0027, \u0027get\u0027, query\u003dquery, enable_tunneling\u003dFalse)"},{"line_number":3435,"context_line":"        self.assertEqual(result, expected_result)"},{"line_number":3436,"context_line":""},{"line_number":3437,"context_line":"    def test_get_vserver_peers_empty(self):"},{"line_number":3438,"context_line":"        vserver_peers_response \u003d copy.deepcopy("}],"source_content_type":"text/x-python","patch_set":13,"id":"b675557b_5a63fbf7","line":3435,"range":{"start_line":3435,"start_character":25,"end_line":3435,"end_character":48},"in_reply_to":"c49c72e3_1e9df892","updated":"2022-09-09 17:30:14.000000000","message":"you\u0027re right, fixed.","commit_id":"5d3c81afa7436a8979a910de24097ba010985261"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"716e051d3db8768522d12afa45632997cc54d5aa","unresolved":true,"context_lines":[{"line_number":3450,"context_line":""},{"line_number":3451,"context_line":"        self.client.send_request.assert_called_once_with("},{"line_number":3452,"context_line":"            \u0027/svm/peers\u0027, \u0027get\u0027, query\u003dquery, enable_tunneling\u003dFalse)"},{"line_number":3453,"context_line":"        self.assertEqual(result, [])"},{"line_number":3454,"context_line":""},{"line_number":3455,"context_line":"    @ddt.data([\u0027snapmirror\u0027, \u0027lun_copy\u0027], None)"},{"line_number":3456,"context_line":"    def test_create_vserver_peer(self, applications):"}],"source_content_type":"text/x-python","patch_set":14,"id":"078105c7_1fd32664","line":3453,"range":{"start_line":3453,"start_character":25,"end_line":3453,"end_character":35},"updated":"2022-09-09 17:33:39.000000000","message":"the same pattern is repeated throughout the file","commit_id":"9757260cc9007e5090d3377b8d2d569768689799"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"c3cfb73b6ab74433190dc773cf6588229d7dd6c5","unresolved":false,"context_lines":[{"line_number":3450,"context_line":""},{"line_number":3451,"context_line":"        self.client.send_request.assert_called_once_with("},{"line_number":3452,"context_line":"            \u0027/svm/peers\u0027, \u0027get\u0027, query\u003dquery, enable_tunneling\u003dFalse)"},{"line_number":3453,"context_line":"        self.assertEqual(result, [])"},{"line_number":3454,"context_line":""},{"line_number":3455,"context_line":"    @ddt.data([\u0027snapmirror\u0027, \u0027lun_copy\u0027], None)"},{"line_number":3456,"context_line":"    def test_create_vserver_peer(self, applications):"}],"source_content_type":"text/x-python","patch_set":14,"id":"857f89d8_a1b383cf","line":3453,"range":{"start_line":3453,"start_character":25,"end_line":3453,"end_character":35},"in_reply_to":"078105c7_1fd32664","updated":"2022-09-09 17:57:13.000000000","message":"thanks, all fixed.","commit_id":"9757260cc9007e5090d3377b8d2d569768689799"}],"cinder/volume/drivers/netapp/dataontap/client/client_cmode_rest.py":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"cca0529ce1aae4b08fa0af7251a432a49ac9de39","unresolved":true,"context_lines":[{"line_number":2514,"context_line":"        \"\"\"Gets cluster name.\"\"\""},{"line_number":2515,"context_line":"        query \u003d {\u0027fields\u0027: \u0027name\u0027}"},{"line_number":2516,"context_line":""},{"line_number":2517,"context_line":"        response \u003d self.send_request(\u0027/cluster\u0027, \u0027get\u0027, query\u003dquery)"},{"line_number":2518,"context_line":""},{"line_number":2519,"context_line":"        return response[\u0027name\u0027]"},{"line_number":2520,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"609fbb2a_d9609ac9","line":2517,"range":{"start_line":2517,"start_character":55,"end_line":2517,"end_character":68},"updated":"2022-08-29 01:10:42.000000000","message":"On ZAPI it is setting the `enable_tunneling` as False, Why is it tunneling here (tunneling is the True as default) ? It is getting the cluster name, I think it doesn\u0027t need to tunnel to a SVM.","commit_id":"b61a0d6ae07a12d13913cacb25ca146b4ee67990"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"0ca9bce968fd7899435903e1077d95d52190391d","unresolved":false,"context_lines":[{"line_number":2514,"context_line":"        \"\"\"Gets cluster name.\"\"\""},{"line_number":2515,"context_line":"        query \u003d {\u0027fields\u0027: \u0027name\u0027}"},{"line_number":2516,"context_line":""},{"line_number":2517,"context_line":"        response \u003d self.send_request(\u0027/cluster\u0027, \u0027get\u0027, query\u003dquery)"},{"line_number":2518,"context_line":""},{"line_number":2519,"context_line":"        return response[\u0027name\u0027]"},{"line_number":2520,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"a16c21fc_10f11714","line":2517,"range":{"start_line":2517,"start_character":55,"end_line":2517,"end_character":68},"in_reply_to":"609fbb2a_d9609ac9","updated":"2022-09-01 15:11:17.000000000","message":"Probably forgot to add the parameter `enable_tunneling\u003dFalse`. I\u0027ll change this.","commit_id":"b61a0d6ae07a12d13913cacb25ca146b4ee67990"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"cca0529ce1aae4b08fa0af7251a432a49ac9de39","unresolved":true,"context_lines":[{"line_number":2530,"context_line":"        if vserver_name:"},{"line_number":2531,"context_line":"            query[\u0027svm.name\u0027] \u003d vserver_name"},{"line_number":2532,"context_line":""},{"line_number":2533,"context_line":"        response \u003d self.send_request(\u0027/svm/peers\u0027, \u0027get\u0027, query\u003dquery)"},{"line_number":2534,"context_line":"        records \u003d response.get(\u0027records\u0027, [])"},{"line_number":2535,"context_line":""},{"line_number":2536,"context_line":"        vserver_peers \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"d3b28098_b051dac4","line":2533,"range":{"start_line":2533,"start_character":68,"end_line":2533,"end_character":70},"updated":"2022-08-29 01:10:42.000000000","message":"same about tunneling mode","commit_id":"b61a0d6ae07a12d13913cacb25ca146b4ee67990"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"0ca9bce968fd7899435903e1077d95d52190391d","unresolved":false,"context_lines":[{"line_number":2530,"context_line":"        if vserver_name:"},{"line_number":2531,"context_line":"            query[\u0027svm.name\u0027] \u003d vserver_name"},{"line_number":2532,"context_line":""},{"line_number":2533,"context_line":"        response \u003d self.send_request(\u0027/svm/peers\u0027, \u0027get\u0027, query\u003dquery)"},{"line_number":2534,"context_line":"        records \u003d response.get(\u0027records\u0027, [])"},{"line_number":2535,"context_line":""},{"line_number":2536,"context_line":"        vserver_peers \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"46bb82a1_48add718","line":2533,"range":{"start_line":2533,"start_character":68,"end_line":2533,"end_character":70},"in_reply_to":"d3b28098_b051dac4","updated":"2022-09-01 15:11:17.000000000","message":"Done","commit_id":"b61a0d6ae07a12d13913cacb25ca146b4ee67990"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"cca0529ce1aae4b08fa0af7251a432a49ac9de39","unresolved":true,"context_lines":[{"line_number":2534,"context_line":"        records \u003d response.get(\u0027records\u0027, [])"},{"line_number":2535,"context_line":""},{"line_number":2536,"context_line":"        vserver_peers \u003d []"},{"line_number":2537,"context_line":""},{"line_number":2538,"context_line":"        for vserver_info in records:"},{"line_number":2539,"context_line":"            vserver_peer \u003d {"},{"line_number":2540,"context_line":"                \u0027vserver\u0027: vserver_info[\u0027svm\u0027][\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"756c0041_78461c5c","line":2537,"updated":"2022-08-29 01:10:42.000000000","message":"nit: remove empty line","commit_id":"b61a0d6ae07a12d13913cacb25ca146b4ee67990"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"0ca9bce968fd7899435903e1077d95d52190391d","unresolved":false,"context_lines":[{"line_number":2534,"context_line":"        records \u003d response.get(\u0027records\u0027, [])"},{"line_number":2535,"context_line":""},{"line_number":2536,"context_line":"        vserver_peers \u003d []"},{"line_number":2537,"context_line":""},{"line_number":2538,"context_line":"        for vserver_info in records:"},{"line_number":2539,"context_line":"            vserver_peer \u003d {"},{"line_number":2540,"context_line":"                \u0027vserver\u0027: vserver_info[\u0027svm\u0027][\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"db544669_1aae697c","line":2537,"in_reply_to":"756c0041_78461c5c","updated":"2022-09-01 15:11:17.000000000","message":"Done","commit_id":"b61a0d6ae07a12d13913cacb25ca146b4ee67990"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"cca0529ce1aae4b08fa0af7251a432a49ac9de39","unresolved":true,"context_lines":[{"line_number":2575,"context_line":""},{"line_number":2576,"context_line":"        body \u003d {\u0027name\u0027: dest_path}"},{"line_number":2577,"context_line":"        self._lun_update_by_path("},{"line_number":2578,"context_line":"            f\u0027/vol/{src_ontap_volume}/{lun_name}\u0027, body)"},{"line_number":2579,"context_line":""},{"line_number":2580,"context_line":"        return dest_path"},{"line_number":2581,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"4736dfcf_568a5818","line":2578,"range":{"start_line":2578,"start_character":54,"end_line":2578,"end_character":56},"updated":"2022-08-29 01:10:42.000000000","message":"The method will call \"send_request\" with \"wait_on_accepted\u003dTrue\". So, this method will wait to complete the job iteself. But the driver layer is doing the waiter too.","commit_id":"b61a0d6ae07a12d13913cacb25ca146b4ee67990"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"0ca9bce968fd7899435903e1077d95d52190391d","unresolved":false,"context_lines":[{"line_number":2575,"context_line":""},{"line_number":2576,"context_line":"        body \u003d {\u0027name\u0027: dest_path}"},{"line_number":2577,"context_line":"        self._lun_update_by_path("},{"line_number":2578,"context_line":"            f\u0027/vol/{src_ontap_volume}/{lun_name}\u0027, body)"},{"line_number":2579,"context_line":""},{"line_number":2580,"context_line":"        return dest_path"},{"line_number":2581,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"0769ada5_feef94b3","line":2578,"range":{"start_line":2578,"start_character":54,"end_line":2578,"end_character":56},"in_reply_to":"4736dfcf_568a5818","updated":"2022-09-01 15:11:17.000000000","message":"The ONTAP REST API [1] doc says that \"A successful request returns a response of 200 synchronously, which indicates that the movement has been successfully queued\" - which means that it will not wait for the LUN to be moved but only for the operation to be queued.\n\n\n[1] https://library.netapp.com/ecmdocs/ECMLP2882307/html/index.html","commit_id":"b61a0d6ae07a12d13913cacb25ca146b4ee67990"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"cca0529ce1aae4b08fa0af7251a432a49ac9de39","unresolved":true,"context_lines":[{"line_number":2577,"context_line":"        self._lun_update_by_path("},{"line_number":2578,"context_line":"            f\u0027/vol/{src_ontap_volume}/{lun_name}\u0027, body)"},{"line_number":2579,"context_line":""},{"line_number":2580,"context_line":"        return dest_path"},{"line_number":2581,"context_line":""},{"line_number":2582,"context_line":"    def get_lun_move_status(self, dest_path):"},{"line_number":2583,"context_line":"        \"\"\"Get lun move job status from a given dest_path.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"46afecfa_5dc7f614","line":2580,"range":{"start_line":2580,"start_character":8,"end_line":2580,"end_character":24},"updated":"2022-08-29 01:10:42.000000000","message":"should it return the job uuid ? The driver layer is waiting for a job and it will log and do the flow based on that.","commit_id":"b61a0d6ae07a12d13913cacb25ca146b4ee67990"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"0ca9bce968fd7899435903e1077d95d52190391d","unresolved":false,"context_lines":[{"line_number":2577,"context_line":"        self._lun_update_by_path("},{"line_number":2578,"context_line":"            f\u0027/vol/{src_ontap_volume}/{lun_name}\u0027, body)"},{"line_number":2579,"context_line":""},{"line_number":2580,"context_line":"        return dest_path"},{"line_number":2581,"context_line":""},{"line_number":2582,"context_line":"    def get_lun_move_status(self, dest_path):"},{"line_number":2583,"context_line":"        \"\"\"Get lun move job status from a given dest_path.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5d2d30a3_874f5b5d","line":2580,"range":{"start_line":2580,"start_character":8,"end_line":2580,"end_character":24},"in_reply_to":"46afecfa_5dc7f614","updated":"2022-09-01 15:11:17.000000000","message":"Since a job uuid is not returned, ONTAP REST API provide a different way to check the LUN movement status. That\u0027s why the dest_path is returned instead of the job.\n\nAs we discussed, I think the best option here is to modify the driver layer to log the correct messages and have the appropriate variable names.","commit_id":"b61a0d6ae07a12d13913cacb25ca146b4ee67990"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"cca0529ce1aae4b08fa0af7251a432a49ac9de39","unresolved":true,"context_lines":[{"line_number":2579,"context_line":""},{"line_number":2580,"context_line":"        return dest_path"},{"line_number":2581,"context_line":""},{"line_number":2582,"context_line":"    def get_lun_move_status(self, dest_path):"},{"line_number":2583,"context_line":"        \"\"\"Get lun move job status from a given dest_path.\"\"\""},{"line_number":2584,"context_line":"        lun \u003d self._get_first_lun_by_path("},{"line_number":2585,"context_line":"            dest_path, fields\u003d\u0027movement.progress\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"f10cc614_9fa8ea41","line":2582,"range":{"start_line":2582,"start_character":8,"end_line":2582,"end_character":27},"updated":"2022-08-29 01:10:42.000000000","message":"it should retrieve the job status. the driver is calling passing one object and the REST method here is getting a different one.","commit_id":"b61a0d6ae07a12d13913cacb25ca146b4ee67990"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"0ca9bce968fd7899435903e1077d95d52190391d","unresolved":false,"context_lines":[{"line_number":2579,"context_line":""},{"line_number":2580,"context_line":"        return dest_path"},{"line_number":2581,"context_line":""},{"line_number":2582,"context_line":"    def get_lun_move_status(self, dest_path):"},{"line_number":2583,"context_line":"        \"\"\"Get lun move job status from a given dest_path.\"\"\""},{"line_number":2584,"context_line":"        lun \u003d self._get_first_lun_by_path("},{"line_number":2585,"context_line":"            dest_path, fields\u003d\u0027movement.progress\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"4d60ce4d_ad46b853","line":2582,"range":{"start_line":2582,"start_character":8,"end_line":2582,"end_character":27},"in_reply_to":"f10cc614_9fa8ea41","updated":"2022-09-01 15:11:17.000000000","message":"ONTAP REST API does not provide a job uuid to get the movement status. Rather than that we must use the movement status available in the LUN endpoint.","commit_id":"b61a0d6ae07a12d13913cacb25ca146b4ee67990"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"cca0529ce1aae4b08fa0af7251a432a49ac9de39","unresolved":true,"context_lines":[{"line_number":2617,"context_line":"            \u0027svm.name\u0027: dest_vserver"},{"line_number":2618,"context_line":"        }"},{"line_number":2619,"context_line":""},{"line_number":2620,"context_line":"        self.send_request(\u0027/storage/luns\u0027, \u0027post\u0027, body\u003dbody,"},{"line_number":2621,"context_line":"                          enable_tunneling\u003dFalse)"},{"line_number":2622,"context_line":""},{"line_number":2623,"context_line":"        return dest_path"},{"line_number":2624,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"d1051df8_b03f8cc9","line":2621,"range":{"start_line":2620,"start_character":8,"end_line":2621,"end_character":49},"updated":"2022-08-29 01:10:42.000000000","message":"The method will call \"send_request\" with \"wait_on_accepted\u003dTrue\". So, this method will wait to complete the job iteself. But the driver layer is doing the waiter too.","commit_id":"b61a0d6ae07a12d13913cacb25ca146b4ee67990"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"0ca9bce968fd7899435903e1077d95d52190391d","unresolved":false,"context_lines":[{"line_number":2617,"context_line":"            \u0027svm.name\u0027: dest_vserver"},{"line_number":2618,"context_line":"        }"},{"line_number":2619,"context_line":""},{"line_number":2620,"context_line":"        self.send_request(\u0027/storage/luns\u0027, \u0027post\u0027, body\u003dbody,"},{"line_number":2621,"context_line":"                          enable_tunneling\u003dFalse)"},{"line_number":2622,"context_line":""},{"line_number":2623,"context_line":"        return dest_path"},{"line_number":2624,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"4aa88fb1_8725998f","line":2621,"range":{"start_line":2620,"start_character":8,"end_line":2621,"end_character":49},"in_reply_to":"d1051df8_b03f8cc9","updated":"2022-09-01 15:11:17.000000000","message":"Similar to start_lun_move. Fixed.","commit_id":"b61a0d6ae07a12d13913cacb25ca146b4ee67990"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"cca0529ce1aae4b08fa0af7251a432a49ac9de39","unresolved":true,"context_lines":[{"line_number":2620,"context_line":"        self.send_request(\u0027/storage/luns\u0027, \u0027post\u0027, body\u003dbody,"},{"line_number":2621,"context_line":"                          enable_tunneling\u003dFalse)"},{"line_number":2622,"context_line":""},{"line_number":2623,"context_line":"        return dest_path"},{"line_number":2624,"context_line":""},{"line_number":2625,"context_line":"    def get_lun_copy_status(self, dest_path):"},{"line_number":2626,"context_line":"        \"\"\"Get lun copy job status from a given dest_path.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"8b570aa9_9f3200f4","line":2623,"range":{"start_line":2623,"start_character":12,"end_line":2623,"end_character":23},"updated":"2022-08-29 01:10:42.000000000","message":"same about job uuid","commit_id":"b61a0d6ae07a12d13913cacb25ca146b4ee67990"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"0ca9bce968fd7899435903e1077d95d52190391d","unresolved":false,"context_lines":[{"line_number":2620,"context_line":"        self.send_request(\u0027/storage/luns\u0027, \u0027post\u0027, body\u003dbody,"},{"line_number":2621,"context_line":"                          enable_tunneling\u003dFalse)"},{"line_number":2622,"context_line":""},{"line_number":2623,"context_line":"        return dest_path"},{"line_number":2624,"context_line":""},{"line_number":2625,"context_line":"    def get_lun_copy_status(self, dest_path):"},{"line_number":2626,"context_line":"        \"\"\"Get lun copy job status from a given dest_path.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5ce053c3_428fadb7","line":2623,"range":{"start_line":2623,"start_character":12,"end_line":2623,"end_character":23},"in_reply_to":"8b570aa9_9f3200f4","updated":"2022-09-01 15:11:17.000000000","message":"Done","commit_id":"b61a0d6ae07a12d13913cacb25ca146b4ee67990"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"cca0529ce1aae4b08fa0af7251a432a49ac9de39","unresolved":true,"context_lines":[{"line_number":2622,"context_line":""},{"line_number":2623,"context_line":"        return dest_path"},{"line_number":2624,"context_line":""},{"line_number":2625,"context_line":"    def get_lun_copy_status(self, dest_path):"},{"line_number":2626,"context_line":"        \"\"\"Get lun copy job status from a given dest_path.\"\"\""},{"line_number":2627,"context_line":"        lun \u003d self._get_first_lun_by_path("},{"line_number":2628,"context_line":"            dest_path, fields\u003d\u0027copy.source.progress\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"cc4ea4b8_a9e1073d","line":2625,"range":{"start_line":2625,"start_character":9,"end_line":2625,"end_character":27},"updated":"2022-08-29 01:10:42.000000000","message":"same about driver and client different object types","commit_id":"b61a0d6ae07a12d13913cacb25ca146b4ee67990"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"0ca9bce968fd7899435903e1077d95d52190391d","unresolved":false,"context_lines":[{"line_number":2622,"context_line":""},{"line_number":2623,"context_line":"        return dest_path"},{"line_number":2624,"context_line":""},{"line_number":2625,"context_line":"    def get_lun_copy_status(self, dest_path):"},{"line_number":2626,"context_line":"        \"\"\"Get lun copy job status from a given dest_path.\"\"\""},{"line_number":2627,"context_line":"        lun \u003d self._get_first_lun_by_path("},{"line_number":2628,"context_line":"            dest_path, fields\u003d\u0027copy.source.progress\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"a5c936b9_6b7d7220","line":2625,"range":{"start_line":2625,"start_character":9,"end_line":2625,"end_character":27},"in_reply_to":"cc4ea4b8_a9e1073d","updated":"2022-09-01 15:11:17.000000000","message":"Done","commit_id":"b61a0d6ae07a12d13913cacb25ca146b4ee67990"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"33d8b4ec37b12161f1034b80155508abf2c3f6eb","unresolved":true,"context_lines":[{"line_number":2298,"context_line":"        response \u003d self.send_request(\u0027/cluster\u0027, \u0027get\u0027, query\u003dquery,"},{"line_number":2299,"context_line":"                                     enable_tunneling\u003dFalse)"},{"line_number":2300,"context_line":""},{"line_number":2301,"context_line":"        return response[\u0027name\u0027]"},{"line_number":2302,"context_line":""},{"line_number":2303,"context_line":"    def get_vserver_peers(self, vserver_name\u003dNone, peer_vserver_name\u003dNone):"},{"line_number":2304,"context_line":"        \"\"\"Gets one or more Vserver peer relationships.\"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"3aafaa04_6c1f360d","line":2301,"range":{"start_line":2301,"start_character":15,"end_line":2301,"end_character":31},"updated":"2022-09-09 16:58:02.000000000","message":"I can see that the response can be None[1] in which case this will generate a KeyError which doesn\u0027t seem correct and should be handled right?\n\n[1] https://github.com/openstack/cinder/blob/48a36c38008f08cbecaa1504f7723ed5d5f3019b/cinder/volume/drivers/netapp/dataontap/client/client_cmode_rest.py#L224","commit_id":"5d3c81afa7436a8979a910de24097ba010985261"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"ef1afbe9edcc7399005fa72b43386d82cb54324d","unresolved":true,"context_lines":[{"line_number":2298,"context_line":"        response \u003d self.send_request(\u0027/cluster\u0027, \u0027get\u0027, query\u003dquery,"},{"line_number":2299,"context_line":"                                     enable_tunneling\u003dFalse)"},{"line_number":2300,"context_line":""},{"line_number":2301,"context_line":"        return response[\u0027name\u0027]"},{"line_number":2302,"context_line":""},{"line_number":2303,"context_line":"    def get_vserver_peers(self, vserver_name\u003dNone, peer_vserver_name\u003dNone):"},{"line_number":2304,"context_line":"        \"\"\"Gets one or more Vserver peer relationships.\"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"d9d63ea8_9543c28c","line":2301,"range":{"start_line":2301,"start_character":15,"end_line":2301,"end_character":31},"in_reply_to":"3aafaa04_6c1f360d","updated":"2022-09-09 17:30:14.000000000","message":"Not really. The response will never be None, even though the response object starts as None, its value is changed right after inside the if or else block. Both blocks will get the returned value of self.connection.invoke_succefully. This function always returns a dictionary.","commit_id":"5d3c81afa7436a8979a910de24097ba010985261"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"716e051d3db8768522d12afa45632997cc54d5aa","unresolved":false,"context_lines":[{"line_number":2298,"context_line":"        response \u003d self.send_request(\u0027/cluster\u0027, \u0027get\u0027, query\u003dquery,"},{"line_number":2299,"context_line":"                                     enable_tunneling\u003dFalse)"},{"line_number":2300,"context_line":""},{"line_number":2301,"context_line":"        return response[\u0027name\u0027]"},{"line_number":2302,"context_line":""},{"line_number":2303,"context_line":"    def get_vserver_peers(self, vserver_name\u003dNone, peer_vserver_name\u003dNone):"},{"line_number":2304,"context_line":"        \"\"\"Gets one or more Vserver peer relationships.\"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"70701659_52bfa57b","line":2301,"range":{"start_line":2301,"start_character":15,"end_line":2301,"end_character":31},"in_reply_to":"d9d63ea8_9543c28c","updated":"2022-09-09 17:33:39.000000000","message":"Ack","commit_id":"5d3c81afa7436a8979a910de24097ba010985261"}]}