)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"a5db9cc6abfa60501d4a78e407dde8f985918d76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"358f138a_cc0f13fe","updated":"2022-08-29 01:13:10.000000000","message":"thanks, overall looks good! you\u0027ve just missed the release notes.","commit_id":"d3dafc1565271ed308af9472e0d37b5e753f9424"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"241a3beae4c0bbd3385149333d93a5e7cbc02681","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0a81eee9_8f0a5a30","updated":"2022-08-31 17:32:34.000000000","message":"run-NetApp CI","commit_id":"24bc95d6512c967c75fe6830ae7e42ad9d14f3c3"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"943c4b471c8b59d7ad56d0c0cf5c21c4d890af41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"556a4f53_187c1a76","updated":"2022-08-31 19:39:54.000000000","message":"run-NetApp CI","commit_id":"24bc95d6512c967c75fe6830ae7e42ad9d14f3c3"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"5f0d06941d60c716d64414648555211f3ecdf549","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9a4da67d_34122a81","updated":"2022-09-02 12:44:14.000000000","message":"LGTM.","commit_id":"c05251f86ea6c07588ee15fdfec168c437d2bc7e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f1767cd89f8b123e31778273d4764fc53eb2600a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"b06f0745_94ed56f4","updated":"2022-09-09 11:11:46.000000000","message":"recheck\n\npost_failure in tempest slow, unrelated to this patch","commit_id":"2e02e4376daa248db92dbf8bc1085501cbac3160"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0b369837f8d62af1d6325c63aa5634367b4be2da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"ee6be30e_43c525a2","updated":"2022-09-09 17:10:20.000000000","message":"run-NetApp CI","commit_id":"4b5e70888adec5e2272bde591c87b55d1106756e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0c0305d6344da746d8a1f1f51585ea45033d953d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"3abacdf1_ccea5fef","updated":"2022-09-10 02:39:53.000000000","message":"Code and tests look fine.  NetApp CI failure was the solidfire job, so not related to this patch.  The /etc/cinder/cinder.conf for the ontap jobs, however, are not setting netapp_use_legacy_client, and its default value is True.  So the plus side is that it looks like this series of patches has not caused a regression, but I guess my question is, how is the REST client being tested?","commit_id":"b0b35a874fdbe14c232cfd617f4c258cc9d1f638"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d2882a876ecec702e96e53db716d980831f35dfa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"5e16e90e_8c2f75a6","updated":"2022-09-12 20:17:09.000000000","message":"Felipe answered my questions and the NetApp CI is green; upgrading to +2.","commit_id":"b0b35a874fdbe14c232cfd617f4c258cc9d1f638"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"dfa19df974d6bab059405d07943e937aa43295a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"bd66fe04_c3bb878d","updated":"2022-09-09 17:57:53.000000000","message":"I discussed on IRC with the netapp team and the FC CI is unstable but the failures are unrelated to the REST API client changes.\ncode and tests LGTM.","commit_id":"b0b35a874fdbe14c232cfd617f4c258cc9d1f638"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"63608fcb7a6bf7fb78114cc18125d5cfe0784cba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"cc71b607_9d62d8d7","updated":"2022-09-10 13:17:56.000000000","message":"Thanks Brian I added an explanation about testing the new client.","commit_id":"b0b35a874fdbe14c232cfd617f4c258cc9d1f638"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"797dcca755b4d0e15a09a29258668991ecbcc94b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"d8a62973_2d54feb5","updated":"2022-09-09 22:20:40.000000000","message":"recheck","commit_id":"b0b35a874fdbe14c232cfd617f4c258cc9d1f638"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"86273bb55392ce7f193343b82c939de4500ae046","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"166fcd41_c3f6a7f2","updated":"2022-09-09 20:03:17.000000000","message":"recheck - failure unrelated to the patch","commit_id":"b0b35a874fdbe14c232cfd617f4c258cc9d1f638"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"de37ffb527e3f57a50be5c419150c3594f384de5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"90e40f9c_31805246","updated":"2022-09-10 02:25:51.000000000","message":"run-NetApp CI","commit_id":"b0b35a874fdbe14c232cfd617f4c258cc9d1f638"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"63608fcb7a6bf7fb78114cc18125d5cfe0784cba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"6b42ef8b_87529c0d","in_reply_to":"3abacdf1_ccea5fef","updated":"2022-09-10 13:17:56.000000000","message":"Thank you Brian for reviewing the patch. Good question! Our CI will keep running the tempest with ZAPI (legacy method), since the REST is still experimental. However, we created a downstream pipeline to run the tempest using netapp_use_legacy_client\u003dFalse (new client). I triggered an execution with this latest patch (containing all REST code), it\u0027s passed (you can access the execution log to see):\n\ncinder-tempest-plugin-ontap-iscsi-rest:  https://netappopenstacklogserver.s3.us-west-1.amazonaws.com/index.html#logs/53/1653/17/downstream-experimental/cinder-tempest-plugin-ontap-iscsi-rest/a04d949/ : SUCCESS in 46m 36s\n\ncinder-tempest-plugin-ontap-nfs-rest: https://netappopenstacklogserver.s3.us-west-1.amazonaws.com/index.html#logs/53/1653/17/downstream-experimental/cinder-tempest-plugin-ontap-nfs-rest/41a5b7d/ : SUCCESS in 1h 05m 31s","commit_id":"b0b35a874fdbe14c232cfd617f4c258cc9d1f638"}]}
