)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"4c93f7e8a16c4555d9282e57715d25db87953f72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"30302ca8_433951ae","updated":"2022-08-11 14:57:12.000000000","message":"Do we document the behavior of \"driver_volume_type\" somewhere?\n\ndoc/source/contributors/drivers.rst mentions that we shouldn\u0027t confuse it with storage_protocol, but seems lacking in actual explanation.\n\nMaybe would be a useful follow-up patch...","commit_id":"2e15704db3940147f0cde9086df130db42d9a421"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"dc85cd624ddf244b90409e671a2e423147ce7f81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c5696fff_03639e75","updated":"2022-08-11 13:14:49.000000000","message":"I think this makes sense.  -1 because I think there\u0027s one more place where you need to make the change.  Otherwise looks good.","commit_id":"2e15704db3940147f0cde9086df130db42d9a421"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"81ddcc063bfb423693018118f3eef2b8fe73db80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e795ca3b_f00b58e7","updated":"2022-11-07 16:20:14.000000000","message":"Thanks Brian","commit_id":"2e15704db3940147f0cde9086df130db42d9a421"},{"author":{"_account_id":34815,"name":"Aneesh Pachilangottil","email":"aneesh.p@fungible.com","username":"aneeeshp1"},"change_message_id":"2328a625b2e4ebdd4ff55925d396a2d7e3e4e0f9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"92b673f8_003a0f63","updated":"2022-11-08 23:54:30.000000000","message":"While going through this patch, just noticed a place where DRIVER_VOLUME_TYPE is assigned to self._stats[\"storage_protocol\"].\n\nhttps://opendev.org/openstack/cinder/src/commit/2603af55e18cdfbca930c1502e83fc05c35d5daf/cinder/volume/drivers/veritas_cnfs.py#L190\n\nRenaming DRIVER_VOLUME_TYPE or using constants.NFS_VARIANT in place of DRIVER_VOLUME_TYPE may be helpful.","commit_id":"98afb031736d9082eeb2cbee6ff6464baf8f2738"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"71fea93c396bda8c25e418bda08603b39fef74da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1415cad4_0294ad70","updated":"2023-07-10 16:42:16.000000000","message":"recheck for fresh logs","commit_id":"98afb031736d9082eeb2cbee6ff6464baf8f2738"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"606775c15133f29378234b8a90483ab13e5e7d89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f04631ff_f39a4708","updated":"2023-07-11 07:59:38.000000000","message":"recheck zuul not triggered","commit_id":"98afb031736d9082eeb2cbee6ff6464baf8f2738"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"71fea93c396bda8c25e418bda08603b39fef74da","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c8e13490_b1d9236f","in_reply_to":"92b673f8_003a0f63","updated":"2023-07-10 16:42:16.000000000","message":"There are few things due to which this change wouldn\u0027t be worth it,\n\n1. The Veritas CNFS driver is unsupported\n2. the DRIVER_VOLUME_TYPE is set to constants.NFS_VARIANT in the same class[1]\n\n[1] https://opendev.org/openstack/cinder/src/commit/2603af55e18cdfbca930c1502e83fc05c35d5daf/cinder/volume/drivers/veritas_cnfs.py#L56","commit_id":"98afb031736d9082eeb2cbee6ff6464baf8f2738"}],"cinder/volume/drivers/remotefs.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"dc85cd624ddf244b90409e671a2e423147ce7f81","unresolved":true,"context_lines":[{"line_number":2066,"context_line":"        data[\u0027volume_backend_name\u0027] \u003d backend_name or self.volume_backend_name"},{"line_number":2067,"context_line":"        data[\u0027vendor_name\u0027] \u003d self.vendor_name"},{"line_number":2068,"context_line":"        data[\u0027driver_version\u0027] \u003d self.get_version()"},{"line_number":2069,"context_line":"        data[\u0027storage_protocol\u0027] \u003d self.driver_volume_type"},{"line_number":2070,"context_line":""},{"line_number":2071,"context_line":"        self._ensure_shares_mounted()"},{"line_number":2072,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"02324b63_0ed5eccb","line":2069,"range":{"start_line":2069,"start_character":8,"end_line":2069,"end_character":58},"updated":"2022-08-11 13:14:49.000000000","message":"I think you need the same change as line 650-651 here?","commit_id":"2e15704db3940147f0cde9086df130db42d9a421"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"81ddcc063bfb423693018118f3eef2b8fe73db80","unresolved":false,"context_lines":[{"line_number":2066,"context_line":"        data[\u0027volume_backend_name\u0027] \u003d backend_name or self.volume_backend_name"},{"line_number":2067,"context_line":"        data[\u0027vendor_name\u0027] \u003d self.vendor_name"},{"line_number":2068,"context_line":"        data[\u0027driver_version\u0027] \u003d self.get_version()"},{"line_number":2069,"context_line":"        data[\u0027storage_protocol\u0027] \u003d self.driver_volume_type"},{"line_number":2070,"context_line":""},{"line_number":2071,"context_line":"        self._ensure_shares_mounted()"},{"line_number":2072,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"8761966e_07ded1da","line":2069,"range":{"start_line":2069,"start_character":8,"end_line":2069,"end_character":58},"in_reply_to":"02324b63_0ed5eccb","updated":"2022-11-07 16:20:14.000000000","message":"Done","commit_id":"2e15704db3940147f0cde9086df130db42d9a421"}]}