)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"aaa1e2b52b8907853ef14daebaafe2f64e3d0084","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"747a3887_b72e0fe7","updated":"2022-08-16 15:41:52.000000000","message":"I have addressed with this review lack of unit tests, obsolete or unnecessary code (storage version), and have made a few places more clear in coding and wording. This review will allow us to proceed with bug-fixes in follow-up reviews.","commit_id":"0a0a0d4710c55d094fe1d63565d466e15b5ce660"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"50d17bf4ebb5171aabb1fb36dc9262a8597a652a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"178baff9_fd504374","updated":"2022-08-31 12:42:20.000000000","message":"run-Yadro Tatlin Unified CI","commit_id":"c7df0cf373371f9ff075badec496e6a7c734a4bc"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"951b706e328fc4fb4a75df9b2d9bca12364ae65b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2052b9d7_12273031","updated":"2022-08-17 14:05:34.000000000","message":"run-Yadro Tatlin Unified CI","commit_id":"c7df0cf373371f9ff075badec496e6a7c734a4bc"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"17f63d9a7efe3d12230bf8c1e1018e94baf19ac1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5832eccf_24adb9dd","updated":"2022-08-17 14:11:18.000000000","message":"run-Yadro Tatlin Unified CI","commit_id":"c7df0cf373371f9ff075badec496e6a7c734a4bc"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"a3dc455a3278b96682e86e31a7d85ea94c972522","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a9d6986c_d4fe50e7","updated":"2022-08-17 13:27:06.000000000","message":"run-Yadro Tatlin Unified CI","commit_id":"c7df0cf373371f9ff075badec496e6a7c734a4bc"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"119446ff2283d2eecb11a02c6455685bb964a7b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bbd5761c_69d4a5fb","updated":"2022-08-17 13:21:34.000000000","message":"run-Yadro Tatlin Unified CI","commit_id":"c7df0cf373371f9ff075badec496e6a7c734a4bc"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"798165b086d119403c099d2b33f1a9c1eeb74414","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"dfd9592b_95254075","updated":"2022-08-22 07:04:09.000000000","message":"run-Yadro Tatlin Unified CI","commit_id":"c7df0cf373371f9ff075badec496e6a7c734a4bc"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"122c966780063018adf757cc7e48ec3d9109c620","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"df55e2b2_d996b6a1","updated":"2022-09-05 19:32:52.000000000","message":"One issue i see throughout is regarding the import of classes and methods rather than modules. We follow the standard of only importing modules and that should be consistent here as well.","commit_id":"cbe34430087e41b6f3e9277628ba5e1b55a923ce"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"6dac1aae87e5de9260152b0b0c21222314c0ab4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1f345c26_574b1e82","updated":"2022-09-02 15:31:50.000000000","message":"run-Yadro Tatlin Unified CI","commit_id":"cbe34430087e41b6f3e9277628ba5e1b55a923ce"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"c5055d22146fe62c17036fcbbddee33f650187f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"aa3ef178_5b8b8f68","updated":"2022-09-05 08:01:09.000000000","message":"run-Yadro Tatlin Unified CI","commit_id":"cbe34430087e41b6f3e9277628ba5e1b55a923ce"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"deb580ba30457e0637f8a2038f4bb6f930566f2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"613b9586_578aa074","in_reply_to":"6c0e8416_d39c02b5","updated":"2022-09-07 09:10:46.000000000","message":"Done","commit_id":"cbe34430087e41b6f3e9277628ba5e1b55a923ce"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"e1bb528a3e11e1a12004371924f58d5a015aaf1e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6c0e8416_d39c02b5","in_reply_to":"df55e2b2_d996b6a1","updated":"2022-09-06 06:24:35.000000000","message":"thank you very much, Rajat! The required changes are underway.","commit_id":"cbe34430087e41b6f3e9277628ba5e1b55a923ce"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"66f92d06ab4fbe5244dea7aade7c9855640989c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2b4d8bab_e7586060","updated":"2022-09-07 14:45:15.000000000","message":"I would split syntax changes and bug fixes? later, when things go south, it will be easier to see where is the issue.","commit_id":"551a1ffdad4c01d04e149996a7de76a824d39822"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"be9cf86aefc31396b4159959f13e1f6f55f34728","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"231fc3c3_02a505a7","updated":"2022-09-07 09:59:28.000000000","message":"run-Yadro Tatlin Unified CI","commit_id":"551a1ffdad4c01d04e149996a7de76a824d39822"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"79bdd56a700ddd36f855ed5354a7c9a9060a2eb8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b61c74b9_62d61867","updated":"2022-09-12 08:08:39.000000000","message":"Overall looks good.\nOne issue noted in tests which does not follow our format of assertions in Cinder i.e. (expected, result)","commit_id":"489a70e09402368896bd0cd190a2171f9ad9bcbb"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"55c1025141f63709a289d3cbc3391014be17fac5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ae4d27e1_f31787a6","updated":"2022-09-09 12:29:51.000000000","message":"run-Yadro Tatlin Unified CI","commit_id":"489a70e09402368896bd0cd190a2171f9ad9bcbb"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"340aaf15027d8469c8ccb327baabe01e9ac42e56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e384cf3a_5be23a05","updated":"2022-09-09 12:35:30.000000000","message":"run-Yadro Tatlin Unified CI","commit_id":"489a70e09402368896bd0cd190a2171f9ad9bcbb"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"45682385bdf1846b1047f0133a04042e9d7c4394","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"feee570f_bd52d920","in_reply_to":"30185cd9_6d6b7328","updated":"2022-09-12 11:22:09.000000000","message":"Done","commit_id":"489a70e09402368896bd0cd190a2171f9ad9bcbb"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"bb73d95f2c4903b35b984d302af47982cc390d33","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"30185cd9_6d6b7328","in_reply_to":"b61c74b9_62d61867","updated":"2022-09-12 09:08:19.000000000","message":"thanks for your guidance!","commit_id":"489a70e09402368896bd0cd190a2171f9ad9bcbb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"224b5f2a9de552b134612fe96cd6e30e35224f28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f43e2ad8_6d35d256","updated":"2022-09-12 19:51:38.000000000","message":"My comments have been addressed. CI is green. LGTM. Thanks!","commit_id":"899a4227449d22ea4e0c29233381e7e80a4973a6"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"3f61ede5aff304b5ef6acf8bb2d3d7dcf9546d5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d58c4b58_5b793b9a","updated":"2022-10-24 07:56:11.000000000","message":"i will try to split this review into much smaller chunks if it\u0027s hard to review","commit_id":"899a4227449d22ea4e0c29233381e7e80a4973a6"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"ce901ee6a1a431b0c65177a3116d570f654a718b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f52f4956_c08a4961","updated":"2022-10-24 12:38:22.000000000","message":"see \nhttps://review.opendev.org/c/openstack/cinder/+/862489\nhttps://review.opendev.org/c/openstack/cinder/+/862491\nhttps://review.opendev.org/c/openstack/cinder/+/862490\n\nAfter the reviews I will revive this one to catch up with left tests\n","commit_id":"899a4227449d22ea4e0c29233381e7e80a4973a6"}],"cinder/tests/unit/volume/drivers/yadro/test_tatlin_iscsi.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"79bdd56a700ddd36f855ed5354a7c9a9060a2eb8","unresolved":true,"context_lines":[{"line_number":189,"context_line":"    def test_get_ports_portals(self, get_port_portal):"},{"line_number":190,"context_line":"        get_port_portal.return_value \u003d tc.PORTS_RESP"},{"line_number":191,"context_line":"        pp \u003d self.driver._get_ports_portals()"},{"line_number":192,"context_line":"        self.assertDictEqual(pp, ISCSI_PORT_PORTALS)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    @mock.patch.object(tatlin_client.TatlinClientCommon,"},{"line_number":195,"context_line":"                       \u0027get_host_info\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"411b8fbd_5ca220d3","line":192,"range":{"start_line":192,"start_character":29,"end_line":192,"end_character":51},"updated":"2022-09-12 08:08:39.000000000","message":"I think we will need to update the tests to correct the placement of these parameters as (expected, result)","commit_id":"489a70e09402368896bd0cd190a2171f9ad9bcbb"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"45682385bdf1846b1047f0133a04042e9d7c4394","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    def test_get_ports_portals(self, get_port_portal):"},{"line_number":190,"context_line":"        get_port_portal.return_value \u003d tc.PORTS_RESP"},{"line_number":191,"context_line":"        pp \u003d self.driver._get_ports_portals()"},{"line_number":192,"context_line":"        self.assertDictEqual(pp, ISCSI_PORT_PORTALS)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    @mock.patch.object(tatlin_client.TatlinClientCommon,"},{"line_number":195,"context_line":"                       \u0027get_host_info\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"869b3aa9_08965681","line":192,"range":{"start_line":192,"start_character":29,"end_line":192,"end_character":51},"in_reply_to":"411b8fbd_5ca220d3","updated":"2022-09-12 11:22:09.000000000","message":"Done","commit_id":"489a70e09402368896bd0cd190a2171f9ad9bcbb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"79bdd56a700ddd36f855ed5354a7c9a9060a2eb8","unresolved":true,"context_lines":[{"line_number":237,"context_line":"                         VOLUME_DATA[\u0027auth_method\u0027])"},{"line_number":238,"context_line":"        self.assertEqual(data[\u0027auth_username\u0027],"},{"line_number":239,"context_line":"                         VOLUME_DATA[\u0027auth_username\u0027])"},{"line_number":240,"context_line":"        self.assertEqual(data[\u0027auth_password\u0027],"},{"line_number":241,"context_line":"                         VOLUME_DATA[\u0027auth_password\u0027])"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def test_create_volume_data_no_chap_no_data(self):"},{"line_number":244,"context_line":"        self.driver._auth_method \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"4205bab5_b164df0a","line":241,"range":{"start_line":240,"start_character":25,"end_line":241,"end_character":53},"updated":"2022-09-12 08:08:39.000000000","message":"the format we follow throughout our code is (expected, result)\nHere i asume data is the result dict so it should come after the VOLUME_DATA field","commit_id":"489a70e09402368896bd0cd190a2171f9ad9bcbb"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"45682385bdf1846b1047f0133a04042e9d7c4394","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                         VOLUME_DATA[\u0027auth_method\u0027])"},{"line_number":238,"context_line":"        self.assertEqual(data[\u0027auth_username\u0027],"},{"line_number":239,"context_line":"                         VOLUME_DATA[\u0027auth_username\u0027])"},{"line_number":240,"context_line":"        self.assertEqual(data[\u0027auth_password\u0027],"},{"line_number":241,"context_line":"                         VOLUME_DATA[\u0027auth_password\u0027])"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def test_create_volume_data_no_chap_no_data(self):"},{"line_number":244,"context_line":"        self.driver._auth_method \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"e5263ffb_8e5f140e","line":241,"range":{"start_line":240,"start_character":25,"end_line":241,"end_character":53},"in_reply_to":"4205bab5_b164df0a","updated":"2022-09-12 11:22:09.000000000","message":"Done","commit_id":"489a70e09402368896bd0cd190a2171f9ad9bcbb"}],"cinder/volume/drivers/yadro/tatlin_client.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"122c966780063018adf757cc7e48ec3d9109c620","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_log import log as logging"},{"line_number":19,"context_line":"import requests"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from cinder.exception import NotAuthorized"},{"line_number":22,"context_line":"from cinder.exception import VolumeBackendAPIException"},{"line_number":23,"context_line":"from cinder.i18n import _"},{"line_number":24,"context_line":"from cinder.utils import retry"},{"line_number":25,"context_line":"from cinder.volume.drivers.yadro import tatlin_api"}],"source_content_type":"text/x-python","patch_set":6,"id":"98db9dbe_0c167760","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":54},"updated":"2022-09-05 19:32:52.000000000","message":"same","commit_id":"cbe34430087e41b6f3e9277628ba5e1b55a923ce"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"deb580ba30457e0637f8a2038f4bb6f930566f2b","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_log import log as logging"},{"line_number":19,"context_line":"import requests"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from cinder.exception import NotAuthorized"},{"line_number":22,"context_line":"from cinder.exception import VolumeBackendAPIException"},{"line_number":23,"context_line":"from cinder.i18n import _"},{"line_number":24,"context_line":"from cinder.utils import retry"},{"line_number":25,"context_line":"from cinder.volume.drivers.yadro import tatlin_api"}],"source_content_type":"text/x-python","patch_set":6,"id":"b13d741d_72eefc4c","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":54},"in_reply_to":"98db9dbe_0c167760","updated":"2022-09-07 09:10:46.000000000","message":"Done","commit_id":"cbe34430087e41b6f3e9277628ba5e1b55a923ce"}],"cinder/volume/drivers/yadro/tatlin_common.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"122c966780063018adf757cc7e48ec3d9109c620","unresolved":true,"context_lines":[{"line_number":21,"context_line":"from oslo_utils import units"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from cinder import context as cinder_context"},{"line_number":24,"context_line":"from cinder.exception import InvalidInput"},{"line_number":25,"context_line":"from cinder.exception import ManageExistingInvalidReference"},{"line_number":26,"context_line":"from cinder.exception import VolumeBackendAPIException"},{"line_number":27,"context_line":"from cinder.i18n import _"},{"line_number":28,"context_line":"from cinder import objects"},{"line_number":29,"context_line":"from cinder import utils"}],"source_content_type":"text/x-python","patch_set":6,"id":"86c66dc3_ee493290","line":26,"range":{"start_line":24,"start_character":29,"end_line":26,"end_character":54},"updated":"2022-09-05 19:32:52.000000000","message":"import modules not classes\n\nhttps://docs.openstack.org/hacking/latest/user/hacking.html#imports","commit_id":"cbe34430087e41b6f3e9277628ba5e1b55a923ce"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"deb580ba30457e0637f8a2038f4bb6f930566f2b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from oslo_utils import units"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from cinder import context as cinder_context"},{"line_number":24,"context_line":"from cinder.exception import InvalidInput"},{"line_number":25,"context_line":"from cinder.exception import ManageExistingInvalidReference"},{"line_number":26,"context_line":"from cinder.exception import VolumeBackendAPIException"},{"line_number":27,"context_line":"from cinder.i18n import _"},{"line_number":28,"context_line":"from cinder import objects"},{"line_number":29,"context_line":"from cinder import utils"}],"source_content_type":"text/x-python","patch_set":6,"id":"44b89af9_b1b82267","line":26,"range":{"start_line":24,"start_character":29,"end_line":26,"end_character":54},"in_reply_to":"86c66dc3_ee493290","updated":"2022-09-07 09:10:46.000000000","message":"Done","commit_id":"cbe34430087e41b6f3e9277628ba5e1b55a923ce"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"122c966780063018adf757cc7e48ec3d9109c620","unresolved":true,"context_lines":[{"line_number":30,"context_line":"from cinder.volume import configuration"},{"line_number":31,"context_line":"from cinder.volume import driver"},{"line_number":32,"context_line":"from cinder.volume.drivers.san import san"},{"line_number":33,"context_line":"from cinder.volume.drivers.yadro.tatlin_client import InitTatlinClient"},{"line_number":34,"context_line":"from cinder.volume.drivers.yadro.tatlin_utils import TatlinVolumeConnections"},{"line_number":35,"context_line":"from cinder.volume import qos_specs"},{"line_number":36,"context_line":"from cinder.volume import volume_types"}],"source_content_type":"text/x-python","patch_set":6,"id":"354712f0_1b275be2","line":33,"range":{"start_line":33,"start_character":54,"end_line":33,"end_character":70},"updated":"2022-09-05 19:32:52.000000000","message":"same","commit_id":"cbe34430087e41b6f3e9277628ba5e1b55a923ce"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"deb580ba30457e0637f8a2038f4bb6f930566f2b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from cinder.volume import configuration"},{"line_number":31,"context_line":"from cinder.volume import driver"},{"line_number":32,"context_line":"from cinder.volume.drivers.san import san"},{"line_number":33,"context_line":"from cinder.volume.drivers.yadro.tatlin_client import InitTatlinClient"},{"line_number":34,"context_line":"from cinder.volume.drivers.yadro.tatlin_utils import TatlinVolumeConnections"},{"line_number":35,"context_line":"from cinder.volume import qos_specs"},{"line_number":36,"context_line":"from cinder.volume import volume_types"}],"source_content_type":"text/x-python","patch_set":6,"id":"8066d638_e898f261","line":33,"range":{"start_line":33,"start_character":54,"end_line":33,"end_character":70},"in_reply_to":"354712f0_1b275be2","updated":"2022-09-07 09:10:46.000000000","message":"Done","commit_id":"cbe34430087e41b6f3e9277628ba5e1b55a923ce"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"122c966780063018adf757cc7e48ec3d9109c620","unresolved":true,"context_lines":[{"line_number":31,"context_line":"from cinder.volume import driver"},{"line_number":32,"context_line":"from cinder.volume.drivers.san import san"},{"line_number":33,"context_line":"from cinder.volume.drivers.yadro.tatlin_client import InitTatlinClient"},{"line_number":34,"context_line":"from cinder.volume.drivers.yadro.tatlin_utils import TatlinVolumeConnections"},{"line_number":35,"context_line":"from cinder.volume import qos_specs"},{"line_number":36,"context_line":"from cinder.volume import volume_types"},{"line_number":37,"context_line":"from cinder.volume import volume_utils"}],"source_content_type":"text/x-python","patch_set":6,"id":"e870f33d_33d6bcac","line":34,"range":{"start_line":34,"start_character":53,"end_line":34,"end_character":76},"updated":"2022-09-05 19:32:52.000000000","message":"same","commit_id":"cbe34430087e41b6f3e9277628ba5e1b55a923ce"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"deb580ba30457e0637f8a2038f4bb6f930566f2b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from cinder.volume import driver"},{"line_number":32,"context_line":"from cinder.volume.drivers.san import san"},{"line_number":33,"context_line":"from cinder.volume.drivers.yadro.tatlin_client import InitTatlinClient"},{"line_number":34,"context_line":"from cinder.volume.drivers.yadro.tatlin_utils import TatlinVolumeConnections"},{"line_number":35,"context_line":"from cinder.volume import qos_specs"},{"line_number":36,"context_line":"from cinder.volume import volume_types"},{"line_number":37,"context_line":"from cinder.volume import volume_utils"}],"source_content_type":"text/x-python","patch_set":6,"id":"f1da7c01_1c2b4892","line":34,"range":{"start_line":34,"start_character":53,"end_line":34,"end_character":76},"in_reply_to":"e870f33d_33d6bcac","updated":"2022-09-07 09:10:46.000000000","message":"Done","commit_id":"cbe34430087e41b6f3e9277628ba5e1b55a923ce"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"122c966780063018adf757cc7e48ec3d9109c620","unresolved":true,"context_lines":[{"line_number":35,"context_line":"from cinder.volume import qos_specs"},{"line_number":36,"context_line":"from cinder.volume import volume_types"},{"line_number":37,"context_line":"from cinder.volume import volume_utils"},{"line_number":38,"context_line":"from cinder.volume.volume_utils import brick_get_connector_properties"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":6,"id":"478b45f6_6714474f","line":38,"range":{"start_line":38,"start_character":39,"end_line":38,"end_character":69},"updated":"2022-09-05 19:32:52.000000000","message":"import modules not methods","commit_id":"cbe34430087e41b6f3e9277628ba5e1b55a923ce"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"deb580ba30457e0637f8a2038f4bb6f930566f2b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"from cinder.volume import qos_specs"},{"line_number":36,"context_line":"from cinder.volume import volume_types"},{"line_number":37,"context_line":"from cinder.volume import volume_utils"},{"line_number":38,"context_line":"from cinder.volume.volume_utils import brick_get_connector_properties"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":6,"id":"71bcc5f7_eb474b52","line":38,"range":{"start_line":38,"start_character":39,"end_line":38,"end_character":69},"in_reply_to":"478b45f6_6714474f","updated":"2022-09-07 09:10:46.000000000","message":"Done","commit_id":"cbe34430087e41b6f3e9277628ba5e1b55a923ce"}],"cinder/volume/drivers/yadro/tatlin_iscsi.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"122c966780063018adf757cc7e48ec3d9109c620","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_log import log as logging"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from cinder.exception import VolumeBackendAPIException"},{"line_number":19,"context_line":"from cinder.i18n import _"},{"line_number":20,"context_line":"from cinder import interface"},{"line_number":21,"context_line":"from cinder import utils"}],"source_content_type":"text/x-python","patch_set":6,"id":"bbf46c21_8bb8571b","line":18,"range":{"start_line":18,"start_character":29,"end_line":18,"end_character":54},"updated":"2022-09-05 19:32:52.000000000","message":"we should only import modules not classes","commit_id":"cbe34430087e41b6f3e9277628ba5e1b55a923ce"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"deb580ba30457e0637f8a2038f4bb6f930566f2b","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_log import log as logging"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from cinder.exception import VolumeBackendAPIException"},{"line_number":19,"context_line":"from cinder.i18n import _"},{"line_number":20,"context_line":"from cinder import interface"},{"line_number":21,"context_line":"from cinder import utils"}],"source_content_type":"text/x-python","patch_set":6,"id":"8f92c339_1e32e753","line":18,"range":{"start_line":18,"start_character":29,"end_line":18,"end_character":54},"in_reply_to":"bbf46c21_8bb8571b","updated":"2022-09-07 09:10:46.000000000","message":"Done","commit_id":"cbe34430087e41b6f3e9277628ba5e1b55a923ce"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"122c966780063018adf757cc7e48ec3d9109c620","unresolved":true,"context_lines":[{"line_number":20,"context_line":"from cinder import interface"},{"line_number":21,"context_line":"from cinder import utils"},{"line_number":22,"context_line":"from cinder.volume import driver"},{"line_number":23,"context_line":"from cinder.volume.drivers.yadro.tatlin_common import TatlinCommonVolumeDriver"},{"line_number":24,"context_line":"from cinder.volume import volume_utils"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":6,"id":"63d57bd8_104bd7b0","line":23,"range":{"start_line":23,"start_character":54,"end_line":23,"end_character":78},"updated":"2022-09-05 19:32:52.000000000","message":"same","commit_id":"cbe34430087e41b6f3e9277628ba5e1b55a923ce"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"deb580ba30457e0637f8a2038f4bb6f930566f2b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from cinder import interface"},{"line_number":21,"context_line":"from cinder import utils"},{"line_number":22,"context_line":"from cinder.volume import driver"},{"line_number":23,"context_line":"from cinder.volume.drivers.yadro.tatlin_common import TatlinCommonVolumeDriver"},{"line_number":24,"context_line":"from cinder.volume import volume_utils"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":6,"id":"e0025a20_22d0bdb7","line":23,"range":{"start_line":23,"start_character":54,"end_line":23,"end_character":78},"in_reply_to":"63d57bd8_104bd7b0","updated":"2022-09-07 09:10:46.000000000","message":"Done","commit_id":"cbe34430087e41b6f3e9277628ba5e1b55a923ce"}]}