)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e32721b3eb1edfc4e99aa4b8bca9cfa1f27f76e0","unresolved":true,"context_lines":[{"line_number":15,"context_line":"unable to reproduce the issue again even when running tests with"},{"line_number":16,"context_line":"\u0027--random\u0027."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"We have to way to know existing looping calls that must be stopped,"},{"line_number":19,"context_line":"tracking them with a decorator on the LoopingCallBase class __init__"},{"line_number":20,"context_line":"method or looking for its instances in the objects tracked by the"},{"line_number":21,"context_line":"Garbage Collector."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"85422184_9d6fc2a9","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":32},"updated":"2022-08-24 16:50:54.000000000","message":"Maybe, \"We need a way to identify\"","commit_id":"c0863e79853c0c0ae363d87e4bf801c16af2ecaf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e32721b3eb1edfc4e99aa4b8bca9cfa1f27f76e0","unresolved":true,"context_lines":[{"line_number":21,"context_line":"Garbage Collector."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Using the GC mechanisms makes tests take 12 times longer to complete, so"},{"line_number":24,"context_line":"this patch creates a new test utils class called InstanceTracke that"},{"line_number":25,"context_line":"allows tracking any class."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"We haven\u0027t been able to reproduce the test runner freeze situation with"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a8809a31_07dff39e","line":24,"range":{"start_line":24,"start_character":49,"end_line":24,"end_character":63},"updated":"2022-08-24 16:50:54.000000000","message":"missing the final \u0027r\u0027","commit_id":"c0863e79853c0c0ae363d87e4bf801c16af2ecaf"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fc8630936f2d96840bcc36a739abad39c00fc45d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f818d354_fbbf871e","updated":"2022-08-24 18:46:47.000000000","message":"Still looks good!","commit_id":"c0863e79853c0c0ae363d87e4bf801c16af2ecaf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e32721b3eb1edfc4e99aa4b8bca9cfa1f27f76e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2efaf3da_633830f5","updated":"2022-08-24 16:50:54.000000000","message":"This is very clever ... so clever that I want to look at it again after lunch.  All I could find on this run-through were some typos.","commit_id":"c0863e79853c0c0ae363d87e4bf801c16af2ecaf"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5305efc2b10ae533ab9f4d4f2be887241efeac61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"860d21a7_fff42894","in_reply_to":"2efaf3da_633830f5","updated":"2022-08-24 17:35:54.000000000","message":"Gorka and his beloved typos.  Even my branch name has one, so now the topic is rbd-native-treads instead of rbd-native-threads.\n\nIn my defense, I only went with the \"clever\" solution after trying the gc.objects approach first, but with the gc approach running tests went from less than 10 minutes to almost 2 hours.\n\nI\u0027ll wait for your final review before submitting a new series of patches fixing those typos.","commit_id":"c0863e79853c0c0ae363d87e4bf801c16af2ecaf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6d33bce584e96ec4c5cadd105c361cc22f14fcf5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"943a8589_0c5b8f62","updated":"2022-08-30 01:41:53.000000000","message":"Revision LGTM.","commit_id":"eb8409b3a8af41e2203e3b84bc6f02167ceef6a4"}],"cinder/tests/unit/utils.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e32721b3eb1edfc4e99aa4b8bca9cfa1f27f76e0","unresolved":true,"context_lines":[{"line_number":604,"context_line":"    Going through the Garbage collection objects searching for instances makes"},{"line_number":605,"context_line":"    tests take up to 12 times longer."},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"    The slower GC code alternative that was compared whas something like:"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"        for obj in gc.get_objects():"},{"line_number":610,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"8c4af0d1_6c19765d","line":607,"range":{"start_line":607,"start_character":53,"end_line":607,"end_character":57},"updated":"2022-08-24 16:50:54.000000000","message":"was","commit_id":"c0863e79853c0c0ae363d87e4bf801c16af2ecaf"}]}
