)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3d7b8a83179cf914ba08d96d1f817c4cef10a9a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a4133666_126e3260","updated":"2022-08-24 21:51:30.000000000","message":"Fixes look OK to me.","commit_id":"f061eaeeca8f117cb00326df40e8f8b931826efe"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"2518f1582c30a4e4e539567ef9b8ce35090d3af6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2262c2ee_33076bdf","updated":"2022-08-29 19:50:38.000000000","message":"LGTM","commit_id":"e2278994384e3e4e2b36a3e614d0a832a8bd1f50"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"aba8fb0c03f050b389d3a0acc06cb959bece6381","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e925ebe7_2e63b3d9","updated":"2022-09-13 07:29:17.000000000","message":"LGTM","commit_id":"e2278994384e3e4e2b36a3e614d0a832a8bd1f50"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5312e845532fd8c0da8213f19cb32903376fd285","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"92ad4050_5bf34db9","updated":"2022-08-30 01:47:18.000000000","message":"LGTM.","commit_id":"e2278994384e3e4e2b36a3e614d0a832a8bd1f50"}],"cinder/tests/unit/zonemanager/test_brcd_fc_zone_driver.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3d7b8a83179cf914ba08d96d1f817c4cef10a9a9","unresolved":true,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def setUp(self):"},{"line_number":95,"context_line":"        global GlobalVars"},{"line_number":96,"context_line":"        GlobalVars \u003d GlobalVarsClass()"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        super(TestBrcdFcZoneDriver, self).setUp()"},{"line_number":99,"context_line":"        # setup config for normal flow"}],"source_content_type":"text/x-python","patch_set":1,"id":"aa8926bf_63adb94f","line":96,"updated":"2022-08-24 21:51:30.000000000","message":"This whole use of global vars is freaking me out, but it looks like this will give each test its own freshly-minted instance of GlobalVars to work with, and the init method you defined for the GVClass will make the data members local to that instance, so it looks like we\u0027ll get sufficient isolation for each test without having to completely rewrite the entire file.  But this is definitely not a test pattern that we want to encourage!","commit_id":"f061eaeeca8f117cb00326df40e8f8b931826efe"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7d77c35adc2baa4d8ea995e7a087b8d345ca6c15","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def setUp(self):"},{"line_number":95,"context_line":"        global GlobalVars"},{"line_number":96,"context_line":"        GlobalVars \u003d GlobalVarsClass()"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        super(TestBrcdFcZoneDriver, self).setUp()"},{"line_number":99,"context_line":"        # setup config for normal flow"}],"source_content_type":"text/x-python","patch_set":1,"id":"58bdf4e3_b44299ed","line":96,"in_reply_to":"aa8926bf_63adb94f","updated":"2022-08-29 12:22:09.000000000","message":"Agreed.  Using global variables and constants should be done carefully. :-(","commit_id":"f061eaeeca8f117cb00326df40e8f8b931826efe"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3d7b8a83179cf914ba08d96d1f817c4cef10a9a9","unresolved":true,"context_lines":[{"line_number":273,"context_line":""},{"line_number":274,"context_line":"class GlobalVarsClass(object):"},{"line_number":275,"context_line":"    def __init__(self):"},{"line_number":276,"context_line":"        self. _active_cfg \u003d {}"},{"line_number":277,"context_line":"        self._zone_state \u003d list()"},{"line_number":278,"context_line":"        self._is_normal_test \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fd01315_06ff8eaf","line":276,"range":{"start_line":276,"start_character":13,"end_line":276,"end_character":14},"updated":"2022-08-24 21:51:30.000000000","message":"Nothing wrong with this space, though it looks a little odd.","commit_id":"f061eaeeca8f117cb00326df40e8f8b931826efe"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7d77c35adc2baa4d8ea995e7a087b8d345ca6c15","unresolved":true,"context_lines":[{"line_number":273,"context_line":""},{"line_number":274,"context_line":"class GlobalVarsClass(object):"},{"line_number":275,"context_line":"    def __init__(self):"},{"line_number":276,"context_line":"        self. _active_cfg \u003d {}"},{"line_number":277,"context_line":"        self._zone_state \u003d list()"},{"line_number":278,"context_line":"        self._is_normal_test \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"fef0bffe_8d60e8f2","line":276,"range":{"start_line":276,"start_character":13,"end_line":276,"end_character":14},"in_reply_to":"5fd01315_06ff8eaf","updated":"2022-08-29 12:22:09.000000000","message":"Yeah, my bad.  I\u0027ll fix if I submit a new patch.","commit_id":"f061eaeeca8f117cb00326df40e8f8b931826efe"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"eb832930cd7e7edb9a1d49a58bc5221db71b247e","unresolved":false,"context_lines":[{"line_number":273,"context_line":""},{"line_number":274,"context_line":"class GlobalVarsClass(object):"},{"line_number":275,"context_line":"    def __init__(self):"},{"line_number":276,"context_line":"        self. _active_cfg \u003d {}"},{"line_number":277,"context_line":"        self._zone_state \u003d list()"},{"line_number":278,"context_line":"        self._is_normal_test \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"47b2c48c_7998715d","line":276,"range":{"start_line":276,"start_character":13,"end_line":276,"end_character":14},"in_reply_to":"fef0bffe_8d60e8f2","updated":"2022-08-29 15:10:42.000000000","message":"Done","commit_id":"f061eaeeca8f117cb00326df40e8f8b931826efe"}],"cinder/tests/unit/zonemanager/test_cisco_fc_zone_driver.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"aba8fb0c03f050b389d3a0acc06cb959bece6381","unresolved":true,"context_lines":[{"line_number":146,"context_line":"        self.setup_driver(self.setup_config(True, 1))"},{"line_number":147,"context_line":"        get_zoning_status_mock.return_value \u003d {\u0027mode\u0027: \u0027basis\u0027,"},{"line_number":148,"context_line":"                                               \u0027session\u0027: \u0027none\u0027}"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        get_active_zone_set_mock.return_value \u003d _active_cfg_default"},{"line_number":151,"context_line":"        self.driver.add_connection(\u0027CISCO_FAB_1\u0027, _initiator_target_map)"},{"line_number":152,"context_line":"        self.assertIn(_zone_name, GlobalVars._zone_state)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5621026f_03aea441","line":149,"updated":"2022-09-13 07:29:17.000000000","message":"nit: unrelated change","commit_id":"e2278994384e3e4e2b36a3e614d0a832a8bd1f50"}]}