)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8b023e940f52dcd38a8d2432ebb56b384503d91c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"71ec4d04_551d918a","updated":"2022-08-26 03:12:20.000000000","message":"LGTM.","commit_id":"eef26ba18eae0ddae0d6dee3bf1a63250da5a2ab"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"79b84f6d2316dc5cf9e05fa58f719f535f8a5f19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b09c105e_d5589168","updated":"2022-08-24 10:47:01.000000000","message":"Thank you for the change - LGTM.","commit_id":"eef26ba18eae0ddae0d6dee3bf1a63250da5a2ab"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"2dd9d8d7dbe6efa0b88a75b7916ddb550bd6f8cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d1fc31ae_e1d0a50a","updated":"2022-09-12 18:22:43.000000000","message":"I think i\u0027m guilty of doing this wrong. Thanks for working on this! ","commit_id":"685e35c9b8e0cee93ebeb9ba938bbd9ee865144e"}],"cinder/tests/unit/volume/drivers/test_nfs.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e7059bb8188491cb4ce8ff676f2c4d536e149c37","unresolved":true,"context_lines":[{"line_number":780,"context_line":"        drv \u003d self._driver"},{"line_number":781,"context_line":"        volume \u003d self._simple_volume()"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":"        # configuration is a Mock, don\u0027t use self.override_config"},{"line_number":784,"context_line":"        self.configuration.nfs_sparsed_volumes \u003d True"},{"line_number":785,"context_line":""},{"line_number":786,"context_line":"        with mock.patch.object("}],"source_content_type":"text/x-python","patch_set":1,"id":"5b09794c_2f9806c1","line":783,"range":{"start_line":783,"start_character":10,"end_line":783,"end_character":65},"updated":"2022-08-23 20:26:52.000000000","message":"It seems like a stretch to expect people to know this -- it\u0027s not very obvious.\n\nCan we just have self.override_config() check if the conf is a Mock and fail instead of documenting this?","commit_id":"5c4138d3a3f360ea5f4b46a116e121864b87cd83"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ed2cd34fb1f38d9f7c9f5c5576f477c4bad3b7cc","unresolved":false,"context_lines":[{"line_number":780,"context_line":"        drv \u003d self._driver"},{"line_number":781,"context_line":"        volume \u003d self._simple_volume()"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":"        # configuration is a Mock, don\u0027t use self.override_config"},{"line_number":784,"context_line":"        self.configuration.nfs_sparsed_volumes \u003d True"},{"line_number":785,"context_line":""},{"line_number":786,"context_line":"        with mock.patch.object("}],"source_content_type":"text/x-python","patch_set":1,"id":"bd27ea18_2f186f6d","line":783,"range":{"start_line":783,"start_character":10,"end_line":783,"end_character":65},"in_reply_to":"5b09794c_2f9806c1","updated":"2022-08-24 08:27:41.000000000","message":"I wanted to keep the changes to a minimum while fixing all the mistakes we have in our unit tests.\n\nI added the comment to at least explain why the code is weird, which I considered a great improvement over something that is plain wrong.\n\nI\u0027ll update the patch with a proper fix for the underlying issue (using a Mock).  Though it will be larger.","commit_id":"5c4138d3a3f360ea5f4b46a116e121864b87cd83"}]}