)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c6248248c9134daa67171313248ec9d09e218597","unresolved":true,"context_lines":[{"line_number":15,"context_line":"service for that backend."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Now that we can log in native threads (thanks to Change-Id"},{"line_number":18,"context_line":"I4a9680ba651a694bafa3686bf12f7ae943b9f2bc) we can take a different"},{"line_number":19,"context_line":"approach in the RBD driver."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This patch introduces a couple of decorators: \"on_native_thread\" and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9b24d7c0_3877430d","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":41},"updated":"2022-09-21 20:56:23.000000000","message":"This Change-Id seems to not exist?","commit_id":"eec4a5fa91e028e04be030f071de34b544ced325"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8f171c644b4ce9cca3ed050f1aead8fa1b2473a0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"service for that backend."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Now that we can log in native threads (thanks to Change-Id"},{"line_number":18,"context_line":"I4a9680ba651a694bafa3686bf12f7ae943b9f2bc) we can take a different"},{"line_number":19,"context_line":"approach in the RBD driver."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This patch introduces a couple of decorators: \"on_native_thread\" and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"8d0b8a9f_aca58d56","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":41},"in_reply_to":"9b24d7c0_3877430d","updated":"2023-11-13 16:56:46.000000000","message":"Yup, it\u0027s Iac1b0891ae584ce4b95964e6cdc0ff2483a4e57d","commit_id":"eec4a5fa91e028e04be030f071de34b544ced325"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"77f1dfef301a83edbafb8fe083d1ecd98bdce97e","unresolved":true,"context_lines":[{"line_number":42,"context_line":"calls:"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- Changing class name from \"RBDVolumeProxy\" to \"RBDVolume\" since it\u0027s no"},{"line_number":45,"context_line":"  longer proxying the calls via tpool.Poxy."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- Driver\u0027s RBDProxy method is no longer necessary since we don\u0027t need a"},{"line_number":48,"context_line":"  tpool.Poxy, so we can use the same rbd.RBD instance in the driver."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1c530c75_a26c10b0","line":45,"range":{"start_line":45,"start_character":38,"end_line":45,"end_character":42},"updated":"2024-11-07 15:13:39.000000000","message":"nit: Proxy","commit_id":"cc37d013ebe4cfb43248af2dc318635cd7888c42"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"77f1dfef301a83edbafb8fe083d1ecd98bdce97e","unresolved":true,"context_lines":[{"line_number":45,"context_line":"  longer proxying the calls via tpool.Poxy."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- Driver\u0027s RBDProxy method is no longer necessary since we don\u0027t need a"},{"line_number":48,"context_line":"  tpool.Poxy, so we can use the same rbd.RBD instance in the driver."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"This patch requires the next oslo.log release that includes the fix for"},{"line_number":51,"context_line":"logging in eventlet native threads so they don\u0027t block."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"4be09af1_4bbde966","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":12},"updated":"2024-11-07 15:13:39.000000000","message":"nit: Proxy","commit_id":"cc37d013ebe4cfb43248af2dc318635cd7888c42"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"1660a888f9da6a0cfc1c55aa86fccd786fe6efb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8bb32e10_eefcfe59","updated":"2023-03-24 18:22:39.000000000","message":"see cinder-mypy job failures","commit_id":"d73db8d55c6965745c76a67cb4475f5dea047c55"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"19dd6e66ff8fba2a21a7795caf50734385a5e67f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7820aa3c_ec2b3610","updated":"2024-11-04 23:39:07.000000000","message":"This patch is pretty cool, and the new decorators should be useful when it\u0027s time to remove the dependency on eventlet (the decorators will need to be reworked, but they help with an abstraction layer). It would also be good to get this patch merged earlier in the epoxy cycle.\n\n-1 just to get it rebased","commit_id":"b28bd26ee4098c1f38fa20ea226df4b0c933ef11"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c537ac2c90f60f434013a5b8e9b36c4721fecbaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c7ddba6b_dd99ef97","updated":"2024-11-12 21:11:00.000000000","message":"Merging this as-is means that we are now using an extra native thread during image upload because we also landed https://review.opendev.org/c/openstack/cinder/+/934086 .  We should assess if this change lets us revert that one, or if there is another need for it.","commit_id":"cc37d013ebe4cfb43248af2dc318635cd7888c42"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"77f1dfef301a83edbafb8fe083d1ecd98bdce97e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"53d07164_4632a9a3","updated":"2024-11-07 15:13:39.000000000","message":"The logic looks good to me. However I\u0027ve two concerns:\n\n1. Previously we used to run a \"part\" of code and now we are running the whole method in native thread. Will it have performance impact or block other operations running with green threads?\n2. Should we test any edge scenarios to verify that we are not breaking any special case not tested in CI.\n\nThe main ceph temepst job is passing.\nThe ceph tempest multinode AA failed with two tests:\n1. test_snapshot_data_integrity: looks unrelated\nfailed waiting on ssh\n  File \"/opt/stack/tempest/tempest/common/compute.py\", line 335, in create_test_server\n    wait_for_ssh_or_ping(\n  File \"/opt/stack/tempest/tempest/common/compute.py\", line 148, in wait_for_ssh_or_ping\n    waiters.wait_for_ssh(\n  File \"/opt/stack/tempest/tempest/common/waiters.py\", line 706, in wait_for_ssh\n    raise lib_exc.TimeoutException()\ntempest.lib.exceptions.TimeoutException: Request timed out\nDetails: None\n\n2. test_available_volume_retype\n\nThe retype seems to fail, probably the volume didn\u0027t retype?\n  File \"/opt/stack/tempest/tempest/api/volume/admin/test_volume_retype.py\", line 187, in _verify_migration\n    self.assertEqual(volume_source[key], volume_dest[key])\n  File \"/opt/stack/tempest/.tox/tempest/lib/python3.10/site-packages/testtools/testcase.py\", line 419, in assertEqual\n    self.assertThat(observed, matcher, message)\n  File \"/opt/stack/tempest/.tox/tempest/lib/python3.10/site-packages/testtools/testcase.py\", line 509, in assertThat\n    raise mismatch_error\ntesttools.matchers._impl.MismatchError: \u0027np0038969716@ceph#ceph\u0027 !\u003d \u0027np0038969715@ceph#ceph\u0027","commit_id":"cc37d013ebe4cfb43248af2dc318635cd7888c42"}],"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"77f1dfef301a83edbafb8fe083d1ecd98bdce97e","unresolved":true,"context_lines":[{"line_number":312,"context_line":"    RBD_FEATURE_JOURNALING \u003d 64"},{"line_number":313,"context_line":"    STORAGE_PROTOCOL \u003d constants.CEPH"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    # Don\u0027t run things on native threads here due to oslo.service bug #1983949"},{"line_number":316,"context_line":"    @utils.on_any_thread"},{"line_number":317,"context_line":"    def __init__(self,"},{"line_number":318,"context_line":"                 active_backend_id: Optional[str] \u003d None,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ceafae24_6f2d718e","line":315,"range":{"start_line":315,"start_character":66,"end_line":315,"end_character":78},"updated":"2024-11-07 15:13:39.000000000","message":"this is merged 1 year ago and most probably released, can we remove this decorator here now?\n\nhttps://review.opendev.org/c/openstack/oslo.service/+/852450","commit_id":"cc37d013ebe4cfb43248af2dc318635cd7888c42"}]}