)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"02d946fe5ee6530ae961bcc8f97e35a939fe85fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"242e59bc_c8318e6e","updated":"2022-09-01 13:23:48.000000000","message":"Code and tests look good.  Two places in the doc I\u0027d like you to look at, though.","commit_id":"23c2f8e297e7ae049ff267b296ba55ba547b766a"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"f6db565ab0961b975a6e45100d2458d106e129c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0b60a1b6_4506506a","updated":"2022-08-31 14:22:54.000000000","message":"lgtm","commit_id":"23c2f8e297e7ae049ff267b296ba55ba547b766a"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"df5bd1bf166acc80e8ba7ba31adf97f6c0d1e70a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"afe74cc1_1bb249cb","updated":"2022-09-01 14:19:15.000000000","message":"Good catch on the docs - thanks","commit_id":"bf3e51e5b24f04d792f37d48deb09c268e7b442f"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"d2ef1095a21ebbe3ad102e1ed8837cdeaaec5f1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d1b5d220_14aa234d","updated":"2022-09-05 14:41:53.000000000","message":"Looks good to me and pure-devstack-cinder-tempest-nvme-roce-aio passed","commit_id":"bf3e51e5b24f04d792f37d48deb09c268e7b442f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5cfca5bb58c39786b5cfce077c82480cd14c01d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"aebfc0c8_ff324e6f","updated":"2022-09-05 20:31:55.000000000","message":"Removing a restriction since backend supports replication now.\nI noticed that we haven\u0027t mentioned this driver in our support matrix but that can be done in a followup. LGTM.\n\nPure CI is passing.\n\nBuild succeeded.\npure-devstack-cinder-tempest-iscsi-aio http://openstack-logs.purestorage.com/58/855058/2/thirdparty-check/pure-devstack-cinder-tempest-iscsi-aio/3285e3f/ : SUCCESS in 1h 42m 25s\npure-devstack-cinder-tempest-fc-aio http://openstack-logs.purestorage.com/58/855058/2/thirdparty-check/pure-devstack-cinder-tempest-fc-aio/876f240/ : SUCCESS in 1h 35m 18s\npure-devstack-cinder-tempest-nvme-roce-aio http://openstack-logs.purestorage.com/58/855058/2/thirdparty-check/pure-devstack-cinder-tempest-nvme-roce-aio/7e2402d/ : SUCCESS in 1h 51m 32s","commit_id":"bf3e51e5b24f04d792f37d48deb09c268e7b442f"}],"cinder/tests/unit/volume/drivers/test_pure.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"02d946fe5ee6530ae961bcc8f97e35a939fe85fe","unresolved":true,"context_lines":[{"line_number":4678,"context_line":"        # each host of the ActiveCluster, so we should check that we only"},{"line_number":4679,"context_line":"        # get two+two results back"},{"line_number":4680,"context_line":"        self.driver.configuration.pure_nvme \u003d NVME_CIDR"},{"line_number":4681,"context_line":"        self.driver.configuration.pure_nvme_cidr_list \u003d NVME_CIDRS_FILTERED"},{"line_number":4682,"context_line":"        mock_secondary \u003d mock.MagicMock()"},{"line_number":4683,"context_line":"        self.driver._uniform_active_cluster_target_arrays \u003d [mock_secondary]"},{"line_number":4684,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"10048368_4a206254","line":4681,"range":{"start_line":4681,"start_character":56,"end_line":4681,"end_character":75},"updated":"2022-09-01 13:23:48.000000000","message":"The test data at the top of the file is nicely commented to explain how this all hangs together.","commit_id":"23c2f8e297e7ae049ff267b296ba55ba547b766a"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"df5bd1bf166acc80e8ba7ba31adf97f6c0d1e70a","unresolved":false,"context_lines":[{"line_number":4678,"context_line":"        # each host of the ActiveCluster, so we should check that we only"},{"line_number":4679,"context_line":"        # get two+two results back"},{"line_number":4680,"context_line":"        self.driver.configuration.pure_nvme \u003d NVME_CIDR"},{"line_number":4681,"context_line":"        self.driver.configuration.pure_nvme_cidr_list \u003d NVME_CIDRS_FILTERED"},{"line_number":4682,"context_line":"        mock_secondary \u003d mock.MagicMock()"},{"line_number":4683,"context_line":"        self.driver._uniform_active_cluster_target_arrays \u003d [mock_secondary]"},{"line_number":4684,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a9fda48d_82d4f5db","line":4681,"range":{"start_line":4681,"start_character":56,"end_line":4681,"end_character":75},"in_reply_to":"10048368_4a206254","updated":"2022-09-01 14:19:15.000000000","message":"Done","commit_id":"23c2f8e297e7ae049ff267b296ba55ba547b766a"}],"doc/source/configuration/block-storage/drivers/pure-storage-driver.rst":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"02d946fe5ee6530ae961bcc8f97e35a939fe85fe","unresolved":true,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"* Create a thin provisioned volume."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* Replicate volumes to remote Pure Storage array(s) - synchronous replication"},{"line_number":53,"context_line":"  is not supported with the NVMe driver."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"QoS support for the Pure Storage drivers include the ability to set the"},{"line_number":56,"context_line":"following capabilities in the OpenStack Block Storage API"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7bfa80be_0383925c","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":40},"updated":"2022-09-01 13:23:48.000000000","message":"remove","commit_id":"23c2f8e297e7ae049ff267b296ba55ba547b766a"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"df5bd1bf166acc80e8ba7ba31adf97f6c0d1e70a","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"* Create a thin provisioned volume."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* Replicate volumes to remote Pure Storage array(s) - synchronous replication"},{"line_number":53,"context_line":"  is not supported with the NVMe driver."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"QoS support for the Pure Storage drivers include the ability to set the"},{"line_number":56,"context_line":"following capabilities in the OpenStack Block Storage API"}],"source_content_type":"text/x-rst","patch_set":1,"id":"a458551f_e79eebd6","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":40},"in_reply_to":"7bfa80be_0383925c","updated":"2022-09-01 14:19:15.000000000","message":"Done","commit_id":"23c2f8e297e7ae049ff267b296ba55ba547b766a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"02d946fe5ee6530ae961bcc8f97e35a939fe85fe","unresolved":true,"context_lines":[{"line_number":265,"context_line":"The ``REPLICATION_TYPE`` value for the ``type`` key can be either ``sync`` or"},{"line_number":266,"context_line":"``async``"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":".. note::"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"   Synchronous replication is not supported by the NVMe driver."},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"If the ``type`` is ``sync`` volumes will be created in a stretched Pod. This"},{"line_number":273,"context_line":"requires two arrays pre-configured with Active Cluster enabled. You can"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2bcbe709_98cd080e","line":270,"range":{"start_line":268,"start_character":0,"end_line":270,"end_character":63},"updated":"2022-09-01 13:23:48.000000000","message":"remove","commit_id":"23c2f8e297e7ae049ff267b296ba55ba547b766a"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"df5bd1bf166acc80e8ba7ba31adf97f6c0d1e70a","unresolved":false,"context_lines":[{"line_number":265,"context_line":"The ``REPLICATION_TYPE`` value for the ``type`` key can be either ``sync`` or"},{"line_number":266,"context_line":"``async``"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":".. note::"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"   Synchronous replication is not supported by the NVMe driver."},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"If the ``type`` is ``sync`` volumes will be created in a stretched Pod. This"},{"line_number":273,"context_line":"requires two arrays pre-configured with Active Cluster enabled. You can"}],"source_content_type":"text/x-rst","patch_set":1,"id":"f481b4f0_d0e09cd6","line":270,"range":{"start_line":268,"start_character":0,"end_line":270,"end_character":63},"in_reply_to":"2bcbe709_98cd080e","updated":"2022-09-01 14:19:15.000000000","message":"Done","commit_id":"23c2f8e297e7ae049ff267b296ba55ba547b766a"}]}