)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"03b29e54c56e834d064ef45425e769c1b7b44316","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"caf23b2f_a1e8ef46","updated":"2022-09-21 15:32:36.000000000","message":"A better commit message would be great.\nAlso, is it related to bug https://bugs.launchpad.net/cinder/+bug/1990053?\nIf so, it should be mentioned in the commit message","commit_id":"3c42d0d84d65775457df814c57528b9e016d003d"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"3bca9096ce25c8158af2299987cb68c99a7aa2e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"18902456_305216ea","updated":"2022-09-07 12:28:12.000000000","message":"Can you explain why this is needed and how everything worked with out it?","commit_id":"3c42d0d84d65775457df814c57528b9e016d003d"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"5474e5e3e5af8a0888258f1637945dfdbe60024a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"90b561b9_65d120bd","updated":"2023-01-31 12:10:08.000000000","message":"Is anybody working on it anymore?","commit_id":"3c42d0d84d65775457df814c57528b9e016d003d"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"8064ca8c3ed849201f46ce17ab08cb1c518aa934","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b854113a_3b64ade7","updated":"2022-09-08 23:31:31.000000000","message":"Please create a launchpad bug describing this problem so the team can reproduce it. ","commit_id":"3c42d0d84d65775457df814c57528b9e016d003d"},{"author":{"_account_id":34653,"name":"Danila Balagansky","email":"dbalagansky@me.com","username":"dbalagansky"},"change_message_id":"55758791e22795d06424c230d4586ccc65b0adce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f5c0bd5a_c6240b06","in_reply_to":"90b561b9_65d120bd","updated":"2023-02-01 13:14:09.000000000","message":"Nope. I\u0027ve wrote down some of the concerns about this whole change and whether it should be fixed separately from similiar bug here: https://review.opendev.org/c/openstack/cinder/+/855964/comments/caf23b2f_a1e8ef46. If someone would answer those, I could try to push this change further, but as of now this is not a priority for me, as I\u0027ve stopped using NFS driver in Cinder.","commit_id":"3c42d0d84d65775457df814c57528b9e016d003d"},{"author":{"_account_id":34653,"name":"Danila Balagansky","email":"dbalagansky@me.com","username":"dbalagansky"},"change_message_id":"aa87a3a04b154371973a04f722a70d97d698c7b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3f213722_5cb1f7d3","in_reply_to":"b854113a_3b64ade7","updated":"2022-09-18 08:20:53.000000000","message":"https://bugs.launchpad.net/cinder/+bug/1990053","commit_id":"3c42d0d84d65775457df814c57528b9e016d003d"},{"author":{"_account_id":34653,"name":"Danila Balagansky","email":"dbalagansky@me.com","username":"dbalagansky"},"change_message_id":"24851d2671777852e8b0989dcc7fe8bd39386ef1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ef1e0b48_72aac5b5","in_reply_to":"caf23b2f_a1e8ef46","updated":"2022-10-03 13:46:07.000000000","message":"Yes, it is related to https://bugs.launchpad.net/cinder/+bug/1990053, and I, surely can fix the commit message, but:\n\nThere\u0027s also this bug: https://bugs.launchpad.net/cinder/+bug/1988803, which:\n* looks the same, but was discovered with volumes with size less than size of the original image (image-volume cache volume)\n* doesn\u0027t have any info about volume driver in use, whereas this change and related bug https://bugs.launchpad.net/cinder/+bug/1990053 is specifically about NFS -- I don\u0027t see the same behavior with LVM driver, which is everything I can test against. \n\nI\u0027m not sure if I should polish this change or is there a need for more generalized approach, in a way:\n* should this change take into account https://bugs.launchpad.net/cinder/+bug/1988803 and cover creating volumes with lesser size than original image (I haven\u0027t tried to reproduce this case)?\n* should suggestions from https://bugs.launchpad.net/cinder/+bug/1988803/comments/1 be addressed in this change?\n* maybe these two mentioned bugs should be merged?","commit_id":"3c42d0d84d65775457df814c57528b9e016d003d"}],"cinder/volume/drivers/nfs.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7e3cc6aedfa517c828e7216220d1c432804f2175","unresolved":true,"context_lines":[{"line_number":681,"context_line":"                                      out_format,"},{"line_number":682,"context_line":"                                      run_as_root\u003dself._execute_as_root)"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"        image_utils.resize_image(path_to_new_vol, volume_size,"},{"line_number":685,"context_line":"                                 run_as_root\u003dself._execute_as_root)"},{"line_number":686,"context_line":""},{"line_number":687,"context_line":"        self._set_rw_permissions_for_all(path_to_new_vol)"}],"source_content_type":"text/x-python","patch_set":1,"id":"f03fb1d2_e327232c","line":685,"range":{"start_line":684,"start_character":8,"end_line":685,"end_character":67},"updated":"2022-09-07 15:10:56.000000000","message":"will this try to shrink the volume if the new volume created has size \u003c original volume? that might fail","commit_id":"3c42d0d84d65775457df814c57528b9e016d003d"}]}