)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d66bd32c6b17c9096e85420a8ed689ac867f98de","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Tushar Trambak Gite \u003ctushargite96@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-10-06 11:39:51 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update API returns"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To return an HTTP 500 for the \"duplicate connectors detected on volume\" case "},{"line_number":10,"context_line":"while raising request attachment to the volume."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"688a4911_91ad85e1","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":18},"updated":"2022-10-06 19:16:33.000000000","message":"This needs a more meaningful summary message.","commit_id":"9e2ec885500f5f0defb2b36c7f109505e4f1e2a5"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"ab37f9d8c57cef04174a8f61f707cea7277cc88e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bf25f558_26a9f814","updated":"2022-09-12 10:47:39.000000000","message":"Looks fine.","commit_id":"cc188a53c4a4252a4eb44286b12047090045a93d"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0411f395592edd5f5cde8ac66090e69e18a70d46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3b79c045_60f5eded","updated":"2022-09-29 15:37:41.000000000","message":"Why is it more correct to return 400 instead of 500 here?  I suspect it was returning 500 to indicate that a condition occurred that wasn\u0027t supposed to happen.","commit_id":"cc188a53c4a4252a4eb44286b12047090045a93d"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"052fee5fb12ce64d92083b6dee108e486ede2e9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"14b05de4_a99b4c73","updated":"2022-09-29 04:01:24.000000000","message":"ping","commit_id":"cc188a53c4a4252a4eb44286b12047090045a93d"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"a9893630cb78e7297112d900d71b2925e6e39f89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"15af319a_4b7e8aa9","updated":"2022-09-22 05:18:43.000000000","message":"ping","commit_id":"cc188a53c4a4252a4eb44286b12047090045a93d"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"305613bf34b5e85f79942d892583887e3ef8d7d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"22781490_d9598e67","updated":"2022-09-26 04:16:04.000000000","message":"ping","commit_id":"cc188a53c4a4252a4eb44286b12047090045a93d"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"44d4ac39bae13a11f6fd88201ce4f466a68575bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"05a34eab_70a644f7","updated":"2022-09-12 15:42:42.000000000","message":"run-Yadro Tatlin Unified CI","commit_id":"cc188a53c4a4252a4eb44286b12047090045a93d"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"6054a2239ec9cdb44b17b7c0afc6ec32cf2ea1c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a9890c8e_bdae7568","in_reply_to":"3b79c045_60f5eded","updated":"2022-09-29 16:20:10.000000000","message":"in my opinion, HTTP 500 should be used when something unexpected happen and the server was not prepared to response anything. HTTP 400 is more used when a request which is known by the server is malformed resulting in an error.\nIt depends on what kind of response we\u0027re looking at in this particular case.","commit_id":"cc188a53c4a4252a4eb44286b12047090045a93d"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"b52d82708a0954e65959d093ce5965c17c625023","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3ae485d6_7ef043be","in_reply_to":"4a928a71_98a68489","updated":"2022-10-06 11:38:20.000000000","message":"i think the request is to create attachment to the volume","commit_id":"cc188a53c4a4252a4eb44286b12047090045a93d"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"97f0c5ba96c0e5ee75221202ab8a7630ef775a3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4a928a71_98a68489","in_reply_to":"a9890c8e_bdae7568","updated":"2022-09-30 14:54:24.000000000","message":"HTTP 400 indicates that the user has made an invalid request.  What request / sequence of requests leads to this error?","commit_id":"cc188a53c4a4252a4eb44286b12047090045a93d"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"da22e719c0450d5edbd9c20f80c918e3f848de86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dc3093b5_8362c69c","updated":"2023-01-31 12:08:22.000000000","message":"Where are you with that patch? It looks like nobody is working on it...","commit_id":"9e2ec885500f5f0defb2b36c7f109505e4f1e2a5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c5fa0305913ea23b0b2bfc4226fdb481752c09b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0cc921c5_52174205","updated":"2024-09-30 13:09:32.000000000","message":"Looked at this again today -- added a suggestion for how to fix it.  This looks like it\u0027s still a valid bug.","commit_id":"9950f0dd221032589f802305be8a75a576f18108"}],"cinder/api/v3/attachments.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d66bd32c6b17c9096e85420a8ed689ac867f98de","unresolved":true,"context_lines":[{"line_number":207,"context_line":"            LOG.exception(err_msg)"},{"line_number":208,"context_line":"        finally:"},{"line_number":209,"context_line":"            if err_msg:"},{"line_number":210,"context_line":"                raise webob.exc.HTTPBadRequest(explanation\u003derr_msg)"},{"line_number":211,"context_line":"        return attachment_views.ViewBuilder.detail(attachment_ref)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    @wsgi.Controller.api_version(mv.NEW_ATTACH)"}],"source_content_type":"text/x-python","patch_set":2,"id":"cee4bd32_e3be06ee","line":210,"range":{"start_line":210,"start_character":32,"end_line":210,"end_character":46},"updated":"2022-10-06 19:16:33.000000000","message":"If the premise of this patch is assumed to be correct, this solution is still not quite right.\n\nThis will result in unexpected random exceptions (the except Exception: case above) being returned as HTTP 400 Bad Request errors.  This is not correct -- the intent of this code is to return a 500 when something unexpected (i.e. a bug) happens.\n\n(This seems to hint that we are missing adequate unit test coverage around this path.)","commit_id":"9e2ec885500f5f0defb2b36c7f109505e4f1e2a5"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"d47f8e83101ccbdc85af42700ea5ced760bc1b58","unresolved":true,"context_lines":[{"line_number":207,"context_line":"            LOG.exception(err_msg)"},{"line_number":208,"context_line":"        finally:"},{"line_number":209,"context_line":"            if err_msg:"},{"line_number":210,"context_line":"                raise webob.exc.HTTPBadRequest(explanation\u003derr_msg)"},{"line_number":211,"context_line":"        return attachment_views.ViewBuilder.detail(attachment_ref)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    @wsgi.Controller.api_version(mv.NEW_ATTACH)"}],"source_content_type":"text/x-python","patch_set":2,"id":"90e898fd_bd9d86d6","line":210,"range":{"start_line":210,"start_character":32,"end_line":210,"end_character":46},"in_reply_to":"cee4bd32_e3be06ee","updated":"2022-10-10 11:28:21.000000000","message":"Ok i\u0027ll ping you after writing UT coverage for this case","commit_id":"9e2ec885500f5f0defb2b36c7f109505e4f1e2a5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c5fa0305913ea23b0b2bfc4226fdb481752c09b5","unresolved":true,"context_lines":[{"line_number":201,"context_line":"        except exception.CinderException as ex:"},{"line_number":202,"context_line":"            err_msg \u003d _("},{"line_number":203,"context_line":"                \"Unable to create attachment for volume (%s).\") % ex.msg"},{"line_number":204,"context_line":"            LOG.exception(err_msg)"},{"line_number":205,"context_line":"        except Exception:"},{"line_number":206,"context_line":"            err_msg \u003d _(\"Unable to create attachment for volume.\")"},{"line_number":207,"context_line":"            LOG.exception(err_msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"d73a003c_a173f8d9","line":204,"updated":"2024-09-30 13:09:32.000000000","message":"I think the needed change here is to detect code 400 exceptions (i.e. Invalid*) and return them here rather than falling back to HTTPInternalServerError at line 210.","commit_id":"9950f0dd221032589f802305be8a75a576f18108"}]}