)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34459,"name":"Muli Ben-Yehuda","email":"muli@lightbitslabs.com","username":"muliby"},"change_message_id":"8d20011fe561e7ec794fd4e67a0ad634146d9cdb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1628e8ea_b5be7488","updated":"2022-09-08 06:23:08.000000000","message":"LGTM and much needed\nsee one nit wrt comment out of sync\n","commit_id":"deb06d4a0cf5ae17982667203e7956cc72c6e540"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"7a879f3a75df5f2c9909ab74ef24a8bbd3925f6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"81fb482a_083db338","updated":"2022-09-07 11:50:49.000000000","message":"recheck","commit_id":"deb06d4a0cf5ae17982667203e7956cc72c6e540"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4bcc3056c092510ddc2349fef2e37795a04076a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"de9b62ab_7c11406a","updated":"2022-09-09 09:30:18.000000000","message":"This looks driver specific and doesn\u0027t seem to have user impact. Ligthbits CI has passed. LGTM.","commit_id":"686eb45e1e10afa808d4a503caea7f63cb710aec"}],"cinder/volume/drivers/lightos.py":[{"author":{"_account_id":34459,"name":"Muli Ben-Yehuda","email":"muli@lightbitslabs.com","username":"muliby"},"change_message_id":"8d20011fe561e7ec794fd4e67a0ad634146d9cdb","unresolved":true,"context_lines":[{"line_number":538,"context_line":"        # while creating lightos volume we can stop on any terminal status"},{"line_number":539,"context_line":"        # possible states: Unknown, Creating, Available, Deleting, Deleted,"},{"line_number":540,"context_line":"        # Failed, Updating"},{"line_number":541,"context_line":"        states \u003d (\u0027Available\u0027, \u0027Deleting\u0027, \u0027Deleted\u0027, \u0027Failed\u0027, \u0027UNKNOWN\u0027,"},{"line_number":542,"context_line":"                  \u0027Migrating\u0027, \u0027Rollback\u0027)"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"        stop \u003d time.time() + timeout"}],"source_content_type":"text/x-python","patch_set":1,"id":"6a3d65ef_0f9244b1","line":541,"updated":"2022-09-08 06:23:08.000000000","message":"The comment is out of sync with the code. I suggest we change it to\n```\n# while creating LightOS volume we can stop on of the below states\nstates \u003d ...\n```","commit_id":"deb06d4a0cf5ae17982667203e7956cc72c6e540"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"0ca4268c3dfe93be1f72277a74a7b7fc067289b0","unresolved":true,"context_lines":[{"line_number":538,"context_line":"        # while creating lightos volume we can stop on any terminal status"},{"line_number":539,"context_line":"        # possible states: Unknown, Creating, Available, Deleting, Deleted,"},{"line_number":540,"context_line":"        # Failed, Updating"},{"line_number":541,"context_line":"        states \u003d (\u0027Available\u0027, \u0027Deleting\u0027, \u0027Deleted\u0027, \u0027Failed\u0027, \u0027UNKNOWN\u0027,"},{"line_number":542,"context_line":"                  \u0027Migrating\u0027, \u0027Rollback\u0027)"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"        stop \u003d time.time() + timeout"}],"source_content_type":"text/x-python","patch_set":1,"id":"a93699ae_ecbfe7f6","line":541,"in_reply_to":"6a3d65ef_0f9244b1","updated":"2022-09-08 08:10:15.000000000","message":"got it","commit_id":"deb06d4a0cf5ae17982667203e7956cc72c6e540"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"5e620b887cc19f389438c3a3bd828c3e73f7bcaf","unresolved":false,"context_lines":[{"line_number":538,"context_line":"        # while creating lightos volume we can stop on any terminal status"},{"line_number":539,"context_line":"        # possible states: Unknown, Creating, Available, Deleting, Deleted,"},{"line_number":540,"context_line":"        # Failed, Updating"},{"line_number":541,"context_line":"        states \u003d (\u0027Available\u0027, \u0027Deleting\u0027, \u0027Deleted\u0027, \u0027Failed\u0027, \u0027UNKNOWN\u0027,"},{"line_number":542,"context_line":"                  \u0027Migrating\u0027, \u0027Rollback\u0027)"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"        stop \u003d time.time() + timeout"}],"source_content_type":"text/x-python","patch_set":1,"id":"fd56e55c_a2537b4a","line":541,"in_reply_to":"a93699ae_ecbfe7f6","updated":"2022-09-08 15:27:41.000000000","message":"Done","commit_id":"deb06d4a0cf5ae17982667203e7956cc72c6e540"}]}
