)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"eebcadd8736a66d32a5406d914d6d25c70d35e2c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     inspur-storage \u003cjiaohaolin01@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-13 15:17:10 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add retry when exception is encountered in creating ssh_connection"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6788871e7b5289cd36066bc924ee3eb27f4089c0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bfa2ee1d_06d6833f","line":7,"updated":"2022-09-13 12:24:41.000000000","message":"The first line in commit msg should be short i.e max 50 chars.\nDetails can be provided in subsequent lines.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"c5410900af96f6f068427c222aa37512df992298"},{"author":{"_account_id":23729,"name":"焦浩霖","display_name":"jiaohaolin","email":"jiaohaolin01@inspur.com","username":"inspur-storage"},"change_message_id":"1d87354d0422f7cd082303a5d4015c3ef1a3f0e5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     inspur-storage \u003cjiaohaolin01@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-13 15:17:10 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add retry when exception is encountered in creating ssh_connection"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6788871e7b5289cd36066bc924ee3eb27f4089c0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"99042d55_849d97cb","line":7,"in_reply_to":"bfa2ee1d_06d6833f","updated":"2022-09-14 05:56:16.000000000","message":"Done","commit_id":"c5410900af96f6f068427c222aa37512df992298"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"eebcadd8736a66d32a5406d914d6d25c70d35e2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"12b0497b_f0e2940e","updated":"2022-09-13 12:24:41.000000000","message":"Minor comment","commit_id":"c5410900af96f6f068427c222aa37512df992298"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"7f25e3050927e6ceb4ce9a24f3e722a6be01bdd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9311e62f_681bf2c9","updated":"2022-09-13 13:16:16.000000000","message":"When this exception is supposed to happen? Does it fix a bug?","commit_id":"c5410900af96f6f068427c222aa37512df992298"},{"author":{"_account_id":23729,"name":"焦浩霖","display_name":"jiaohaolin","email":"jiaohaolin01@inspur.com","username":"inspur-storage"},"change_message_id":"1d87354d0422f7cd082303a5d4015c3ef1a3f0e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"76434de5_33b70cfa","in_reply_to":"9311e62f_681bf2c9","updated":"2022-09-14 05:56:16.000000000","message":"in my environment, storage\u0027s management is quite unstable，\nThere is a limit of 16 ssh connections, so if high concurrency occurs, the creating_connection of the ssh_pool will be occured exceptions.\nso, add retry cloud solve this problem","commit_id":"c5410900af96f6f068427c222aa37512df992298"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"a2fc8fde563fc85d3d3cd070476f8a703a135071","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b068d313_cd39989a","updated":"2022-09-14 10:04:59.000000000","message":"My comment has been addressed. Thanks.\n","commit_id":"50110aca756daf26394ddd972ec7adb04a5d4921"},{"author":{"_account_id":23729,"name":"焦浩霖","display_name":"jiaohaolin","email":"jiaohaolin01@inspur.com","username":"inspur-storage"},"change_message_id":"af8f3019a1d3d82f18fd5a6fb039e0d0922d0eea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5614095c_c59d2142","updated":"2022-12-30 01:33:08.000000000","message":"\nThis patch  is an improvement of stability","commit_id":"1a6bbd32976f12025d4848fbc3d2bdeae877f633"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"63ccc3f31e61776c09bb94bb139e88bf948d6407","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c4c3b7dc_725713f8","updated":"2022-12-16 15:00:57.000000000","message":"seems like a reasonable retry request","commit_id":"1a6bbd32976f12025d4848fbc3d2bdeae877f633"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"79ae7359822bcd3b3bcafaadf87cd75a435a5d50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6fb2a1cf_bcaccb93","updated":"2022-12-16 16:33:53.000000000","message":"this change looks legit. LGTM","commit_id":"1a6bbd32976f12025d4848fbc3d2bdeae877f633"}],"cinder/ssh_utils.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2f0173a8e3ce795db4d419cab0cd5ce0fe38a5dd","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from cinder import exception"},{"line_number":30,"context_line":"from cinder.i18n import _"},{"line_number":31,"context_line":"from cinder import utils as cinder_utils"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a609bb5_43f9a099","line":31,"range":{"start_line":31,"start_character":24,"end_line":31,"end_character":40},"updated":"2022-09-21 20:32:30.000000000","message":"It would be better to drop the \"as cinder_utils\" part so the utils.retry() usage matches most other cinder code.  This seems to be unnecessary.","commit_id":"50110aca756daf26394ddd972ec7adb04a5d4921"},{"author":{"_account_id":23729,"name":"焦浩霖","display_name":"jiaohaolin","email":"jiaohaolin01@inspur.com","username":"inspur-storage"},"change_message_id":"705518886749f77d63c84befaff67bbc2fb52aa4","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from cinder import exception"},{"line_number":30,"context_line":"from cinder.i18n import _"},{"line_number":31,"context_line":"from cinder import utils as cinder_utils"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"f35c709a_c0b8b212","line":31,"range":{"start_line":31,"start_character":24,"end_line":31,"end_character":40},"in_reply_to":"9a609bb5_43f9a099","updated":"2022-09-22 02:13:03.000000000","message":"Done","commit_id":"50110aca756daf26394ddd972ec7adb04a5d4921"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2f0173a8e3ce795db4d419cab0cd5ce0fe38a5dd","unresolved":true,"context_lines":[{"line_number":117,"context_line":"            self.free_items.popleft().close()"},{"line_number":118,"context_line":"            self.current_size -\u003d 1"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @cinder_utils.retry(paramiko.SSHException, interval\u003d1,"},{"line_number":121,"context_line":"                        retries\u003d3, backoff_rate\u003d1)"},{"line_number":122,"context_line":"    def create(self):"},{"line_number":123,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"b9e2958e_ab01579e","line":120,"range":{"start_line":120,"start_character":24,"end_line":120,"end_character":45},"updated":"2022-09-21 20:32:30.000000000","message":"Is there a more specific exception that can be used to detect this condition?  Won\u0027t this retry on things like auth failures?","commit_id":"50110aca756daf26394ddd972ec7adb04a5d4921"},{"author":{"_account_id":23729,"name":"焦浩霖","display_name":"jiaohaolin","email":"jiaohaolin01@inspur.com","username":"inspur-storage"},"change_message_id":"705518886749f77d63c84befaff67bbc2fb52aa4","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            self.free_items.popleft().close()"},{"line_number":118,"context_line":"            self.current_size -\u003d 1"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @cinder_utils.retry(paramiko.SSHException, interval\u003d1,"},{"line_number":121,"context_line":"                        retries\u003d3, backoff_rate\u003d1)"},{"line_number":122,"context_line":"    def create(self):"},{"line_number":123,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"f7c37e92_61f07b66","line":120,"range":{"start_line":120,"start_character":24,"end_line":120,"end_character":45},"in_reply_to":"b9e2958e_ab01579e","updated":"2022-09-22 02:13:03.000000000","message":"The exceptions I have encountered are mainly reading ssh-banner exceptions, timeouts, and others. But paramiko does not list all kind of exceptions. so,it can not use any more specific exception","commit_id":"50110aca756daf26394ddd972ec7adb04a5d4921"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"3d8bb414b93dfb42f6defdfa1905723ef0ce1bb9","unresolved":true,"context_lines":[{"line_number":117,"context_line":"            self.free_items.popleft().close()"},{"line_number":118,"context_line":"            self.current_size -\u003d 1"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @cinder_utils.retry(paramiko.SSHException, interval\u003d1,"},{"line_number":121,"context_line":"                        retries\u003d3, backoff_rate\u003d1)"},{"line_number":122,"context_line":"    def create(self):"},{"line_number":123,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"122bbf0a_e6a65401","line":120,"range":{"start_line":120,"start_character":24,"end_line":120,"end_character":45},"in_reply_to":"f7c37e92_61f07b66","updated":"2023-01-20 15:46:41.000000000","message":"I think it\u0027s worth doing some testing before merging this, as this could lead to minor bugs that we\u0027re not handling or aware of.","commit_id":"50110aca756daf26394ddd972ec7adb04a5d4921"}]}