)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"70f2600aa2243b62c3cd6e2f9f9b237c932964dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7d3c13f8_0a51f8ef","updated":"2022-09-14 10:46:03.000000000","message":"Couple of minor comments.","commit_id":"80ea18d8ef523841371f27e2641ae6cbe5babc16"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"2043ffe1dad201bd140900b42a5ba9112a674898","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b516f3c8_fe60eaa0","updated":"2022-09-23 12:33:29.000000000","message":"Hi Nahim,\nI see that, some of my comments have been marked as \u0027Resolved\u0027.\nHowever, new patchset isn\u0027t pushed.\nIs it like ... changes have been done on your system; but for some reason they didn\u0027t reach here ?\n\n","commit_id":"80ea18d8ef523841371f27e2641ae6cbe5babc16"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"3a4f8ce4f30d48decda4883b4b804b4edede8240","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"730fa56c_f5cffb2e","updated":"2022-09-21 15:41:25.000000000","message":"Thanks for the review, Raghavendra.","commit_id":"80ea18d8ef523841371f27e2641ae6cbe5babc16"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"8f18a3af6614e68e545b0934da1fbcad6a817307","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e174ad33_a72f66a9","in_reply_to":"b516f3c8_fe60eaa0","updated":"2022-09-23 13:06:23.000000000","message":"Sorry, Raghavendra, I uploaded the patch with the changes now :)","commit_id":"80ea18d8ef523841371f27e2641ae6cbe5babc16"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"335b61d5dc4307c283ae959560766fb993cfd9bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fd8c2b43_2e22382f","updated":"2023-07-03 14:47:28.000000000","message":"Hi Nahim, Matheus, Luisa and Luiz, thanks for the coverage improve. Please take a look at the comments inline","commit_id":"137f4b6e2d0255f8880cca7d5e2594ccdb7abe61"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"af67586d007bb74d8418bfd21ec59276d5f87565","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e93832f2_3a953d38","updated":"2023-06-21 19:13:51.000000000","message":"Hi Nahim, thanks for the patch. I added a few comments and questions inline, also need to resolve the merge conflict.","commit_id":"137f4b6e2d0255f8880cca7d5e2594ccdb7abe61"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"63f7277a404f9ea92ade668899ce70e9ac7399d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8d2d1de0_90b3c49d","updated":"2022-09-28 04:54:27.000000000","message":"My comments have been addressed. Thanks.","commit_id":"137f4b6e2d0255f8880cca7d5e2594ccdb7abe61"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"dae4830947a3554680710145eee4cda0507ed40b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8469da2e_0e0432e5","updated":"2022-09-26 10:50:23.000000000","message":"The code changes look good.\nIs NetApp CI getting triggered on this patch \u0026 submitting results?","commit_id":"137f4b6e2d0255f8880cca7d5e2594ccdb7abe61"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"a9636b8694a5e6d0b1c870a0a31879286a4bcb5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6a775c7a_cf3bb211","in_reply_to":"8469da2e_0e0432e5","updated":"2022-09-27 12:02:51.000000000","message":"It\u0027s possible to trigger the NetApp CI manually, but I think it\u0027s not necessary to do that in this case because only the unit tests were changed, and these changes were already validated by the jobs \u0027openstack-tox-p39\u0027 and \u0027openstack-tox-py310\u0027.","commit_id":"137f4b6e2d0255f8880cca7d5e2594ccdb7abe61"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"772057d289aa00ccea4654407141da5be8a9ce70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"72be675d_7bd3e0ed","in_reply_to":"e93832f2_3a953d38","updated":"2023-07-25 15:02:01.000000000","message":"Done","commit_id":"137f4b6e2d0255f8880cca7d5e2594ccdb7abe61"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"a3c18e92ee81fed98cc2848e2f0e59d2f7efbd84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f7dfc956_3b86fe56","updated":"2026-02-26 12:10:24.000000000","message":"LGTM","commit_id":"607973d5dfd3d871e6435095d65309eba056f832"},{"author":{"_account_id":33986,"name":"Lucas Morais de oliveira","email":"lucasmoliveira059@gmail.com","username":"lucasmoliveira059"},"change_message_id":"79fd34aca2ce7253bdbf347fc294a46cd14f716c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"060e3f36_6be1f49d","updated":"2023-07-28 14:33:37.000000000","message":"LGTM!","commit_id":"607973d5dfd3d871e6435095d65309eba056f832"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"7b8ad93e55a8ef0bb1cc18d5900ddfd40732830c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cd8074e8_9051a55c","updated":"2023-08-10 13:17:47.000000000","message":"My comments have been addressed. Thanks.","commit_id":"607973d5dfd3d871e6435095d65309eba056f832"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"d2b6dfe12b7aeb3848d12a775b78514b8e2a6475","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a5362a72_0a85784a","updated":"2023-07-25 15:01:39.000000000","message":"Thank you for the reviews. I replied the comments and updated the patch.","commit_id":"607973d5dfd3d871e6435095d65309eba056f832"}],"cinder/tests/unit/volume/drivers/netapp/dataontap/client/fakes.py":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"70f2600aa2243b62c3cd6e2f9f9b237c932964dc","unresolved":true,"context_lines":[{"line_number":3087,"context_line":"                    \"total\": \"1000\","},{"line_number":3088,"context_line":"                    \"write\": \"100\""},{"line_number":3089,"context_line":"                },"},{"line_number":3090,"context_line":"                \"timestamp\": \"2017-01-25T11:20:13Z\","},{"line_number":3091,"context_line":"                \"status\": \"ok\""},{"line_number":3092,"context_line":"            },"},{"line_number":3093,"context_line":"            \"ip\": {"}],"source_content_type":"text/x-python","patch_set":2,"id":"55b8c4bd_97220434","line":3090,"range":{"start_line":3090,"start_character":30,"end_line":3090,"end_character":34},"updated":"2022-09-14 10:46:03.000000000","message":"nit: any specific reason for year 2017 ?\nCan 2022 be used ? [like in lines 2984 and 3014]","commit_id":"80ea18d8ef523841371f27e2641ae6cbe5babc16"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"3a4f8ce4f30d48decda4883b4b804b4edede8240","unresolved":false,"context_lines":[{"line_number":3087,"context_line":"                    \"total\": \"1000\","},{"line_number":3088,"context_line":"                    \"write\": \"100\""},{"line_number":3089,"context_line":"                },"},{"line_number":3090,"context_line":"                \"timestamp\": \"2017-01-25T11:20:13Z\","},{"line_number":3091,"context_line":"                \"status\": \"ok\""},{"line_number":3092,"context_line":"            },"},{"line_number":3093,"context_line":"            \"ip\": {"}],"source_content_type":"text/x-python","patch_set":2,"id":"9b3b48a2_aeddaf4e","line":3090,"range":{"start_line":3090,"start_character":30,"end_line":3090,"end_character":34},"in_reply_to":"55b8c4bd_97220434","updated":"2022-09-21 15:41:25.000000000","message":"Nope, it could be any value - it was just a \"copy and paste\" from some example in the doc :)","commit_id":"80ea18d8ef523841371f27e2641ae6cbe5babc16"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"70f2600aa2243b62c3cd6e2f9f9b237c932964dc","unresolved":true,"context_lines":[{"line_number":3101,"context_line":"                }"},{"line_number":3102,"context_line":"            },"},{"line_number":3103,"context_line":"            \"metric\": {"},{"line_number":3104,"context_line":"                \"timestamp\": \"2017-01-25T11:20:13Z\","},{"line_number":3105,"context_line":"                \"status\": \"ok\","},{"line_number":3106,"context_line":"                \"_links\": {"},{"line_number":3107,"context_line":"                    \"self\": {"}],"source_content_type":"text/x-python","patch_set":2,"id":"d7729c89_f26101d5","line":3104,"range":{"start_line":3104,"start_character":30,"end_line":3104,"end_character":34},"updated":"2022-09-14 10:46:03.000000000","message":"same as above","commit_id":"80ea18d8ef523841371f27e2641ae6cbe5babc16"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"3a4f8ce4f30d48decda4883b4b804b4edede8240","unresolved":false,"context_lines":[{"line_number":3101,"context_line":"                }"},{"line_number":3102,"context_line":"            },"},{"line_number":3103,"context_line":"            \"metric\": {"},{"line_number":3104,"context_line":"                \"timestamp\": \"2017-01-25T11:20:13Z\","},{"line_number":3105,"context_line":"                \"status\": \"ok\","},{"line_number":3106,"context_line":"                \"_links\": {"},{"line_number":3107,"context_line":"                    \"self\": {"}],"source_content_type":"text/x-python","patch_set":2,"id":"af9341ee_1bc9772d","line":3104,"range":{"start_line":3104,"start_character":30,"end_line":3104,"end_character":34},"in_reply_to":"d7729c89_f26101d5","updated":"2022-09-21 15:41:25.000000000","message":"Ack","commit_id":"80ea18d8ef523841371f27e2641ae6cbe5babc16"}],"cinder/tests/unit/volume/drivers/netapp/dataontap/client/test_client_cmode_rest.py":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"70f2600aa2243b62c3cd6e2f9f9b237c932964dc","unresolved":true,"context_lines":[{"line_number":54,"context_line":"        # Setup ZAPI Client mocks"},{"line_number":55,"context_line":"        self.mock_object(client_cmode.Client, \u0027_init_ssh_client\u0027)"},{"line_number":56,"context_line":"        self.mock_object(client_cmode.Client, \u0027get_ontap_version\u0027,"},{"line_number":57,"context_line":"                         return_value\u003d(9, 11, 1))"},{"line_number":58,"context_line":"        self.mock_object(client_cmode.Client,"},{"line_number":59,"context_line":"                         \u0027get_ontapi_version\u0027,"},{"line_number":60,"context_line":"                         return_value\u003d(1, 20))"}],"source_content_type":"text/x-python","patch_set":2,"id":"cd8989cc_aca48522","line":57,"range":{"start_line":57,"start_character":39,"end_line":57,"end_character":47},"updated":"2022-09-14 10:46:03.000000000","message":"this value/version (9, 11, 1) is used at few places.\nCan a variable/constant be used ?","commit_id":"80ea18d8ef523841371f27e2641ae6cbe5babc16"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"8f18a3af6614e68e545b0934da1fbcad6a817307","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        # Setup ZAPI Client mocks"},{"line_number":55,"context_line":"        self.mock_object(client_cmode.Client, \u0027_init_ssh_client\u0027)"},{"line_number":56,"context_line":"        self.mock_object(client_cmode.Client, \u0027get_ontap_version\u0027,"},{"line_number":57,"context_line":"                         return_value\u003d(9, 11, 1))"},{"line_number":58,"context_line":"        self.mock_object(client_cmode.Client,"},{"line_number":59,"context_line":"                         \u0027get_ontapi_version\u0027,"},{"line_number":60,"context_line":"                         return_value\u003d(1, 20))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7d38e784_7fd56dd7","line":57,"range":{"start_line":57,"start_character":39,"end_line":57,"end_character":47},"in_reply_to":"52ac12d4_f7d0e7d8","updated":"2022-09-23 13:06:23.000000000","message":"Done","commit_id":"80ea18d8ef523841371f27e2641ae6cbe5babc16"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"3a4f8ce4f30d48decda4883b4b804b4edede8240","unresolved":true,"context_lines":[{"line_number":54,"context_line":"        # Setup ZAPI Client mocks"},{"line_number":55,"context_line":"        self.mock_object(client_cmode.Client, \u0027_init_ssh_client\u0027)"},{"line_number":56,"context_line":"        self.mock_object(client_cmode.Client, \u0027get_ontap_version\u0027,"},{"line_number":57,"context_line":"                         return_value\u003d(9, 11, 1))"},{"line_number":58,"context_line":"        self.mock_object(client_cmode.Client,"},{"line_number":59,"context_line":"                         \u0027get_ontapi_version\u0027,"},{"line_number":60,"context_line":"                         return_value\u003d(1, 20))"}],"source_content_type":"text/x-python","patch_set":2,"id":"52ac12d4_f7d0e7d8","line":57,"range":{"start_line":57,"start_character":39,"end_line":57,"end_character":47},"in_reply_to":"cd8989cc_aca48522","updated":"2022-09-21 15:41:25.000000000","message":"Yes, it makes sense to use a constant in this case. I can change the code.","commit_id":"80ea18d8ef523841371f27e2641ae6cbe5babc16"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"af67586d007bb74d8418bfd21ec59276d5f87565","unresolved":true,"context_lines":[{"line_number":57,"context_line":"                         return_value\u003dfake.ONTAP_VERSION)"},{"line_number":58,"context_line":"        self.mock_object(client_cmode.Client,"},{"line_number":59,"context_line":"                         \u0027get_ontapi_version\u0027,"},{"line_number":60,"context_line":"                         return_value\u003d(1, 20))"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        # Setup RestClient mocks"},{"line_number":63,"context_line":"        self.mock_object(client_cmode_rest.RestClient, \u0027_init_ssh_client\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"6a5d9c89_9aadb35b","line":60,"updated":"2023-06-21 19:13:51.000000000","message":"nit: (1, 20) could be a const, like fake.ONTAP_VERSION","commit_id":"137f4b6e2d0255f8880cca7d5e2594ccdb7abe61"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"d2b6dfe12b7aeb3848d12a775b78514b8e2a6475","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                         return_value\u003dfake.ONTAP_VERSION)"},{"line_number":58,"context_line":"        self.mock_object(client_cmode.Client,"},{"line_number":59,"context_line":"                         \u0027get_ontapi_version\u0027,"},{"line_number":60,"context_line":"                         return_value\u003d(1, 20))"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        # Setup RestClient mocks"},{"line_number":63,"context_line":"        self.mock_object(client_cmode_rest.RestClient, \u0027_init_ssh_client\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"13d501b8_ff786ce8","line":60,"in_reply_to":"6a5d9c89_9aadb35b","updated":"2023-07-25 15:01:39.000000000","message":"Done","commit_id":"137f4b6e2d0255f8880cca7d5e2594ccdb7abe61"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"335b61d5dc4307c283ae959560766fb993cfd9bd","unresolved":true,"context_lines":[{"line_number":2622,"context_line":"        aggregates \u003d [fake_client.VOLUME_AGGREGATE_NAME]"},{"line_number":2623,"context_line":"        size \u003d 100"},{"line_number":2624,"context_line":""},{"line_number":2625,"context_line":"        expected_response \u003d {"},{"line_number":2626,"context_line":"            \u0027status\u0027: None,"},{"line_number":2627,"context_line":"            \u0027jobid\u0027: fake.JOB_UUID,"},{"line_number":2628,"context_line":"            \u0027error-code\u0027: None,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a8ab8e6_99b2e561","line":2625,"updated":"2023-07-03 14:47:28.000000000","message":"Couldn\u0027t this be in the fakes file?","commit_id":"137f4b6e2d0255f8880cca7d5e2594ccdb7abe61"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"d2b6dfe12b7aeb3848d12a775b78514b8e2a6475","unresolved":false,"context_lines":[{"line_number":2622,"context_line":"        aggregates \u003d [fake_client.VOLUME_AGGREGATE_NAME]"},{"line_number":2623,"context_line":"        size \u003d 100"},{"line_number":2624,"context_line":""},{"line_number":2625,"context_line":"        expected_response \u003d {"},{"line_number":2626,"context_line":"            \u0027status\u0027: None,"},{"line_number":2627,"context_line":"            \u0027jobid\u0027: fake.JOB_UUID,"},{"line_number":2628,"context_line":"            \u0027error-code\u0027: None,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf543a93_ebf6b465","line":2625,"in_reply_to":"3a8ab8e6_99b2e561","updated":"2023-07-25 15:01:39.000000000","message":"Done","commit_id":"137f4b6e2d0255f8880cca7d5e2594ccdb7abe61"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"af67586d007bb74d8418bfd21ec59276d5f87565","unresolved":true,"context_lines":[{"line_number":3757,"context_line":""},{"line_number":3758,"context_line":"        result \u003d self.client._get_cluster_nodes_info()"},{"line_number":3759,"context_line":""},{"line_number":3760,"context_line":"        if error_code \u003d\u003d netapp_api.REST_UNAUTHORIZED:"},{"line_number":3761,"context_line":"            mock_log_debug.assert_called_once_with("},{"line_number":3762,"context_line":"                \u0027Cluster nodes can only be collected with \u0027"},{"line_number":3763,"context_line":"                \u0027cluster scoped credentials.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae96c2c_a207122f","line":3760,"updated":"2023-06-21 19:13:51.000000000","message":"Maybe also there should be a check when error_code is REST_API_NOT_FOUND or the test method only raises these 2 exceptions?","commit_id":"137f4b6e2d0255f8880cca7d5e2594ccdb7abe61"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"d2b6dfe12b7aeb3848d12a775b78514b8e2a6475","unresolved":false,"context_lines":[{"line_number":3757,"context_line":""},{"line_number":3758,"context_line":"        result \u003d self.client._get_cluster_nodes_info()"},{"line_number":3759,"context_line":""},{"line_number":3760,"context_line":"        if error_code \u003d\u003d netapp_api.REST_UNAUTHORIZED:"},{"line_number":3761,"context_line":"            mock_log_debug.assert_called_once_with("},{"line_number":3762,"context_line":"                \u0027Cluster nodes can only be collected with \u0027"},{"line_number":3763,"context_line":"                \u0027cluster scoped credentials.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dd0e6e8e_bfb215b0","line":3760,"in_reply_to":"1ae96c2c_a207122f","updated":"2023-07-25 15:01:39.000000000","message":"Only these two cases need to be tested, because the output will be different only if the REST_UNAUTHORIZED error is returned. For other cases, a generic message is returned.","commit_id":"137f4b6e2d0255f8880cca7d5e2594ccdb7abe61"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"af67586d007bb74d8418bfd21ec59276d5f87565","unresolved":true,"context_lines":[{"line_number":3779,"context_line":"                         return_value\u003dresponse)"},{"line_number":3780,"context_line":"        result \u003d self.client._wait_job_result("},{"line_number":3781,"context_line":"            f\u0027/cluster/jobs/{fake_client.FAKE_UUID}\u0027)"},{"line_number":3782,"context_line":"        self.assertEqual(response, result)"},{"line_number":3783,"context_line":""},{"line_number":3784,"context_line":"    def test__wait_job_result_failure(self):"},{"line_number":3785,"context_line":"        response \u003d fake_client.JOB_ERROR_REST"}],"source_content_type":"text/x-python","patch_set":4,"id":"c9a27bb5_92559130","line":3782,"updated":"2023-06-21 19:13:51.000000000","message":"nit: I think it should be more readable change var name from response to expected.","commit_id":"137f4b6e2d0255f8880cca7d5e2594ccdb7abe61"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"d2b6dfe12b7aeb3848d12a775b78514b8e2a6475","unresolved":false,"context_lines":[{"line_number":3779,"context_line":"                         return_value\u003dresponse)"},{"line_number":3780,"context_line":"        result \u003d self.client._wait_job_result("},{"line_number":3781,"context_line":"            f\u0027/cluster/jobs/{fake_client.FAKE_UUID}\u0027)"},{"line_number":3782,"context_line":"        self.assertEqual(response, result)"},{"line_number":3783,"context_line":""},{"line_number":3784,"context_line":"    def test__wait_job_result_failure(self):"},{"line_number":3785,"context_line":"        response \u003d fake_client.JOB_ERROR_REST"}],"source_content_type":"text/x-python","patch_set":4,"id":"1e2fc189_12c8d69d","line":3782,"in_reply_to":"c9a27bb5_92559130","updated":"2023-07-25 15:01:39.000000000","message":"Done","commit_id":"137f4b6e2d0255f8880cca7d5e2594ccdb7abe61"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"335b61d5dc4307c283ae959560766fb993cfd9bd","unresolved":true,"context_lines":[{"line_number":3836,"context_line":""},{"line_number":3837,"context_line":"        self.assertRaises(exception.NotFound,"},{"line_number":3838,"context_line":"                          self.client.get_if_info_by_ip,"},{"line_number":3839,"context_line":"                          \u0027192.168.1.101\u0027)"},{"line_number":3840,"context_line":""},{"line_number":3841,"context_line":"    @ddt.data(True, False)"},{"line_number":3842,"context_line":"    def test_set_iscsi_chap_authentication(self, initiator):"}],"source_content_type":"text/x-python","patch_set":4,"id":"917e7024_ab71562a","line":3839,"updated":"2023-07-03 14:47:28.000000000","message":"As this IP value is used in other locations, could\u0027t be a constant in the fake files too?","commit_id":"137f4b6e2d0255f8880cca7d5e2594ccdb7abe61"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"d2b6dfe12b7aeb3848d12a775b78514b8e2a6475","unresolved":false,"context_lines":[{"line_number":3836,"context_line":""},{"line_number":3837,"context_line":"        self.assertRaises(exception.NotFound,"},{"line_number":3838,"context_line":"                          self.client.get_if_info_by_ip,"},{"line_number":3839,"context_line":"                          \u0027192.168.1.101\u0027)"},{"line_number":3840,"context_line":""},{"line_number":3841,"context_line":"    @ddt.data(True, False)"},{"line_number":3842,"context_line":"    def test_set_iscsi_chap_authentication(self, initiator):"}],"source_content_type":"text/x-python","patch_set":4,"id":"2461a5cc_949ed26b","line":3839,"in_reply_to":"917e7024_ab71562a","updated":"2023-07-25 15:01:39.000000000","message":"Done","commit_id":"137f4b6e2d0255f8880cca7d5e2594ccdb7abe61"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"af67586d007bb74d8418bfd21ec59276d5f87565","unresolved":true,"context_lines":[{"line_number":3838,"context_line":"                          self.client.get_if_info_by_ip,"},{"line_number":3839,"context_line":"                          \u0027192.168.1.101\u0027)"},{"line_number":3840,"context_line":""},{"line_number":3841,"context_line":"    @ddt.data(True, False)"},{"line_number":3842,"context_line":"    def test_set_iscsi_chap_authentication(self, initiator):"},{"line_number":3843,"context_line":"        self.mock_object(self.client, \u0027check_iscsi_initiator_exists\u0027,"},{"line_number":3844,"context_line":"                         return_value\u003dinitiator)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf4b88de_87f5aeab","line":3841,"updated":"2023-06-21 19:13:51.000000000","message":"Will there be any difference in output for each initiator value (true or false)? Maybe some additional call or something like that?","commit_id":"137f4b6e2d0255f8880cca7d5e2594ccdb7abe61"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"d2b6dfe12b7aeb3848d12a775b78514b8e2a6475","unresolved":false,"context_lines":[{"line_number":3838,"context_line":"                          self.client.get_if_info_by_ip,"},{"line_number":3839,"context_line":"                          \u0027192.168.1.101\u0027)"},{"line_number":3840,"context_line":""},{"line_number":3841,"context_line":"    @ddt.data(True, False)"},{"line_number":3842,"context_line":"    def test_set_iscsi_chap_authentication(self, initiator):"},{"line_number":3843,"context_line":"        self.mock_object(self.client, \u0027check_iscsi_initiator_exists\u0027,"},{"line_number":3844,"context_line":"                         return_value\u003dinitiator)"}],"source_content_type":"text/x-python","patch_set":4,"id":"e19826a7_e4ef36fc","line":3841,"in_reply_to":"bf4b88de_87f5aeab","updated":"2023-07-25 15:01:39.000000000","message":"Nice catch, the command is different in each case. Done.","commit_id":"137f4b6e2d0255f8880cca7d5e2594ccdb7abe61"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"af67586d007bb74d8418bfd21ec59276d5f87565","unresolved":true,"context_lines":[{"line_number":3855,"context_line":"        mock_prompt.assert_called_once_with(mock.ANY, mock.ANY, \u0027Password:\u0027,"},{"line_number":3856,"context_line":"                                            \u0027fake_pass\u0027)"},{"line_number":3857,"context_line":""},{"line_number":3858,"context_line":"    @ddt.data(True, False)"},{"line_number":3859,"context_line":"    def test_set_iscsi_chap_authentication_error(self, initiator):"},{"line_number":3860,"context_line":"        self.mock_object(self.client, \u0027check_iscsi_initiator_exists\u0027,"},{"line_number":3861,"context_line":"                         return_value\u003dinitiator)"}],"source_content_type":"text/x-python","patch_set":4,"id":"0d692a3c_06deb1d7","line":3858,"updated":"2023-06-21 19:13:51.000000000","message":"Will there be any difference in output for each initiator value (true or false)? Maybe some additional call or something like that?","commit_id":"137f4b6e2d0255f8880cca7d5e2594ccdb7abe61"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"d2b6dfe12b7aeb3848d12a775b78514b8e2a6475","unresolved":false,"context_lines":[{"line_number":3855,"context_line":"        mock_prompt.assert_called_once_with(mock.ANY, mock.ANY, \u0027Password:\u0027,"},{"line_number":3856,"context_line":"                                            \u0027fake_pass\u0027)"},{"line_number":3857,"context_line":""},{"line_number":3858,"context_line":"    @ddt.data(True, False)"},{"line_number":3859,"context_line":"    def test_set_iscsi_chap_authentication_error(self, initiator):"},{"line_number":3860,"context_line":"        self.mock_object(self.client, \u0027check_iscsi_initiator_exists\u0027,"},{"line_number":3861,"context_line":"                         return_value\u003dinitiator)"}],"source_content_type":"text/x-python","patch_set":4,"id":"138f19c9_dd681e5f","line":3858,"in_reply_to":"0d692a3c_06deb1d7","updated":"2023-07-25 15:01:39.000000000","message":"This case is similar to the previous one. Since the True/False flag is tested on the \"happy path\" test, I think this ddt can be droped from the error test case.","commit_id":"137f4b6e2d0255f8880cca7d5e2594ccdb7abe61"}]}