)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"3d261f81b10d6e0a50aaffbd98e0c9c8db2a588b","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Haleema khan \u003chsadia538@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-10-23 01:30:20 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add api-ref tests to check url and parameter for importing backups"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds functional test to make sure that api-ref is in sync with the actual code."},{"line_number":10,"context_line":"The api-ref for import a backup (POST) was previously not in sync with the code"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bc83dbd8_c73aa643","line":7,"updated":"2022-10-26 03:54:55.000000000","message":"As I mentioned in the other comment, I think we can make a more basic case and leave the bug for later.\n\nWe could rewrite the title as \"Automate generation of backups api-ref samples\"\n\nAnd the commit message body could be:\n\n```\n\nThis patch adds the following tests:\n\n1) Backup list\n\n```\n\nAnd replace \"Closes bug\" line with: \n```\nPartially-Implements: blueprint generating-sample-files\n```\n\nRemember that lines shouldn\u0027t be too long, break them up for easy reading.","commit_id":"77ec811858416c25033572d104b82613960926c7"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"22299c60350bebb43f6dde8fb54d46bb73dfcd66","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Haleema khan \u003chsadia538@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-10-23 01:30:20 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add api-ref tests to check url and parameter for importing backups"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds functional test to make sure that api-ref is in sync with the actual code."},{"line_number":10,"context_line":"The api-ref for import a backup (POST) was previously not in sync with the code"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3b733fdb_9ecb111e","line":7,"in_reply_to":"bc83dbd8_c73aa643","updated":"2023-05-24 10:16:15.000000000","message":"Done","commit_id":"77ec811858416c25033572d104b82613960926c7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cb471e4f2249d133a0d313359e947a5c15c019b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a8c4b2a5_1a0c8e97","updated":"2022-10-17 13:12:02.000000000","message":"Thanks for working on this. Please see my comments inline.","commit_id":"5b0d4f861d91b8e8851e58f07f26ea3f0d257e74"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"3d261f81b10d6e0a50aaffbd98e0c9c8db2a588b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bdf5a4d2_fa507e55","updated":"2022-10-26 03:54:55.000000000","message":"Thank you very much for working on this, I think that with the changes that I left below I would be ready to merge.","commit_id":"77ec811858416c25033572d104b82613960926c7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"917b83540c53011052d1342c3d6f4d7dce522814","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d0d203c8_31aa3f69","updated":"2022-11-04 17:35:03.000000000","message":"Updated with the changes but it\u0027s still failing with the error\n\n    testtools.matchers._impl.MismatchError: 202 !\u003d 400: {\"badRequest\": {\"code\": 400, \"message\": \"Malformed request body\"}}\n\nthe request seems correct so need to check why this fails","commit_id":"d12f4bd2a312bca145a21c8353ac175f146ba368"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3716b8c179f2a87b2063a4a34febc5fd651f0c4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a25c5fbb_e89d3e51","updated":"2022-11-08 14:00:58.000000000","message":"Updating the patch with some more changes to make it pass.","commit_id":"d12f4bd2a312bca145a21c8353ac175f146ba368"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"49668872c570abe150f5efa942597568130b5667","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"6e0c4be8_cd372a3b","updated":"2022-11-08 14:15:28.000000000","message":"The tests should pass now.\n\nThere are few more change I\u0027ve left to be made,\n\n1) change file names inline\n2) remove backup create request response files that are out of sample dir[1]\n3) make changes in .inc file[2] to include the new path i.e. samples/backups/*\n\n[1] https://github.com/openstack/cinder/tree/master/api-ref/source/v3/samples\n[2] https://github.com/openstack/cinder/blob/master/api-ref/source/v3/ext-backups.inc#create-a-backup","commit_id":"eb097b43f98cc7fbaa108927418407d72691cc85"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"86ff44b4db4a4a24c68311b023d3519caded9be9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"4217f5dd_0146610a","updated":"2023-04-02 15:31:25.000000000","message":"run-INFINIDAT","commit_id":"9e612282c0512494c15c68f77fa5063a63e9b747"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"b8c21b6ab10ed9cf108e234e2aaa95b2a8f6a5fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"06639f44_bc72c433","updated":"2023-05-25 15:07:24.000000000","message":"Already looked at by two cores.  Looks safe to merge to me.","commit_id":"ed2115a6f3e03f99fa99f071f686ad1467698a24"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d78333272a5dc9d6d0b98df7d88dbef872a11726","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"25cddc93_a0689e57","updated":"2023-05-25 13:57:32.000000000","message":"Tested this locally by deleting the request and response sample files and it generates them correctly.\n\nAlso Backup create test is passing in gate\n\ncinder.tests.functional.api_sample_tests.test_backups.BackupClassesSampleJsonTest\t1\t1\t0\t0\t0\tDetail\t\ntest_backup_create\npass\n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_d9b/861491/13/check/openstack-tox-functional-py310/d9bd99a/testr_results.html\n\nLGTM.","commit_id":"ed2115a6f3e03f99fa99f071f686ad1467698a24"}],"api-ref/source/v3/samples/backups/backups-create-request.json":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"49668872c570abe150f5efa942597568130b5667","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"backup\": {"},{"line_number":3,"context_line":"        \"container\": null,"},{"line_number":4,"context_line":"        \"description\": \"Test backup\","}],"source_content_type":"application/json","patch_set":10,"id":"d72ebf08_a7e6bb9c","line":1,"updated":"2022-11-08 14:15:28.000000000","message":"The file name should be backup-create-request.json","commit_id":"eb097b43f98cc7fbaa108927418407d72691cc85"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"22299c60350bebb43f6dde8fb54d46bb73dfcd66","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"backup\": {"},{"line_number":3,"context_line":"        \"container\": null,"},{"line_number":4,"context_line":"        \"description\": \"Test backup\","}],"source_content_type":"application/json","patch_set":10,"id":"5f922482_b5587fc6","line":1,"in_reply_to":"d72ebf08_a7e6bb9c","updated":"2023-05-24 10:16:15.000000000","message":"Done","commit_id":"eb097b43f98cc7fbaa108927418407d72691cc85"}],"api-ref/source/v3/samples/backups/backups-create-response.json":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"49668872c570abe150f5efa942597568130b5667","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"backup\": {"},{"line_number":3,"context_line":"        \"id\": \"b1f41f9b-741e-4992-a246-b97de7e6e87e\","},{"line_number":4,"context_line":"        \"links\": ["}],"source_content_type":"application/json","patch_set":10,"id":"11fcc036_970a33ed","line":1,"updated":"2022-11-08 14:15:28.000000000","message":"change the file name to backup-create-response.json","commit_id":"eb097b43f98cc7fbaa108927418407d72691cc85"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"22299c60350bebb43f6dde8fb54d46bb73dfcd66","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"backup\": {"},{"line_number":3,"context_line":"        \"id\": \"b1f41f9b-741e-4992-a246-b97de7e6e87e\","},{"line_number":4,"context_line":"        \"links\": ["}],"source_content_type":"application/json","patch_set":10,"id":"84f91e76_81d35b5f","line":1,"in_reply_to":"11fcc036_970a33ed","updated":"2023-05-24 10:16:15.000000000","message":"Done","commit_id":"eb097b43f98cc7fbaa108927418407d72691cc85"}],"cinder/tests/functional/api_sample_tests/samples/backups/backups-create-request.json.tpl":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"3d261f81b10d6e0a50aaffbd98e0c9c8db2a588b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"backup-record\": {"},{"line_number":3,"context_line":"        \"backup_service\": \"cinder.backup.drivers.swift\","},{"line_number":4,"context_line":"        \"backup_url\": \"eyJzdGF0\""},{"line_number":5,"context_line":"    }"},{"line_number":6,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"3e2db177_d33f17f9","line":6,"range":{"start_line":1,"start_character":0,"end_line":6,"end_character":1},"updated":"2022-10-26 03:54:55.000000000","message":"This should be :\n\n```\n\n{\n    \"backup\": {\n        \"container\": null,\n        \"description\": null,\n        \"name\": \"backup001\",\n        \"volume_id\": \"%(volume_id)s\",\n        \"incremental\": false,\n        \"availability_zone\": \"AZ2\",\n        \"metadata\": null\n    }\n}\n\n```\n\n\nhttps://opendev.org/openstack/cinder/src/branch/master/api-ref/source/v3/samples/backup-create-request.json","commit_id":"77ec811858416c25033572d104b82613960926c7"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"5c5d640aa7599575f6c1fed85f0ff0b9206edefa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"backup-record\": {"},{"line_number":3,"context_line":"        \"backup_service\": \"cinder.backup.drivers.swift\","},{"line_number":4,"context_line":"        \"backup_url\": \"eyJzdGF0\""},{"line_number":5,"context_line":"    }"},{"line_number":6,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"b56854df_a075533a","line":6,"range":{"start_line":1,"start_character":0,"end_line":6,"end_character":1},"in_reply_to":"3e2db177_d33f17f9","updated":"2022-11-04 15:05:29.000000000","message":"Done! Thanks","commit_id":"77ec811858416c25033572d104b82613960926c7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a22d84e0c081cf9d5f5a80ef81067b93ebced110","unresolved":true,"context_lines":[{"line_number":5,"context_line":"        \"name\": \"backup001\","},{"line_number":6,"context_line":"        \"volume_id\": \"%(volume_id)s\","},{"line_number":7,"context_line":"        \"incremental\": false,"},{"line_number":8,"context_line":"        \"availability_zone\": \"AZ2\","},{"line_number":9,"context_line":"        \"metadata\": null"},{"line_number":10,"context_line":"    }"},{"line_number":11,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"6be07df9_97b096eb","line":9,"range":{"start_line":8,"start_character":0,"end_line":9,"end_character":24},"updated":"2022-11-04 17:32:59.000000000","message":"These are optional properties only available in microversions so better not to pass it","commit_id":"54618984ee9ab3ee624b1f8cb45fa99242cbf346"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"917b83540c53011052d1342c3d6f4d7dce522814","unresolved":false,"context_lines":[{"line_number":5,"context_line":"        \"name\": \"backup001\","},{"line_number":6,"context_line":"        \"volume_id\": \"%(volume_id)s\","},{"line_number":7,"context_line":"        \"incremental\": false,"},{"line_number":8,"context_line":"        \"availability_zone\": \"AZ2\","},{"line_number":9,"context_line":"        \"metadata\": null"},{"line_number":10,"context_line":"    }"},{"line_number":11,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"8a113d32_37320fdc","line":9,"range":{"start_line":8,"start_character":0,"end_line":9,"end_character":24},"in_reply_to":"6be07df9_97b096eb","updated":"2022-11-04 17:35:03.000000000","message":"Done","commit_id":"54618984ee9ab3ee624b1f8cb45fa99242cbf346"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3716b8c179f2a87b2063a4a34febc5fd651f0c4a","unresolved":true,"context_lines":[{"line_number":4,"context_line":"        \"description\": \"Test backup\","},{"line_number":5,"context_line":"        \"name\": \"backup001\","},{"line_number":6,"context_line":"        \"volume_id\": \"%(volume_id)s\","},{"line_number":7,"context_line":"        \"incremental\": false,"},{"line_number":8,"context_line":"    }"},{"line_number":9,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":9,"id":"c7e549a7_bde05158","line":7,"range":{"start_line":7,"start_character":28,"end_line":7,"end_character":29},"updated":"2022-11-08 14:00:58.000000000","message":"this is the issue","commit_id":"d12f4bd2a312bca145a21c8353ac175f146ba368"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"49668872c570abe150f5efa942597568130b5667","unresolved":false,"context_lines":[{"line_number":4,"context_line":"        \"description\": \"Test backup\","},{"line_number":5,"context_line":"        \"name\": \"backup001\","},{"line_number":6,"context_line":"        \"volume_id\": \"%(volume_id)s\","},{"line_number":7,"context_line":"        \"incremental\": false,"},{"line_number":8,"context_line":"    }"},{"line_number":9,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":9,"id":"2109512f_db557051","line":7,"range":{"start_line":7,"start_character":28,"end_line":7,"end_character":29},"in_reply_to":"c7e549a7_bde05158","updated":"2022-11-08 14:15:28.000000000","message":"Done","commit_id":"d12f4bd2a312bca145a21c8353ac175f146ba368"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"49668872c570abe150f5efa942597568130b5667","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"backup\": {"},{"line_number":3,"context_line":"        \"container\": null,"},{"line_number":4,"context_line":"        \"description\": \"Test backup\","}],"source_content_type":"text/x-smarty","patch_set":10,"id":"b21b1581_5d98aa09","line":1,"updated":"2022-11-08 14:15:28.000000000","message":"change file name to backup-create-request.json.tpl","commit_id":"eb097b43f98cc7fbaa108927418407d72691cc85"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"22299c60350bebb43f6dde8fb54d46bb73dfcd66","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"backup\": {"},{"line_number":3,"context_line":"        \"container\": null,"},{"line_number":4,"context_line":"        \"description\": \"Test backup\","}],"source_content_type":"text/x-smarty","patch_set":10,"id":"842545b5_d2eda3ee","line":1,"in_reply_to":"b21b1581_5d98aa09","updated":"2023-05-24 10:16:15.000000000","message":"Done","commit_id":"eb097b43f98cc7fbaa108927418407d72691cc85"}],"cinder/tests/functional/api_sample_tests/samples/backups/backups-create-response.json.tpl":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"3d261f81b10d6e0a50aaffbd98e0c9c8db2a588b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"backup\": {"},{"line_number":3,"context_line":"        \"id\": \"%(uuid)s\","},{"line_number":4,"context_line":"        \"links\": ["},{"line_number":5,"context_line":"            {"},{"line_number":6,"context_line":"                \"href\": \"%(host)s/c95fc3e4afe248a49a28828f286a7b38/backups/%(uuid)s\","},{"line_number":7,"context_line":"                \"rel\": \"self\""},{"line_number":8,"context_line":"            },"},{"line_number":9,"context_line":"            {"},{"line_number":10,"context_line":"                \"href\": \"%(host)s/c95fc3e4afe248a49a28828f286a7b38/backups/%(uuid)s\","},{"line_number":11,"context_line":"                \"rel\": \"bookmark\""},{"line_number":12,"context_line":"            }"},{"line_number":13,"context_line":"        ],"},{"line_number":14,"context_line":"        \"name\": null"},{"line_number":15,"context_line":"    }"},{"line_number":16,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"2c7b00ce_dcf3a37d","line":16,"range":{"start_line":1,"start_character":0,"end_line":16,"end_character":1},"updated":"2022-10-26 03:54:55.000000000","message":"Looks good, just add metadata and a name:\n\n```\n\n{\n    \"backup\": {\n        \"id\": \"%(uuid)s\",\n        \"links\": [\n            {\n                \"href\": \"%(host)s/c95fc3e4afe248a49a28828f286a7b38/backups/%(uuid)s\",\n                \"rel\": \"self\"\n            },\n            {\n                \"href\": \"href\": \"%(host)s/c95fc3e4afe248a49a28828f286a7b38/backups/%(uuid)s\",\n                \"rel\": \"bookmark\"\n            }\n        ],\n        \"name\": \"backup001\",\n        \"metadata\": {}\n    }\n}\n```\n\nhttps://opendev.org/openstack/cinder/src/branch/master/api-ref/source/v3/samples/backup-create-response.json","commit_id":"77ec811858416c25033572d104b82613960926c7"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"5c5d640aa7599575f6c1fed85f0ff0b9206edefa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"backup\": {"},{"line_number":3,"context_line":"        \"id\": \"%(uuid)s\","},{"line_number":4,"context_line":"        \"links\": ["},{"line_number":5,"context_line":"            {"},{"line_number":6,"context_line":"                \"href\": \"%(host)s/c95fc3e4afe248a49a28828f286a7b38/backups/%(uuid)s\","},{"line_number":7,"context_line":"                \"rel\": \"self\""},{"line_number":8,"context_line":"            },"},{"line_number":9,"context_line":"            {"},{"line_number":10,"context_line":"                \"href\": \"%(host)s/c95fc3e4afe248a49a28828f286a7b38/backups/%(uuid)s\","},{"line_number":11,"context_line":"                \"rel\": \"bookmark\""},{"line_number":12,"context_line":"            }"},{"line_number":13,"context_line":"        ],"},{"line_number":14,"context_line":"        \"name\": null"},{"line_number":15,"context_line":"    }"},{"line_number":16,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"0d083fcd_6cf2c4b9","line":16,"range":{"start_line":1,"start_character":0,"end_line":16,"end_character":1},"in_reply_to":"2c7b00ce_dcf3a37d","updated":"2022-11-04 15:05:29.000000000","message":"Done","commit_id":"77ec811858416c25033572d104b82613960926c7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a22d84e0c081cf9d5f5a80ef81067b93ebced110","unresolved":true,"context_lines":[{"line_number":12,"context_line":"            }"},{"line_number":13,"context_line":"        ],"},{"line_number":14,"context_line":"        \"name\": \"backup001\","},{"line_number":15,"context_line":"        \"metadata\": {}"},{"line_number":16,"context_line":"    }"},{"line_number":17,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"eb2a35ae_1ed563a7","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":22},"updated":"2022-11-04 17:32:59.000000000","message":"this is also part of MV 3.43 so better not to include it","commit_id":"54618984ee9ab3ee624b1f8cb45fa99242cbf346"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"917b83540c53011052d1342c3d6f4d7dce522814","unresolved":false,"context_lines":[{"line_number":12,"context_line":"            }"},{"line_number":13,"context_line":"        ],"},{"line_number":14,"context_line":"        \"name\": \"backup001\","},{"line_number":15,"context_line":"        \"metadata\": {}"},{"line_number":16,"context_line":"    }"},{"line_number":17,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"c238a67e_be703b57","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":22},"in_reply_to":"eb2a35ae_1ed563a7","updated":"2022-11-04 17:35:03.000000000","message":"Done","commit_id":"54618984ee9ab3ee624b1f8cb45fa99242cbf346"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a22d84e0c081cf9d5f5a80ef81067b93ebced110","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"backup\": {"},{"line_number":3,"context_line":"        \"id\": \"%(uuid)s\","},{"line_number":4,"context_line":"        \"links\": ["},{"line_number":5,"context_line":"            {"},{"line_number":6,"context_line":"                \"href\": \"%(host)s/c95fc3e4afe248a49a28828f286a7b38/backups/%(uuid)s\","},{"line_number":7,"context_line":"                \"rel\": \"self\""},{"line_number":8,"context_line":"            },"},{"line_number":9,"context_line":"            {"},{"line_number":10,"context_line":"                \"href\": \"%(host)s/c95fc3e4afe248a49a28828f286a7b38/backups/%(uuid)s\","},{"line_number":11,"context_line":"                \"rel\": \"bookmark\""},{"line_number":12,"context_line":"            }"},{"line_number":13,"context_line":"        ],"},{"line_number":14,"context_line":"        \"name\": \"backup001\","},{"line_number":15,"context_line":"        \"metadata\": {}"},{"line_number":16,"context_line":"    }"},{"line_number":17,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"52fc88ae_21aafc31","line":17,"range":{"start_line":1,"start_character":0,"end_line":17,"end_character":1},"updated":"2022-11-04 17:32:59.000000000","message":"This response corresponds to create backup whereas we wrote the test for list backup, I think this is correct and we can directly test create backup","commit_id":"54618984ee9ab3ee624b1f8cb45fa99242cbf346"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"917b83540c53011052d1342c3d6f4d7dce522814","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"backup\": {"},{"line_number":3,"context_line":"        \"id\": \"%(uuid)s\","},{"line_number":4,"context_line":"        \"links\": ["},{"line_number":5,"context_line":"            {"},{"line_number":6,"context_line":"                \"href\": \"%(host)s/c95fc3e4afe248a49a28828f286a7b38/backups/%(uuid)s\","},{"line_number":7,"context_line":"                \"rel\": \"self\""},{"line_number":8,"context_line":"            },"},{"line_number":9,"context_line":"            {"},{"line_number":10,"context_line":"                \"href\": \"%(host)s/c95fc3e4afe248a49a28828f286a7b38/backups/%(uuid)s\","},{"line_number":11,"context_line":"                \"rel\": \"bookmark\""},{"line_number":12,"context_line":"            }"},{"line_number":13,"context_line":"        ],"},{"line_number":14,"context_line":"        \"name\": \"backup001\","},{"line_number":15,"context_line":"        \"metadata\": {}"},{"line_number":16,"context_line":"    }"},{"line_number":17,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"56c403f9_c692ec09","line":17,"range":{"start_line":1,"start_character":0,"end_line":17,"end_character":1},"in_reply_to":"52fc88ae_21aafc31","updated":"2022-11-04 17:35:03.000000000","message":"Done","commit_id":"54618984ee9ab3ee624b1f8cb45fa99242cbf346"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"49668872c570abe150f5efa942597568130b5667","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"backup\": {"},{"line_number":3,"context_line":"        \"id\": \"%(uuid)s\","},{"line_number":4,"context_line":"        \"links\": ["}],"source_content_type":"text/x-smarty","patch_set":10,"id":"f165674e_57533d53","line":1,"updated":"2022-11-08 14:15:28.000000000","message":"Change file name to backup-create-response.json.tpl","commit_id":"eb097b43f98cc7fbaa108927418407d72691cc85"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"22299c60350bebb43f6dde8fb54d46bb73dfcd66","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"backup\": {"},{"line_number":3,"context_line":"        \"id\": \"%(uuid)s\","},{"line_number":4,"context_line":"        \"links\": ["}],"source_content_type":"text/x-smarty","patch_set":10,"id":"5f930759_02453e30","line":1,"in_reply_to":"f165674e_57533d53","updated":"2023-05-24 10:16:15.000000000","message":"Done","commit_id":"eb097b43f98cc7fbaa108927418407d72691cc85"}],"cinder/tests/functional/api_sample_tests/test_backups.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cb471e4f2249d133a0d313359e947a5c15c019b1","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def test_backup_type_create(self):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"        response \u003d self._backup_type_create()"},{"line_number":25,"context_line":"        self._verify_response(\u0027backup-type-create-response\u0027,"},{"line_number":26,"context_line":"                              self.subs, response, 200)"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"6ff94b6a_73bb751f","line":24,"range":{"start_line":24,"start_character":24,"end_line":24,"end_character":43},"updated":"2022-10-17 13:12:02.000000000","message":"currently there is no method with this name. you will need to create this helper method similar to the volume one[1].\nAlso you will need to create a request sample file like[2]\n\n[1] https://github.com/openstack/cinder/blob/5b89039e9e51a429c6894e2b8791a3ee4fc338cd/cinder/tests/functional/api_samples_test_base.py#L534-L543\n[2] https://github.com/openstack/cinder/blob/5b89039e9e51a429c6894e2b8791a3ee4fc338cd/cinder/tests/functional/api_sample_tests/samples/volumes/volume-create-request.json.tpl","commit_id":"5b0d4f861d91b8e8851e58f07f26ea3f0d257e74"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"5c5d640aa7599575f6c1fed85f0ff0b9206edefa","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def test_backup_type_create(self):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"        response \u003d self._backup_type_create()"},{"line_number":25,"context_line":"        self._verify_response(\u0027backup-type-create-response\u0027,"},{"line_number":26,"context_line":"                              self.subs, response, 200)"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"d57b17d7_9fa5bbfb","line":24,"range":{"start_line":24,"start_character":24,"end_line":24,"end_character":43},"in_reply_to":"6ff94b6a_73bb751f","updated":"2022-11-04 15:05:29.000000000","message":"Done","commit_id":"5b0d4f861d91b8e8851e58f07f26ea3f0d257e74"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"3d261f81b10d6e0a50aaffbd98e0c9c8db2a588b","unresolved":true,"context_lines":[{"line_number":20,"context_line":"        super(BackupClassesSampleJsonTest, self).setUp()"},{"line_number":21,"context_line":"        self.response \u003d self._create_backup()"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def test_backup_type_create(self):"},{"line_number":24,"context_line":"        response \u003d self._do_post(\u0027backups/import_record\u0027, \u0027backups-create-request\u0027,)"},{"line_number":25,"context_line":"        self._verify_response(\u0027backup-type-create-response\u0027,"},{"line_number":26,"context_line":"                              self.subs, response, 200)"}],"source_content_type":"text/x-python","patch_set":5,"id":"59788431_3e335190","line":23,"updated":"2022-10-26 03:54:55.000000000","message":"I think you are doing an excellent job, and the bug description is a bit confusing because it talks about backup import when we still don\u0027t have code for backup create or list. Why don\u0027t we do the base case first? Maybe replace test_backup_type_create with: \n\n```\ndef test_backup_list(self):\n        response \u003d self._do_get(\u0027backups\u0027)\n        self._verify_response(\u0027backups-list-response\u0027,\n                              {}, response, 200)\n```\n\nExample: https://github.com/openstack/cinder/blob/5b89039e9e51a429c6894e2b8791a3ee4fc338cd/cinder/tests/functional/api_sample_tests/test_volumes.py#L80-L85","commit_id":"77ec811858416c25033572d104b82613960926c7"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"5c5d640aa7599575f6c1fed85f0ff0b9206edefa","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        super(BackupClassesSampleJsonTest, self).setUp()"},{"line_number":21,"context_line":"        self.response \u003d self._create_backup()"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def test_backup_type_create(self):"},{"line_number":24,"context_line":"        response \u003d self._do_post(\u0027backups/import_record\u0027, \u0027backups-create-request\u0027,)"},{"line_number":25,"context_line":"        self._verify_response(\u0027backup-type-create-response\u0027,"},{"line_number":26,"context_line":"                              self.subs, response, 200)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1c6eb6cd_fd5953bb","line":23,"in_reply_to":"59788431_3e335190","updated":"2022-11-04 15:05:29.000000000","message":"Done","commit_id":"77ec811858416c25033572d104b82613960926c7"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"5c5d640aa7599575f6c1fed85f0ff0b9206edefa","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        self.response \u003d self._create_backup()"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def test_backup_type_create(self):"},{"line_number":24,"context_line":"        response \u003d self._do_post(\u0027backups/import_record\u0027, \u0027backups-create-request\u0027,)"},{"line_number":25,"context_line":"        self._verify_response(\u0027backup-type-create-response\u0027,"},{"line_number":26,"context_line":"                              self.subs, response, 200)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9dea9182_8b1c01f8","line":24,"in_reply_to":"b79c1619_17bb5b41","updated":"2022-11-04 15:05:29.000000000","message":"Done","commit_id":"77ec811858416c25033572d104b82613960926c7"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"3d261f81b10d6e0a50aaffbd98e0c9c8db2a588b","unresolved":true,"context_lines":[{"line_number":21,"context_line":"        self.response \u003d self._create_backup()"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def test_backup_type_create(self):"},{"line_number":24,"context_line":"        response \u003d self._do_post(\u0027backups/import_record\u0027, \u0027backups-create-request\u0027,)"},{"line_number":25,"context_line":"        self._verify_response(\u0027backup-type-create-response\u0027,"},{"line_number":26,"context_line":"                              self.subs, response, 200)"}],"source_content_type":"text/x-python","patch_set":5,"id":"b79c1619_17bb5b41","line":24,"in_reply_to":"eb94ab43_b95e3c1c","updated":"2022-10-26 03:54:55.000000000","message":"\u003e pep8: E501 line too long (84 \u003e 79 characters)\n\nPlease check python PEP8 docs: https://peps.python.org/pep-0008/#should-a-line-break-before-or-after-a-binary-operator","commit_id":"77ec811858416c25033572d104b82613960926c7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a22d84e0c081cf9d5f5a80ef81067b93ebced110","unresolved":true,"context_lines":[{"line_number":20,"context_line":"        super(BackupClassesSampleJsonTest, self).setUp()"},{"line_number":21,"context_line":"        self.response \u003d self._create_backup()"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def test_backup_list(self):"},{"line_number":24,"context_line":"        response \u003d self._do_get(\u0027backups\u0027)"},{"line_number":25,"context_line":"        self._verify_response(\u0027backups-list-response\u0027,"},{"line_number":26,"context_line":"                              {}, response, 200)"}],"source_content_type":"text/x-python","patch_set":7,"id":"0c787ead_8038cd76","line":23,"range":{"start_line":23,"start_character":8,"end_line":23,"end_character":24},"updated":"2022-11-04 17:32:59.000000000","message":"I think it would be better to test create backup response first since we\u0027re already doing it in setup and doesn\u0027t require an extra api call","commit_id":"54618984ee9ab3ee624b1f8cb45fa99242cbf346"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"917b83540c53011052d1342c3d6f4d7dce522814","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        super(BackupClassesSampleJsonTest, self).setUp()"},{"line_number":21,"context_line":"        self.response \u003d self._create_backup()"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def test_backup_list(self):"},{"line_number":24,"context_line":"        response \u003d self._do_get(\u0027backups\u0027)"},{"line_number":25,"context_line":"        self._verify_response(\u0027backups-list-response\u0027,"},{"line_number":26,"context_line":"                              {}, response, 200)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3b5894ec_7b80da24","line":23,"range":{"start_line":23,"start_character":8,"end_line":23,"end_character":24},"in_reply_to":"0c787ead_8038cd76","updated":"2022-11-04 17:35:03.000000000","message":"Done","commit_id":"54618984ee9ab3ee624b1f8cb45fa99242cbf346"}],"cinder/tests/functional/api_samples_test_base.py":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"3d261f81b10d6e0a50aaffbd98e0c9c8db2a588b","unresolved":true,"context_lines":[{"line_number":550,"context_line":"        # Use the samples from the common API for the request"},{"line_number":551,"context_line":"        with self.common_api_sample(\u0027backups\u0027):"},{"line_number":552,"context_line":"            response \u003d self._do_post(\u0027backups\u0027,"},{"line_number":553,"context_line":"                                     \u0027backups-create-request\u0027,"},{"line_number":554,"context_line":"                                     subs)"},{"line_number":555,"context_line":"            return response"}],"source_content_type":"text/x-python","patch_set":5,"id":"870b0a2c_c9ce6bb0","line":553,"range":{"start_line":553,"start_character":38,"end_line":553,"end_character":60},"updated":"2022-10-26 03:54:55.000000000","message":"fix typo: this should be `backup-create-request` \n\nhttps://opendev.org/openstack/cinder/src/branch/master/api-ref/source/v3/ext-backups.inc#L306","commit_id":"77ec811858416c25033572d104b82613960926c7"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"22299c60350bebb43f6dde8fb54d46bb73dfcd66","unresolved":false,"context_lines":[{"line_number":550,"context_line":"        # Use the samples from the common API for the request"},{"line_number":551,"context_line":"        with self.common_api_sample(\u0027backups\u0027):"},{"line_number":552,"context_line":"            response \u003d self._do_post(\u0027backups\u0027,"},{"line_number":553,"context_line":"                                     \u0027backups-create-request\u0027,"},{"line_number":554,"context_line":"                                     subs)"},{"line_number":555,"context_line":"            return response"}],"source_content_type":"text/x-python","patch_set":5,"id":"edfb2bce_b6daa144","line":553,"range":{"start_line":553,"start_character":38,"end_line":553,"end_character":60},"in_reply_to":"870b0a2c_c9ce6bb0","updated":"2023-05-24 10:16:15.000000000","message":"Done","commit_id":"77ec811858416c25033572d104b82613960926c7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"86d2ac9244e03a4d5b60d297f7b2f435901d3a88","unresolved":true,"context_lines":[{"line_number":550,"context_line":"        # Use the samples from the common API for the request"},{"line_number":551,"context_line":"        with self.common_api_sample(\u0027backups\u0027):"},{"line_number":552,"context_line":"            response \u003d self._do_post(\u0027backups\u0027,"},{"line_number":553,"context_line":"                                     \u0027backup-create-request\u0027,"},{"line_number":554,"context_line":"                                     subs)"},{"line_number":555,"context_line":"            return response"}],"source_content_type":"text/x-python","patch_set":6,"id":"b5b1b697_69edbb3b","line":553,"range":{"start_line":553,"start_character":38,"end_line":553,"end_character":44},"updated":"2022-11-04 14:51:50.000000000","message":"this should be \u0027backups\u0027","commit_id":"2c9feceaf47ba204a40590652573ee16524f7070"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"22299c60350bebb43f6dde8fb54d46bb73dfcd66","unresolved":false,"context_lines":[{"line_number":550,"context_line":"        # Use the samples from the common API for the request"},{"line_number":551,"context_line":"        with self.common_api_sample(\u0027backups\u0027):"},{"line_number":552,"context_line":"            response \u003d self._do_post(\u0027backups\u0027,"},{"line_number":553,"context_line":"                                     \u0027backup-create-request\u0027,"},{"line_number":554,"context_line":"                                     subs)"},{"line_number":555,"context_line":"            return response"}],"source_content_type":"text/x-python","patch_set":6,"id":"76e61e28_3e99dce9","line":553,"range":{"start_line":553,"start_character":38,"end_line":553,"end_character":44},"in_reply_to":"b5b1b697_69edbb3b","updated":"2023-05-24 10:16:15.000000000","message":"I think this should be singular to sync with the name of the files, otherwise it fails with `    FileNotFoundError: [Errno 2] No such file or directory: \u0027/home/zuul/src/opendev.org/openstack/cinder/cinder/tests/functional/api_sample_tests/samples/backups/backups-create-request.json.tpl\u0027`","commit_id":"2c9feceaf47ba204a40590652573ee16524f7070"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a22d84e0c081cf9d5f5a80ef81067b93ebced110","unresolved":true,"context_lines":[{"line_number":551,"context_line":"        with self.common_api_sample(\u0027backups\u0027):"},{"line_number":552,"context_line":"            response \u003d self._do_post(\u0027backups\u0027,"},{"line_number":553,"context_line":"                                     \u0027backups-create-request\u0027,"},{"line_number":554,"context_line":"                                     subs)"},{"line_number":555,"context_line":"            return response"}],"source_content_type":"text/x-python","patch_set":7,"id":"91ea2cb1_cc81625c","line":554,"range":{"start_line":554,"start_character":37,"end_line":554,"end_character":41},"updated":"2022-11-04 17:32:59.000000000","message":"this should contain the volume ID and we need to create a volume first for it","commit_id":"54618984ee9ab3ee624b1f8cb45fa99242cbf346"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"917b83540c53011052d1342c3d6f4d7dce522814","unresolved":false,"context_lines":[{"line_number":551,"context_line":"        with self.common_api_sample(\u0027backups\u0027):"},{"line_number":552,"context_line":"            response \u003d self._do_post(\u0027backups\u0027,"},{"line_number":553,"context_line":"                                     \u0027backups-create-request\u0027,"},{"line_number":554,"context_line":"                                     subs)"},{"line_number":555,"context_line":"            return response"}],"source_content_type":"text/x-python","patch_set":7,"id":"eb189ec2_7c27c0f8","line":554,"range":{"start_line":554,"start_character":37,"end_line":554,"end_character":41},"in_reply_to":"91ea2cb1_cc81625c","updated":"2022-11-04 17:35:03.000000000","message":"Done","commit_id":"54618984ee9ab3ee624b1f8cb45fa99242cbf346"}]}