)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"43feed34f5293714070e9c6ab7a47efb4fdb8499","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-10-21 23:12:15 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"cinder-backup: use the same backup backend host for incremental backups"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Bug: 1952805"},{"line_number":10,"context_line":"Change-Id: Id239b4150b1c8e9f4bf32f2ef867fdffbe84f96d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bda8b669_8a7fd8df","line":8,"updated":"2023-01-20 14:55:58.000000000","message":":-1: As important as the content of the change, is the content of the commit message describing it. Please describe why the change is being made.","commit_id":"ffffd61306e4143861953d8f38ff705403e3cc88"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"ac31b20004c6217e8eadd097aa63f801c2166ab1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-10-21 23:12:15 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"cinder-backup: use the same backup backend host for incremental backups"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Bug: 1952805"},{"line_number":10,"context_line":"Change-Id: Id239b4150b1c8e9f4bf32f2ef867fdffbe84f96d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"f1908c6a_e39b4246","line":8,"in_reply_to":"bda8b669_8a7fd8df","updated":"2023-01-24 15:33:51.000000000","message":"Done","commit_id":"ffffd61306e4143861953d8f38ff705403e3cc88"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6e28c9d5c7e510f77879a5bda00bf65cf1c92bc8","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"cinder-backup: use the same backup backend host for incremental backups"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Bug: 1952805"},{"line_number":10,"context_line":"Change-Id: Id239b4150b1c8e9f4bf32f2ef867fdffbe84f96d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7deb57f6_74f5d3bf","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":3},"updated":"2023-01-20 15:28:31.000000000","message":"nit: this could be \u0027Closes-bug:\u0027 (but the key thing is that there\u0027s a link to the filed bug here, so not a big deal)","commit_id":"ffffd61306e4143861953d8f38ff705403e3cc88"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"6780e8271bca68299d15515717445735d6d7044e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"cinder-backup: use the same backup backend host for incremental backups"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Bug: 1952805"},{"line_number":10,"context_line":"Change-Id: Id239b4150b1c8e9f4bf32f2ef867fdffbe84f96d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a5fcebc_937c7bf2","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":3},"in_reply_to":"7deb57f6_74f5d3bf","updated":"2023-01-23 19:30:54.000000000","message":"Done","commit_id":"ffffd61306e4143861953d8f38ff705403e3cc88"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34588,"name":"DataCore Software","email":"cinder-ci@datacore.com","username":"Arun"},"change_message_id":"900d4a204a660e42fec77e0733601eb63939b3e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a6fa73dc_e5d59975","updated":"2022-10-18 04:22:26.000000000","message":"run-Datacore CI","commit_id":"13a35655f11bd8254618a67388e46ba9c049e153"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"762a3543f664f0e5a13f9c9e0d5d195cca23a0b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"08cef1cd_0892b24d","updated":"2022-10-21 13:37:49.000000000","message":"can you try not using the \"backup_driver\" configuration option here please?","commit_id":"8f65cd82d7ec9275fe0b4c53e45e963d48687ee9"},{"author":{"_account_id":34588,"name":"DataCore Software","email":"cinder-ci@datacore.com","username":"Arun"},"change_message_id":"f7a4805877198b4351bab909850bb8740c575aa8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dbc7170f_c1228d17","updated":"2022-10-20 08:14:44.000000000","message":"run-DataCore CI","commit_id":"8f65cd82d7ec9275fe0b4c53e45e963d48687ee9"},{"author":{"_account_id":22248,"name":"HPE AlletraMP iSCSI CI","email":"hp.cinder.blr.ci@groups.ext.hpe.com","username":"hp-storage-blr-ci","tags":["SERVICE_USER"]},"change_message_id":"fd55e8774c58f4013b06473bfbcb39e0ed7ed83e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4acf8dd0_3ce7a9ee","updated":"2022-10-20 09:39:13.000000000","message":"run-Nimble Storage Alletra 6k CI","commit_id":"8f65cd82d7ec9275fe0b4c53e45e963d48687ee9"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"68fee983ee78cb3adba82eba607acc036d3b4033","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"235c2b93_47f07dca","updated":"2022-11-07 19:55:36.000000000","message":"*bump*","commit_id":"ffffd61306e4143861953d8f38ff705403e3cc88"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"fc8938e6399a77ab4c270af4c94a90a4634b53cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"320d63df_3968a49f","updated":"2022-12-02 18:49:43.000000000","message":"...anyone here with +2?","commit_id":"ffffd61306e4143861953d8f38ff705403e3cc88"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"43feed34f5293714070e9c6ab7a47efb4fdb8499","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c761aeb2_120539ca","updated":"2023-01-20 14:55:58.000000000","message":":-1: This looks like a big bug, que need a release note","commit_id":"ffffd61306e4143861953d8f38ff705403e3cc88"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"cd963e51bf26a1b8f562abc144d412840773d49b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"42d7dab3_d2c2088d","updated":"2023-01-19 17:00:24.000000000","message":"All looks okay to me.\n","commit_id":"ffffd61306e4143861953d8f38ff705403e3cc88"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6e28c9d5c7e510f77879a5bda00bf65cf1c92bc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"30efb049_517385eb","updated":"2023-01-20 15:28:31.000000000","message":"Code and tests look good.  Agree with Sofia that we should have a release note, something like:\n\n  `Bug #1952805 \u003chttps://bugs.launchpad.net/cinder/+bug/1952805\u003e`_: Fixed issue\n  where incremental backups would fail with the Posix backend due to the backup\n  not being deterministically scheduled to the node containing the parent backup.\n  \nIf you haven\u0027t done a release note before, easiest thing is to go to the releasenotes/notes directory and copy one of the files there (e.g., bug-1671220-4d521be71d0b8aa4.yaml) and edit it with your content.","commit_id":"ffffd61306e4143861953d8f38ff705403e3cc88"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"898287badd008e3a1c01db20a8f2a0c360f56503","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"47ddc242_0faf69f2","updated":"2023-01-20 15:29:23.000000000","message":"I\u0027m +2 on this except for the release note.  Ping us in IRC when you revise the patch, and it should be a pretty quick approval.  Thanks!","commit_id":"ffffd61306e4143861953d8f38ff705403e3cc88"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"505f1e9d2dcbe5adad8ee7e74456baa3355631f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"999b4bce_27225684","updated":"2022-11-09 17:46:05.000000000","message":"LGTM","commit_id":"ffffd61306e4143861953d8f38ff705403e3cc88"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"093a5aacf6e369b301ea1b0a9a07d315d0a9526b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ef9ce5c6_76731fe5","updated":"2023-01-10 15:59:33.000000000","message":"Looks good to me - thank you!","commit_id":"ffffd61306e4143861953d8f38ff705403e3cc88"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"54304ae965ab80759d14284bdf2fc69bcb4038b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b3299c76_98ba26ee","updated":"2022-10-28 14:05:22.000000000","message":"The reward for reviewing my last patch is getting added as a reviewer to this one :)","commit_id":"ffffd61306e4143861953d8f38ff705403e3cc88"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"1b4c93ecc05f0a807039dfba32e27edac08885a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5dba184b_1dcf1b24","updated":"2022-10-23 09:44:05.000000000","message":"looks good, thanks!","commit_id":"ffffd61306e4143861953d8f38ff705403e3cc88"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"cbba6e3bda410f99c3d0be111d7863ca8fada75d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6a3e3934_f5e6ddbb","updated":"2022-10-22 23:27:46.000000000","message":"recheck","commit_id":"ffffd61306e4143861953d8f38ff705403e3cc88"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5fc229b9bc29f51979b2ee2954d4a427cf60168f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"37730cd6_796d2ad7","updated":"2023-01-24 15:33:37.000000000","message":"LGTM.  Thanks for adding the release note.","commit_id":"73c0d73aba1855edb774d69ae940a1b53dc975e0"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"e952986eea601f13b39bcc9cf2afccb2cf8d0ae7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4e8198cd_ef8946d5","updated":"2023-01-23 21:50:43.000000000","message":"Looks good to me - thank you!","commit_id":"73c0d73aba1855edb774d69ae940a1b53dc975e0"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"0faf8ead66411387e860064b378bad5c9f1e9368","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f1baf558_ecfbdbe7","updated":"2023-01-27 14:27:27.000000000","message":"Thanks for updating! the code looks good to me!","commit_id":"73c0d73aba1855edb774d69ae940a1b53dc975e0"}],"cinder/backup/api.py":[{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"762a3543f664f0e5a13f9c9e0d5d195cca23a0b1","unresolved":true,"context_lines":[{"line_number":317,"context_line":"        if latest_backup:"},{"line_number":318,"context_line":"            parent \u003d latest_backup"},{"line_number":319,"context_line":"            parent_id \u003d latest_backup.id"},{"line_number":320,"context_line":"            if \u0027posix\u0027 in CONF.backup_driver:"},{"line_number":321,"context_line":"                # The posix driver needs to schedule incremental backups"},{"line_number":322,"context_line":"                #  on the same host as the last backup, otherwise there\u0027s"},{"line_number":323,"context_line":"                #  nothing to base the incremental backup on."}],"source_content_type":"text/x-python","patch_set":3,"id":"ebf32886_8f9119b7","line":320,"updated":"2022-10-21 13:37:49.000000000","message":"you probably don\u0027t need CONF.backup_driver here and above, the driver name is set in latest_backup.service field.","commit_id":"8f65cd82d7ec9275fe0b4c53e45e963d48687ee9"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"cbba6e3bda410f99c3d0be111d7863ca8fada75d","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        if latest_backup:"},{"line_number":318,"context_line":"            parent \u003d latest_backup"},{"line_number":319,"context_line":"            parent_id \u003d latest_backup.id"},{"line_number":320,"context_line":"            if \u0027posix\u0027 in CONF.backup_driver:"},{"line_number":321,"context_line":"                # The posix driver needs to schedule incremental backups"},{"line_number":322,"context_line":"                #  on the same host as the last backup, otherwise there\u0027s"},{"line_number":323,"context_line":"                #  nothing to base the incremental backup on."}],"source_content_type":"text/x-python","patch_set":3,"id":"c6bff986_637a0a62","line":320,"in_reply_to":"3f34524b_f1890ee0","updated":"2022-10-22 23:27:46.000000000","message":"Done","commit_id":"8f65cd82d7ec9275fe0b4c53e45e963d48687ee9"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"4aa4b731186523d188161d24d2a6d871b2c99da9","unresolved":true,"context_lines":[{"line_number":317,"context_line":"        if latest_backup:"},{"line_number":318,"context_line":"            parent \u003d latest_backup"},{"line_number":319,"context_line":"            parent_id \u003d latest_backup.id"},{"line_number":320,"context_line":"            if \u0027posix\u0027 in CONF.backup_driver:"},{"line_number":321,"context_line":"                # The posix driver needs to schedule incremental backups"},{"line_number":322,"context_line":"                #  on the same host as the last backup, otherwise there\u0027s"},{"line_number":323,"context_line":"                #  nothing to base the incremental backup on."}],"source_content_type":"text/x-python","patch_set":3,"id":"3f34524b_f1890ee0","line":320,"in_reply_to":"de4bd23f_84302651","updated":"2022-10-21 14:54:51.000000000","message":"I\u0027ve removed -1 since it\u0027s not appropriate feedback, I only suggest alternative :) . Thanks for the bugfix!","commit_id":"8f65cd82d7ec9275fe0b4c53e45e963d48687ee9"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"df6598d3a9307e1b0f5341dbcadb361658b1cbec","unresolved":true,"context_lines":[{"line_number":317,"context_line":"        if latest_backup:"},{"line_number":318,"context_line":"            parent \u003d latest_backup"},{"line_number":319,"context_line":"            parent_id \u003d latest_backup.id"},{"line_number":320,"context_line":"            if \u0027posix\u0027 in CONF.backup_driver:"},{"line_number":321,"context_line":"                # The posix driver needs to schedule incremental backups"},{"line_number":322,"context_line":"                #  on the same host as the last backup, otherwise there\u0027s"},{"line_number":323,"context_line":"                #  nothing to base the incremental backup on."}],"source_content_type":"text/x-python","patch_set":3,"id":"de4bd23f_84302651","line":320,"in_reply_to":"ebf32886_8f9119b7","updated":"2022-10-21 14:25:35.000000000","message":"Oh? That would be so much better!  I will try.","commit_id":"8f65cd82d7ec9275fe0b4c53e45e963d48687ee9"}]}