)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"70e4bda56509bb0c8b43fadf7c8fbf3c46904710","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dd63da52_86b79242","updated":"2022-11-09 15:26:00.000000000","message":"Agree with Sofia that a unit test would be good.  Hopefully there\u0027s an existing test that can easily be adapted.","commit_id":"c157021b61781532131a932d8d4741917f41cc38"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"a790846be49a7f7995c9757354f439a1bfa8db42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"22d66250_996c71dd","updated":"2022-11-09 11:52:08.000000000","message":"Thanks for working on this!\n:-1: unittest","commit_id":"c157021b61781532131a932d8d4741917f41cc38"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"167ed9481737e6c94ae30bc3809043dfad70f2f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1c70f492_258c108e","updated":"2022-11-16 12:12:59.000000000","message":"Looks good to me. I think it is wise to update the volume status if it was not found.","commit_id":"813df9b99f23bdc54787a0c918e47f9d61df3232"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5996555d6ed338932c9c3b7c20ee2bc2b433fb0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bbdd1945_b4e6ee07","updated":"2022-11-16 03:05:40.000000000","message":"Thanks for adding the test.  Code and release note LGTM.","commit_id":"813df9b99f23bdc54787a0c918e47f9d61df3232"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"156875f17f402b24077997cdec2914892079f823","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"be85e655_d5bf3b27","updated":"2022-11-10 11:44:11.000000000","message":"Updated per your comments.","commit_id":"813df9b99f23bdc54787a0c918e47f9d61df3232"}],"cinder/backup/manager.py":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"a790846be49a7f7995c9757354f439a1bfa8db42","unresolved":true,"context_lines":[{"line_number":424,"context_line":"                    except exception.VolumeNotFound:"},{"line_number":425,"context_line":"                        # If the volume was deleted we cannot update it\u0027s"},{"line_number":426,"context_line":"                        # status but we still want to set the backup to error."},{"line_number":427,"context_line":"                        pass"},{"line_number":428,"context_line":"                volume_utils.update_backup_error(backup, str(err))"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    def _start_backup(self, context, backup, volume):"}],"source_content_type":"text/x-python","patch_set":1,"id":"07770b15_e2b0bfb6","line":427,"range":{"start_line":427,"start_character":24,"end_line":427,"end_character":28},"updated":"2022-11-09 11:52:08.000000000","message":":nit: As far as I understand, we are raising a VolumeNotFound error. I\u0027m still reviewing this but I think we should show the user a more helpful message.","commit_id":"c157021b61781532131a932d8d4741917f41cc38"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"70e4bda56509bb0c8b43fadf7c8fbf3c46904710","unresolved":true,"context_lines":[{"line_number":424,"context_line":"                    except exception.VolumeNotFound:"},{"line_number":425,"context_line":"                        # If the volume was deleted we cannot update it\u0027s"},{"line_number":426,"context_line":"                        # status but we still want to set the backup to error."},{"line_number":427,"context_line":"                        pass"},{"line_number":428,"context_line":"                volume_utils.update_backup_error(backup, str(err))"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    def _start_backup(self, context, backup, volume):"}],"source_content_type":"text/x-python","patch_set":1,"id":"75e09309_77795db9","line":427,"range":{"start_line":427,"start_character":24,"end_line":427,"end_character":28},"in_reply_to":"07770b15_e2b0bfb6","updated":"2022-11-09 15:26:00.000000000","message":"I think we\u0027re probably OK here, because this is happening in the context of line 414, so we\u0027ll re-raise whatever exception happened in lines 400-412, which is what we really want to report.\n\nMy nit is that \"it\u0027s\" should be \"its\" in line 425.","commit_id":"c157021b61781532131a932d8d4741917f41cc38"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"8e3715a7b748e23192aa6595161489e57b510b66","unresolved":false,"context_lines":[{"line_number":424,"context_line":"                    except exception.VolumeNotFound:"},{"line_number":425,"context_line":"                        # If the volume was deleted we cannot update it\u0027s"},{"line_number":426,"context_line":"                        # status but we still want to set the backup to error."},{"line_number":427,"context_line":"                        pass"},{"line_number":428,"context_line":"                volume_utils.update_backup_error(backup, str(err))"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    def _start_backup(self, context, backup, volume):"}],"source_content_type":"text/x-python","patch_set":1,"id":"05e9214a_254e2b10","line":427,"range":{"start_line":427,"start_character":24,"end_line":427,"end_character":28},"in_reply_to":"75e09309_77795db9","updated":"2022-11-10 11:44:34.000000000","message":"Done","commit_id":"c157021b61781532131a932d8d4741917f41cc38"}]}