)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"722430b91acb445c88b4bc1952068115bbdd27c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9b8cc369_3617f2a1","updated":"2022-12-16 10:35:45.000000000","message":"\u003e Patch Set 2:\n\u003e \n\u003e Build succeeded.\n\u003e * Infinidat-FC http://openstack-ci-logs.aws.infinidat.com/#logs/refs-changes-87-864287-2/FC/ : SUCCESS in 1h 8m 45s\n\u003e * Infinidat-iSCSI http://openstack-ci-logs.aws.infinidat.com/#logs/refs-changes-87-864287-2/iSCSI/ : SUCCESS in 1h 45m 59s\n\u003e For more information about Infinidat CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/INFINIDAT_CI\n\ntest_volume_migrate_attached passed ","commit_id":"2c0cde10780bef11db3d3a115fd7d449dc5b9f8f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8cd39233c89eef3296c3b126d3f7b1da0c079632","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"79f81ded_56aa4078","updated":"2023-01-28 19:22:57.000000000","message":"Code and tests look good.  Coverage report shows complete unit test coverage for this change!  Third-party CI is green, so LGTM.","commit_id":"7d442e5b5bf990d54385dfb43fe6de5ac5625b7f"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"9d89084d19f404446f55ada07acd63982526afb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d116d073_8c8d17cd","updated":"2023-01-12 17:40:00.000000000","message":"LGTM","commit_id":"7d442e5b5bf990d54385dfb43fe6de5ac5625b7f"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"194b7cf9fe14f7c2fcc5676f5536c75fe91d7991","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5693b32b_e3b4f4f8","updated":"2022-12-20 14:11:19.000000000","message":"Looks good. Comments addressed and passing CIs","commit_id":"7d442e5b5bf990d54385dfb43fe6de5ac5625b7f"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"d83144323107489d45ba4369e1158605025ef818","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0ab83a01_10606f07","updated":"2022-12-19 15:57:35.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican","commit_id":"7d442e5b5bf990d54385dfb43fe6de5ac5625b7f"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"04aaaf8229ce4432718329459aca7909a8c20e40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5e26f307_c7dfaca6","updated":"2023-01-21 10:30:47.000000000","message":"recheck tempest-integrated-storage-ubuntu-focal","commit_id":"7d442e5b5bf990d54385dfb43fe6de5ac5625b7f"}],"cinder/volume/drivers/infinidat.py":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"0ab24a5e0d5abb6a0f1e9e633a6bb0c5c4153ee1","unresolved":true,"context_lines":[{"line_number":1366,"context_line":"            LOG.error(\u0027Destination pool %s not found on host %s\u0027, pool, host)"},{"line_number":1367,"context_line":"            return False, None"},{"line_number":1368,"context_line":"        infinidat_volume.move_pool(infinidat_pool)"},{"line_number":1369,"context_line":"        LOG.debug(\u0027Migrated volume %s to pool %s\u0027, volume.name, pool)"},{"line_number":1370,"context_line":"        return True, None"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f24ec55_f1327498","line":1369,"updated":"2022-12-16 15:11:06.000000000","message":":nit: Would be nice to add a msg to the user:\n\n```\nLOG.info(\"Migrate volume completed successfully.\", resource\u003dvolume)\n```","commit_id":"2c0cde10780bef11db3d3a115fd7d449dc5b9f8f"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"bb48c3ee936391737247e52fd8a5a69354c8e49d","unresolved":false,"context_lines":[{"line_number":1366,"context_line":"            LOG.error(\u0027Destination pool %s not found on host %s\u0027, pool, host)"},{"line_number":1367,"context_line":"            return False, None"},{"line_number":1368,"context_line":"        infinidat_volume.move_pool(infinidat_pool)"},{"line_number":1369,"context_line":"        LOG.debug(\u0027Migrated volume %s to pool %s\u0027, volume.name, pool)"},{"line_number":1370,"context_line":"        return True, None"}],"source_content_type":"text/x-python","patch_set":2,"id":"01a90edc_8d437840","line":1369,"in_reply_to":"9f24ec55_f1327498","updated":"2022-12-19 13:48:18.000000000","message":"Hello Sofia,\n\nThank you very much for the review!\n\n\u003e\u003e Would be nice to add a msg to the user:\nDone - please review patch set #3.\n\nThank you!","commit_id":"2c0cde10780bef11db3d3a115fd7d449dc5b9f8f"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"e9aec1fd0382cc4ef6abb04fdc2959072d81fa94","unresolved":true,"context_lines":[{"line_number":1352,"context_line":"            LOG.error(\u0027Invalid location info %s found for host %s: %s\u0027,"},{"line_number":1353,"context_line":"                      location, host, error)"},{"line_number":1354,"context_line":"            return False, None"},{"line_number":1355,"context_line":"        if driver !\u003d self.__class__.__name__:"},{"line_number":1356,"context_line":"            LOG.debug(\u0027Unsupported storage driver %s found for host %s\u0027,"},{"line_number":1357,"context_line":"                      driver, host)"},{"line_number":1358,"context_line":"            return False, None"}],"source_content_type":"text/x-python","patch_set":3,"id":"f2921fd1_086b0d58","line":1355,"updated":"2022-12-23 19:55:52.000000000","message":"Not enough to veto but this clearly conflates implementation details with externally visible nomenclature.","commit_id":"7d442e5b5bf990d54385dfb43fe6de5ac5625b7f"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"68f98595d7da252541f35243413734f68f01c90b","unresolved":false,"context_lines":[{"line_number":1352,"context_line":"            LOG.error(\u0027Invalid location info %s found for host %s: %s\u0027,"},{"line_number":1353,"context_line":"                      location, host, error)"},{"line_number":1354,"context_line":"            return False, None"},{"line_number":1355,"context_line":"        if driver !\u003d self.__class__.__name__:"},{"line_number":1356,"context_line":"            LOG.debug(\u0027Unsupported storage driver %s found for host %s\u0027,"},{"line_number":1357,"context_line":"                      driver, host)"},{"line_number":1358,"context_line":"            return False, None"}],"source_content_type":"text/x-python","patch_set":3,"id":"441d8bcc_6d6613a9","line":1355,"in_reply_to":"f2921fd1_086b0d58","updated":"2022-12-23 20:10:02.000000000","message":"Hello Pete,\n\nThank you very much for the review!\n\n\u003e\u003e Not enough to veto but this clearly conflates implementation \n\u003e\u003e details with externally visible nomenclature.\n\nWe added this check to make sure that the migration happens between backends of the same driver. And many other drivers use the same way.\n\nThank you!","commit_id":"7d442e5b5bf990d54385dfb43fe6de5ac5625b7f"}]}