)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"88e74e0c4299de47e2fe2bc9d80a87931c5c8ac7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3760e622_0c6cb383","updated":"2022-11-16 18:57:51.000000000","message":"I agree with your answer to Walt, but I have a different issue noted inline.","commit_id":"836a43ecf7927f71c9cf441e9834cb842494fcfa"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"8ba870a06310fd5293f68d04dc5ed4fccd0445da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"66e58919_d58a94fe","updated":"2022-11-15 22:11:33.000000000","message":"What \u0027legacy clouds\u0027 are you talking about?  Are they older versions of openstack and therefore cinder/keystone?\n\nI don\u0027t like the idea of not ensuring uuids for project ids here for cinder.\n","commit_id":"836a43ecf7927f71c9cf441e9834cb842494fcfa"},{"author":{"_account_id":28801,"name":"Cisco Cinder CI","email":"cisco-cinder-ci@cisco.com","username":"cisco-cinder-ci"},"change_message_id":"c66fb714cb10a6566464e46d1cb6e134908d7a87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"20daa5de_b697f13f","updated":"2022-11-16 11:35:22.000000000","message":"cisco-cinder-ci","commit_id":"836a43ecf7927f71c9cf441e9834cb842494fcfa"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"a7d2b109f38c99f843519a8582198397a80e29bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"507b708d_bc1398da","in_reply_to":"66e58919_d58a94fe","updated":"2022-11-15 23:29:28.000000000","message":"Older versions of Keystone assigned project_id \u003d\u003d project_name. So any cloud that still has users from that era will encounter this case, regardless of what version they\u0027re currently running.\n\nI agree that the validation /looks/ right, but even cinder doesn\u0027t do this consistently, only for this one exact API.","commit_id":"836a43ecf7927f71c9cf441e9834cb842494fcfa"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4b5bba80deb7a6d0f1f92e7751b83a148fcad9e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c064f8d0_120ac171","updated":"2022-11-18 14:11:29.000000000","message":"Brian\u0027s comment was addressed but I\u0027d like to see more reviews before voting +2","commit_id":"17a3c67aeebf1946f153c72d0d5660a80ed2ff68"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"3d087abb662dab621aa8d739f727b90de1dd8c73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ec4c2ba2_ea770501","updated":"2022-12-16 14:55:37.000000000","message":"I have no issue with this","commit_id":"17a3c67aeebf1946f153c72d0d5660a80ed2ff68"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"33cb16cdb596155540499ef59b7e40b53a3a7f2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3c18d458_679cb2f8","updated":"2023-01-20 14:33:18.000000000","message":"I think make sense for a consistency point of view.","commit_id":"17a3c67aeebf1946f153c72d0d5660a80ed2ff68"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"b21d3b4be276ccc1c2b7cefdc0c3157a7c5ef07d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"601ceb52_8d4014e4","updated":"2022-11-24 05:00:43.000000000","message":"Looks good","commit_id":"17a3c67aeebf1946f153c72d0d5660a80ed2ff68"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6f881ae73caa4d841301f103d24ce974c647d5dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b33f1807_1ea1017d","updated":"2022-12-21 15:09:53.000000000","message":"The motivation and code change LGTM.  This change has tempest coverage [0] that would make an API request that would hit the validation code using the changed schema, so in addition to looking correct, I think it actually works.\n\n[0] https://opendev.org/openstack/tempest/src/branch/master/tempest/api/volume/admin/test_volume_type_access.py","commit_id":"17a3c67aeebf1946f153c72d0d5660a80ed2ff68"}],"cinder/api/schemas/volume_type_access.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"88e74e0c4299de47e2fe2bc9d80a87931c5c8ac7","unresolved":true,"context_lines":[{"line_number":27,"context_line":"        \u0027addProjectAccess\u0027: {"},{"line_number":28,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":29,"context_line":"            \u0027properties\u0027: {"},{"line_number":30,"context_line":"                \u0027project\u0027: parameter_types.nullable_string,"},{"line_number":31,"context_line":"            },"},{"line_number":32,"context_line":"            \u0027required\u0027: [\u0027project\u0027],"},{"line_number":33,"context_line":"            \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":1,"id":"cce2ad6c_d843a776","line":30,"range":{"start_line":30,"start_character":27,"end_line":30,"end_character":59},"updated":"2022-11-16 18:57:51.000000000","message":"Why a nullable string?  The parameter_types.uuid wasn\u0027t nullable, plus it doesn\u0027t seem to make sense to have a nullable property be a required property, or to make an add/remove call if you\u0027re not actually going to pass a project_id.  I think this should be:\n\n  {\u0027type\u0027: \u0027string\u0027, \u0027minLength\u0027: 1, \u0027maxLength\u0027: 255}","commit_id":"836a43ecf7927f71c9cf441e9834cb842494fcfa"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"2c81a3efea4f0ec64d36a3ea6ee50ee999d61cbd","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        \u0027addProjectAccess\u0027: {"},{"line_number":28,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":29,"context_line":"            \u0027properties\u0027: {"},{"line_number":30,"context_line":"                \u0027project\u0027: parameter_types.nullable_string,"},{"line_number":31,"context_line":"            },"},{"line_number":32,"context_line":"            \u0027required\u0027: [\u0027project\u0027],"},{"line_number":33,"context_line":"            \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":1,"id":"34addd94_dce86a4b","line":30,"range":{"start_line":30,"start_character":27,"end_line":30,"end_character":59},"in_reply_to":"cce2ad6c_d843a776","updated":"2022-11-16 23:46:15.000000000","message":"You\u0027re right, it shouldn\u0027t be nullable! I will use your type suggestion.","commit_id":"836a43ecf7927f71c9cf441e9834cb842494fcfa"}]}