)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b898aeac3f45b21f0f457e33db21ad76c6a3aa6e","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set backup status to error on VolumeNotFound"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating a backup and it fails we will try"},{"line_number":10,"context_line":"to update the status on the volume but if it does"},{"line_number":11,"context_line":"not exist we will instead fail on that and the"},{"line_number":12,"context_line":"backup will be stuck in creating status which means"},{"line_number":13,"context_line":"cloud admin need to help resetting the status."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1bd32de9_0615f915","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":9},"updated":"2022-12-06 17:51:10.000000000","message":"I\u0027m not sure how this case occurs. based on the error trace in the bug report, the original volume should be in backing-up state and the temporary volume in in-use state so it\u0027s not possible to delete the volume.\n\nhttps://github.com/openstack/cinder/blob/24a783408879abd479e77dd88b43bf2a1be048fe/cinder/backup/chunkeddriver.py#L659","commit_id":"4ed83f6ad155eea9f1c9682a479145f2001994c2"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"e670de33feb5acb61d6fd3985c04c20366012b02","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set backup status to error on VolumeNotFound"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating a backup and it fails we will try"},{"line_number":10,"context_line":"to update the status on the volume but if it does"},{"line_number":11,"context_line":"not exist we will instead fail on that and the"},{"line_number":12,"context_line":"backup will be stuck in creating status which means"},{"line_number":13,"context_line":"cloud admin need to help resetting the status."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9bf69160_ec240137","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":9},"in_reply_to":"1bd32de9_0615f915","updated":"2022-12-07 10:47:50.000000000","message":"So looking into this in more detail, we are running Xena on 19.0 and in the temporarily volumes fix was actually backported, which I missed, and included in the 19.1.1 release [1]\n\nWhat we have is a Heat stack that contains a volume and it also provisions a cron trigger in Mistral for executing a backup on the volume, if the stack is deleted and the cron trigger has triggered a backup that is currently running it will fail because the stack has deleted the volume, but the backup never enters an error state and is in creating forever (note that this is 19.0 without below[1] patch).\n\nI actually think that it\u0027s actually possible this is solved by upgrading to 19.1.1 which would probably cause the Heat stack to enter a DELETE_FAILED state if the volume cannot be deleted when a backup has been started, I have not verified that this is solved by upgrading so I cannot confirm that\u0027s the case.\n\nIt could plausibly also be a race condition at play here but I haven\u0027t verified that to be the case. \n\n[1] https://bugs.launchpad.net/cinder/+bug/1970768","commit_id":"4ed83f6ad155eea9f1c9682a479145f2001994c2"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d2fde651af397277c92788e9348fc1b920b251a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"61e1eab3_1af9f0fd","updated":"2023-07-10 14:09:57.000000000","message":"Since this is merged in master (2023.1 Antelope), my comments should be applied in master. this should be good to go. Clean backport, included in 2023.1, looks good for zed.","commit_id":"4ed83f6ad155eea9f1c9682a479145f2001994c2"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"5220ac05c02a47e00cb61aa66193623b6ef39829","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d858feb6_d6d7962a","updated":"2022-12-07 12:09:21.000000000","message":"The change looks good to me and can be backported.","commit_id":"4ed83f6ad155eea9f1c9682a479145f2001994c2"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b9ec9bd2e92b071ad87e69a19e221036e0449e67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"189bea07_1f7b57d0","updated":"2022-11-23 14:43:18.000000000","message":"This is a small, isolated change that addresses an operator pain point.  I think it\u0027s good to backport.","commit_id":"4ed83f6ad155eea9f1c9682a479145f2001994c2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b898aeac3f45b21f0f457e33db21ad76c6a3aa6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a500a358_51e0fad5","updated":"2022-12-06 17:51:10.000000000","message":"one question inline, I know this is a backport but trying to understand the case better and see if we are missing any important detail.","commit_id":"4ed83f6ad155eea9f1c9682a479145f2001994c2"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"15591fde06354dbd1b5e1e5c8d4f6766fa5bf5a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"585a9dbb_3a2283a8","updated":"2023-07-19 14:57:29.000000000","message":"recheck","commit_id":"4ed83f6ad155eea9f1c9682a479145f2001994c2"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"ef56202ca86ca695a196f90f43123b39a432cee3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7c660147_141267b9","updated":"2023-07-11 11:16:30.000000000","message":"recheck","commit_id":"4ed83f6ad155eea9f1c9682a479145f2001994c2"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"5c5d1b5391de8034104124bb83b33ff209e8a619","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"039aa0c3_e0a38342","updated":"2022-11-18 09:28:54.000000000","message":"recheck transient issue?","commit_id":"4ed83f6ad155eea9f1c9682a479145f2001994c2"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"903c215e457f93b380550ad6bc07d990eea5ba2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a775165d_74e7cb82","updated":"2023-08-11 14:03:20.000000000","message":"Renewing the +W after a rebase.","commit_id":"5f357504ff95ea4731ba309f285b937066d8908a"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"64a7c3e7d4487170c253ee54271f3d4e37ddde39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ef79409e_d26b96e9","updated":"2023-08-14 12:28:41.000000000","message":"recheck gate timeout","commit_id":"5f357504ff95ea4731ba309f285b937066d8908a"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"f29521fcd882fb695371a44b7b42f3afa70cf695","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7ed8cbf7_c962b6da","updated":"2023-08-11 09:00:33.000000000","message":"recheck try gate again","commit_id":"5f357504ff95ea4731ba309f285b937066d8908a"}],"cinder/tests/unit/backup/test_backup.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b898aeac3f45b21f0f457e33db21ad76c6a3aa6e","unresolved":true,"context_lines":[{"line_number":690,"context_line":"                          backup)"},{"line_number":691,"context_line":"        backup.refresh()"},{"line_number":692,"context_line":"        self.assertEqual(fields.BackupStatus.ERROR, backup.status)"},{"line_number":693,"context_line":"        self.assertTrue(start_backup_mock.called)"},{"line_number":694,"context_line":"        self.assertTrue(vol_up_mock.called)"},{"line_number":695,"context_line":""},{"line_number":696,"context_line":"    @mock.patch(\u0027cinder.backup.manager.BackupManager._start_backup\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"b7732992_ef70d963","line":693,"range":{"start_line":693,"start_character":8,"end_line":693,"end_character":49},"updated":"2022-12-06 17:51:10.000000000","message":"could be written as start_backup_mock.assert_called_once()","commit_id":"4ed83f6ad155eea9f1c9682a479145f2001994c2"}],"releasenotes/notes/backup-volumenotfound-set-to-error-fa47b3631093a702.yaml":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b898aeac3f45b21f0f457e33db21ad76c6a3aa6e","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1996049 \u003chttps://bugs.launchpad.net/cinder/+bug/1996049\u003e`_: Fixed bug"},{"line_number":5,"context_line":"    where backup was not set to error on failure when volume did not exist."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1abd2830_83809237","line":5,"range":{"start_line":5,"start_character":41,"end_line":5,"end_character":48},"updated":"2022-12-06 17:51:10.000000000","message":"would\u0027ve been better to specify the operation that fails i.e. create backup\n\nFixed bug where backup was not set to error on backup creation failure when volume did not exist.","commit_id":"4ed83f6ad155eea9f1c9682a479145f2001994c2"}]}