)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"2af7379590684e474de266022b7a576b744f9cd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"305b50f5_1370d706","updated":"2022-11-25 19:54:30.000000000","message":"Thank you! Very useful feature:\n```\nNov 25 19:51:40 devstack-aio-fc-master cinder-volume[626131]: INFO cinder.image.image_utils [None req-5abb829f-b3b2-442c-b32d-c823ae1a63c3 admin None] Image upload 28.00 MB at 13.11 MB/s\n```\n\nLooks good to me and passing CI.\n\n","commit_id":"e87f3f2e005ce23b6d83e65e8742127ab9c3a669"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"f6877e8f2f99557953674bdc660abfb8b59f5ad3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9b90f5bb_88a4b07b","updated":"2022-12-16 14:45:38.000000000","message":"Very helpful. LGTM  +1","commit_id":"e87f3f2e005ce23b6d83e65e8742127ab9c3a669"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"c8eb7d8a40d3f8e3492ab5c06aa4b0840c9e4576","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"450fc4d1_91aaf67d","updated":"2023-04-21 14:50:29.000000000","message":"Agree with Jon","commit_id":"912d18d9103e4243a1a8702bbe246aad4b1fb616"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"ba8095a539887849417064934b7a05f057faf449","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"05e47ac6_8afd2731","updated":"2023-02-15 19:04:32.000000000","message":"Code is correct; release note, lp, or tests don\u0027t seem relevant in this\ncase.  LGTM.\n","commit_id":"912d18d9103e4243a1a8702bbe246aad4b1fb616"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"0f9b2c57fea526fcdc91a06478e96233f27d0f49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"67ecd02e_34a420ce","updated":"2023-02-14 12:06:56.000000000","message":"LGTM. I would like to confirm one point.\nEven if `with open()` is failed or image file size is very small, the variable `duration` is set alway non-zero, isn\u0027t it?","commit_id":"912d18d9103e4243a1a8702bbe246aad4b1fb616"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"69b670cbb172397dfd8b97d6360d24a60e3a1756","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"83efe124_bba9420d","updated":"2023-02-14 12:29:03.000000000","message":"Looks good to me and passing CI - thank you!","commit_id":"912d18d9103e4243a1a8702bbe246aad4b1fb616"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"9f9910a7909fa865ef54fa8a05d2bdf86055ecdb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dc84b67c_fc8061b9","updated":"2023-05-15 08:56:53.000000000","message":"Looks good to me - thank you!","commit_id":"f5ca7d818fda8a01b80cc32692f3354dd79ed3f5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c8fea415020f82fc94514ee4a16f7adeae78f56e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"aab62017_ec5386c1","updated":"2024-12-19 16:17:12.000000000","message":"Looks useful \u0026 correct.","commit_id":"f5ca7d818fda8a01b80cc32692f3354dd79ed3f5"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"0319d2988a57cf4471da66e15b63b802b7d2fed7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a9a56920_11309ea1","updated":"2024-12-30 15:31:50.000000000","message":"Excellent idea. LGTM","commit_id":"0b586c790d0b17e6d897f449c171e208ccbc0485"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"1e85c4cae88c45bc87763fc976327447b5bc651d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ee07dc52_daae64bb","updated":"2025-01-02 09:40:12.000000000","message":"This is very useful. Thanks.","commit_id":"0b586c790d0b17e6d897f449c171e208ccbc0485"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"8075012cfac6fa3897eae795c88bcffed7d6ca4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5d5813a1_e9a9985a","updated":"2025-01-02 09:40:42.000000000","message":"recheck cinder-plugin-ceph-tempest","commit_id":"0b586c790d0b17e6d897f449c171e208ccbc0485"}],"cinder/image/image_utils.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d64803848fcb373af983932e235d4f27ac7c3d24","unresolved":true,"context_lines":[{"line_number":830,"context_line":"                      run_as_root\u003drun_as_root)"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"def _log_upload_details(start_time, image_file):"},{"line_number":834,"context_line":"    duration \u003d timeutils.delta_seconds(start_time, timeutils.utcnow())"},{"line_number":835,"context_line":"    fsz_mb \u003d os.stat(image_file.name).st_size / units.Mi"},{"line_number":836,"context_line":"    mbps \u003d (fsz_mb / duration)"}],"source_content_type":"text/x-python","patch_set":2,"id":"617a61bf_17295e45","line":833,"updated":"2023-04-21 15:17:11.000000000","message":"No need to pass the file object, just pass in the name from the caller.","commit_id":"912d18d9103e4243a1a8702bbe246aad4b1fb616"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"724bc820127235b12b31a6a4baee0cf80b7113ad","unresolved":false,"context_lines":[{"line_number":830,"context_line":"                      run_as_root\u003drun_as_root)"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"def _log_upload_details(start_time, image_file):"},{"line_number":834,"context_line":"    duration \u003d timeutils.delta_seconds(start_time, timeutils.utcnow())"},{"line_number":835,"context_line":"    fsz_mb \u003d os.stat(image_file.name).st_size / units.Mi"},{"line_number":836,"context_line":"    mbps \u003d (fsz_mb / duration)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ecfb4ea9_ac1565e4","line":833,"in_reply_to":"617a61bf_17295e45","updated":"2023-05-08 15:11:33.000000000","message":"Done","commit_id":"912d18d9103e4243a1a8702bbe246aad4b1fb616"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d64803848fcb373af983932e235d4f27ac7c3d24","unresolved":true,"context_lines":[{"line_number":854,"context_line":"    check_image_conversion_disable("},{"line_number":855,"context_line":"        image_meta[\u0027disk_format\u0027], volume_format, image_id, upload\u003dTrue)"},{"line_number":856,"context_line":""},{"line_number":857,"context_line":"    start_time \u003d timeutils.utcnow()"},{"line_number":858,"context_line":"    if image_meta.get(\u0027container_format\u0027) !\u003d \u0027compressed\u0027:"},{"line_number":859,"context_line":"        if (image_meta[\u0027disk_format\u0027] \u003d\u003d volume_format):"},{"line_number":860,"context_line":"            LOG.debug(\"%s was %s, no need to convert to %s\","}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2d1cb5_62dd8ea9","line":857,"range":{"start_line":857,"start_character":0,"end_line":857,"end_character":7},"updated":"2023-04-21 15:17:11.000000000","message":"Should move this down to line 860","commit_id":"912d18d9103e4243a1a8702bbe246aad4b1fb616"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"724bc820127235b12b31a6a4baee0cf80b7113ad","unresolved":false,"context_lines":[{"line_number":854,"context_line":"    check_image_conversion_disable("},{"line_number":855,"context_line":"        image_meta[\u0027disk_format\u0027], volume_format, image_id, upload\u003dTrue)"},{"line_number":856,"context_line":""},{"line_number":857,"context_line":"    start_time \u003d timeutils.utcnow()"},{"line_number":858,"context_line":"    if image_meta.get(\u0027container_format\u0027) !\u003d \u0027compressed\u0027:"},{"line_number":859,"context_line":"        if (image_meta[\u0027disk_format\u0027] \u003d\u003d volume_format):"},{"line_number":860,"context_line":"            LOG.debug(\"%s was %s, no need to convert to %s\","}],"source_content_type":"text/x-python","patch_set":2,"id":"ee5d202f_992893f4","line":857,"range":{"start_line":857,"start_character":0,"end_line":857,"end_character":7},"in_reply_to":"5a2d1cb5_62dd8ea9","updated":"2023-05-08 15:11:33.000000000","message":"Done","commit_id":"912d18d9103e4243a1a8702bbe246aad4b1fb616"}]}
