)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9abd8fbeadde9f29d9b4c7892e531ed6b8b25d9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a50b191d_16cc8d6e","updated":"2023-01-20 15:54:38.000000000","message":"Adding a warning log for not providing cert file with ssl enabled. looks logical to me.","commit_id":"d2b516d378e5c54c4ab6b32d24c86114bcc5c619"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fcb52c12400dfa2467847ef2354ecb0f10148290","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c418ee35_1aec7b99","updated":"2023-01-20 15:56:31.000000000","message":"LGTM.","commit_id":"d2b516d378e5c54c4ab6b32d24c86114bcc5c619"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"4b761f71b82fa49603428500bbf770548e8f2d0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"43f73dda_3cad5935","updated":"2022-12-16 14:14:29.000000000","message":"looks reasonable.","commit_id":"d2b516d378e5c54c4ab6b32d24c86114bcc5c619"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"9fe1efb5e5fb999e2515ea23b11eb2523fc5a3b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"44576c10_b7c9b30c","updated":"2023-01-23 15:56:14.000000000","message":"recheck\n\ncinder-grenade-mn-sub-volbak security groups tempest error","commit_id":"d2b516d378e5c54c4ab6b32d24c86114bcc5c619"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"027c44fedccf4896eb3af71a5159189415d6c3e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"af27469d_a78433fc","updated":"2023-01-20 15:54:20.000000000","message":"we definitely need this check","commit_id":"d2b516d378e5c54c4ab6b32d24c86114bcc5c619"}],"cinder/backup/drivers/s3.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fcb52c12400dfa2467847ef2354ecb0f10148290","unresolved":true,"context_lines":[{"line_number":200,"context_line":"        if CONF.backup_s3_verify_ssl:"},{"line_number":201,"context_line":"            conn_args[\u0027verify\u0027] \u003d CONF.backup_s3_ca_cert_file"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"            if CONF.backup_s3_ca_cert_file is None:"},{"line_number":204,"context_line":"                LOG.warning(\u0027backup_s3_verify_ssl is True but no cert file \u0027"},{"line_number":205,"context_line":"                            \u0027was provided\u0027)"},{"line_number":206,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fbf41ea3_ade1bbac","line":203,"range":{"start_line":203,"start_character":46,"end_line":203,"end_character":50},"updated":"2023-01-20 15:56:31.000000000","message":"None is the default value [0], and since they are 2 separate options, it could be easy for an operator to misconfigure.  Definitely a good idea to log a warning.\n\n[0] https://opendev.org/openstack/cinder/src/commit/344ec1da64b6c69f7915ef92a7f341393485a777/cinder/backup/drivers/s3.py#L128","commit_id":"d2b516d378e5c54c4ab6b32d24c86114bcc5c619"}]}