)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"81186bdfdf0c7b83aa48c49f21025ad0ac5e8128","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Pure storage: Add support for IPv6 in pure_iscsi_cidr parameter."},{"line_number":10,"context_line":"Pure storage: Add parameter pure_iscsi_cidr_list to support a list of networks."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: Ib001e2b4d1347754c2b46730bc10d86e8cdab7ad"},{"line_number":13,"context_line":"Change-Id: Ib04e49dac9fdabd81809ca389553ce3638bb9bbf"},{"line_number":14,"context_line":"Closes-Bug: 1910143"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"4825f237_ed1c6ffb","line":11,"updated":"2023-01-03 11:26:51.000000000","message":"We should mention the conflict of cinder/volume/drivers/pure.py file here","commit_id":"34c4130e53ab7fd850c19b66ac85587155030a23"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"16e630fc0b0dae49e920136a5e0064b45bf86d52","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Pure storage: Add support for IPv6 in pure_iscsi_cidr parameter."},{"line_number":10,"context_line":"Pure storage: Add parameter pure_iscsi_cidr_list to support a list of networks."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: Ib001e2b4d1347754c2b46730bc10d86e8cdab7ad"},{"line_number":13,"context_line":"Change-Id: Ib04e49dac9fdabd81809ca389553ce3638bb9bbf"},{"line_number":14,"context_line":"Closes-Bug: 1910143"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dfb7a794_c39c556e","line":11,"in_reply_to":"4825f237_ed1c6ffb","updated":"2023-01-03 13:08:09.000000000","message":"Done","commit_id":"34c4130e53ab7fd850c19b66ac85587155030a23"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"81186bdfdf0c7b83aa48c49f21025ad0ac5e8128","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"360e6906_b78154ca","updated":"2023-01-03 11:26:51.000000000","message":"Few comments inline","commit_id":"34c4130e53ab7fd850c19b66ac85587155030a23"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1c0d45ed31d7047491bda4ddf777eb70b606d91e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"607efe9f_054711a7","updated":"2023-01-04 04:57:12.000000000","message":"Thanks Manoj for addressing my comments. merged in Ussuri, looks good for train.","commit_id":"14c2db209b2f734d646c5ff4c798b456cdcaa911"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"21a010096d61e7d6206ed658d4b11c8c00d02015","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"cf3ef47d_9bb20d26","updated":"2023-01-04 10:19:09.000000000","message":"Thanks for updating, looks good to me","commit_id":"14c2db209b2f734d646c5ff4c798b456cdcaa911"}],"cinder/volume/drivers/pure.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"81186bdfdf0c7b83aa48c49f21025ad0ac5e8128","unresolved":true,"context_lines":[{"line_number":23,"context_line":"import math"},{"line_number":24,"context_line":"import platform"},{"line_number":25,"context_line":"import re"},{"line_number":26,"context_line":"import six"},{"line_number":27,"context_line":"import sys"},{"line_number":28,"context_line":"import uuid"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5ebe26a4_b30da5e9","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":10},"updated":"2023-01-03 11:26:51.000000000","message":"six is not part of builtin python modules and is a third party import so should be put in the second group","commit_id":"34c4130e53ab7fd850c19b66ac85587155030a23"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"16e630fc0b0dae49e920136a5e0064b45bf86d52","unresolved":false,"context_lines":[{"line_number":23,"context_line":"import math"},{"line_number":24,"context_line":"import platform"},{"line_number":25,"context_line":"import re"},{"line_number":26,"context_line":"import six"},{"line_number":27,"context_line":"import sys"},{"line_number":28,"context_line":"import uuid"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"de86720c_5837bcd3","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":10},"in_reply_to":"5ebe26a4_b30da5e9","updated":"2023-01-03 13:08:09.000000000","message":"Done","commit_id":"34c4130e53ab7fd850c19b66ac85587155030a23"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"81186bdfdf0c7b83aa48c49f21025ad0ac5e8128","unresolved":true,"context_lines":[{"line_number":2429,"context_line":"            check_cidrs \u003d [ipaddress.ip_network(item) for item in cidrs]"},{"line_number":2430,"context_line":"        else:"},{"line_number":2431,"context_line":"            check_cidrs \u003d \\"},{"line_number":2432,"context_line":"                [ipaddress.ip_network(item.decode(\u0027utf8\u0027)) for item in cidrs]"},{"line_number":2433,"context_line":""},{"line_number":2434,"context_line":"        target_luns \u003d []"},{"line_number":2435,"context_line":"        target_iqns \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"493e5251_8b41a25f","line":2432,"range":{"start_line":2432,"start_character":38,"end_line":2432,"end_character":57},"updated":"2023-01-03 11:26:51.000000000","message":"are we sure we are receiving a byte array here? this will error out if we get a normal string\n\n    \u003e\u003e\u003e \u0027abcd\u0027.decode(\u0027utf8\u0027)\n    Traceback (most recent call last):\n      File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n    AttributeError: \u0027str\u0027 object has no attribute \u0027decode\u0027. Did you mean: \u0027encode\u0027?\n\nif we aren\u0027t sure, we can add an if statement in the list comprehension\n\n    check_cidrs \u003d [ipaddress.ip_network(item.decode(\u0027utf8\u0027)) if \n                   isinstance(item, bytes) else ipaddress.ip_network(item)\n                   for item in cidrs]","commit_id":"34c4130e53ab7fd850c19b66ac85587155030a23"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"16e630fc0b0dae49e920136a5e0064b45bf86d52","unresolved":false,"context_lines":[{"line_number":2429,"context_line":"            check_cidrs \u003d [ipaddress.ip_network(item) for item in cidrs]"},{"line_number":2430,"context_line":"        else:"},{"line_number":2431,"context_line":"            check_cidrs \u003d \\"},{"line_number":2432,"context_line":"                [ipaddress.ip_network(item.decode(\u0027utf8\u0027)) for item in cidrs]"},{"line_number":2433,"context_line":""},{"line_number":2434,"context_line":"        target_luns \u003d []"},{"line_number":2435,"context_line":"        target_iqns \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"f07a6200_1907230d","line":2432,"range":{"start_line":2432,"start_character":38,"end_line":2432,"end_character":57},"in_reply_to":"493e5251_8b41a25f","updated":"2023-01-03 13:08:09.000000000","message":"The error you got is in py 3.x\n\nin py2, \u0027str\u0027 is bytes by default and it has to be converted to unicode object.\n\nPython 2.7.18 (default, Mar  4 2022, 00:00:00) \n[GCC 11.2.1 20220127 (Red Hat 11.2.1-9)] on linux2\n\u003e\u003e\u003e print(type(\u0027abcd\u0027))\n\u003ctype \u0027str\u0027\u003e\n\u003e\u003e\u003e \u0027abcd\u0027.decode(\u0027utf8\u0027)\nu\u0027abcd\u0027\n\u003e\u003e\u003e","commit_id":"34c4130e53ab7fd850c19b66ac85587155030a23"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1c0d45ed31d7047491bda4ddf777eb70b606d91e","unresolved":false,"context_lines":[{"line_number":2429,"context_line":"            check_cidrs \u003d [ipaddress.ip_network(item) for item in cidrs]"},{"line_number":2430,"context_line":"        else:"},{"line_number":2431,"context_line":"            check_cidrs \u003d \\"},{"line_number":2432,"context_line":"                [ipaddress.ip_network(item.decode(\u0027utf8\u0027)) for item in cidrs]"},{"line_number":2433,"context_line":""},{"line_number":2434,"context_line":"        target_luns \u003d []"},{"line_number":2435,"context_line":"        target_iqns \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"b15633e5_8072919f","line":2432,"range":{"start_line":2432,"start_character":38,"end_line":2432,"end_character":57},"in_reply_to":"f07a6200_1907230d","updated":"2023-01-04 04:57:12.000000000","message":"Ack","commit_id":"34c4130e53ab7fd850c19b66ac85587155030a23"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"81186bdfdf0c7b83aa48c49f21025ad0ac5e8128","unresolved":true,"context_lines":[{"line_number":2449,"context_line":"                if sys.version_info[0] \u003e\u003d 3:"},{"line_number":2450,"context_line":"                    check_ip \u003d ipaddress.ip_address(portal)"},{"line_number":2451,"context_line":"                else:"},{"line_number":2452,"context_line":"                    check_ip \u003d ipaddress.ip_address(portal.decode(\u0027utf8\u0027))"},{"line_number":2453,"context_line":"                for check_cidr in check_cidrs:"},{"line_number":2454,"context_line":"                    if check_ip in check_cidr:"},{"line_number":2455,"context_line":"                        target_luns.append(target[\"connection\"][\"lun\"])"}],"source_content_type":"text/x-python","patch_set":5,"id":"5bd9fa7c_5b732f5a","line":2452,"range":{"start_line":2452,"start_character":67,"end_line":2452,"end_character":71},"updated":"2023-01-03 11:26:51.000000000","message":"i see utf8 is also an accepted encoding and an alias of utf-8","commit_id":"34c4130e53ab7fd850c19b66ac85587155030a23"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1c0d45ed31d7047491bda4ddf777eb70b606d91e","unresolved":false,"context_lines":[{"line_number":2449,"context_line":"                if sys.version_info[0] \u003e\u003d 3:"},{"line_number":2450,"context_line":"                    check_ip \u003d ipaddress.ip_address(portal)"},{"line_number":2451,"context_line":"                else:"},{"line_number":2452,"context_line":"                    check_ip \u003d ipaddress.ip_address(portal.decode(\u0027utf8\u0027))"},{"line_number":2453,"context_line":"                for check_cidr in check_cidrs:"},{"line_number":2454,"context_line":"                    if check_ip in check_cidr:"},{"line_number":2455,"context_line":"                        target_luns.append(target[\"connection\"][\"lun\"])"}],"source_content_type":"text/x-python","patch_set":5,"id":"9bfb87a0_0cae60a7","line":2452,"range":{"start_line":2452,"start_character":67,"end_line":2452,"end_character":71},"in_reply_to":"57ea6c8e_5b222f9c","updated":"2023-01-04 04:57:12.000000000","message":"Done","commit_id":"34c4130e53ab7fd850c19b66ac85587155030a23"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"16e630fc0b0dae49e920136a5e0064b45bf86d52","unresolved":true,"context_lines":[{"line_number":2449,"context_line":"                if sys.version_info[0] \u003e\u003d 3:"},{"line_number":2450,"context_line":"                    check_ip \u003d ipaddress.ip_address(portal)"},{"line_number":2451,"context_line":"                else:"},{"line_number":2452,"context_line":"                    check_ip \u003d ipaddress.ip_address(portal.decode(\u0027utf8\u0027))"},{"line_number":2453,"context_line":"                for check_cidr in check_cidrs:"},{"line_number":2454,"context_line":"                    if check_ip in check_cidr:"},{"line_number":2455,"context_line":"                        target_luns.append(target[\"connection\"][\"lun\"])"}],"source_content_type":"text/x-python","patch_set":5,"id":"57ea6c8e_5b222f9c","line":2452,"range":{"start_line":2452,"start_character":67,"end_line":2452,"end_character":71},"in_reply_to":"5bd9fa7c_5b732f5a","updated":"2023-01-03 13:08:09.000000000","message":"Ack","commit_id":"34c4130e53ab7fd850c19b66ac85587155030a23"}]}