)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"5cbf7ed92a6a7f107d7d9ecec3ec89adedb96f6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"389d5e1f_d562fdfb","updated":"2022-12-15 08:00:24.000000000","message":"You should add the bug reference id in the commit message","commit_id":"13e975cf371574eb31f91609793aa73502f46174"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"ac063f51d27d8e5b1c2e2253cb2805dbe6cbcdbc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1045d9c9_a5456689","updated":"2022-12-17 02:05:34.000000000","message":"- You should add a title line on the top of the commit message, \nlike \"PowerStore Driver: fixed volume chaching\" or something.\n\n- Each line of the commit message should be wrapped at 72 characters.\n\nPlease check:\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"d7242d0d3f083e240d6cc9632f176e7644dea85e"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"47f43ab2d91f9fbcae8f2e97893d13e69b725876","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4951d673_48e8119d","updated":"2022-12-19 10:26:19.000000000","message":"Name of the patch should be more precise. \nShould be something like Dell PowerStore Driver - Fixed volume caching","commit_id":"d7242d0d3f083e240d6cc9632f176e7644dea85e"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"6a2567d298ec7ad121fbc0375a6aa15c3a554a0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3ceca18d_5abd72a1","updated":"2023-01-05 22:24:35.000000000","message":"recheck","commit_id":"87a0d182855c3ac44c1c6b872a4a078a820c2e35"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"1767e7adb11afb644dc7df4b21f834935ae90cc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"68f8ffe7_cc0d76c5","updated":"2023-01-06 18:09:20.000000000","message":"recheck","commit_id":"87a0d182855c3ac44c1c6b872a4a078a820c2e35"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"42a242d9aed33efe131243440ad05149e59a244b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a3709a0e_20b4c52e","updated":"2023-01-06 13:37:23.000000000","message":"recheck","commit_id":"87a0d182855c3ac44c1c6b872a4a078a820c2e35"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3134310b4163f68a81d162a42adaa5ef7213bea1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c3bb4db8_6f48a423","updated":"2023-01-11 18:52:40.000000000","message":"Congratulations on your first patch!\n\nCode looks OK.  I think it would be worth adding a test; the code isn\u0027t checked by any existing test: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_098/867753/4/check/cinder-code-coverage/098ca6d/cover/d_e486f56c76328f87_client_py.html#t279\n\nYou could use the test in https://review.opendev.org/c/openstack/cinder/+/806605 to get some ideas.","commit_id":"d817cb658286134dfea4edfe8d92c4065ad976fb"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"45d10331969ab42784b91653fa6558f854caa208","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"18f4bfab_a8cd71f7","updated":"2023-01-09 07:44:15.000000000","message":"recheck tox4 issues","commit_id":"d817cb658286134dfea4edfe8d92c4065ad976fb"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"6f8287db4af258c55da85639f2fc0510b2c45011","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7dd82782_3e68f858","updated":"2023-01-09 15:14:23.000000000","message":"recheck tox4 issues","commit_id":"d817cb658286134dfea4edfe8d92c4065ad976fb"},{"author":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"change_message_id":"4c27015ad0e70f6ff662fdbc8239368eba4974c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1cb9810b_4b57ceb5","in_reply_to":"c3bb4db8_6f48a423","updated":"2023-01-13 15:06:16.000000000","message":"Thanks for the example! Done!","commit_id":"d817cb658286134dfea4edfe8d92c4065ad976fb"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"a85ee948390a1646eade1a6af95bd76c78f1c933","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"87606c3f_b91a9d25","updated":"2023-01-24 18:26:53.000000000","message":"Looks good to me - thank you!","commit_id":"f47be72adc41e731502463e0f43102f84ef9903d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8b94c09c8683561cacea4727a4ac47fccbc0c910","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"135b5fab_c9209e81","updated":"2023-01-17 16:33:43.000000000","message":"Thanks for adding the test.  LGTM!","commit_id":"f47be72adc41e731502463e0f43102f84ef9903d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"20b63bf961136420e5fa97a874919b8ae7bc850d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a29d5899_16625ba0","updated":"2023-02-01 11:42:14.000000000","message":"code and tests looks good. this will work based on our image cache handling[1] code.\n\nPowerstore CI is passing (apart from the NFS one but that should be fine with this type of change).\n\n[1] https://github.com/openstack/cinder/blob/9f7a3c8768e100320d4b59dcd44a308a3f9f7f97/cinder/volume/flows/manager/create_volume.py#L849-L856\n","commit_id":"f47be72adc41e731502463e0f43102f84ef9903d"},{"author":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"change_message_id":"1302de15765ecfa1c15b1556f2ea68df434ec0c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"48c0e8c7_c832bf0c","updated":"2023-01-13 18:18:14.000000000","message":"recheck tox4 issues","commit_id":"f47be72adc41e731502463e0f43102f84ef9903d"}],"cinder/volume/drivers/dell_emc/powerstore/adapter.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8b94c09c8683561cacea4727a4ac47fccbc0c910","unresolved":true,"context_lines":[{"line_number":350,"context_line":"                      \"entity_id\": source.id,"},{"line_number":351,"context_line":"                      \"pp_name\": pp_name,"},{"line_number":352,"context_line":"                  })"},{"line_number":353,"context_line":"        volume_provider_id \u003d self.client.clone_volume_or_snapshot("},{"line_number":354,"context_line":"            volume.name,"},{"line_number":355,"context_line":"            source_provider_id,"},{"line_number":356,"context_line":"            pp_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fef7ffa_58d2d0dd","line":353,"range":{"start_line":353,"start_character":29,"end_line":353,"end_character":65},"updated":"2023-01-17 16:33:43.000000000","message":"I was confused at first by the unit test, but here is where the call is made that tests your patch.","commit_id":"f47be72adc41e731502463e0f43102f84ef9903d"},{"author":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"change_message_id":"595e909567b4d94247e2c64451b504576e52efc5","unresolved":false,"context_lines":[{"line_number":350,"context_line":"                      \"entity_id\": source.id,"},{"line_number":351,"context_line":"                      \"pp_name\": pp_name,"},{"line_number":352,"context_line":"                  })"},{"line_number":353,"context_line":"        volume_provider_id \u003d self.client.clone_volume_or_snapshot("},{"line_number":354,"context_line":"            volume.name,"},{"line_number":355,"context_line":"            source_provider_id,"},{"line_number":356,"context_line":"            pp_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"c3066550_4f90d5ad","line":353,"range":{"start_line":353,"start_character":29,"end_line":353,"end_character":65},"in_reply_to":"5fef7ffa_58d2d0dd","updated":"2023-01-26 16:33:24.000000000","message":"Done","commit_id":"f47be72adc41e731502463e0f43102f84ef9903d"}],"releasenotes/notes/bug-1962824-ff0cac0d35021f84.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3134310b4163f68a81d162a42adaa5ef7213bea1","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/1962824\u003e`_: Fixed Cinder"},{"line_number":6,"context_line":"    volume caching mechanism for the driver. Now the driver"},{"line_number":7,"context_line":"    correctly raises ``exception.SnapshotLimitReached`` when maximum"},{"line_number":8,"context_line":"    snapshots are created for a given volume and a volume cache is"},{"line_number":9,"context_line":"    invalidated to allow a new row of fast volume clones."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"6a41cbaa_519b91c2","line":8,"range":{"start_line":8,"start_character":49,"end_line":8,"end_character":50},"updated":"2023-01-11 18:52:40.000000000","message":"nit: the","commit_id":"d817cb658286134dfea4edfe8d92c4065ad976fb"},{"author":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"change_message_id":"4c27015ad0e70f6ff662fdbc8239368eba4974c1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/1962824\u003e`_: Fixed Cinder"},{"line_number":6,"context_line":"    volume caching mechanism for the driver. Now the driver"},{"line_number":7,"context_line":"    correctly raises ``exception.SnapshotLimitReached`` when maximum"},{"line_number":8,"context_line":"    snapshots are created for a given volume and a volume cache is"},{"line_number":9,"context_line":"    invalidated to allow a new row of fast volume clones."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3ea88af0_713f76ec","line":8,"range":{"start_line":8,"start_character":49,"end_line":8,"end_character":50},"in_reply_to":"6a41cbaa_519b91c2","updated":"2023-01-13 15:06:16.000000000","message":"Done","commit_id":"d817cb658286134dfea4edfe8d92c4065ad976fb"}]}
