)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b712821bdb81cc468936e6d6ae0d34c9ae519118","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"94448b86_f263023b","updated":"2023-02-08 17:03:09.000000000","message":"Code and tests look good to me!","commit_id":"78f8a7bbe6eb12cd2b249eec456a00642181d8af"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"808d2fb01490f65b3bfdef80a0c41c5c52e78307","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ea7d4eb2_f3ac9fa9","updated":"2023-01-03 12:59:06.000000000","message":"LGTM - thank you!","commit_id":"78f8a7bbe6eb12cd2b249eec456a00642181d8af"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2cbb79d3c06dea8bb26a122d34144781cab96e81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5355f01e_633934c4","updated":"2023-02-09 07:21:36.000000000","message":"Thanks Brian and Sofia for the review.","commit_id":"78f8a7bbe6eb12cd2b249eec456a00642181d8af"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"cf35d9423c2ee2d9e96997e78ea951fef8926007","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e4f1d8fd_319a6d08","updated":"2023-02-07 14:58:28.000000000","message":"The code looks good to me. Agree to add a new test with a descriptive name than extending the current test_extend_volume_manager_in_use_successful test","commit_id":"78f8a7bbe6eb12cd2b249eec456a00642181d8af"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2cbb79d3c06dea8bb26a122d34144781cab96e81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"089ad9e0_a1c67bc5","in_reply_to":"e4f1d8fd_319a6d08","updated":"2023-02-09 07:21:36.000000000","message":"The _test_extend_volume_manager_successful is not a test but a helper method which is used by multiple tests and same approach is used here. We do have a new test that creates an attachment record with instance_uuid\u003dNULL (glance cinder store case) and assert that nova external events is not called.\nIf we create a new test, we would have to introduce a bunch of redundant code that would be similar to the current helper method.","commit_id":"78f8a7bbe6eb12cd2b249eec456a00642181d8af"}],"releasenotes/notes/handle-external-events-in-extend-6ae53b822baf0004.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b712821bdb81cc468936e6d6ae0d34c9ae519118","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    `bug #2000724"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2000724\u003e`_:"},{"line_number":6,"context_line":"    Handled the case when glance is calling online extend"},{"line_number":7,"context_line":"    and externals events were being sent to nova."},{"line_number":8,"context_line":"    Now Cinder will only send external events when the volume,"},{"line_number":9,"context_line":"    to be extended, is attached to a nova instance."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3915a308_9904d990","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":17},"updated":"2023-02-08 17:03:09.000000000","message":"nit: external","commit_id":"78f8a7bbe6eb12cd2b249eec456a00642181d8af"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2cbb79d3c06dea8bb26a122d34144781cab96e81","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    `bug #2000724"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2000724\u003e`_:"},{"line_number":6,"context_line":"    Handled the case when glance is calling online extend"},{"line_number":7,"context_line":"    and externals events were being sent to nova."},{"line_number":8,"context_line":"    Now Cinder will only send external events when the volume,"},{"line_number":9,"context_line":"    to be extended, is attached to a nova instance."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5272bba0_e0436919","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":17},"in_reply_to":"3915a308_9904d990","updated":"2023-02-09 07:21:36.000000000","message":"corrected here https://review.opendev.org/c/openstack/cinder/+/873224","commit_id":"78f8a7bbe6eb12cd2b249eec456a00642181d8af"}]}