)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"07d10fc3365bbce9afd78470b4d1ce4c1f63de5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c0923631_b0965055","updated":"2023-01-11 15:34:12.000000000","message":"recheck","commit_id":"667eec931e5f25fe1f30eaee8ced91abc607b473"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"65da7888b07a31a95dd94aada3181467349f7a62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c0017f61_522ec879","updated":"2023-01-12 08:55:28.000000000","message":"run-IBM Storage CI","commit_id":"a7a0ab431c8c5947d5f1eb9dd1e1c5ea1fdd01d3"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"a653d3a8ea0a32a6cf653795821a0d2b5a045c0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"156bd27b_be732523","updated":"2023-01-17 13:59:41.000000000","message":"Code looks good.","commit_id":"dc54aae2b50fd20db083d116b4823e7e955a3efa"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"68c898fa184c90bea884da64a9737ccc9514c2b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"09e6b6e4_d5535488","updated":"2023-01-19 07:15:47.000000000","message":"LGTM. Zuul and CI passed.","commit_id":"dc54aae2b50fd20db083d116b4823e7e955a3efa"},{"author":{"_account_id":35679,"name":"Sathyanarayana R","display_name":"Sathyanarayana R","email":"sathyanarayana.r@ibm.com","username":"sathya-narayana"},"change_message_id":"05504a4c17ecf2e0e43ba5ae93c981322ac9c257","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"27279293_7c988937","updated":"2023-01-19 08:40:52.000000000","message":"Looks good to me","commit_id":"dc54aae2b50fd20db083d116b4823e7e955a3efa"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"b363bf272c178e3a17e1d45fca986a3d98bc8bf8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"036d1f88_684ab290","updated":"2023-01-19 09:02:27.000000000","message":"Looks good to me - thank you!","commit_id":"dc54aae2b50fd20db083d116b4823e7e955a3efa"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"aa5f35177e454b5bab46b294448045aad03417e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e37aac9f_1068c742","updated":"2023-01-18 14:03:11.000000000","message":"There is one nit in the release note that should be fixed if there is another upload.  Looks ok otherwise.","commit_id":"dc54aae2b50fd20db083d116b4823e7e955a3efa"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"7acf1751f7909b460dd05b59af21b5f365b87c20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"62070e54_4f7497d1","updated":"2023-01-17 08:12:39.000000000","message":"recheck","commit_id":"dc54aae2b50fd20db083d116b4823e7e955a3efa"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"461d2eae1f159c9d81a4592637f928184f1c7cc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7fc4aad4_24032c5b","updated":"2023-01-16 12:29:04.000000000","message":"recheck","commit_id":"dc54aae2b50fd20db083d116b4823e7e955a3efa"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"0563abc22f181d2d0d970acf935afd571f6d8bcd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ac87c9f4_779ac27a","updated":"2023-01-16 16:43:03.000000000","message":"recheck","commit_id":"dc54aae2b50fd20db083d116b4823e7e955a3efa"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"4fd5719654b14dc83bdf9e5b591c1e52a26bdc9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cda75344_d01ee6b3","updated":"2023-01-16 09:17:25.000000000","message":"recheck","commit_id":"dc54aae2b50fd20db083d116b4823e7e955a3efa"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"b5a787275f1355b9648222845f01d708cdc35f89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e1d8b601_cb85d875","updated":"2023-01-16 08:16:07.000000000","message":"recheck","commit_id":"dc54aae2b50fd20db083d116b4823e7e955a3efa"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"d401ed58df78b3236985bda6ba5a413687578a2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"45fddc7f_ecace7ed","updated":"2023-01-17 10:49:32.000000000","message":"run-IBM Storage CI","commit_id":"dc54aae2b50fd20db083d116b4823e7e955a3efa"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"dafe1261544589e9aa61b8e2a9d51585988edadc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d575e26a_2b53dbd3","updated":"2023-01-17 14:42:30.000000000","message":"run-storpoolci","commit_id":"dc54aae2b50fd20db083d116b4823e7e955a3efa"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"33093ced6831402695b4ac2b38d3e5ce4fc49f62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ea6cdd59_f2649833","updated":"2023-01-25 15:52:24.000000000","message":"A question and a few minor issues noted inline.","commit_id":"c4ff285dd2f0fd0626aa49168dbe5d5895605151"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"457d6362c55d729d25d9c8033e4e843e27f3392a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9639bab8_42ba3f96","updated":"2023-01-25 13:35:19.000000000","message":"One question inline, and CI hasn\u0027t run on latest PS.","commit_id":"c4ff285dd2f0fd0626aa49168dbe5d5895605151"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"6eb55010a9483f2110f0d3a34fbf5677c170d017","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f61b0b77_b947f9a3","updated":"2023-01-24 10:02:45.000000000","message":"run-IBM Storage CI","commit_id":"c4ff285dd2f0fd0626aa49168dbe5d5895605151"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7fdc48b58d78c0d83714d7deae0a4dc0f03d7cda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ce481d02_1181266e","updated":"2023-02-13 06:55:02.000000000","message":"Overall looks good, one question inline regarding volumes_model_update list not being used anywhere.","commit_id":"5388d2ea3388877337c35f4be05e600c7422bed5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"23ede37bd435e371c5109020a7209c0354256e33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"21740675_519b5401","updated":"2023-02-14 07:57:25.000000000","message":"Since deadline is near and to get response on my query, changing my vote to -1","commit_id":"5388d2ea3388877337c35f4be05e600c7422bed5"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"6d69b8ab7e9a201a07b6ad8c2e50bc3b3202f58c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5f7af799_a246a816","updated":"2023-02-10 11:33:36.000000000","message":"run-IBM Storage CI","commit_id":"5388d2ea3388877337c35f4be05e600c7422bed5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"68bb0671893674ceb253a87fc237e7a9bbb49629","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"40c004c9_eafa41ae","updated":"2023-02-17 10:42:46.000000000","message":"CI passed, upgrading vote.","commit_id":"04650c7d605fc772bc2f22e9601c829a1e635dee"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c50c1be381a4a63d5dddb5d5d9be9304e63dbb4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"35bf8dff_89e6fe20","updated":"2023-02-16 13:52:27.000000000","message":"my comments are addressed, will wait for zuul and IBM CI to report.","commit_id":"04650c7d605fc772bc2f22e9601c829a1e635dee"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2a0b1476033818bcfe91d40f5cd9990f57882506","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"acd4d2e8_089a9a6b","updated":"2023-02-16 15:44:28.000000000","message":"recheck cinder-plugin-ceph-tempest timed out","commit_id":"04650c7d605fc772bc2f22e9601c829a1e635dee"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"65468af7bfc98429b81c252974ed8fe64dc9da20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9c5e2096_1b799360","updated":"2023-02-17 05:55:02.000000000","message":"run-IBM Storage CI","commit_id":"04650c7d605fc772bc2f22e9601c829a1e635dee"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"797d260edb71669150012d049f26e4c4a942a382","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"40c9a8e3_95bce0f9","updated":"2023-02-23 11:58:49.000000000","message":"IBM Storage CI","commit_id":"39931083520f8c6bb7e451438806caf9e0894997"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"012b10f118ed38111cc610ce9481ab1aa1938876","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7e5ba764_88857c78","updated":"2023-02-23 13:52:54.000000000","message":"Previously approved but rebased due to a merge conflict. Zuul and IBM Storage CI is passing, LGTM.","commit_id":"39931083520f8c6bb7e451438806caf9e0894997"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"1f4afa7e38ac44ad7cb5bd2290ebd9be5b35b0ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ec0cbcac_0cce7d52","updated":"2023-02-25 06:14:29.000000000","message":"recheck","commit_id":"39931083520f8c6bb7e451438806caf9e0894997"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"1e18eddedbe2c2e811b16ac7c1e3c896f857568f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a2e9cc53_0833a830","updated":"2023-02-24 15:47:56.000000000","message":"recheck  Appears that this hit the same POST_FAILURE twice.  Try one more time.","commit_id":"39931083520f8c6bb7e451438806caf9e0894997"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e738e4a2261acd4c6ebdd025fa2469cf72fa2c28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5ae12419_bcfe72ee","updated":"2023-02-25 08:13:15.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican failed because of DBConnectionError","commit_id":"39931083520f8c6bb7e451438806caf9e0894997"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0b4517b753ca4fe642688b73be585440d640fdfb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"08147d42_96342af9","updated":"2023-02-23 16:12:22.000000000","message":"recheck unrelated failures in tempest jobs","commit_id":"39931083520f8c6bb7e451438806caf9e0894997"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"53f880fc02060821ee6438db3acc04ae5cecd1c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4582712e_3e2bb745","updated":"2023-02-24 15:46:36.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"39931083520f8c6bb7e451438806caf9e0894997"}],"cinder/tests/unit/volume/drivers/ibm/test_storwize_svc.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"33093ced6831402695b4ac2b38d3e5ce4fc49f62","unresolved":true,"context_lines":[{"line_number":7467,"context_line":"        # Delete Volume Group"},{"line_number":7468,"context_line":"        model_update \u003d self.driver.delete_group(self.ctxt,"},{"line_number":7469,"context_line":"                                                source_volumegroup,"},{"line_number":7470,"context_line":"                                                [source_vol])"},{"line_number":7471,"context_line":"        self.assertEqual(fields.GroupStatus.DELETED,"},{"line_number":7472,"context_line":"                         model_update[0][\u0027status\u0027])"},{"line_number":7473,"context_line":"        for volume in model_update[1]:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ba7c60d_b0625275","line":7470,"updated":"2023-01-25 15:52:24.000000000","message":"OK, this is what\u0027s doing the --delete-volumes ... can you point me to a test that verifies that if you pass [] here, you assert that the volumes are NOT deleted?  (You probably have one, I just don\u0027t see it at a quick look through the file.)","commit_id":"c4ff285dd2f0fd0626aa49168dbe5d5895605151"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"24f803762433ccd24d79ec6cbb1c8ad29fda42f7","unresolved":false,"context_lines":[{"line_number":7467,"context_line":"        # Delete Volume Group"},{"line_number":7468,"context_line":"        model_update \u003d self.driver.delete_group(self.ctxt,"},{"line_number":7469,"context_line":"                                                source_volumegroup,"},{"line_number":7470,"context_line":"                                                [source_vol])"},{"line_number":7471,"context_line":"        self.assertEqual(fields.GroupStatus.DELETED,"},{"line_number":7472,"context_line":"                         model_update[0][\u0027status\u0027])"},{"line_number":7473,"context_line":"        for volume in model_update[1]:"}],"source_content_type":"text/x-python","patch_set":4,"id":"21d07f32_0a873dfd","line":7470,"in_reply_to":"7ba7c60d_b0625275","updated":"2023-02-10 07:36:41.000000000","message":"If it is an empty list, it indicates group is empty .","commit_id":"c4ff285dd2f0fd0626aa49168dbe5d5895605151"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"75ace96930b7cd759df2a6b2eab5f00f1b715f54","unresolved":true,"context_lines":[{"line_number":7418,"context_line":""},{"line_number":7419,"context_line":"    @mock.patch.object(storwize_svc_common.StorwizeHelpers,"},{"line_number":7420,"context_line":"                       \u0027get_system_info\u0027)"},{"line_number":7421,"context_line":"    def test_storwize_delete_volumegroup_with_delete_volumes(self,"},{"line_number":7422,"context_line":"                                                             get_system_info):"},{"line_number":7423,"context_line":"        \"\"\"Test volume group creation and deletion\"\"\""},{"line_number":7424,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"a9af37d2_ade5a4e5","line":7421,"range":{"start_line":7421,"start_character":8,"end_line":7421,"end_character":60},"updated":"2023-02-17 15:20:26.000000000","message":"there seems to be some issue with this test, it passed the first time but failed in a recent job run https://dc171be34dbe42d909d1-c8825dc5e793ff7436d7dbd356115c46.ssl.cf1.rackcdn.com/869704/6/gate/openstack-tox-py38/a96751f/testr_results.html","commit_id":"04650c7d605fc772bc2f22e9601c829a1e635dee"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"c84039772eadc58609617dfe7ddd284e25d5ec53","unresolved":false,"context_lines":[{"line_number":7418,"context_line":""},{"line_number":7419,"context_line":"    @mock.patch.object(storwize_svc_common.StorwizeHelpers,"},{"line_number":7420,"context_line":"                       \u0027get_system_info\u0027)"},{"line_number":7421,"context_line":"    def test_storwize_delete_volumegroup_with_delete_volumes(self,"},{"line_number":7422,"context_line":"                                                             get_system_info):"},{"line_number":7423,"context_line":"        \"\"\"Test volume group creation and deletion\"\"\""},{"line_number":7424,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"2388c32f_bba5e40b","line":7421,"range":{"start_line":7421,"start_character":8,"end_line":7421,"end_character":60},"in_reply_to":"a9af37d2_ade5a4e5","updated":"2023-02-23 09:32:51.000000000","message":"Done","commit_id":"04650c7d605fc772bc2f22e9601c829a1e635dee"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"457d6362c55d729d25d9c8033e4e843e27f3392a","unresolved":true,"context_lines":[{"line_number":6927,"context_line":"        model_update \u003d {\u0027status\u0027: fields.GroupStatus.DELETED}"},{"line_number":6928,"context_line":"        volumegroup_name \u003d self._get_volumegroup_name(group)"},{"line_number":6929,"context_line":"        volumes_model_update \u003d []"},{"line_number":6930,"context_line":"        if self._state[\u0027code_level\u0027] \u003c (7, 7, 0, 0):"},{"line_number":6931,"context_line":"            force_unmap \u003d False"},{"line_number":6932,"context_line":"        else:"},{"line_number":6933,"context_line":"            force_unmap \u003d True"},{"line_number":6934,"context_line":"        for volume in volumes:"},{"line_number":6935,"context_line":"            volume \u003d self._helpers.get_volume_name_from_metadata(volume)"},{"line_number":6936,"context_line":"            if self._active_backend_id:"}],"source_content_type":"text/x-python","patch_set":3,"id":"f3bef227_4498e14b","line":6933,"range":{"start_line":6930,"start_character":8,"end_line":6933,"end_character":30},"updated":"2023-01-25 13:35:19.000000000","message":"nit: could save 1 LOC here\n\n        force_unmap \u003d True\n        if self._state[\u0027code_level\u0027] \u003c (7, 7, 0, 0):\n            force_unmap \u003d False","commit_id":"dc54aae2b50fd20db083d116b4823e7e955a3efa"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"24f803762433ccd24d79ec6cbb1c8ad29fda42f7","unresolved":false,"context_lines":[{"line_number":6927,"context_line":"        model_update \u003d {\u0027status\u0027: fields.GroupStatus.DELETED}"},{"line_number":6928,"context_line":"        volumegroup_name \u003d self._get_volumegroup_name(group)"},{"line_number":6929,"context_line":"        volumes_model_update \u003d []"},{"line_number":6930,"context_line":"        if self._state[\u0027code_level\u0027] \u003c (7, 7, 0, 0):"},{"line_number":6931,"context_line":"            force_unmap \u003d False"},{"line_number":6932,"context_line":"        else:"},{"line_number":6933,"context_line":"            force_unmap \u003d True"},{"line_number":6934,"context_line":"        for volume in volumes:"},{"line_number":6935,"context_line":"            volume \u003d self._helpers.get_volume_name_from_metadata(volume)"},{"line_number":6936,"context_line":"            if self._active_backend_id:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bb9fa0ef_3137624b","line":6933,"range":{"start_line":6930,"start_character":8,"end_line":6933,"end_character":30},"in_reply_to":"f3bef227_4498e14b","updated":"2023-02-10 07:36:41.000000000","message":"Done","commit_id":"dc54aae2b50fd20db083d116b4823e7e955a3efa"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"457d6362c55d729d25d9c8033e4e843e27f3392a","unresolved":true,"context_lines":[{"line_number":6942,"context_line":"            else:"},{"line_number":6943,"context_line":"                try:"},{"line_number":6944,"context_line":"                    self._helpers.delete_vdisk("},{"line_number":6945,"context_line":"                        volume[\u0027name\u0027],"},{"line_number":6946,"context_line":"                        force_unmap\u003dforce_unmap,"},{"line_number":6947,"context_line":"                        force_delete\u003dTrue)"},{"line_number":6948,"context_line":"                    volumes_model_update.append({\u0027id\u0027: volume.id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"e5daff43_81536222","line":6945,"range":{"start_line":6945,"start_character":24,"end_line":6945,"end_character":38},"updated":"2023-01-25 13:35:19.000000000","message":"nit: volume.name\n\nthe dictionary like access is a compatibility thing but the recommendation is to use it as an object","commit_id":"dc54aae2b50fd20db083d116b4823e7e955a3efa"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"24f803762433ccd24d79ec6cbb1c8ad29fda42f7","unresolved":false,"context_lines":[{"line_number":6942,"context_line":"            else:"},{"line_number":6943,"context_line":"                try:"},{"line_number":6944,"context_line":"                    self._helpers.delete_vdisk("},{"line_number":6945,"context_line":"                        volume[\u0027name\u0027],"},{"line_number":6946,"context_line":"                        force_unmap\u003dforce_unmap,"},{"line_number":6947,"context_line":"                        force_delete\u003dTrue)"},{"line_number":6948,"context_line":"                    volumes_model_update.append({\u0027id\u0027: volume.id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"a33bbf12_43e58c07","line":6945,"range":{"start_line":6945,"start_character":24,"end_line":6945,"end_character":38},"in_reply_to":"e5daff43_81536222","updated":"2023-02-10 07:36:41.000000000","message":"Ack","commit_id":"dc54aae2b50fd20db083d116b4823e7e955a3efa"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"457d6362c55d729d25d9c8033e4e843e27f3392a","unresolved":true,"context_lines":[{"line_number":2920,"context_line":"    def get_volume_name_from_metadata(self, volume):"},{"line_number":2921,"context_line":"        \"\"\"Get Volume name from metadata if metadata exists\"\"\""},{"line_number":2922,"context_line":"        if volume.metadata:"},{"line_number":2923,"context_line":"            svc_volume_name \u003d volume.metadata.get(\"Volume Name\", None)"},{"line_number":2924,"context_line":"            if svc_volume_name:"},{"line_number":2925,"context_line":"                LOG.info(\u0027Volume %(cinder_id)s in cinder API is linked to \u0027"},{"line_number":2926,"context_line":"                         \u0027volume_name %(svc_volume_name)s in SVC\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"b00c66ae_a78e00bb","line":2923,"range":{"start_line":2923,"start_character":12,"end_line":2923,"end_character":70},"updated":"2023-01-25 13:35:19.000000000","message":"not sure how good of an idea it is to store it in volume metadata, an end-user (non-admin) can modify metadata so can modify/remove this field","commit_id":"c4ff285dd2f0fd0626aa49168dbe5d5895605151"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7fdc48b58d78c0d83714d7deae0a4dc0f03d7cda","unresolved":false,"context_lines":[{"line_number":2920,"context_line":"    def get_volume_name_from_metadata(self, volume):"},{"line_number":2921,"context_line":"        \"\"\"Get Volume name from metadata if metadata exists\"\"\""},{"line_number":2922,"context_line":"        if volume.metadata:"},{"line_number":2923,"context_line":"            svc_volume_name \u003d volume.metadata.get(\"Volume Name\", None)"},{"line_number":2924,"context_line":"            if svc_volume_name:"},{"line_number":2925,"context_line":"                LOG.info(\u0027Volume %(cinder_id)s in cinder API is linked to \u0027"},{"line_number":2926,"context_line":"                         \u0027volume_name %(svc_volume_name)s in SVC\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"cc680fb3_d5e8d5d1","line":2923,"range":{"start_line":2923,"start_character":12,"end_line":2923,"end_character":70},"in_reply_to":"33256259_29710bb3","updated":"2023-02-13 06:55:02.000000000","message":"We should rethink this at some point but for now I won\u0027t block the change for this.","commit_id":"c4ff285dd2f0fd0626aa49168dbe5d5895605151"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"24f803762433ccd24d79ec6cbb1c8ad29fda42f7","unresolved":false,"context_lines":[{"line_number":2920,"context_line":"    def get_volume_name_from_metadata(self, volume):"},{"line_number":2921,"context_line":"        \"\"\"Get Volume name from metadata if metadata exists\"\"\""},{"line_number":2922,"context_line":"        if volume.metadata:"},{"line_number":2923,"context_line":"            svc_volume_name \u003d volume.metadata.get(\"Volume Name\", None)"},{"line_number":2924,"context_line":"            if svc_volume_name:"},{"line_number":2925,"context_line":"                LOG.info(\u0027Volume %(cinder_id)s in cinder API is linked to \u0027"},{"line_number":2926,"context_line":"                         \u0027volume_name %(svc_volume_name)s in SVC\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"33256259_29710bb3","line":2923,"range":{"start_line":2923,"start_character":12,"end_line":2923,"end_character":70},"in_reply_to":"4a211c55_345c0416","updated":"2023-02-10 07:36:41.000000000","message":"The similar kind of approach we followed while creating replication volumes where we update svc volume name in metadata .please see the below code lines \n\nhttps://opendev.org/openstack/cinder/src/branch/master/cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py#L3825","commit_id":"c4ff285dd2f0fd0626aa49168dbe5d5895605151"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"7a1fcdd4bea3fc50e04e4fc0526d0945222dc4d1","unresolved":true,"context_lines":[{"line_number":2920,"context_line":"    def get_volume_name_from_metadata(self, volume):"},{"line_number":2921,"context_line":"        \"\"\"Get Volume name from metadata if metadata exists\"\"\""},{"line_number":2922,"context_line":"        if volume.metadata:"},{"line_number":2923,"context_line":"            svc_volume_name \u003d volume.metadata.get(\"Volume Name\", None)"},{"line_number":2924,"context_line":"            if svc_volume_name:"},{"line_number":2925,"context_line":"                LOG.info(\u0027Volume %(cinder_id)s in cinder API is linked to \u0027"},{"line_number":2926,"context_line":"                         \u0027volume_name %(svc_volume_name)s in SVC\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"4a211c55_345c0416","line":2923,"range":{"start_line":2923,"start_character":12,"end_line":2923,"end_character":70},"in_reply_to":"b00c66ae_a78e00bb","updated":"2023-01-25 14:46:17.000000000","message":"Yes I totally agree with you but We don\u0027t have any other way to store the volume name apart from metadata . so we discussed this approach with our customer and they have accepted for it .","commit_id":"c4ff285dd2f0fd0626aa49168dbe5d5895605151"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"33093ced6831402695b4ac2b38d3e5ce4fc49f62","unresolved":true,"context_lines":[{"line_number":2922,"context_line":"        if volume.metadata:"},{"line_number":2923,"context_line":"            svc_volume_name \u003d volume.metadata.get(\"Volume Name\", None)"},{"line_number":2924,"context_line":"            if svc_volume_name:"},{"line_number":2925,"context_line":"                LOG.info(\u0027Volume %(cinder_id)s in cinder API is linked to \u0027"},{"line_number":2926,"context_line":"                         \u0027volume_name %(svc_volume_name)s in SVC\u0027,"},{"line_number":2927,"context_line":"                         {\u0027cinder_id\u0027: volume.name,"},{"line_number":2928,"context_line":"                          \u0027svc_volume_name\u0027: svc_volume_name})"}],"source_content_type":"text/x-python","patch_set":4,"id":"847f01a0_4cd6a2d4","line":2925,"range":{"start_line":2925,"start_character":20,"end_line":2925,"end_character":24},"updated":"2023-01-25 15:52:24.000000000","message":"maybe better as DEBUG level, but INFO looks consistent with some similar messages in this file, so I won\u0027t object","commit_id":"c4ff285dd2f0fd0626aa49168dbe5d5895605151"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"24f803762433ccd24d79ec6cbb1c8ad29fda42f7","unresolved":false,"context_lines":[{"line_number":2922,"context_line":"        if volume.metadata:"},{"line_number":2923,"context_line":"            svc_volume_name \u003d volume.metadata.get(\"Volume Name\", None)"},{"line_number":2924,"context_line":"            if svc_volume_name:"},{"line_number":2925,"context_line":"                LOG.info(\u0027Volume %(cinder_id)s in cinder API is linked to \u0027"},{"line_number":2926,"context_line":"                         \u0027volume_name %(svc_volume_name)s in SVC\u0027,"},{"line_number":2927,"context_line":"                         {\u0027cinder_id\u0027: volume.name,"},{"line_number":2928,"context_line":"                          \u0027svc_volume_name\u0027: svc_volume_name})"}],"source_content_type":"text/x-python","patch_set":4,"id":"459d618c_1363274e","line":2925,"range":{"start_line":2925,"start_character":20,"end_line":2925,"end_character":24},"in_reply_to":"847f01a0_4cd6a2d4","updated":"2023-02-10 07:36:41.000000000","message":"Ack","commit_id":"c4ff285dd2f0fd0626aa49168dbe5d5895605151"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"33093ced6831402695b4ac2b38d3e5ce4fc49f62","unresolved":true,"context_lines":[{"line_number":6350,"context_line":"            self._helpers.check_codelevel_for_volumegroup("},{"line_number":6351,"context_line":"                self._state[\u0027code_level\u0027])"},{"line_number":6352,"context_line":"            model_update \u003d self._delete_volumegroup(group, volumes)"},{"line_number":6353,"context_line":""},{"line_number":6354,"context_line":"        else:"},{"line_number":6355,"context_line":"            for volume in volumes:"},{"line_number":6356,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"96ff826f_0e00cf44","line":6353,"updated":"2023-01-25 15:52:24.000000000","message":"This may be a dumb question, but it looks like if you pass a list of volumes to _delete_volumegroup() they all get deleted.  So if a user does *not* request \"--delete-volumes\" how is the group being deleted and the volumes not deleted?","commit_id":"c4ff285dd2f0fd0626aa49168dbe5d5895605151"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"24f803762433ccd24d79ec6cbb1c8ad29fda42f7","unresolved":false,"context_lines":[{"line_number":6350,"context_line":"            self._helpers.check_codelevel_for_volumegroup("},{"line_number":6351,"context_line":"                self._state[\u0027code_level\u0027])"},{"line_number":6352,"context_line":"            model_update \u003d self._delete_volumegroup(group, volumes)"},{"line_number":6353,"context_line":""},{"line_number":6354,"context_line":"        else:"},{"line_number":6355,"context_line":"            for volume in volumes:"},{"line_number":6356,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"891196e2_b03b8ede","line":6353,"in_reply_to":"96ff826f_0e00cf44","updated":"2023-02-10 07:36:41.000000000","message":"Hi Brian,\n\nIn the above case if user tries to delete a group which consists of volumes and if user tries to delete the group with out passing --delete-volumes flag , driver will throws an error.","commit_id":"c4ff285dd2f0fd0626aa49168dbe5d5895605151"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"33093ced6831402695b4ac2b38d3e5ce4fc49f62","unresolved":true,"context_lines":[{"line_number":7084,"context_line":"            force_unmap \u003d False"},{"line_number":7085,"context_line":"        else:"},{"line_number":7086,"context_line":"            force_unmap \u003d True"},{"line_number":7087,"context_line":"        for volume in volumes:"},{"line_number":7088,"context_line":"            volume \u003d self._helpers.get_volume_name_from_metadata(volume)"},{"line_number":7089,"context_line":"            if self._active_backend_id:"},{"line_number":7090,"context_line":"                msg \u003d (_(\u0027Error: delete non-replicate volume in \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ad09ff8_c25ffb1d","line":7087,"range":{"start_line":7087,"start_character":22,"end_line":7087,"end_character":29},"updated":"2023-01-25 15:52:24.000000000","message":"This worries me a bit, because if someone calls the function like\n\n  _delete_volgroup(group, volumes\u003dNone)\n\n(which seems just as legit as passing volumes\u003d[]) the code will break at this line.  I suggest making volumes\u003dNone in the function definition, and then do something like\n\n  volumes \u003d volumes or []\n\nbefore this line.  (You wouldn\u0027t have had to make as many changes to the unit tests, too.)","commit_id":"c4ff285dd2f0fd0626aa49168dbe5d5895605151"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"24f803762433ccd24d79ec6cbb1c8ad29fda42f7","unresolved":false,"context_lines":[{"line_number":7084,"context_line":"            force_unmap \u003d False"},{"line_number":7085,"context_line":"        else:"},{"line_number":7086,"context_line":"            force_unmap \u003d True"},{"line_number":7087,"context_line":"        for volume in volumes:"},{"line_number":7088,"context_line":"            volume \u003d self._helpers.get_volume_name_from_metadata(volume)"},{"line_number":7089,"context_line":"            if self._active_backend_id:"},{"line_number":7090,"context_line":"                msg \u003d (_(\u0027Error: delete non-replicate volume in \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"b7fff52c_fe67bcd0","line":7087,"range":{"start_line":7087,"start_character":22,"end_line":7087,"end_character":29},"in_reply_to":"7ad09ff8_c25ffb1d","updated":"2023-02-10 07:36:41.000000000","message":"In delete_group(group, volumes) function, The volumes param type is list coming from Manager.py \n\nhttps://opendev.org/openstack/cinder/src/branch/master/cinder/volume/manager.py#L3769\n\nIf volumes \u003d [] ---\u003e it indicates group is empty","commit_id":"c4ff285dd2f0fd0626aa49168dbe5d5895605151"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7fdc48b58d78c0d83714d7deae0a4dc0f03d7cda","unresolved":true,"context_lines":[{"line_number":7086,"context_line":"        for volume in volumes:"},{"line_number":7087,"context_line":"            volume \u003d self._helpers.get_volume_name_from_metadata(volume)"},{"line_number":7088,"context_line":"            if self._active_backend_id:"},{"line_number":7089,"context_line":"                msg \u003d (_(\u0027Error: delete non-replicate volume in \u0027"},{"line_number":7090,"context_line":"                         \u0027failover mode is not allowed.\u0027))"},{"line_number":7091,"context_line":"                LOG.error(msg)"},{"line_number":7092,"context_line":"                volume.name_id \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f57bde7_ba3685af","line":7089,"range":{"start_line":7089,"start_character":33,"end_line":7089,"end_character":39},"updated":"2023-02-13 06:55:02.000000000","message":"nit: deleting","commit_id":"5388d2ea3388877337c35f4be05e600c7422bed5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7fdc48b58d78c0d83714d7deae0a4dc0f03d7cda","unresolved":true,"context_lines":[{"line_number":7086,"context_line":"        for volume in volumes:"},{"line_number":7087,"context_line":"            volume \u003d self._helpers.get_volume_name_from_metadata(volume)"},{"line_number":7088,"context_line":"            if self._active_backend_id:"},{"line_number":7089,"context_line":"                msg \u003d (_(\u0027Error: delete non-replicate volume in \u0027"},{"line_number":7090,"context_line":"                         \u0027failover mode is not allowed.\u0027))"},{"line_number":7091,"context_line":"                LOG.error(msg)"},{"line_number":7092,"context_line":"                volume.name_id \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"65b68f91_63fd0ece","line":7089,"range":{"start_line":7089,"start_character":44,"end_line":7089,"end_character":53},"updated":"2023-02-13 06:55:02.000000000","message":"nit: replicated","commit_id":"5388d2ea3388877337c35f4be05e600c7422bed5"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"a1a78636d6e54e1ed8ad15a8fc4368c9f3961bfb","unresolved":false,"context_lines":[{"line_number":7086,"context_line":"        for volume in volumes:"},{"line_number":7087,"context_line":"            volume \u003d self._helpers.get_volume_name_from_metadata(volume)"},{"line_number":7088,"context_line":"            if self._active_backend_id:"},{"line_number":7089,"context_line":"                msg \u003d (_(\u0027Error: delete non-replicate volume in \u0027"},{"line_number":7090,"context_line":"                         \u0027failover mode is not allowed.\u0027))"},{"line_number":7091,"context_line":"                LOG.error(msg)"},{"line_number":7092,"context_line":"                volume.name_id \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"06a18cf0_a71fe219","line":7089,"range":{"start_line":7089,"start_character":33,"end_line":7089,"end_character":39},"in_reply_to":"1f57bde7_ba3685af","updated":"2023-02-16 11:04:14.000000000","message":"Done","commit_id":"5388d2ea3388877337c35f4be05e600c7422bed5"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"a1a78636d6e54e1ed8ad15a8fc4368c9f3961bfb","unresolved":false,"context_lines":[{"line_number":7086,"context_line":"        for volume in volumes:"},{"line_number":7087,"context_line":"            volume \u003d self._helpers.get_volume_name_from_metadata(volume)"},{"line_number":7088,"context_line":"            if self._active_backend_id:"},{"line_number":7089,"context_line":"                msg \u003d (_(\u0027Error: delete non-replicate volume in \u0027"},{"line_number":7090,"context_line":"                         \u0027failover mode is not allowed.\u0027))"},{"line_number":7091,"context_line":"                LOG.error(msg)"},{"line_number":7092,"context_line":"                volume.name_id \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"0f7f01e8_76d6faad","line":7089,"range":{"start_line":7089,"start_character":44,"end_line":7089,"end_character":53},"in_reply_to":"65b68f91_63fd0ece","updated":"2023-02-16 11:04:14.000000000","message":"Done","commit_id":"5388d2ea3388877337c35f4be05e600c7422bed5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7fdc48b58d78c0d83714d7deae0a4dc0f03d7cda","unresolved":true,"context_lines":[{"line_number":7091,"context_line":"                LOG.error(msg)"},{"line_number":7092,"context_line":"                volume.name_id \u003d None"},{"line_number":7093,"context_line":"                raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":7094,"context_line":"            else:"},{"line_number":7095,"context_line":"                try:"},{"line_number":7096,"context_line":"                    self._helpers.delete_vdisk("},{"line_number":7097,"context_line":"                        volume.name,"}],"source_content_type":"text/x-python","patch_set":5,"id":"378b8e3e_0597d469","line":7094,"range":{"start_line":7094,"start_character":12,"end_line":7094,"end_character":17},"updated":"2023-02-13 06:55:02.000000000","message":"nit: no need of else since we raise in the if condition","commit_id":"5388d2ea3388877337c35f4be05e600c7422bed5"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"0bc0dcb713aea9d0cb7dde0576723573a281f8b9","unresolved":false,"context_lines":[{"line_number":7091,"context_line":"                LOG.error(msg)"},{"line_number":7092,"context_line":"                volume.name_id \u003d None"},{"line_number":7093,"context_line":"                raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":7094,"context_line":"            else:"},{"line_number":7095,"context_line":"                try:"},{"line_number":7096,"context_line":"                    self._helpers.delete_vdisk("},{"line_number":7097,"context_line":"                        volume.name,"}],"source_content_type":"text/x-python","patch_set":5,"id":"d8b9288e_a4fd9baa","line":7094,"range":{"start_line":7094,"start_character":12,"end_line":7094,"end_character":17},"in_reply_to":"34f53fba_c55aaad6","updated":"2023-02-17 10:49:06.000000000","message":"Thanks Rajath","commit_id":"5388d2ea3388877337c35f4be05e600c7422bed5"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"a1a78636d6e54e1ed8ad15a8fc4368c9f3961bfb","unresolved":false,"context_lines":[{"line_number":7091,"context_line":"                LOG.error(msg)"},{"line_number":7092,"context_line":"                volume.name_id \u003d None"},{"line_number":7093,"context_line":"                raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":7094,"context_line":"            else:"},{"line_number":7095,"context_line":"                try:"},{"line_number":7096,"context_line":"                    self._helpers.delete_vdisk("},{"line_number":7097,"context_line":"                        volume.name,"}],"source_content_type":"text/x-python","patch_set":5,"id":"404f503a_3bdc0e72","line":7094,"range":{"start_line":7094,"start_character":12,"end_line":7094,"end_character":17},"in_reply_to":"378b8e3e_0597d469","updated":"2023-02-16 11:04:14.000000000","message":"Done","commit_id":"5388d2ea3388877337c35f4be05e600c7422bed5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c50c1be381a4a63d5dddb5d5d9be9304e63dbb4e","unresolved":false,"context_lines":[{"line_number":7091,"context_line":"                LOG.error(msg)"},{"line_number":7092,"context_line":"                volume.name_id \u003d None"},{"line_number":7093,"context_line":"                raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":7094,"context_line":"            else:"},{"line_number":7095,"context_line":"                try:"},{"line_number":7096,"context_line":"                    self._helpers.delete_vdisk("},{"line_number":7097,"context_line":"                        volume.name,"}],"source_content_type":"text/x-python","patch_set":5,"id":"34f53fba_c55aaad6","line":7094,"range":{"start_line":7094,"start_character":12,"end_line":7094,"end_character":17},"in_reply_to":"404f503a_3bdc0e72","updated":"2023-02-16 13:52:27.000000000","message":"It\u0027s not addressed in the latest PS but not a big thing to block the patch for.","commit_id":"5388d2ea3388877337c35f4be05e600c7422bed5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7fdc48b58d78c0d83714d7deae0a4dc0f03d7cda","unresolved":true,"context_lines":[{"line_number":7097,"context_line":"                        volume.name,"},{"line_number":7098,"context_line":"                        force_unmap\u003dforce_unmap,"},{"line_number":7099,"context_line":"                        force_delete\u003dTrue)"},{"line_number":7100,"context_line":"                    volumes_model_update.append({\u0027id\u0027: volume.id,"},{"line_number":7101,"context_line":"                                                 \u0027status\u0027: \u0027deleted\u0027})"},{"line_number":7102,"context_line":"                except exception.VolumeBackendAPIException as err:"},{"line_number":7103,"context_line":"                    model_update[\u0027status\u0027] \u003d ("}],"source_content_type":"text/x-python","patch_set":5,"id":"c15e6d1d_9e709993","line":7100,"range":{"start_line":7100,"start_character":20,"end_line":7100,"end_character":40},"updated":"2023-02-13 06:55:02.000000000","message":"I don\u0027t see this being used anywhere. we return the model_update, why are we creating/updating this list?","commit_id":"5388d2ea3388877337c35f4be05e600c7422bed5"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"6cbade6c2ae9229bd04efb1b572da3ddf1d03f1d","unresolved":false,"context_lines":[{"line_number":7097,"context_line":"                        volume.name,"},{"line_number":7098,"context_line":"                        force_unmap\u003dforce_unmap,"},{"line_number":7099,"context_line":"                        force_delete\u003dTrue)"},{"line_number":7100,"context_line":"                    volumes_model_update.append({\u0027id\u0027: volume.id,"},{"line_number":7101,"context_line":"                                                 \u0027status\u0027: \u0027deleted\u0027})"},{"line_number":7102,"context_line":"                except exception.VolumeBackendAPIException as err:"},{"line_number":7103,"context_line":"                    model_update[\u0027status\u0027] \u003d ("}],"source_content_type":"text/x-python","patch_set":5,"id":"715d9357_71182206","line":7100,"range":{"start_line":7100,"start_character":20,"end_line":7100,"end_character":40},"in_reply_to":"c15e6d1d_9e709993","updated":"2023-02-16 11:03:41.000000000","message":"Ack","commit_id":"5388d2ea3388877337c35f4be05e600c7422bed5"}],"releasenotes/notes/ibm-svf-delete-volume-flag-support-for-deletevolumegroup-4224db1ca798a3bf.yaml":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"aa5f35177e454b5bab46b294448045aad03417e2","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    IBM Spectrum Virtualize Family driver: Added --delete-volumes flag"},{"line_number":5,"context_line":"    support for delete volumegroup operation. After adding support"},{"line_number":6,"context_line":"    volume group can be\tdeleted along with the volumes."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"36c6d718_3493f645","line":6,"range":{"start_line":6,"start_character":23,"end_line":6,"end_character":24},"updated":"2023-01-18 14:03:11.000000000","message":"Nit:  Looks like there is an extra tab in here or something.","commit_id":"dc54aae2b50fd20db083d116b4823e7e955a3efa"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"24f803762433ccd24d79ec6cbb1c8ad29fda42f7","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    IBM Spectrum Virtualize Family driver: Added --delete-volumes flag"},{"line_number":5,"context_line":"    support for delete volumegroup operation. After adding support"},{"line_number":6,"context_line":"    volume group can be\tdeleted along with the volumes."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d1d8f80f_916f8d5e","line":6,"range":{"start_line":6,"start_character":23,"end_line":6,"end_character":24},"in_reply_to":"01789994_7c43a56a","updated":"2023-02-10 07:36:41.000000000","message":"Done","commit_id":"dc54aae2b50fd20db083d116b4823e7e955a3efa"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"959a58221105f34fec354911583187ebf7f248fc","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    IBM Spectrum Virtualize Family driver: Added --delete-volumes flag"},{"line_number":5,"context_line":"    support for delete volumegroup operation. After adding support"},{"line_number":6,"context_line":"    volume group can be\tdeleted along with the volumes."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"01789994_7c43a56a","line":6,"range":{"start_line":6,"start_character":23,"end_line":6,"end_character":24},"in_reply_to":"36c6d718_3493f645","updated":"2023-01-24 09:38:56.000000000","message":"This is addressed can you please review","commit_id":"dc54aae2b50fd20db083d116b4823e7e955a3efa"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"33093ced6831402695b4ac2b38d3e5ce4fc49f62","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5b49bfaf_b31a860f","line":7,"updated":"2023-01-25 15:52:24.000000000","message":"Two things:\n\n(1) When you mention a flag like this, you need to use double-backticks (``) to put it into monospace font ... otherwise, when sphinx processes the release notes, it will turn it into an \"em-dash\", as you can see here:\nhttps://8b9b13e3efb7f9665607-81643e490252b5c512a6329ac6b46eb6.ssl.cf2.rackcdn.com/869704/4/check/build-openstack-releasenotes/7f11027/docs/unreleased.html#new-features\n\n(2) \"After adding support volume group can be deleted along with the volumes.\"  Isn\u0027t it more that after adding support, the volumes can optionally be deleted when the volume group is deleted?","commit_id":"c4ff285dd2f0fd0626aa49168dbe5d5895605151"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"24f803762433ccd24d79ec6cbb1c8ad29fda42f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"626b30ff_ced451f0","line":7,"in_reply_to":"5b49bfaf_b31a860f","updated":"2023-02-10 07:36:41.000000000","message":"Done","commit_id":"c4ff285dd2f0fd0626aa49168dbe5d5895605151"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c50c1be381a4a63d5dddb5d5d9be9304e63dbb4e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    IBM Spectrum Virtualize Family driver: Added `--delete-volumes` flag"},{"line_number":5,"context_line":"    support for delete volumegroup operation. After adding support,"},{"line_number":6,"context_line":"    the volumes can optionally be deleted when the volume group is deleted."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"d1227f62_f64e23d5","line":4,"range":{"start_line":4,"start_character":49,"end_line":4,"end_character":67},"updated":"2023-02-16 13:52:27.000000000","message":"this is a cinderclient specific argument. we should\u0027ve used the api-specific wordings which is \u0027delete-volumes\u0027 argument but i think this will convey the meaning.\n\nhttps://docs.openstack.org/api-ref/block-storage/v3/?expanded\u003ddelete-group-detail#id615","commit_id":"04650c7d605fc772bc2f22e9601c829a1e635dee"}]}