)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"d7e09a6f08bc0aac906f5157bcf7b54a51c15efd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3633744f_70b27e8f","updated":"2023-01-19 11:54:14.000000000","message":"Looks good to me - thank you!","commit_id":"beb843f3bbbc98f65fcb3956f5ec245870a73944"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"7b37060a776c642debbd500c68c094e814abb618","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"684a446b_065826d9","updated":"2023-01-23 16:46:18.000000000","message":"Looks like new unit tests passed. LGTM","commit_id":"beb843f3bbbc98f65fcb3956f5ec245870a73944"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4edb69084b52a2bf5a13baaee453ec7f1f46b6f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8c0e743d_55fe59f0","updated":"2023-01-20 15:07:04.000000000","message":"This test doesn\u0027t tell us much without the validation removed but it doesn\u0027t even benefit us being skipped so I don\u0027t have a strong opinion here.","commit_id":"beb843f3bbbc98f65fcb3956f5ec245870a73944"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"48c7f40973a9246159723ec7d13683a0cb84b3b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"06a02510_495716bd","updated":"2023-01-11 16:53:41.000000000","message":"check storwize","commit_id":"beb843f3bbbc98f65fcb3956f5ec245870a73944"}],"cinder/tests/unit/volume/drivers/ibm/test_storwize_svc.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4edb69084b52a2bf5a13baaee453ec7f1f46b6f6","unresolved":false,"context_lines":[{"line_number":4234,"context_line":"        # Run test"},{"line_number":4235,"context_line":"        host_name \u003d helper.get_host_from_connector(self._connector)"},{"line_number":4236,"context_line":""},{"line_number":4237,"context_line":"        self.assertIsNotNone(host_name)"},{"line_number":4238,"context_line":""},{"line_number":4239,"context_line":"    def test_storwize_get_host_from_connector_with_lshost_failure2(self):"},{"line_number":4240,"context_line":"        self._connector.pop(\u0027initiator\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dd4fc009_4dc8352c","line":4237,"range":{"start_line":4237,"start_character":8,"end_line":4237,"end_character":39},"updated":"2023-01-20 15:07:04.000000000","message":"it fails here[1] and we get nothing returned.\nthis assertion doesn\u0027t provide a lot of information about where exactly it failed but at least tells us get_host_from_connector didn\u0027t execute successfully.\n\n[1] https://github.com/openstack/cinder/blob/bc9910f0409c60d82788b9ad248327b377439c3a/cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py#L1330","commit_id":"beb843f3bbbc98f65fcb3956f5ec245870a73944"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"f8c833b327d70759208f81c5169d03027ab83998","unresolved":false,"context_lines":[{"line_number":4234,"context_line":"        # Run test"},{"line_number":4235,"context_line":"        host_name \u003d helper.get_host_from_connector(self._connector)"},{"line_number":4236,"context_line":""},{"line_number":4237,"context_line":"        self.assertIsNotNone(host_name)"},{"line_number":4238,"context_line":""},{"line_number":4239,"context_line":"    def test_storwize_get_host_from_connector_with_lshost_failure2(self):"},{"line_number":4240,"context_line":"        self._connector.pop(\u0027initiator\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"b6030f1e_041eeb66","line":4237,"range":{"start_line":4237,"start_character":8,"end_line":4237,"end_character":39},"in_reply_to":"dd4fc009_4dc8352c","updated":"2023-02-10 04:34:04.000000000","message":"Guys, do you think we could add something  if USESIM: self.assertEqual(host_name, \u0027storwize-svc-test-9\u0027)  or nah?","commit_id":"beb843f3bbbc98f65fcb3956f5ec245870a73944"}]}
