)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"8e7b87471841d9fbbc058261fbf3487ac2ebaffa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d07b7d8a_59caacdf","updated":"2023-01-20 15:17:59.000000000","message":"\n\u003e - cinder-tempest-plugin-ontap-nvme-tcp https://netappopenstacklogserver.s3.us-west-1.amazonaws.com/index.html#logs/04/870004/2/upstream-check/cinder-tempest-plugin-ontap-nvme-tcp/2cc3e2e/ : SUCCESS in 45m 57s (non-voting)\n\nLooks good, all the scenarios are working except for:\n- (tempest.api.compute.volumes.test_attach_volume.AttachVolumeMultiAttachTest) ... SKIPPED: Volume multi-attach is not available.\n\nI cant remember if this was an optional one for NVMe or not. ","commit_id":"8e5d49372477a37d82b7c97769bcf050f46ac640"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7f6d4d490fe17c80b45432fb1c7dce95fdfbd0e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0c310ead_45b9333f","updated":"2023-01-25 11:41:12.000000000","message":"-1 for missing releasenote and one issue noted inline.\n\nThe coverage in the nvme_cmode file is less since the tests directly call methods in nvme_library, i think we should\u0027ve tests that call the nvme_cmode code first to test the right parameters are being passed by that file but can be done in a followup.\n\ncinder/volume/drivers/netapp/dataontap/nvme_cmode.py\t54\t20\t0\t2\t0\t64%\ncinder/volume/drivers/netapp/dataontap/nvme_library.py\t406\t21\t0\t84\t9\t93%","commit_id":"8e5d49372477a37d82b7c97769bcf050f46ac640"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"80c660ac2a16e037b58010732e960b59863de2bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"edc9ef68_63398ccb","updated":"2023-01-20 17:20:13.000000000","message":"LGTM, NetApp CI is green, thanks Felipe.","commit_id":"8e5d49372477a37d82b7c97769bcf050f46ac640"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4e125c67800acc58319807583128a181ff3fefd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"58179aca_7394497b","updated":"2023-01-18 17:01:04.000000000","message":"recheck: no related job failed","commit_id":"8e5d49372477a37d82b7c97769bcf050f46ac640"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4cdebf39bee10b5d0c23235208af79ab86e4677d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ca59591e_d74a0113","updated":"2023-01-18 14:50:20.000000000","message":"run NetApp-CI","commit_id":"8e5d49372477a37d82b7c97769bcf050f46ac640"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"9ee30bdcf0701ba0aef00a924bf16045a7795737","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2dc4badf_9300fa5a","updated":"2023-01-19 03:10:16.000000000","message":"run-NetApp CI","commit_id":"8e5d49372477a37d82b7c97769bcf050f46ac640"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"094269101e8eaefeb62774d6c6f7642cd1dde5d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"408f7655_e55e102a","updated":"2023-01-18 19:35:37.000000000","message":"run-NetApp CI","commit_id":"8e5d49372477a37d82b7c97769bcf050f46ac640"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"a8c92542c592c9fd2d7bc97b15888ca7bc0742a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"45abccf9_7576cd7f","updated":"2023-01-18 22:56:13.000000000","message":"run-NetApp CI","commit_id":"8e5d49372477a37d82b7c97769bcf050f46ac640"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"a65b0c662782cd440c2fb2525c318a7b41bb6182","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"602790d8_3355179f","updated":"2023-01-18 16:55:54.000000000","message":"run-NetApp CI","commit_id":"8e5d49372477a37d82b7c97769bcf050f46ac640"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"303fdc484a1f1d512ed505799888963eb519c389","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b14faa56_7487f1df","updated":"2023-01-18 14:54:55.000000000","message":"run-NetApp CI","commit_id":"8e5d49372477a37d82b7c97769bcf050f46ac640"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"d9bb4e4fd296e7756bb28950bd1a969668a7ca40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b27da54d_79f21ac3","updated":"2023-01-18 14:52:01.000000000","message":"run-NetApp CI","commit_id":"8e5d49372477a37d82b7c97769bcf050f46ac640"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"3bba5ffccecf619815e43decee02a8a43f94d497","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"de8709ab_27b69b07","in_reply_to":"d07b7d8a_59caacdf","updated":"2023-01-20 15:19:50.000000000","message":"\u003e \n\u003e \u003e - cinder-tempest-plugin-ontap-nvme-tcp https://netappopenstacklogserver.s3.us-west-1.amazonaws.com/index.html#logs/04/870004/2/upstream-check/cinder-tempest-plugin-ontap-nvme-tcp/2cc3e2e/ : SUCCESS in 45m 57s (non-voting)\n\u003e \n\u003e Looks good, all the scenarios are working except for:\n\u003e - (tempest.api.compute.volumes.test_attach_volume.AttachVolumeMultiAttachTest) ... SKIPPED: Volume multi-attach is not available.\n\u003e \n\u003e I cant remember if this was an optional one for NVMe or not.","commit_id":"8e5d49372477a37d82b7c97769bcf050f46ac640"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"17ef4427f4702ed928946d2d03c4b09c50d9a05a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c2d329f2_80d2ee1b","updated":"2023-01-27 10:32:53.000000000","message":"Looks like it\u0027s ready!","commit_id":"3141da1442e9f6ec18194feefc7173ab7798a193"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5ab4cf36fda08bb08e9a029c30c484b787b6df2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"df69b9fb_aa418f61","updated":"2023-01-27 09:53:05.000000000","message":"My comments are addressed and netapp CI is passing. Though we\u0027re past deadline, NetApp team had internal issues that postponed the driver proposal but it looks ready and have all the requirements in place to be merged. LGTM.","commit_id":"3141da1442e9f6ec18194feefc7173ab7798a193"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"77910f039b689d1bede276f5816fd7e8dcaeebeb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"45603f86_953efb8e","updated":"2023-01-26 00:31:42.000000000","message":"Thank you Rajat for the review! About the coverage, I will work on a followup patch later.","commit_id":"3141da1442e9f6ec18194feefc7173ab7798a193"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"32ffa7f67c2a6af9b7f8f986eac06196b95a55ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"237193e2_921e8634","updated":"2023-11-20 18:32:07.000000000","message":"ZAPI implementation for NVMe feature is missing.","commit_id":"3141da1442e9f6ec18194feefc7173ab7798a193"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"ab5053e01df430e8f3303a681e4ea665eba387c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d523f525_a23421d6","updated":"2023-11-20 18:32:30.000000000","message":"ZAPI implementation for ONTAP NVMe feature is missing.","commit_id":"3141da1442e9f6ec18194feefc7173ab7798a193"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"83536bb65f9bfb1f71a4faf0130d8141a32f5e53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b771d561_fb6d3842","updated":"2023-01-26 09:51:40.000000000","message":"recheck: not related failure","commit_id":"3141da1442e9f6ec18194feefc7173ab7798a193"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"fd374ac5787fc9852db6e1e0f1b72b007b866b24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"389f0360_ede0b0df","updated":"2023-01-26 16:14:17.000000000","message":"run-NetApp CI","commit_id":"3141da1442e9f6ec18194feefc7173ab7798a193"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"0314b4b07493f8b892c28fde3464b0cc66e047bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5cdb0373_11e6b9ac","updated":"2023-01-26 14:17:42.000000000","message":"run-NetApp CI","commit_id":"3141da1442e9f6ec18194feefc7173ab7798a193"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"159d8fe9fb3fcdfaa1475f4de886b12c1721bd2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"647db532_0e7af676","updated":"2023-01-26 18:04:10.000000000","message":"run-NetApp CI","commit_id":"3141da1442e9f6ec18194feefc7173ab7798a193"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"0b602ccae034f0836ae7995c732d033cb4673978","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6f3c6ae8_376c1cef","updated":"2023-01-26 13:02:46.000000000","message":"run-NetApp CI","commit_id":"3141da1442e9f6ec18194feefc7173ab7798a193"}],"cinder/volume/drivers/netapp/dataontap/nvme_library.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7f6d4d490fe17c80b45432fb1c7dce95fdfbd0e9","unresolved":true,"context_lines":[{"line_number":110,"context_line":"        self.reserved_percentage \u003d self._get_reserved_percentage()"},{"line_number":111,"context_line":"        self.loopingcalls \u003d loopingcalls.LoopingCalls()"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def _get_reserved_percentage(self):"},{"line_number":114,"context_line":"        # If the legacy config option if it is set to the default"},{"line_number":115,"context_line":"        # value, use the more general configuration option."},{"line_number":116,"context_line":"        if self.configuration.netapp_size_multiplier \u003d\u003d ("},{"line_number":117,"context_line":"                na_opts.NETAPP_SIZE_MULTIPLIER_DEFAULT):"},{"line_number":118,"context_line":"            return self.configuration.reserved_percentage"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        # If the legacy config option has a non-default value,"},{"line_number":121,"context_line":"        # honor it for one release.  Note that the \"size multiplier\""},{"line_number":122,"context_line":"        # actually acted as a divisor in the code and didn\u0027t apply"},{"line_number":123,"context_line":"        # to the file size (as the help message for this option suggest),"},{"line_number":124,"context_line":"        # but rather to total and free size for the pool."},{"line_number":125,"context_line":"        divisor \u003d self.configuration.netapp_size_multiplier"},{"line_number":126,"context_line":"        reserved_ratio \u003d round(1 - (1 / divisor), 2)"},{"line_number":127,"context_line":"        reserved_percentage \u003d 100 * int(reserved_ratio)"},{"line_number":128,"context_line":"        msg \u003d (\u0027The \"netapp_size_multiplier\" configuration option is \u0027"},{"line_number":129,"context_line":"               \u0027deprecated and will be removed in the Mitaka release. \u0027"},{"line_number":130,"context_line":"               \u0027Please set \"reserved_percentage \u003d %d\" instead.\u0027) % ("},{"line_number":131,"context_line":"                   reserved_percentage)"},{"line_number":132,"context_line":"        versionutils.report_deprecated_feature(LOG, msg)"},{"line_number":133,"context_line":"        return reserved_percentage"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def do_setup(self, context):"},{"line_number":136,"context_line":"        na_utils.check_flags(self.REQUIRED_FLAGS, self.configuration)"}],"source_content_type":"text/x-python","patch_set":2,"id":"cba32b7a_a77a11af","line":133,"range":{"start_line":113,"start_character":0,"end_line":133,"end_character":34},"updated":"2023-01-25 11:41:12.000000000","message":"i see this code has been taken from the iscsi driver but i don\u0027t think this should be used anymore, as the deprecation message says it should\u0027ve been removed in mitaka release and was introduced 8 years ago with commit[1] so we should not use the deprecated config option and also work on removing this from the iscsi driver.\n\n[1] https://github.com/openstack/cinder/commit/528995e4fdb6e302d22df15528182f34e6a55e92","commit_id":"8e5d49372477a37d82b7c97769bcf050f46ac640"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"77910f039b689d1bede276f5816fd7e8dcaeebeb","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        self.reserved_percentage \u003d self._get_reserved_percentage()"},{"line_number":111,"context_line":"        self.loopingcalls \u003d loopingcalls.LoopingCalls()"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def _get_reserved_percentage(self):"},{"line_number":114,"context_line":"        # If the legacy config option if it is set to the default"},{"line_number":115,"context_line":"        # value, use the more general configuration option."},{"line_number":116,"context_line":"        if self.configuration.netapp_size_multiplier \u003d\u003d ("},{"line_number":117,"context_line":"                na_opts.NETAPP_SIZE_MULTIPLIER_DEFAULT):"},{"line_number":118,"context_line":"            return self.configuration.reserved_percentage"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        # If the legacy config option has a non-default value,"},{"line_number":121,"context_line":"        # honor it for one release.  Note that the \"size multiplier\""},{"line_number":122,"context_line":"        # actually acted as a divisor in the code and didn\u0027t apply"},{"line_number":123,"context_line":"        # to the file size (as the help message for this option suggest),"},{"line_number":124,"context_line":"        # but rather to total and free size for the pool."},{"line_number":125,"context_line":"        divisor \u003d self.configuration.netapp_size_multiplier"},{"line_number":126,"context_line":"        reserved_ratio \u003d round(1 - (1 / divisor), 2)"},{"line_number":127,"context_line":"        reserved_percentage \u003d 100 * int(reserved_ratio)"},{"line_number":128,"context_line":"        msg \u003d (\u0027The \"netapp_size_multiplier\" configuration option is \u0027"},{"line_number":129,"context_line":"               \u0027deprecated and will be removed in the Mitaka release. \u0027"},{"line_number":130,"context_line":"               \u0027Please set \"reserved_percentage \u003d %d\" instead.\u0027) % ("},{"line_number":131,"context_line":"                   reserved_percentage)"},{"line_number":132,"context_line":"        versionutils.report_deprecated_feature(LOG, msg)"},{"line_number":133,"context_line":"        return reserved_percentage"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def do_setup(self, context):"},{"line_number":136,"context_line":"        na_utils.check_flags(self.REQUIRED_FLAGS, self.configuration)"}],"source_content_type":"text/x-python","patch_set":2,"id":"b0904811_2a938b07","line":133,"range":{"start_line":113,"start_character":0,"end_line":133,"end_character":34},"in_reply_to":"cba32b7a_a77a11af","updated":"2023-01-26 00:31:42.000000000","message":"You are right Rajat, done!","commit_id":"8e5d49372477a37d82b7c97769bcf050f46ac640"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7f6d4d490fe17c80b45432fb1c7dce95fdfbd0e9","unresolved":true,"context_lines":[{"line_number":276,"context_line":"            msg \u003d _(\"Pool is not available in the volume host field.\")"},{"line_number":277,"context_line":"            raise exception.InvalidHost(reason\u003dmsg)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        namespace \u003d volume[\u0027name\u0027]"},{"line_number":280,"context_line":"        size \u003d int(volume[\u0027size\u0027]) * units.Gi"},{"line_number":281,"context_line":"        metadata \u003d {\u0027OsType\u0027: self.namespace_ostype,"},{"line_number":282,"context_line":"                    \u0027Path\u0027: \u0027/vol/%s/%s\u0027 % (pool_name, namespace)}"}],"source_content_type":"text/x-python","patch_set":2,"id":"61f56eda_4864a82b","line":279,"range":{"start_line":279,"start_character":20,"end_line":279,"end_character":34},"updated":"2023-01-25 11:41:12.000000000","message":"nit: volume.name\n\nalso is this accurate? or should name_id be used?","commit_id":"8e5d49372477a37d82b7c97769bcf050f46ac640"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"77910f039b689d1bede276f5816fd7e8dcaeebeb","unresolved":false,"context_lines":[{"line_number":276,"context_line":"            msg \u003d _(\"Pool is not available in the volume host field.\")"},{"line_number":277,"context_line":"            raise exception.InvalidHost(reason\u003dmsg)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        namespace \u003d volume[\u0027name\u0027]"},{"line_number":280,"context_line":"        size \u003d int(volume[\u0027size\u0027]) * units.Gi"},{"line_number":281,"context_line":"        metadata \u003d {\u0027OsType\u0027: self.namespace_ostype,"},{"line_number":282,"context_line":"                    \u0027Path\u0027: \u0027/vol/%s/%s\u0027 % (pool_name, namespace)}"}],"source_content_type":"text/x-python","patch_set":2,"id":"c40090ae_09421690","line":279,"range":{"start_line":279,"start_character":20,"end_line":279,"end_character":34},"in_reply_to":"61f56eda_4864a82b","updated":"2023-01-26 00:31:42.000000000","message":"Done as volume.name. we want to keep compatible with iSCSI, that\u0027s it, it uses the \"volume_name_template\" and the name_id.","commit_id":"8e5d49372477a37d82b7c97769bcf050f46ac640"}]}