)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"b5413c497127f092ffed5dd83a538f3005bf45b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c6c11ea6_aeb5b9c4","updated":"2023-01-17 01:10:44.000000000","message":"run-storpoolci","commit_id":"767b03274054e1c1e422ef8937769ec9851a4111"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"6df321d345326a51e96560f8953b9abbf43c0884","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ed726c12_6d83d8e5","updated":"2023-05-16 07:23:41.000000000","message":"1] A release note would be required.\n2] Minor comment inline.","commit_id":"c003466a27aee0c1997562eda1d7c7683a944576"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"a07ca2e2b3e5650e56d0ea3ecdc4dbdaaa421e76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7d8c1f4b_52240de9","updated":"2023-12-06 13:28:09.000000000","message":"run-storpoolci","commit_id":"816aa85f4b3b081f1e79436b9c6c60d47fb220e5"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9724a37d753a21af72527119316fb3ac6e7cac3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c3455aa6_2566293e","updated":"2024-05-31 16:55:30.000000000","message":"Added releasenotes","commit_id":"eda6066008d1a07859de090191cafe006b7bf7ac"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"3cb86859dc62c939c86793b07ab54f975aca7f7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"523d445d_7adce6ab","updated":"2024-05-31 08:27:10.000000000","message":"recheck","commit_id":"eda6066008d1a07859de090191cafe006b7bf7ac"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"42dbc5e2f5c05af82eb986cc946906c2bf9756d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"a35fc2d6_bdaeeaf9","updated":"2024-06-03 12:28:58.000000000","message":"My comments have been replied/addressed. So +1","commit_id":"2108392c4c392f99e7832bc69b44113a99d98dde"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1185bbea9aeddb946fef0dbb6153d05a2404c3e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"f3f9ecf7_df30777b","updated":"2024-06-04 16:30:18.000000000","message":"Two minor things to address, otherwise the code \u0026 tests LGTM.","commit_id":"2108392c4c392f99e7832bc69b44113a99d98dde"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"adcd9d4cf89d199af05499eed52a8f09e1cab778","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ca249f26_5ac0bb6f","updated":"2024-06-03 12:41:41.000000000","message":"recheck","commit_id":"2108392c4c392f99e7832bc69b44113a99d98dde"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"edf61164237c8efa432d1cff518173c79697d1d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"eb18a153_d9a4071a","updated":"2024-06-03 12:30:02.000000000","message":"recheck tempest-integrated-storage","commit_id":"2108392c4c392f99e7832bc69b44113a99d98dde"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"989574a9d94669ffb335300a678f96ec319f0a6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"915e38e7_b077f114","updated":"2024-06-05 12:25:35.000000000","message":"Two issues noted inline; the release note revision LGTM.","commit_id":"4d9987181c44306cc326ffba21616d6f2fa83b3b"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"1652e901984eb8843245a9e41880782bb3b250b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"bcf4107f_f14219a0","updated":"2024-06-10 09:44:33.000000000","message":"Raghavendra,\ncan you sign-off again ?","commit_id":"c04d5cb892212f322f6c72e0118a66c1c47edb87"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7e098d7b7ba4ca0c283e6950ce28ff3037bdd89d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"fd3478b2_8df1c7a8","updated":"2024-06-07 13:06:46.000000000","message":"Revisions LGTM.  Thanks for your patience in working on this patch.","commit_id":"c04d5cb892212f322f6c72e0118a66c1c47edb87"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"5c475b4323455fcf7eb069f836f191c727cc8ded","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"5ea8e2a4_c2a313c7","updated":"2024-06-10 12:24:15.000000000","message":"code changes look fine. Zuul also passed.\ni am not a core reviewer. So can vote only +1.\nThanks.","commit_id":"c04d5cb892212f322f6c72e0118a66c1c47edb87"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"2fa6d531566a895edc8b09c0345bd26151ba2d79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"1e41864c_6752c50d","updated":"2024-06-06 09:16:11.000000000","message":"recheck","commit_id":"c04d5cb892212f322f6c72e0118a66c1c47edb87"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"c888e829df798acd3269f758bc3fbd4d337294c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"468eaf2d_0de3f72c","updated":"2024-06-11 10:08:35.000000000","message":"recheck","commit_id":"c04d5cb892212f322f6c72e0118a66c1c47edb87"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"e04d557795d5f22d45116e7ae6ce43101f88f542","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"9beeebcc_618edaae","updated":"2024-06-11 02:50:47.000000000","message":"recheck","commit_id":"c04d5cb892212f322f6c72e0118a66c1c47edb87"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b72a18142b3f58ccd92b3aef44ff1bb1c3bbbb0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"aff5e876_d18f4da7","updated":"2024-06-06 03:32:01.000000000","message":"recheck","commit_id":"c04d5cb892212f322f6c72e0118a66c1c47edb87"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"bc06fdb21e1ceafbbf0518d8cd9d0121023d4192","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"bd7619cc_0e3a188c","updated":"2024-06-11 05:21:53.000000000","message":"recheck","commit_id":"c04d5cb892212f322f6c72e0118a66c1c47edb87"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"e9977d8806156dbc381d8a7715bdaed2c4914c21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"d9b69d9f_f40cf393","updated":"2024-06-05 17:15:17.000000000","message":"recheck","commit_id":"c04d5cb892212f322f6c72e0118a66c1c47edb87"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"193d565071f93b018f11b03788247f721bf3d268","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"612646e6_0de456fd","updated":"2024-06-06 06:25:49.000000000","message":"recheck cinder-plugin-ceph-tempest","commit_id":"c04d5cb892212f322f6c72e0118a66c1c47edb87"}],"cinder/volume/drivers/storpool.py":[{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"639e2af82522caab8a042f5ce4847ae358fdec07","unresolved":true,"context_lines":[{"line_number":412,"context_line":"                return {\u0027_name_id\u0027: None}"},{"line_number":413,"context_line":"            except spapi.ApiError as e:"},{"line_number":414,"context_line":"                LOG.error(\u0027StorPool update_migrated_volume(): \u0027"},{"line_number":415,"context_line":"                          \u0027could not rename a volume: \u0027"},{"line_number":416,"context_line":"                          \u0027%(err)s\u0027,"},{"line_number":417,"context_line":"                          {\u0027err\u0027: e})"},{"line_number":418,"context_line":"                return {\u0027_name_id\u0027: new_volume[\u0027_name_id\u0027] or new_volume[\u0027id\u0027]}"}],"source_content_type":"text/x-python","patch_set":6,"id":"55b65cb0_401d1967","line":415,"updated":"2023-03-03 10:26:14.000000000","message":"patch looks good but here why change previous msg format that one looks more informative.","commit_id":"704cec6d87d88c51af5b4e9ddbdee0f6b2ca0f86"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"1facec2cc31726acfd41f0ce1495e716c4aa6e8a","unresolved":true,"context_lines":[{"line_number":412,"context_line":"                return {\u0027_name_id\u0027: None}"},{"line_number":413,"context_line":"            except spapi.ApiError as e:"},{"line_number":414,"context_line":"                LOG.error(\u0027StorPool update_migrated_volume(): \u0027"},{"line_number":415,"context_line":"                          \u0027could not rename a volume: \u0027"},{"line_number":416,"context_line":"                          \u0027%(err)s\u0027,"},{"line_number":417,"context_line":"                          {\u0027err\u0027: e})"},{"line_number":418,"context_line":"                return {\u0027_name_id\u0027: new_volume[\u0027_name_id\u0027] or new_volume[\u0027id\u0027]}"}],"source_content_type":"text/x-python","patch_set":6,"id":"c3ba8234_692818a7","line":415,"in_reply_to":"55b65cb0_401d1967","updated":"2023-03-03 23:33:52.000000000","message":"This \"catch\" clause can now handle errors in three separate rename operations, so, without further information, it does not know which names to report. If verbose logging is activated, the names of the volumes will be shown in the log message immediately preceding this one.","commit_id":"704cec6d87d88c51af5b4e9ddbdee0f6b2ca0f86"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"45e1843a32ef508a835fd87ae5e3b21f29bb39cb","unresolved":false,"context_lines":[{"line_number":412,"context_line":"                return {\u0027_name_id\u0027: None}"},{"line_number":413,"context_line":"            except spapi.ApiError as e:"},{"line_number":414,"context_line":"                LOG.error(\u0027StorPool update_migrated_volume(): \u0027"},{"line_number":415,"context_line":"                          \u0027could not rename a volume: \u0027"},{"line_number":416,"context_line":"                          \u0027%(err)s\u0027,"},{"line_number":417,"context_line":"                          {\u0027err\u0027: e})"},{"line_number":418,"context_line":"                return {\u0027_name_id\u0027: new_volume[\u0027_name_id\u0027] or new_volume[\u0027id\u0027]}"}],"source_content_type":"text/x-python","patch_set":6,"id":"a368721c_9b5c1344","line":415,"in_reply_to":"c3ba8234_692818a7","updated":"2023-03-08 21:42:31.000000000","message":"Marking this comment thread as resolved. Thanks for the review!","commit_id":"704cec6d87d88c51af5b4e9ddbdee0f6b2ca0f86"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"6df321d345326a51e96560f8953b9abbf43c0884","unresolved":true,"context_lines":[{"line_number":90,"context_line":"                  fix the docstring formatting"},{"line_number":91,"context_line":"        1.2.2   - Reintroduce the driver into OpenStack Queens,"},{"line_number":92,"context_line":"                  add ignore_errors to the internal _detach_volume() method"},{"line_number":93,"context_line":"        1.2.3   - Advertise some more driver capabilities."},{"line_number":94,"context_line":"    \"\"\""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    VERSION \u003d \u00271.2.3\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"b3985c44_1ad5eac0","line":93,"updated":"2023-05-16 07:23:41.000000000","message":"If it helps, can we add version here.\n1.2.4 - fix the retype volume flow.","commit_id":"c003466a27aee0c1997562eda1d7c7683a944576"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9724a37d753a21af72527119316fb3ac6e7cac3c","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                  fix the docstring formatting"},{"line_number":91,"context_line":"        1.2.2   - Reintroduce the driver into OpenStack Queens,"},{"line_number":92,"context_line":"                  add ignore_errors to the internal _detach_volume() method"},{"line_number":93,"context_line":"        1.2.3   - Advertise some more driver capabilities."},{"line_number":94,"context_line":"    \"\"\""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    VERSION \u003d \u00271.2.3\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"076220ee_526cb197","line":93,"in_reply_to":"b3985c44_1ad5eac0","updated":"2024-05-31 16:55:30.000000000","message":"this bugfix not changing interface neither introducing any capabilities. so no version addition needed.","commit_id":"c003466a27aee0c1997562eda1d7c7683a944576"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1185bbea9aeddb946fef0dbb6153d05a2404c3e4","unresolved":true,"context_lines":[{"line_number":338,"context_line":"        templ \u003d self.configuration.storpool_template"},{"line_number":339,"context_line":"        repl \u003d self.configuration.storpool_replication"},{"line_number":340,"context_line":"        if diff[\u0027extra_specs\u0027]:"},{"line_number":341,"context_line":"            for (k, v) in diff[\u0027extra_specs\u0027].items():"},{"line_number":342,"context_line":"                if k \u003d\u003d \u0027volume_backend_name\u0027:"},{"line_number":343,"context_line":"                    if v[0] !\u003d v[1]:"},{"line_number":344,"context_line":"                        # Retype of a volume backend not supported yet,"}],"source_content_type":"text/x-python","patch_set":11,"id":"e90e06e1_116724ad","line":341,"updated":"2024-06-04 16:30:18.000000000","message":"Since the logic of what you are looking for has changed, there\u0027s probably no need to iterate through all the extra specs.  Instead, you could just check to see if either of the items you\u0027re interested in is in the extra_specs, something like:\n\n```\nif diff[\u0027extra_specs\u0027].get(\u0027volume_backend_name\u0027):\n    # do stuff\nif diff[\u0027extra_specs\u0027].get(\u0027storpool_template\u0027):\n    # do stuff\n```","commit_id":"2108392c4c392f99e7832bc69b44113a99d98dde"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"5e76ae1bb8e09b692718bb6c7e074334415341b3","unresolved":false,"context_lines":[{"line_number":338,"context_line":"        templ \u003d self.configuration.storpool_template"},{"line_number":339,"context_line":"        repl \u003d self.configuration.storpool_replication"},{"line_number":340,"context_line":"        if diff[\u0027extra_specs\u0027]:"},{"line_number":341,"context_line":"            for (k, v) in diff[\u0027extra_specs\u0027].items():"},{"line_number":342,"context_line":"                if k \u003d\u003d \u0027volume_backend_name\u0027:"},{"line_number":343,"context_line":"                    if v[0] !\u003d v[1]:"},{"line_number":344,"context_line":"                        # Retype of a volume backend not supported yet,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9e1105ea_e857e382","line":341,"in_reply_to":"e90e06e1_116724ad","updated":"2024-06-05 08:39:50.000000000","message":"Done","commit_id":"2108392c4c392f99e7832bc69b44113a99d98dde"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"989574a9d94669ffb335300a678f96ec319f0a6f","unresolved":true,"context_lines":[{"line_number":344,"context_line":"                    # Retype of a volume backend not supported yet,"},{"line_number":345,"context_line":"                    # the volume needs to be migrated."},{"line_number":346,"context_line":"                    return False"},{"line_number":347,"context_line":"            elif diff[\u0027extra_specs\u0027].get(\u0027storpool_template\u0027):"},{"line_number":348,"context_line":"                v \u003d diff[\u0027extra_specs\u0027].get(\u0027storpool_template\u0027)"},{"line_number":349,"context_line":"                if v[0] !\u003d v[1]:"},{"line_number":350,"context_line":"                    if v[1] is not None:"}],"source_content_type":"text/x-python","patch_set":12,"id":"d56d0b42_3bf68680","line":347,"range":{"start_line":347,"start_character":11,"end_line":347,"end_character":17},"updated":"2024-06-05 12:25:35.000000000","message":"Since you\u0027re not looping any more, I think this needs to be just an \"if\" now, so that you\u0027ll check for both extra_spec keys.","commit_id":"4d9987181c44306cc326ffba21616d6f2fa83b3b"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"2589cb8f5eb89408e6fa599ee93b31d66919c5cf","unresolved":false,"context_lines":[{"line_number":344,"context_line":"                    # Retype of a volume backend not supported yet,"},{"line_number":345,"context_line":"                    # the volume needs to be migrated."},{"line_number":346,"context_line":"                    return False"},{"line_number":347,"context_line":"            elif diff[\u0027extra_specs\u0027].get(\u0027storpool_template\u0027):"},{"line_number":348,"context_line":"                v \u003d diff[\u0027extra_specs\u0027].get(\u0027storpool_template\u0027)"},{"line_number":349,"context_line":"                if v[0] !\u003d v[1]:"},{"line_number":350,"context_line":"                    if v[1] is not None:"}],"source_content_type":"text/x-python","patch_set":12,"id":"abd33854_207a8314","line":347,"range":{"start_line":347,"start_character":11,"end_line":347,"end_character":17},"in_reply_to":"d56d0b42_3bf68680","updated":"2024-06-05 14:42:41.000000000","message":"Done","commit_id":"4d9987181c44306cc326ffba21616d6f2fa83b3b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"989574a9d94669ffb335300a678f96ec319f0a6f","unresolved":true,"context_lines":[{"line_number":353,"context_line":"                        update[\u0027template\u0027] \u003d templ"},{"line_number":354,"context_line":"                    else:"},{"line_number":355,"context_line":"                        update[\u0027replication\u0027] \u003d repl"},{"line_number":356,"context_line":"            else:"},{"line_number":357,"context_line":"                # We ignore any extra specs that we do not know about."},{"line_number":358,"context_line":"                # Let\u0027s leave it to Cinder\u0027s scheduler to not even"},{"line_number":359,"context_line":"                # get this far if there is any serious mismatch between"},{"line_number":360,"context_line":"                # the volume types."},{"line_number":361,"context_line":"                pass"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        if update:"},{"line_number":364,"context_line":"            name \u003d self._attach.volumeName(volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"1b83a905_2e84382f","line":361,"range":{"start_line":356,"start_character":0,"end_line":361,"end_character":20},"updated":"2024-06-05 12:25:35.000000000","message":"since this block doesn\u0027t actually do anything, I suggest moving the comment up to after line 340, and rewrite it to say something like \"Check for the StorPool extra specs.  We intentionally ignore any other extra_specs because the cinder scheduler should not even call us if there\u0027s a serious mismatch between the volume types.\"","commit_id":"4d9987181c44306cc326ffba21616d6f2fa83b3b"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"2589cb8f5eb89408e6fa599ee93b31d66919c5cf","unresolved":false,"context_lines":[{"line_number":353,"context_line":"                        update[\u0027template\u0027] \u003d templ"},{"line_number":354,"context_line":"                    else:"},{"line_number":355,"context_line":"                        update[\u0027replication\u0027] \u003d repl"},{"line_number":356,"context_line":"            else:"},{"line_number":357,"context_line":"                # We ignore any extra specs that we do not know about."},{"line_number":358,"context_line":"                # Let\u0027s leave it to Cinder\u0027s scheduler to not even"},{"line_number":359,"context_line":"                # get this far if there is any serious mismatch between"},{"line_number":360,"context_line":"                # the volume types."},{"line_number":361,"context_line":"                pass"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        if update:"},{"line_number":364,"context_line":"            name \u003d self._attach.volumeName(volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"365f08ad_561827b8","line":361,"range":{"start_line":356,"start_character":0,"end_line":361,"end_character":20},"in_reply_to":"1b83a905_2e84382f","updated":"2024-06-05 14:42:41.000000000","message":"Done","commit_id":"4d9987181c44306cc326ffba21616d6f2fa83b3b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7e098d7b7ba4ca0c283e6950ce28ff3037bdd89d","unresolved":true,"context_lines":[{"line_number":340,"context_line":"        if diff[\u0027extra_specs\u0027]:"},{"line_number":341,"context_line":"            # Check for the StorPool extra specs. We intentionally ignore any"},{"line_number":342,"context_line":"            # other extra_specs because the cinder scheduler should not even"},{"line_number":343,"context_line":"            # call us if there\u0027s a serious mismatch between the volume types.\""},{"line_number":344,"context_line":"            if diff[\u0027extra_specs\u0027].get(\u0027volume_backend_name\u0027):"},{"line_number":345,"context_line":"                v \u003d diff[\u0027extra_specs\u0027].get(\u0027volume_backend_name\u0027)"},{"line_number":346,"context_line":"                if v[0] !\u003d v[1]:"}],"source_content_type":"text/x-python","patch_set":13,"id":"79233f2f_7cc42003","line":343,"range":{"start_line":343,"start_character":77,"end_line":343,"end_character":78},"updated":"2024-06-07 13:06:46.000000000","message":"nit: don\u0027t need this quotation mark, but I think you only need to fix it if you have to make changes for another reviewer.","commit_id":"c04d5cb892212f322f6c72e0118a66c1c47edb87"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"5f4419e47764c881ea4d897de2fa00ce9228b7b9","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        if diff[\u0027extra_specs\u0027]:"},{"line_number":341,"context_line":"            # Check for the StorPool extra specs. We intentionally ignore any"},{"line_number":342,"context_line":"            # other extra_specs because the cinder scheduler should not even"},{"line_number":343,"context_line":"            # call us if there\u0027s a serious mismatch between the volume types.\""},{"line_number":344,"context_line":"            if diff[\u0027extra_specs\u0027].get(\u0027volume_backend_name\u0027):"},{"line_number":345,"context_line":"                v \u003d diff[\u0027extra_specs\u0027].get(\u0027volume_backend_name\u0027)"},{"line_number":346,"context_line":"                if v[0] !\u003d v[1]:"}],"source_content_type":"text/x-python","patch_set":13,"id":"d24fb491_7de85a97","line":343,"range":{"start_line":343,"start_character":77,"end_line":343,"end_character":78},"in_reply_to":"79233f2f_7cc42003","updated":"2024-08-20 14:42:22.000000000","message":"Opened a new change for this: I1ef8c60bfca331b9ec7c4789a65788d41db5f172","commit_id":"c04d5cb892212f322f6c72e0118a66c1c47edb87"}],"releasenotes/notes/bug2002995-e423f17eaddae22d.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1185bbea9aeddb946fef0dbb6153d05a2404c3e4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"6233de1b_46de2ae4","line":8,"updated":"2024-06-04 16:30:18.000000000","message":"I think this could be a bit more clear, maybe something like:\n\nWhen retyping a volume on a StorPool backend to a different volume type also\non that StorPool backend but using a different StorPool template, occasionally\nthe retype operation would fail or the old volume could be left attached to\na StorPool client.  This issue has been fixed in this release.","commit_id":"2108392c4c392f99e7832bc69b44113a99d98dde"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"5e76ae1bb8e09b692718bb6c7e074334415341b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"fec813b8_d987aefe","line":8,"in_reply_to":"6233de1b_46de2ae4","updated":"2024-06-05 08:39:50.000000000","message":"Done","commit_id":"2108392c4c392f99e7832bc69b44113a99d98dde"}]}