)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"bd55e412c4056bb6dfbea4cdc5ffe3a799abbd6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f6f87bde_b086865e","updated":"2023-02-13 19:47:02.000000000","message":"Thanks for this patch, Mounika. I\u0027ve pointed a few codes without cover.","commit_id":"6bd57dd4b8903258692fd043b0f096c123229c0b"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"b9a04c514590439bad72f180bd3e10df5820ddd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0ff0b46c_8cbeed7e","updated":"2023-01-24 09:53:08.000000000","message":"recheck","commit_id":"6bd57dd4b8903258692fd043b0f096c123229c0b"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"3a3f0c69a6dfd55f35c6651036e47c2987e8d717","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"88a2cb81_c6639cf7","updated":"2023-02-07 12:15:18.000000000","message":"run-IBM Storage CI","commit_id":"6bd57dd4b8903258692fd043b0f096c123229c0b"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"d0bcdd3eca87c4a71ef60ae0eec75c4cbd3567df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"caca8281_de77208a","updated":"2023-02-08 14:10:55.000000000","message":"run-IBM Storage CI","commit_id":"6bd57dd4b8903258692fd043b0f096c123229c0b"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"2bf57c8a205fbd9621095989323f063e0d3d6d8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b4a2b099_50e35403","updated":"2023-04-04 15:20:59.000000000","message":"Thank you, LGTM.","commit_id":"ff0b174e8866d22021aad92d2a7898116139c862"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"8ca02d96fcb5eae6e7b91ac49cded17e2fb35236","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"befc8bd9_bdfe7da5","updated":"2025-06-06 07:36:53.000000000","message":"We need to abandon this review as this is not part of our delivery plan anymore.\n\nAs the owner of this review has left the company and is no longer an openstack contributor, requesting you to please abandon this review on behalf of the core team.","commit_id":"ff0b174e8866d22021aad92d2a7898116139c862"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"65aab21c0464c59140a1ce5d9dcb56bf8726ad90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"57db06c8_6a508e21","updated":"2023-03-13 06:55:21.000000000","message":"recheck","commit_id":"ff0b174e8866d22021aad92d2a7898116139c862"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"05e0ebea130f762ffa7efc5abcfac517343142ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ad9ba7d6_2f270086","updated":"2023-03-10 06:35:11.000000000","message":"recheck","commit_id":"ff0b174e8866d22021aad92d2a7898116139c862"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"fe125bca9e1a9877537c3af66b1d5f1050ed1c47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ab6acd58_bc1a76cc","updated":"2023-03-13 10:53:47.000000000","message":"run-IBM Storage CI","commit_id":"ff0b174e8866d22021aad92d2a7898116139c862"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"bd55e412c4056bb6dfbea4cdc5ffe3a799abbd6a","unresolved":true,"context_lines":[{"line_number":2397,"context_line":"            clone_volumes_names \u003d ("},{"line_number":2398,"context_line":"                [volume[\"name\"] for volume in clone_volumes])"},{"line_number":2399,"context_line":"            for svc_volume_name in clone_volumes_names:"},{"line_number":2400,"context_line":"                for source, target in zip(sources, targets):"},{"line_number":2401,"context_line":"                    if(svc_volume_name.rsplit(\"-\", 1)[0] \u003d\u003d source):"},{"line_number":2402,"context_line":"                        self._update_volume_properties(target, svc_volume_name)"},{"line_number":2403,"context_line":"                        break"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ce62961_ba6d2603","line":2400,"updated":"2023-02-13 19:47:02.000000000","message":"Would be good add a UT for this new code, as the coverage shows [1] it is not being tested.\n\n[1] https://11dd0df37f114ab1a199-cf4df5e5ffe136c56cf2c9d8dbb6eb03.ssl.cf5.rackcdn.com/871257/1/check/cinder-code-coverage/fc084b5/cover/d_da174c6a0dd05faf_storwize_svc_common_py.html#t2403","commit_id":"6bd57dd4b8903258692fd043b0f096c123229c0b"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"e930065db1983db88b34e73b6859e9bc1b2d2ca9","unresolved":false,"context_lines":[{"line_number":2397,"context_line":"            clone_volumes_names \u003d ("},{"line_number":2398,"context_line":"                [volume[\"name\"] for volume in clone_volumes])"},{"line_number":2399,"context_line":"            for svc_volume_name in clone_volumes_names:"},{"line_number":2400,"context_line":"                for source, target in zip(sources, targets):"},{"line_number":2401,"context_line":"                    if(svc_volume_name.rsplit(\"-\", 1)[0] \u003d\u003d source):"},{"line_number":2402,"context_line":"                        self._update_volume_properties(target, svc_volume_name)"},{"line_number":2403,"context_line":"                        break"}],"source_content_type":"text/x-python","patch_set":1,"id":"26de0907_372abf59","line":2400,"in_reply_to":"1ce62961_ba6d2603","updated":"2023-03-09 12:41:00.000000000","message":"Thanks for the review.\n\nAddressed it.","commit_id":"6bd57dd4b8903258692fd043b0f096c123229c0b"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"bd55e412c4056bb6dfbea4cdc5ffe3a799abbd6a","unresolved":true,"context_lines":[{"line_number":2977,"context_line":"        return vdisks.result"},{"line_number":2978,"context_line":""},{"line_number":2979,"context_line":"    def _update_volume_properties(self, volume, svc_volume):"},{"line_number":2980,"context_line":"        if not volume.metadata:"},{"line_number":2981,"context_line":"            volume.metadata \u003d dict()"},{"line_number":2982,"context_line":"        volume.metadata[\u0027Volume Name\u0027] \u003d svc_volume"},{"line_number":2983,"context_line":"        volume.save()"}],"source_content_type":"text/x-python","patch_set":1,"id":"365965f6_c343f502","line":2980,"updated":"2023-02-13 19:47:02.000000000","message":"Would be good add a UT for this new code, as the coverage shows [1] it is not being tested.\n\n[1] https://11dd0df37f114ab1a199-cf4df5e5ffe136c56cf2c9d8dbb6eb03.ssl.cf5.rackcdn.com/871257/1/check/cinder-code-coverage/fc084b5/cover/d_da174c6a0dd05faf_storwize_svc_common_py.html#t2983","commit_id":"6bd57dd4b8903258692fd043b0f096c123229c0b"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"e930065db1983db88b34e73b6859e9bc1b2d2ca9","unresolved":false,"context_lines":[{"line_number":2977,"context_line":"        return vdisks.result"},{"line_number":2978,"context_line":""},{"line_number":2979,"context_line":"    def _update_volume_properties(self, volume, svc_volume):"},{"line_number":2980,"context_line":"        if not volume.metadata:"},{"line_number":2981,"context_line":"            volume.metadata \u003d dict()"},{"line_number":2982,"context_line":"        volume.metadata[\u0027Volume Name\u0027] \u003d svc_volume"},{"line_number":2983,"context_line":"        volume.save()"}],"source_content_type":"text/x-python","patch_set":1,"id":"6d4e0bd2_e9c1310a","line":2980,"in_reply_to":"365965f6_c343f502","updated":"2023-03-09 12:41:00.000000000","message":"Thanks for the review.\n\nAddressed it.","commit_id":"6bd57dd4b8903258692fd043b0f096c123229c0b"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"f071bb8a1040c9e3a1842cc89aa60aedce5be0cb","unresolved":true,"context_lines":[{"line_number":5571,"context_line":"                        self._helpers.is_data_reduction_pool(mirror_pool)):"},{"line_number":5572,"context_line":"                    msg \u003d _(\u0027Unable to migrate: the thin-provisioned or \u0027"},{"line_number":5573,"context_line":"                            \u0027compressed volume can not be migrated from a data\u0027"},{"line_number":5574,"context_line":"                            \u0027 reduction pool. \u0027)"},{"line_number":5575,"context_line":"                    volume.name_id \u003d None"},{"line_number":5576,"context_line":"                    raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":5577,"context_line":"                elif self._helpers.is_data_reduction_pool(dest_pool):"}],"source_content_type":"text/x-python","patch_set":1,"id":"0a54cbb4_97931dcb","line":5574,"updated":"2023-02-15 04:43:38.000000000","message":"additional space after punctuation.","commit_id":"6bd57dd4b8903258692fd043b0f096c123229c0b"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"e930065db1983db88b34e73b6859e9bc1b2d2ca9","unresolved":false,"context_lines":[{"line_number":5571,"context_line":"                        self._helpers.is_data_reduction_pool(mirror_pool)):"},{"line_number":5572,"context_line":"                    msg \u003d _(\u0027Unable to migrate: the thin-provisioned or \u0027"},{"line_number":5573,"context_line":"                            \u0027compressed volume can not be migrated from a data\u0027"},{"line_number":5574,"context_line":"                            \u0027 reduction pool. \u0027)"},{"line_number":5575,"context_line":"                    volume.name_id \u003d None"},{"line_number":5576,"context_line":"                    raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":5577,"context_line":"                elif self._helpers.is_data_reduction_pool(dest_pool):"}],"source_content_type":"text/x-python","patch_set":1,"id":"cbe40c87_5a4182dc","line":5574,"in_reply_to":"0a54cbb4_97931dcb","updated":"2023-03-09 12:41:00.000000000","message":"Thanks for the review.\n\nAddressed it.","commit_id":"6bd57dd4b8903258692fd043b0f096c123229c0b"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"309e8d0fff6f1860cc15f97cb6603653e0379279","unresolved":true,"context_lines":[{"line_number":2412,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":2413,"context_line":"                LOG.error(\"Failed to create volumegroup. \""},{"line_number":2414,"context_line":"                          \"Exception: %s\", err)"},{"line_number":2415,"context_line":"            return model_update, volumes_model_update"},{"line_number":2416,"context_line":""},{"line_number":2417,"context_line":"        LOG.debug(\u0027Leave: create_volumegroup_from_source.\u0027)"},{"line_number":2418,"context_line":"        return model_update, volumes_model_update"}],"source_content_type":"text/x-python","patch_set":2,"id":"e3fe723a_d134b490","line":2415,"range":{"start_line":2415,"start_character":12,"end_line":2415,"end_character":53},"updated":"2023-04-10 13:39:40.000000000","message":"Does this return ever happen?","commit_id":"ff0b174e8866d22021aad92d2a7898116139c862"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"8ca02d96fcb5eae6e7b91ac49cded17e2fb35236","unresolved":false,"context_lines":[{"line_number":2412,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":2413,"context_line":"                LOG.error(\"Failed to create volumegroup. \""},{"line_number":2414,"context_line":"                          \"Exception: %s\", err)"},{"line_number":2415,"context_line":"            return model_update, volumes_model_update"},{"line_number":2416,"context_line":""},{"line_number":2417,"context_line":"        LOG.debug(\u0027Leave: create_volumegroup_from_source.\u0027)"},{"line_number":2418,"context_line":"        return model_update, volumes_model_update"}],"source_content_type":"text/x-python","patch_set":2,"id":"ec6ce172_4050e0c9","line":2415,"range":{"start_line":2415,"start_character":12,"end_line":2415,"end_character":53},"in_reply_to":"e3fe723a_d134b490","updated":"2025-06-06 07:36:53.000000000","message":"Thanks for your review Eric, but we need to abandon this review as this is not part of our delivery plan anymore.\n\nAs the owner of this review has left the company and is no longer an openstack contributor, requesting you to please abandon this review on behalf of the core team.","commit_id":"ff0b174e8866d22021aad92d2a7898116139c862"}]}