)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"b6026c7ab7a74238728c87cf5c8e5392b5681cc1","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Felix Huettner \u003cfelix.huettner@mail.schwarz\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-01-27 16:16:55 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Limit number of file for qemu calls"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a followup of [1] handling a potential denial of service"},{"line_number":10,"context_line":"vulnerbility in cinder-volume."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"38ae7e02_4286e8e7","line":7,"updated":"2023-01-30 18:16:08.000000000","message":"Maybe:\n\n\tLimit number of file descriptors for image conversion","commit_id":"7e84186385d14942b82c4a7fdad6f1e24de0c18f"},{"author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"change_message_id":"660631938c302cc2b7e1c119459db267a44cc99c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Felix Huettner \u003cfelix.huettner@mail.schwarz\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-01-27 16:16:55 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Limit number of file for qemu calls"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a followup of [1] handling a potential denial of service"},{"line_number":10,"context_line":"vulnerbility in cinder-volume."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"909c1de3_ef338e45","line":7,"in_reply_to":"38ae7e02_4286e8e7","updated":"2023-01-31 13:40:11.000000000","message":"+1, done","commit_id":"7e84186385d14942b82c4a7fdad6f1e24de0c18f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"b6026c7ab7a74238728c87cf5c8e5392b5681cc1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d15e4bf5_3dd145c8","updated":"2023-01-30 18:16:08.000000000","message":"Since a configuration parameter is being added, a release note is\nrequired.\n","commit_id":"7e84186385d14942b82c4a7fdad6f1e24de0c18f"},{"author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"change_message_id":"660631938c302cc2b7e1c119459db267a44cc99c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"17417ea7_831e8588","updated":"2023-01-31 13:40:11.000000000","message":"thanks","commit_id":"7e84186385d14942b82c4a7fdad6f1e24de0c18f"},{"author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"change_message_id":"660631938c302cc2b7e1c119459db267a44cc99c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"279d75ec_dd425b23","in_reply_to":"d15e4bf5_3dd145c8","updated":"2023-01-31 13:40:11.000000000","message":"ok, done.\n\ni also added the current limitation in there that oslo.rootwrap enforces","commit_id":"7e84186385d14942b82c4a7fdad6f1e24de0c18f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e7109ece474b52e830b8ed08eb1582975ac470fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c71ac55e_86f29b04","updated":"2023-01-31 17:15:47.000000000","message":"Felix, please file this as a separate bug.  Since it\u0027s currently non-exploitable, it can be a public security bug (it\u0027s a \"hardening opportunity\" for cinder).  I think it\u0027s worth tracking separately from the backing file/named extent vulnerability, particularly since the \u0027monolithicFlat\u0027 create-type is blocked by default by the fix for Bug #1196188.  But I think this is a good catch as an illustration of the file handle exhaustion problem, and we should definitely not ignore it.","commit_id":"a41ae92aeffed85720dd865edecbcfee9bee31af"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"46ceac04f82394802716617837c9fffb9783f9db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5fab179b_c2c16dd7","updated":"2023-01-31 18:15:11.000000000","message":"Thanks, these changes address all of my concerns.  I appreciate the\ndetailed commit message and thorough release note information.\n","commit_id":"a41ae92aeffed85720dd865edecbcfee9bee31af"},{"author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"change_message_id":"5afa4de43a5341cb152d660c0b68361521447179","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6fb7dfcf_3c866603","in_reply_to":"c71ac55e_86f29b04","updated":"2023-02-02 13:38:15.000000000","message":"ok, done.\nThe new bug is here: https://bugs.launchpad.net/cinder/+bug/2004565","commit_id":"a41ae92aeffed85720dd865edecbcfee9bee31af"},{"author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"change_message_id":"0ea67add6d0d88b35f61ac2610166d016d227ecc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8e257c7e_73647de0","updated":"2023-02-06 07:30:16.000000000","message":"recheck","commit_id":"16ded6eab19f02b2c25985a49f4792c796c4b579"},{"author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"change_message_id":"80b3173b91c80d31a3abed7fe892c67cc5937fba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cb5e7b18_ee3606c5","updated":"2023-02-06 10:36:36.000000000","message":"recheck some timeout occured","commit_id":"16ded6eab19f02b2c25985a49f4792c796c4b579"}],"cinder/image/image_utils.py":[{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"b6026c7ab7a74238728c87cf5c8e5392b5681cc1","unresolved":true,"context_lines":[{"line_number":75,"context_line":"               help\u003d\u0027Address space limit in gigabytes to convert the image\u0027),"},{"line_number":76,"context_line":"    cfg.IntOpt(\u0027image_conversion_file_descriptor_limit\u0027,"},{"line_number":77,"context_line":"               default\u003d1024,"},{"line_number":78,"context_line":"               help\u003d\u0027Maximum number of files that the image conversion \u0027"},{"line_number":79,"context_line":"               \u0027process can use\u0027),"},{"line_number":80,"context_line":"    cfg.BoolOpt(\u0027image_conversion_disable\u0027,"},{"line_number":81,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ee85eca_e53c9859","line":78,"updated":"2023-01-30 18:16:08.000000000","message":"nit:\n\nFor the sake of consistency with the other options, why not something\nlike:\n\n\t\"Maximum file descriptor limit to convert the image\"","commit_id":"7e84186385d14942b82c4a7fdad6f1e24de0c18f"},{"author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"change_message_id":"660631938c302cc2b7e1c119459db267a44cc99c","unresolved":false,"context_lines":[{"line_number":75,"context_line":"               help\u003d\u0027Address space limit in gigabytes to convert the image\u0027),"},{"line_number":76,"context_line":"    cfg.IntOpt(\u0027image_conversion_file_descriptor_limit\u0027,"},{"line_number":77,"context_line":"               default\u003d1024,"},{"line_number":78,"context_line":"               help\u003d\u0027Maximum number of files that the image conversion \u0027"},{"line_number":79,"context_line":"               \u0027process can use\u0027),"},{"line_number":80,"context_line":"    cfg.BoolOpt(\u0027image_conversion_disable\u0027,"},{"line_number":81,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":2,"id":"8de4af00_f0075534","line":78,"in_reply_to":"3ee85eca_e53c9859","updated":"2023-01-31 13:40:11.000000000","message":"+1, done","commit_id":"7e84186385d14942b82c4a7fdad6f1e24de0c18f"}]}