)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6adc31b9725a30b2fd1bf77bbee1b5da807031b1","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"nvmet: Fix setup methods"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On ghange Icae9802713867fa148bc041c86beb010086dacc9 we changed from"},{"line_number":10,"context_line":"using the nvmet CLI interface to using it as a Python library."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"In that change we incorrectly wrote the ``setup`` methods signature and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"18f14c89_5836650d","line":9,"range":{"start_line":9,"start_character":3,"end_line":9,"end_character":9},"updated":"2023-02-16 15:29:31.000000000","message":"nit: change","commit_id":"d89263711247a912bfce74694cbf888b00239d6e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7e50a7f9b0f4b0a53a2aecc90d18b125ba2e5846","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dc14084d_3b3b5fc3","updated":"2023-02-16 17:09:57.000000000","message":"Code and tests LGTM.  I\u0027m ok merging this with the typo in the commit message.","commit_id":"d89263711247a912bfce74694cbf888b00239d6e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66be682613d10a3b561dbdfd636caeb9089e33f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3908d843_3b4da636","updated":"2023-02-16 15:31:32.000000000","message":"LGTM","commit_id":"d89263711247a912bfce74694cbf888b00239d6e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6adc31b9725a30b2fd1bf77bbee1b5da807031b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e73abf71_1283492b","updated":"2023-02-16 15:29:31.000000000","message":"one question inline","commit_id":"d89263711247a912bfce74694cbf888b00239d6e"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"abe2c453df002a81ede2f108c19df076ec1ee57f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a00b14ab_fb3c8817","updated":"2023-02-07 12:34:06.000000000","message":"recheck - cinder-grenade-mn-sub-volbak failure unrelated to this patch","commit_id":"d89263711247a912bfce74694cbf888b00239d6e"}],"cinder/privsep/targets/nvmet.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6adc31b9725a30b2fd1bf77bbee1b5da807031b1","unresolved":true,"context_lines":[{"line_number":159,"context_line":"    \"\"\"Wrapper for _privsep_setup that accepts err_func argument.\"\"\""},{"line_number":160,"context_line":"    # err_func parameter hardcoded in _privsep_setup as it cannot be serialized"},{"line_number":161,"context_line":"    if \u0027err_func\u0027 in kwargs:"},{"line_number":162,"context_line":"        err_func \u003d kwargs.pop(\u0027err_func\u0027)"},{"line_number":163,"context_line":"    else:  # positional is always last argument of the args tuple"},{"line_number":164,"context_line":"        err_func \u003d args[-1]"},{"line_number":165,"context_line":"        args \u003d args[:-1]"}],"source_content_type":"text/x-python","patch_set":3,"id":"38209568_e1d3e135","line":162,"range":{"start_line":162,"start_character":19,"end_line":162,"end_character":41},"updated":"2023-02-16 15:29:31.000000000","message":"if this value is None (since that\u0027s the default used in setup methods) the err_func call will fail on L#171 right? or am i missing something?","commit_id":"d89263711247a912bfce74694cbf888b00239d6e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66be682613d10a3b561dbdfd636caeb9089e33f4","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    \"\"\"Wrapper for _privsep_setup that accepts err_func argument.\"\"\""},{"line_number":160,"context_line":"    # err_func parameter hardcoded in _privsep_setup as it cannot be serialized"},{"line_number":161,"context_line":"    if \u0027err_func\u0027 in kwargs:"},{"line_number":162,"context_line":"        err_func \u003d kwargs.pop(\u0027err_func\u0027)"},{"line_number":163,"context_line":"    else:  # positional is always last argument of the args tuple"},{"line_number":164,"context_line":"        err_func \u003d args[-1]"},{"line_number":165,"context_line":"        args \u003d args[:-1]"}],"source_content_type":"text/x-python","patch_set":3,"id":"379c411c_e5cc999b","line":162,"range":{"start_line":162,"start_character":19,"end_line":162,"end_character":41},"in_reply_to":"38209568_e1d3e135","updated":"2023-02-16 15:31:32.000000000","message":"Done","commit_id":"d89263711247a912bfce74694cbf888b00239d6e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6adc31b9725a30b2fd1bf77bbee1b5da807031b1","unresolved":true,"context_lines":[{"line_number":168,"context_line":"    except exception.CinderException as exc:"},{"line_number":169,"context_line":"        if not err_func:"},{"line_number":170,"context_line":"            raise"},{"line_number":171,"context_line":"        err_func(exc.msg)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"###################"}],"source_content_type":"text/x-python","patch_set":3,"id":"6e45c597_f05cc016","line":171,"range":{"start_line":171,"start_character":8,"end_line":171,"end_character":16},"updated":"2023-02-16 15:29:31.000000000","message":"related to the above comment, if this is None (err_func\u003dNone), this will fail","commit_id":"d89263711247a912bfce74694cbf888b00239d6e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66be682613d10a3b561dbdfd636caeb9089e33f4","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    except exception.CinderException as exc:"},{"line_number":169,"context_line":"        if not err_func:"},{"line_number":170,"context_line":"            raise"},{"line_number":171,"context_line":"        err_func(exc.msg)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"###################"}],"source_content_type":"text/x-python","patch_set":3,"id":"6b0208d1_f4d528b1","line":171,"range":{"start_line":171,"start_character":8,"end_line":171,"end_character":16},"in_reply_to":"6e45c597_f05cc016","updated":"2023-02-16 15:31:32.000000000","message":"/me feels dumb: Sorry missed the if statement above","commit_id":"d89263711247a912bfce74694cbf888b00239d6e"}]}