)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6f45f2c1bc46590298770e4c13daf74b8c8fe36e","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Eric Harney \u003ceharney@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-04-18 09:28:36 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix NFS cloned volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds code to the _copy_volume_from_snapshot method to enable"},{"line_number":10,"context_line":"cloning of encrypted NFS volumes. Currently, when attempting to clone a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"0a62471c_7fa2eb1e","line":7,"updated":"2025-04-18 13:32:32.000000000","message":"This would be more correctly titled \"NFS: Fix cloning encrypted volumes\".","commit_id":"f0f43d64c0d1ad5297db62224525d0d84e20250d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"3fe1714cac8d701b349a5650a0420edf7b45225e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"026bf369_642fbd36","updated":"2023-01-27 21:52:07.000000000","message":"Needs launchpad bug ","commit_id":"593fba43707306c987d265bb5a0229ef01195c97"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"a7a00054a3adefe869531693e12bd62cf1658a4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5b7d0519_88584405","updated":"2023-02-28 04:48:46.000000000","message":"LGTM","commit_id":"58c91c5ca50a39f87db60141e769580abbcffdea"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"8d53466e1656c4a52ccc4b8759dfa5c493d58ed8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"04a401c1_2fb47332","updated":"2023-02-13 15:37:21.000000000","message":"recheck","commit_id":"58c91c5ca50a39f87db60141e769580abbcffdea"}],"cinder/volume/drivers/nfs.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6015ddbfce8026f09cf87ef1a4718e18d24c97d7","unresolved":true,"context_lines":[{"line_number":654,"context_line":"                            \"Encryption requires qcow2 volumes.\""},{"line_number":655,"context_line":"                            ) % {\u0027format\u0027: out_format}"},{"line_number":656,"context_line":"                LOG.error(message)"},{"line_number":657,"context_line":"                raise exception.NfsException(message)"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"            self._copy_encrypted_volume_from_snapshot(volume,"},{"line_number":660,"context_line":"                                                      out_format,"}],"source_content_type":"text/x-python","patch_set":1,"id":"75ece4cb_6182519e","line":657,"range":{"start_line":657,"start_character":0,"end_line":657,"end_character":1},"updated":"2023-01-30 15:10:00.000000000","message":"Failing here is not necessary -- qcow2 is required for the case when the new volume is encrypted, so just make it be qcow2 instead of failing.","commit_id":"593fba43707306c987d265bb5a0229ef01195c97"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4cbbb6246faf5ed29d0f301cad737baa29aff19b","unresolved":false,"context_lines":[{"line_number":654,"context_line":"                            \"Encryption requires qcow2 volumes.\""},{"line_number":655,"context_line":"                            ) % {\u0027format\u0027: out_format}"},{"line_number":656,"context_line":"                LOG.error(message)"},{"line_number":657,"context_line":"                raise exception.NfsException(message)"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"            self._copy_encrypted_volume_from_snapshot(volume,"},{"line_number":660,"context_line":"                                                      out_format,"}],"source_content_type":"text/x-python","patch_set":1,"id":"15afbf8d_c3a1cee6","line":657,"range":{"start_line":657,"start_character":0,"end_line":657,"end_character":1},"in_reply_to":"75ece4cb_6182519e","updated":"2023-02-09 15:07:42.000000000","message":"Done","commit_id":"593fba43707306c987d265bb5a0229ef01195c97"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"854e54f5d8f0c2da3958171d83b6d9a8716062a1","unresolved":true,"context_lines":[{"line_number":625,"context_line":"        forward_file \u003d snap_info[snapshot.id]"},{"line_number":626,"context_line":"        forward_path \u003d os.path.join(vol_path, forward_file)"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"        volume_name_backed \u003d \"%s-%s\" % (\u0027volume\u0027, snapshot.volume.id)"},{"line_number":629,"context_line":"        backingfile \u003d os.path.join(vol_path, volume_name_backed)"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"        # Find the file which backs this file, which represents the point"}],"source_content_type":"text/x-python","patch_set":5,"id":"cc405f09_592aef09","line":628,"range":{"start_line":628,"start_character":29,"end_line":628,"end_character":36},"updated":"2023-02-07 17:15:44.000000000","message":"Don\u0027t need two %s for this.","commit_id":"03e53dab84ae58661cd0d8df2869c0f484fc140f"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4cbbb6246faf5ed29d0f301cad737baa29aff19b","unresolved":false,"context_lines":[{"line_number":625,"context_line":"        forward_file \u003d snap_info[snapshot.id]"},{"line_number":626,"context_line":"        forward_path \u003d os.path.join(vol_path, forward_file)"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"        volume_name_backed \u003d \"%s-%s\" % (\u0027volume\u0027, snapshot.volume.id)"},{"line_number":629,"context_line":"        backingfile \u003d os.path.join(vol_path, volume_name_backed)"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"        # Find the file which backs this file, which represents the point"}],"source_content_type":"text/x-python","patch_set":5,"id":"a2d8c4b5_47f0c017","line":628,"range":{"start_line":628,"start_character":29,"end_line":628,"end_character":36},"in_reply_to":"cc405f09_592aef09","updated":"2023-02-09 15:07:42.000000000","message":"Done","commit_id":"03e53dab84ae58661cd0d8df2869c0f484fc140f"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8019f7fd477805e31a16abacc51d53ccb0e73086","unresolved":true,"context_lines":[{"line_number":651,"context_line":"                # TODO(enriquetaso): handle unencrypted snap-\u003eencrypted vol"},{"line_number":652,"context_line":"                raise exception.NfsException(message)"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"            out_format \u003d\u003d \u0027qcow2\u0027"},{"line_number":655,"context_line":"            self._copy_encrypted_volume_from_snapshot(volume,"},{"line_number":656,"context_line":"                                                      src_encryption_key_id,"},{"line_number":657,"context_line":"                                                      new_encryption_key_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"20c887a3_eae0904a","line":654,"range":{"start_line":654,"start_character":23,"end_line":654,"end_character":25},"updated":"2023-02-07 17:04:30.000000000","message":"Something is off here.","commit_id":"03e53dab84ae58661cd0d8df2869c0f484fc140f"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4cbbb6246faf5ed29d0f301cad737baa29aff19b","unresolved":false,"context_lines":[{"line_number":651,"context_line":"                # TODO(enriquetaso): handle unencrypted snap-\u003eencrypted vol"},{"line_number":652,"context_line":"                raise exception.NfsException(message)"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"            out_format \u003d\u003d \u0027qcow2\u0027"},{"line_number":655,"context_line":"            self._copy_encrypted_volume_from_snapshot(volume,"},{"line_number":656,"context_line":"                                                      src_encryption_key_id,"},{"line_number":657,"context_line":"                                                      new_encryption_key_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"25aa07c5_cc2c35a6","line":654,"range":{"start_line":654,"start_character":23,"end_line":654,"end_character":25},"in_reply_to":"20c887a3_eae0904a","updated":"2023-02-09 15:07:42.000000000","message":"Done","commit_id":"03e53dab84ae58661cd0d8df2869c0f484fc140f"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"46ce602b004ae8e594973d9aef6e6d5f1f6c2ad4","unresolved":true,"context_lines":[{"line_number":642,"context_line":""},{"line_number":643,"context_line":"        # Find the path to the active layer"},{"line_number":644,"context_line":"        forward_file \u003d snap_info[snapshot.id]"},{"line_number":645,"context_line":"        snapshot_img_forward_path \u003d os.path.join(dir_path, forward_file)"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"        # Find the path to the backing file"},{"line_number":648,"context_line":"        img_info \u003d self._qemu_img_info(snapshot_img_forward_path,"}],"source_content_type":"text/x-python","patch_set":7,"id":"554319e2_7b4e22f4","line":645,"updated":"2023-02-23 16:28:14.000000000","message":"What if the dir_path does not exist ?? was it handled anywhere ?","commit_id":"58c91c5ca50a39f87db60141e769580abbcffdea"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"9b1c9f4fe8866fce000fbe7083972ad25268c2e8","unresolved":true,"context_lines":[{"line_number":642,"context_line":""},{"line_number":643,"context_line":"        # Find the path to the active layer"},{"line_number":644,"context_line":"        forward_file \u003d snap_info[snapshot.id]"},{"line_number":645,"context_line":"        snapshot_img_forward_path \u003d os.path.join(dir_path, forward_file)"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"        # Find the path to the backing file"},{"line_number":648,"context_line":"        img_info \u003d self._qemu_img_info(snapshot_img_forward_path,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ec97af3a_80b3ba9c","line":645,"in_reply_to":"554319e2_7b4e22f4","updated":"2023-02-27 14:07:51.000000000","message":"It should exist because we are already manipulating files in that directory and it was mounted before we got here.\n\nIf it no longer exists (i.e. something unmounted/deleted it halfway through this operation), the qemu_img_info operation below will throw an exception and be handled fine.","commit_id":"58c91c5ca50a39f87db60141e769580abbcffdea"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"a7a00054a3adefe869531693e12bd62cf1658a4b","unresolved":true,"context_lines":[{"line_number":642,"context_line":""},{"line_number":643,"context_line":"        # Find the path to the active layer"},{"line_number":644,"context_line":"        forward_file \u003d snap_info[snapshot.id]"},{"line_number":645,"context_line":"        snapshot_img_forward_path \u003d os.path.join(dir_path, forward_file)"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"        # Find the path to the backing file"},{"line_number":648,"context_line":"        img_info \u003d self._qemu_img_info(snapshot_img_forward_path,"}],"source_content_type":"text/x-python","patch_set":7,"id":"f4962435_6e8217e6","line":645,"in_reply_to":"ec97af3a_80b3ba9c","updated":"2023-02-28 04:48:46.000000000","message":"ok , if its already handled then fine","commit_id":"58c91c5ca50a39f87db60141e769580abbcffdea"}]}