)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"19f94a157cc90401ccb399eb98a92b3a4f6403e5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"200186a7_cc8f1632","line":40,"updated":"2023-02-16 16:18:01.000000000","message":"nit: it\u0027s traditional to put the conflict info down here (you did the cherry pick first, and then had to resolve a conflict).  It\u0027s also helpful to say which file(s) the conflict was in.  The reason is that when you have as many open branches as cinder does, it can help you troubleshooting a regression that shows up in a branch because you have an easy way to see where the patch has been modified as it\u0027s been backported.  You can see an extreme version of this here:\n\nhttps://review.opendev.org/c/openstack/cinder/+/871631/1//COMMIT_MSG","commit_id":"e8abcc8e1dc34c09a3bcd3fc638c51b29acf297a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e5c2bb6b18da589107a0ff9be80539efba4f075e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"eb1dd646_987ec30f","line":40,"in_reply_to":"200186a7_cc8f1632","updated":"2023-02-16 17:36:14.000000000","message":"Although the example used[1] in the Conflicts section of stable branch documentation[2] doesn\u0027t follow this convention, I agree that this is more readable and Cinder does follow it across it\u0027s backports.\n\nAnother thing is that we should always mention files that have the conflict.\nSo you will have to make the file change, better to use this opportunity to move the conflict lines here.\n\n[1] https://review.opendev.org/c/openstack/nova/+/686292/\n[2] https://docs.openstack.org/project-team-guide/stable-branches.html#conflicts","commit_id":"e8abcc8e1dc34c09a3bcd3fc638c51b29acf297a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6f330732c7c700a9b1b78641d0d33bdc8329281b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"58d6f55f_19513508","line":40,"in_reply_to":"eb1dd646_987ec30f","updated":"2023-02-21 16:04:05.000000000","message":"Done","commit_id":"e8abcc8e1dc34c09a3bcd3fc638c51b29acf297a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"19f94a157cc90401ccb399eb98a92b3a4f6403e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1c8cfb04_9a695ece","updated":"2023-02-16 16:18:01.000000000","message":"Definitely worth backporting.  Only a +1 while I\u0027m thinking about whether the nit i pointed out on the commit message is something that needs to be revised.  Let\u0027s see what other reviewers think.","commit_id":"e8abcc8e1dc34c09a3bcd3fc638c51b29acf297a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e5c2bb6b18da589107a0ff9be80539efba4f075e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"63bb7ce7_acea653f","updated":"2023-02-16 17:36:14.000000000","message":"See my comment inline.","commit_id":"e8abcc8e1dc34c09a3bcd3fc638c51b29acf297a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"2f5ebb43e85d5d0dc494bb48d969e41503324358","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6a1a59a6_b44f1fb9","updated":"2023-02-15 13:39:02.000000000","message":"recheck","commit_id":"e8abcc8e1dc34c09a3bcd3fc638c51b29acf297a"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"736073dd8f799ed93b3af303f431370e19d37813","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bdc37997_f44dc1ce","updated":"2023-02-17 18:58:10.000000000","message":"Properly backported.  Looks good.","commit_id":"6fd041cf21938c2e4eac1d1afc76adb5a04e3c33"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"da498233c52cfedc874e36dc237612e457b9e4ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b6bc10b9_5fcf4088","updated":"2023-02-21 16:26:51.000000000","message":"Good backport.","commit_id":"f2faf7d70f5cd3ace461d9de9fdfe448d78a0107"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6f330732c7c700a9b1b78641d0d33bdc8329281b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4dad6eb8_3948a656","updated":"2023-02-21 16:04:05.000000000","message":"Thanks for the update. LGTM.","commit_id":"f2faf7d70f5cd3ace461d9de9fdfe448d78a0107"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"80383e2e038ad5f52e3694c64ef118332e54383e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"db7b0635_9be2c11b","updated":"2023-02-22 12:22:54.000000000","message":"recheck","commit_id":"f2faf7d70f5cd3ace461d9de9fdfe448d78a0107"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"29473aebebb0e6d5f8a948c2dd01a61cde5b265e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2a86c68e_07b295ab","updated":"2023-02-22 22:38:53.000000000","message":"recheck tempest-integrated-storage timed out, not related to this patch","commit_id":"f2faf7d70f5cd3ace461d9de9fdfe448d78a0107"}]}