)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"fbd521472bec4951559163ad1ddb68a777fdd27c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f4f2529a_d2c13320","updated":"2023-03-13 22:00:53.000000000","message":"Looks obvious enough to me.","commit_id":"4b7da146c201d02e89634cacc29f17bf4528368b"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3393cb77e892cd244ce516c64f57c40d638f1194","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"71e97515_90b2e944","updated":"2023-02-09 19:41:55.000000000","message":"Setting +RP since this could have significant stability/security impact.","commit_id":"4b7da146c201d02e89634cacc29f17bf4528368b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"eaf294fa69919a996f705d97454edf536eab28ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4731536e_0c64a115","updated":"2023-03-02 08:17:17.000000000","message":"changes look good, one comment inline.","commit_id":"4b7da146c201d02e89634cacc29f17bf4528368b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"028a6f16440cb0bf3bac45fd37cbfd9d5b2952c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"05ea77bb_f947d175","updated":"2025-04-13 16:16:09.000000000","message":"LGTM except that this missed the epoxy release, so the \u0027deprecated_since\u0027 strings will need to be updated.  Raising the priority because this patch was discussed at the Flamingo PTG.","commit_id":"9c7542d578d450500f329cfdb80f9b4fa8582a46"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"60867069037b5c174c89688596b0cbc6cfa35fe0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"78c05809_314b1b9e","updated":"2025-04-14 10:11:49.000000000","message":"@rosmaita.fossdev@gmail.com I updated deprecation time frame related strings.","commit_id":"63c2d1e14f66f6cb6e769527532476f99bb7a045"}],"cinder/image/image_utils.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"eaf294fa69919a996f705d97454edf536eab28ca","unresolved":true,"context_lines":[{"line_number":67,"context_line":"                default\u003dTrue,"},{"line_number":68,"context_line":"                help\u003d\u0027When possible, compress images uploaded \u0027"},{"line_number":69,"context_line":"                \u0027to the image service\u0027),"},{"line_number":70,"context_line":"    cfg.IntOpt(\u0027image_conversion_cpu_limit\u0027,"},{"line_number":71,"context_line":"               default\u003d60,"},{"line_number":72,"context_line":"               help\u003d\u0027CPU time limit in seconds to introspect the image\u0027),"},{"line_number":73,"context_line":"    cfg.IntOpt(\u0027image_conversion_address_space_limit\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac9c009_4642180f","line":70,"range":{"start_line":70,"start_character":16,"end_line":70,"end_character":42},"updated":"2023-03-02 08:17:17.000000000","message":"would be good to update these config options and deprecate the old ones as they\u0027re misleading here, the new options could be,\n\nimage_introspect_cpu_limit\nimage_introspect_address_space_limit","commit_id":"4b7da146c201d02e89634cacc29f17bf4528368b"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"db4dd9286e11e958c1520d3503737ba13c3d1a42","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                default\u003dTrue,"},{"line_number":68,"context_line":"                help\u003d\u0027When possible, compress images uploaded \u0027"},{"line_number":69,"context_line":"                \u0027to the image service\u0027),"},{"line_number":70,"context_line":"    cfg.IntOpt(\u0027image_conversion_cpu_limit\u0027,"},{"line_number":71,"context_line":"               default\u003d60,"},{"line_number":72,"context_line":"               help\u003d\u0027CPU time limit in seconds to introspect the image\u0027),"},{"line_number":73,"context_line":"    cfg.IntOpt(\u0027image_conversion_address_space_limit\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"f4465d9e_41c46a12","line":70,"range":{"start_line":70,"start_character":16,"end_line":70,"end_character":42},"in_reply_to":"3ac9c009_4642180f","updated":"2024-12-19 14:42:16.000000000","message":"Done","commit_id":"4b7da146c201d02e89634cacc29f17bf4528368b"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"bae57718c63349d88eb81ae3c83e0236bbccd35d","unresolved":true,"context_lines":[{"line_number":154,"context_line":"    return QEMU_IMG_FORMAT_MAP_INV.get(disk_format, disk_format)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"def qemu_limits():"},{"line_number":158,"context_line":"    return processutils.ProcessLimits("},{"line_number":159,"context_line":"        cpu_time\u003dCONF.image_conversion_cpu_limit,"},{"line_number":160,"context_line":"        address_space\u003dCONF.image_conversion_address_space_limit * units.Gi)"}],"source_content_type":"text/x-python","patch_set":3,"id":"a4eb71c7_c15da0be","line":157,"updated":"2024-11-04 21:04:52.000000000","message":"Probably better to make this a singleton rather than creating a new object each time.","commit_id":"4b7da146c201d02e89634cacc29f17bf4528368b"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"db4dd9286e11e958c1520d3503737ba13c3d1a42","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    return QEMU_IMG_FORMAT_MAP_INV.get(disk_format, disk_format)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"def qemu_limits():"},{"line_number":158,"context_line":"    return processutils.ProcessLimits("},{"line_number":159,"context_line":"        cpu_time\u003dCONF.image_conversion_cpu_limit,"},{"line_number":160,"context_line":"        address_space\u003dCONF.image_conversion_address_space_limit * units.Gi)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9e072f62_f29f015d","line":157,"in_reply_to":"a4eb71c7_c15da0be","updated":"2024-12-19 14:42:16.000000000","message":"Done","commit_id":"4b7da146c201d02e89634cacc29f17bf4528368b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"028a6f16440cb0bf3bac45fd37cbfd9d5b2952c6","unresolved":true,"context_lines":[{"line_number":68,"context_line":"                \u0027to the image service\u0027),"},{"line_number":69,"context_line":"    cfg.IntOpt(\u0027image_conversion_cpu_limit\u0027,"},{"line_number":70,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":71,"context_line":"               deprecated_since\u003d\"2025.1/Epoxy\","},{"line_number":72,"context_line":"               deprecated_reason\u003d\"Renamed to \u0027image_introspection_cpu_limit\u0027\","},{"line_number":73,"context_line":"               default\u003d60,"},{"line_number":74,"context_line":"               help\u003d\u0027CPU time limit in seconds to convert the image\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"0b9b9c74_a6d8b734","line":71,"range":{"start_line":71,"start_character":33,"end_line":71,"end_character":45},"updated":"2025-04-13 16:16:09.000000000","message":"This will have to change to 2025.2/Flamingo.  We won\u0027t be able to remove the old opt names until 2026.2/H (so that a deprecation notice will appear in the sample config for the next SLURP release, which is 2026.1).  Because that is a long time off, when you update the \u0027deprecated since\u0027, please add a TODO comment after line 68 reminding us to remove the opts in 2026.2.","commit_id":"9c7542d578d450500f329cfdb80f9b4fa8582a46"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"60867069037b5c174c89688596b0cbc6cfa35fe0","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                \u0027to the image service\u0027),"},{"line_number":69,"context_line":"    cfg.IntOpt(\u0027image_conversion_cpu_limit\u0027,"},{"line_number":70,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":71,"context_line":"               deprecated_since\u003d\"2025.1/Epoxy\","},{"line_number":72,"context_line":"               deprecated_reason\u003d\"Renamed to \u0027image_introspection_cpu_limit\u0027\","},{"line_number":73,"context_line":"               default\u003d60,"},{"line_number":74,"context_line":"               help\u003d\u0027CPU time limit in seconds to convert the image\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"4b963934_c871a9ee","line":71,"range":{"start_line":71,"start_character":33,"end_line":71,"end_character":45},"in_reply_to":"0b9b9c74_a6d8b734","updated":"2025-04-14 10:11:49.000000000","message":"Done","commit_id":"9c7542d578d450500f329cfdb80f9b4fa8582a46"}],"cinder/tests/unit/test_image_utils.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"fbd521472bec4951559163ad1ddb68a777fdd27c","unresolved":true,"context_lines":[{"line_number":37,"context_line":"        limits \u003d image_utils.qemu_limits()"},{"line_number":38,"context_line":"        self.assertIsInstance(limits, processutils.ProcessLimits)"},{"line_number":39,"context_line":"        self.assertEqual(0, limits.cpu_time)"},{"line_number":40,"context_line":"        self.assertEqual(0, limits.address_space)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @mock.patch(\u0027os.name\u0027, new\u003d\u0027posix\u0027)"},{"line_number":43,"context_line":"    @mock.patch.object(image_utils, \"qemu_limits\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"556bd321_6de59ff4","line":40,"updated":"2023-03-13 22:00:53.000000000","message":"You know, it you used some other value, the multiplier would\u0027ve been evident too.","commit_id":"4b7da146c201d02e89634cacc29f17bf4528368b"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"db4dd9286e11e958c1520d3503737ba13c3d1a42","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        limits \u003d image_utils.qemu_limits()"},{"line_number":38,"context_line":"        self.assertIsInstance(limits, processutils.ProcessLimits)"},{"line_number":39,"context_line":"        self.assertEqual(0, limits.cpu_time)"},{"line_number":40,"context_line":"        self.assertEqual(0, limits.address_space)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @mock.patch(\u0027os.name\u0027, new\u003d\u0027posix\u0027)"},{"line_number":43,"context_line":"    @mock.patch.object(image_utils, \"qemu_limits\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"362e3319_9de177ac","line":40,"in_reply_to":"556bd321_6de59ff4","updated":"2024-12-19 14:42:16.000000000","message":"Done","commit_id":"4b7da146c201d02e89634cacc29f17bf4528368b"}]}