)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"db9a9f70bbb7b74eb03d7687c7219addbf41342e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"921d6434_b343b749","updated":"2023-02-22 12:28:04.000000000","message":"Code looks good to me.\n\n:-1: Please add unittest to catch know this issue in the future. ","commit_id":"dcafb8c28160a5883a04342d5a2b12cd026b6255"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"401d6112baf47a74ab8c857c52aa3a0f49cb2859","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2be4fe65_104435af","updated":"2023-02-17 11:35:41.000000000","message":"logic seems correct lgtm","commit_id":"dcafb8c28160a5883a04342d5a2b12cd026b6255"},{"author":{"_account_id":33436,"name":"YuehuiLei","display_name":"leiyuehui","email":"leiyuehui-s@inspur.com","username":"leiyuehui"},"change_message_id":"6aaa067617390699c02110f6fa850fa94d4d0433","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"af16fb9b_71942828","in_reply_to":"921d6434_b343b749","updated":"2023-07-17 05:52:13.000000000","message":"Done","commit_id":"dcafb8c28160a5883a04342d5a2b12cd026b6255"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"8887dcc272a761c69e309708a6209fb5f9e1aa4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"36ae1165_9aa3ff4d","updated":"2023-05-24 05:54:03.000000000","message":"Code and UT look good. Zuul also passed.","commit_id":"cfeed78749c9b88e97f5a29e0750235a52266dd1"}],"cinder/scheduler/manager.py":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"db9a9f70bbb7b74eb03d7687c7219addbf41342e","unresolved":true,"context_lines":[{"line_number":644,"context_line":"                backup.save()"},{"line_number":645,"context_line":"            self.backup_api.create_backup(context, backup)"},{"line_number":646,"context_line":"        except exception.ServiceNotFound:"},{"line_number":647,"context_line":"            if not backup.snapshot_id:"},{"line_number":648,"context_line":"                self.db.volume_update(context, volume_id,"},{"line_number":649,"context_line":"                                      {\u0027status\u0027: volume[\u0027previous_status\u0027],"},{"line_number":650,"context_line":"                                       \u0027previous_status\u0027: volume[\u0027status\u0027]})"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fea7a8b_e0abc6af","line":647,"updated":"2023-02-22 12:28:04.000000000","message":"one questions, what happens if the backup has snapshot_id? Will volume status stay in `backing-up` status because is the current status? I guess it\u0027s better than `None`.","commit_id":"dcafb8c28160a5883a04342d5a2b12cd026b6255"},{"author":{"_account_id":33436,"name":"YuehuiLei","display_name":"leiyuehui","email":"leiyuehui-s@inspur.com","username":"leiyuehui"},"change_message_id":"bf72715fc03268f47856152b02ecc90d97a8d678","unresolved":true,"context_lines":[{"line_number":644,"context_line":"                backup.save()"},{"line_number":645,"context_line":"            self.backup_api.create_backup(context, backup)"},{"line_number":646,"context_line":"        except exception.ServiceNotFound:"},{"line_number":647,"context_line":"            if not backup.snapshot_id:"},{"line_number":648,"context_line":"                self.db.volume_update(context, volume_id,"},{"line_number":649,"context_line":"                                      {\u0027status\u0027: volume[\u0027previous_status\u0027],"},{"line_number":650,"context_line":"                                       \u0027previous_status\u0027: volume[\u0027status\u0027]})"}],"source_content_type":"text/x-python","patch_set":1,"id":"b1a9827a_08f36f6a","line":647,"in_reply_to":"5fea7a8b_e0abc6af","updated":"2023-02-23 07:09:22.000000000","message":"Thanks, if a backup has snapshot_id, the volume status will not be changed, and the snapshot status will change to backing-up.Now, after an exception occurs, the volume status will be set to None,it is bug.","commit_id":"dcafb8c28160a5883a04342d5a2b12cd026b6255"},{"author":{"_account_id":33436,"name":"YuehuiLei","display_name":"leiyuehui","email":"leiyuehui-s@inspur.com","username":"leiyuehui"},"change_message_id":"eafb7833c7667ad183c910d0b38ad51cec46af7f","unresolved":false,"context_lines":[{"line_number":644,"context_line":"                backup.save()"},{"line_number":645,"context_line":"            self.backup_api.create_backup(context, backup)"},{"line_number":646,"context_line":"        except exception.ServiceNotFound:"},{"line_number":647,"context_line":"            if not backup.snapshot_id:"},{"line_number":648,"context_line":"                self.db.volume_update(context, volume_id,"},{"line_number":649,"context_line":"                                      {\u0027status\u0027: volume[\u0027previous_status\u0027],"},{"line_number":650,"context_line":"                                       \u0027previous_status\u0027: volume[\u0027status\u0027]})"}],"source_content_type":"text/x-python","patch_set":1,"id":"420cc669_6d1ba8d7","line":647,"in_reply_to":"b1a9827a_08f36f6a","updated":"2023-02-23 07:10:13.000000000","message":"Done","commit_id":"dcafb8c28160a5883a04342d5a2b12cd026b6255"}]}