)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"7157324c0016978e506ea2d46535e3c519c2cf6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cec21141_3a9c2589","updated":"2023-02-22 14:44:13.000000000","message":"\u003e Patch Set 1:\n\u003e \n\u003e Build failed.\n\u003e \n\u003e - pure-devstack-cinder-tempest-iscsi-aio http://openstack-logs.purestorage.com/90/874690/1/thirdparty-check/pure-devstack-cinder-tempest-iscsi-aio/105172a/ : SUCCESS in 1h 50m 13s\n\u003e - pure-devstack-cinder-tempest-fc-aio http://openstack-logs.purestorage.com/90/874690/1/thirdparty-check/pure-devstack-cinder-tempest-fc-aio/e6e36d5/ : FAILURE in 2h 18m 06s (non-voting)\n\u003e - pure-devstack-cinder-tempest-nvme-roce-aio pure-devstack-cinder-tempest-nvme-roce-aio : NODE_FAILURE in 0s\n\u003e - pure-devstack-cinder-tempest-iscsi-aio-jammy http://openstack-logs.purestorage.com/90/874690/1/thirdparty-check/pure-devstack-cinder-tempest-iscsi-aio-jammy/bf27eb2/ : SUCCESS in 2h 06m 29s (non-voting)\n\u003e - pure-devstack-cinder-tempest-nvme-roce-aio-jammy http://openstack-logs.purestorage.com/90/874690/1/thirdparty-check/pure-devstack-cinder-tempest-nvme-roce-aio-jammy/97d9dd2/ : FAILURE in 2h 19m 41s (non-voting)\n\nrun Pure Storage CI","commit_id":"02be1aa0be65294dbc1097a31b4b9706a3ef64e6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"c3d23ebbdeac97417e6462bb06fda808ea12643e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"781165a6_2bb620c6","updated":"2023-03-07 14:04:54.000000000","message":"As there is no way to make tempest test LUN IDs \u003e 255 this patch and the associated os-brick patch have been extensively tested with the iSCSI and FC drivers, where is was possible to manually force LUN IDs on the backend storage.\nThe combined patches work as expected in master. ","commit_id":"02be1aa0be65294dbc1097a31b4b9706a3ef64e6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"5e942cd061e86af784292ab59dd9b0f2217d5a7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e219615b_9963f1c7","updated":"2023-03-07 14:02:04.000000000","message":"recheck","commit_id":"02be1aa0be65294dbc1097a31b4b9706a3ef64e6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"7d79d2ac243b5d160664dd307183559352a9733f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"477994c9_a6a05c3e","updated":"2023-02-22 14:45:03.000000000","message":"run Pure Storage CI","commit_id":"02be1aa0be65294dbc1097a31b4b9706a3ef64e6"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"98fb8889121025446d72e33a133d9236b96485e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"48ca689c_b07a194c","updated":"2023-02-22 10:12:31.000000000","message":"run Pure Storage CI","commit_id":"02be1aa0be65294dbc1097a31b4b9706a3ef64e6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"f8a5ed3a274a7ee0f885544c8c76151d275af98a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f1c01f19_1aa456bb","updated":"2023-02-22 21:21:53.000000000","message":"run Pure Storage CI","commit_id":"02be1aa0be65294dbc1097a31b4b9706a3ef64e6"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"22b92ba62e9be8a1db6c4c0bb61d79cba920f216","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c5f8b023_1e4e3632","updated":"2023-09-15 14:45:14.000000000","message":"Code change looks fine, but I think it would be better to use the os_brick.constants for the field value.","commit_id":"ca587487e4f54b26469ce811fe06813b8bb9a7ac"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"9f10cc701897c7576637130e13b07591f40bdc83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"014d2497_6ea56da5","updated":"2023-09-15 14:52:11.000000000","message":"Looks good to me - thank you!","commit_id":"ca587487e4f54b26469ce811fe06813b8bb9a7ac"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2e0167c6c1414100508620a97d440bdef540bec4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e2a6178d_37b825d6","updated":"2023-09-14 14:17:55.000000000","message":"os-brick change merged, Pure CI is passing. LGTM.","commit_id":"ca587487e4f54b26469ce811fe06813b8bb9a7ac"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"cad98bafc31b5b0dbe2fc18c65922dc7a7347453","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c204ba02_86d00870","updated":"2023-07-27 17:04:14.000000000","message":"recheck","commit_id":"ca587487e4f54b26469ce811fe06813b8bb9a7ac"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"dcc9cced6317cf7328800f682c397101180813f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"deaf293f_8d49364b","updated":"2023-08-23 12:35:34.000000000","message":"recheck","commit_id":"ca587487e4f54b26469ce811fe06813b8bb9a7ac"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"69c8f18b4432ae0f1d1cdf37c28f8d3f3a20b362","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9c29468c_87e383ba","in_reply_to":"c5f8b023_1e4e3632","updated":"2023-09-15 17:21:10.000000000","message":"Done","commit_id":"ca587487e4f54b26469ce811fe06813b8bb9a7ac"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"36345f6bc603fe0be9636f2ece6a43ced7011d2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c80d1ffd_4ce9cb06","updated":"2023-09-15 23:32:54.000000000","message":"My concerns have been addressed.  Carrying over Rajat\u0027s +2 as the only change is using symbolic constants instead of literal strings, there has been no change in logic.","commit_id":"dad485ea665271be66beca750025e3def2a9dc05"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"612ef8b77d2532fad18a215f48f4786d7c8915bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4e45215f_ceef9368","updated":"2023-09-15 19:54:11.000000000","message":"recheck","commit_id":"dad485ea665271be66beca750025e3def2a9dc05"}],"cinder/volume/drivers/pure.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"22b92ba62e9be8a1db6c4c0bb61d79cba920f216","unresolved":true,"context_lines":[{"line_number":3097,"context_line":"                \"target_wwns\": target_wwns,"},{"line_number":3098,"context_line":"                \"initiator_target_map\": init_targ_map,"},{"line_number":3099,"context_line":"                \"discard\": True,"},{"line_number":3100,"context_line":"                \"addressing_mode\": \"SAM2\","},{"line_number":3101,"context_line":"            }"},{"line_number":3102,"context_line":"        }"},{"line_number":3103,"context_line":"        properties[\"data\"][\"wwn\"] \u003d self._get_wwn(pure_vol_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"49cac586_e39c2dff","line":3100,"range":{"start_line":3100,"start_character":35,"end_line":3100,"end_character":41},"updated":"2023-09-15 14:45:14.000000000","message":"I hate to do this to you, but I really think you should use os_brick.constants.SCSI_ADDRESSING_SAM2 here and above, particularly because the commit message uses the alternative language of \"SAM-2\" (which is a perfectly legitimate way to refer to it, it\u0027s just that we don\u0027t want to have to deal with the variants like you have had to do with the storage protocols).","commit_id":"ca587487e4f54b26469ce811fe06813b8bb9a7ac"}],"releasenotes/notes/pure-report-addressing-91963e29fbed32a4.yaml":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2e0167c6c1414100508620a97d440bdef540bec4","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Pure iSCSI \u0026 FC driver `bug #2006960"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2006960\u003e`_: Fixed attaching LUNs"},{"line_number":6,"context_line":"    greater than 255.  Driver leverages new os-brick functionality to specify"},{"line_number":7,"context_line":"    LUN addressing mode."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"542532b1_233cd352","line":6,"updated":"2023-09-14 14:17:55.000000000","message":"nit: having value greater than 255","commit_id":"ca587487e4f54b26469ce811fe06813b8bb9a7ac"}]}