)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ef5ffaa9c7ac543514e86091b6a786d995b7aa2f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rajat Dhasmana \u003crajatdhasmana@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-03-06 08:58:59 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove multiatttach request parameter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The initial cinder design[1][2][3] allowed users to create mutliattach"},{"line_number":10,"context_line":"volumes by spcifying the ``multiattach`` parameter in the request"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7009e117_2680231f","line":7,"updated":"2023-03-07 10:48:02.000000000","message":"Awesome commit message, thanks.","commit_id":"32f1145b7ddf9a9a359e2359e7db63dbdd00b899"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"75399b855ed8a838ff1fd064e0510f108c5e18ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cbc37fb6_5bb633e0","updated":"2023-02-23 19:09:20.000000000","message":"The deprecation is change I00615495a6ed98a996135192ed41719b2b00d936 in Rocky, so I think people have had sufficient warning!","commit_id":"2fbf5850bad3ee794b55804922982dd45691e6ae"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"084418eec27fc63554c4a956bbe81d0aafbcbff4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e4b3fe92_d8952493","updated":"2023-02-23 10:02:29.000000000","message":"checking how gate reacts to this change","commit_id":"2fbf5850bad3ee794b55804922982dd45691e6ae"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6fbca33c32c0b1529d0762433071348c9e909fa7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1937478e_45f986f1","updated":"2023-02-28 10:05:00.000000000","message":"recheck dependent patch passed CI","commit_id":"ca41bca9e313e6e306a416c679d6e026e25495a3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4b859ef8db8644a2a96795f491942539443a4ffc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fff470ea_4fe1bdc6","updated":"2023-02-28 14:22:28.000000000","message":"recheck failure in devstack-plugin-nfs-tempest-full looks unrelated","commit_id":"ca41bca9e313e6e306a416c679d6e026e25495a3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"587f7f02b9cdf5b48186d003a9f7d61cb778eec0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d82f3534_9a938aaa","updated":"2023-03-03 23:36:42.000000000","message":"This looks good to me.  Thanks for getting this bug fixed so quickly.  A few things noted inline that could be fixed in master later (don\u0027t need to be in Antelope).  A suggestion for revising the release note, but that could be a followup too, unless another review notices something that requires respinning this patch.","commit_id":"d70da12f0f92f4ca3fc2105d605445f2b2a54881"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b26cd96629471d8b04e6c67faea273f4f084dbdc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f198a5d9_c1647aa6","updated":"2023-03-03 14:19:01.000000000","message":"recheck grenade - looks like the job never got fully set up","commit_id":"d70da12f0f92f4ca3fc2105d605445f2b2a54881"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f6adb5cdfeec593710e7b012998ad76535534034","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1c4a7d9b_c49ec69e","updated":"2023-03-03 16:42:30.000000000","message":"recheck multiple jobs failure","commit_id":"d70da12f0f92f4ca3fc2105d605445f2b2a54881"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6c7ec9eae74f0ba34afa4355963e8bb3194ac334","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"aa06bc90_6914ea0f","updated":"2023-03-03 21:52:40.000000000","message":"recheck tempest-slow-py3 - timeout during scenario tests","commit_id":"d70da12f0f92f4ca3fc2105d605445f2b2a54881"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"5db26b89b13fcb7c8ae9f94e0d7bb5d13edf0290","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"13e5853d_ea1433a4","updated":"2023-03-13 03:37:27.000000000","message":"I can see the tempest test failure in cinder-grenade-mn-sub-volbak job.\nI\u0027m not sure why this timeout error happened yet.\n\nhttps://zuul.opendev.org/t/openstack/build/68c9b3c80e66415c937fa8678d276c42/log/job-output.txt#32459\n\n~~~\n2023-03-08 14:17:16.596438 | controller | {0} tempest.api.compute.security_groups.test_security_group_rules.SecurityGroupRulesTestJSON.test_security_group_rules_list [60.285624s] ... FAILED\n~~~\n\nHere is the rest of the traceback.\nhttps://paste.openstack.org/show/819106/","commit_id":"32f1145b7ddf9a9a359e2359e7db63dbdd00b899"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d5587589e54e47cada8b15bd78b1e1fb089a7165","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a5b688f6_c4540d33","updated":"2023-03-08 13:11:29.000000000","message":"Just realized that the tempest dependency has not merged, that\u0027s what\u0027s holding this up.","commit_id":"32f1145b7ddf9a9a359e2359e7db63dbdd00b899"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"d209f7c8c5d461347c3d9a36630d7f6c5cbb6c63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"161d2966_4b6688dc","updated":"2023-03-07 09:36:20.000000000","message":"LGTM","commit_id":"32f1145b7ddf9a9a359e2359e7db63dbdd00b899"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ef5ffaa9c7ac543514e86091b6a786d995b7aa2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d610fb0c_5fff89d0","updated":"2023-03-07 10:48:02.000000000","message":"Looks good except for a copule of nits, but these are not important enough to block RC1.","commit_id":"32f1145b7ddf9a9a359e2359e7db63dbdd00b899"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"011a0e38477d9280ed28c51f516050868b42e893","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"aca77ef2_9062dd95","updated":"2023-03-06 13:18:45.000000000","message":"Revisions LGTM.","commit_id":"32f1145b7ddf9a9a359e2359e7db63dbdd00b899"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5c69f4ba81660d6b4e72205dcae22af5025a0768","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c43cf210_eb2788a8","updated":"2023-03-06 09:00:11.000000000","message":"Thanks Brian for the review. The releasenote change was very useful so updated here instead of a followup.","commit_id":"32f1145b7ddf9a9a359e2359e7db63dbdd00b899"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a42ba6288fba3ec82f768841cfe2956a58220407","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b6af5237_73387212","updated":"2023-03-07 08:16:58.000000000","message":"needed for RC1","commit_id":"32f1145b7ddf9a9a359e2359e7db63dbdd00b899"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"793741963cff28e6ffc6763b2678e2b0a58f2882","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"815e0d84_7e0af6e1","updated":"2023-03-08 13:06:58.000000000","message":"recheck - this has a Zuul +1 and two (!) workflow +1s, but somehow wasn\u0027t picked up by Zuul for final gating as far as I can tell","commit_id":"32f1145b7ddf9a9a359e2359e7db63dbdd00b899"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d926a4ab2df63e3b2322a563a6d79c4d45bd0566","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b06b39e4_ca02c297","updated":"2023-03-06 13:16:34.000000000","message":"recheck cinder-grenade-mn-sub-volbak - socket timeout during setup for tempest.api.compute.servers.test_create_server.ServersTestBootFromVolume","commit_id":"32f1145b7ddf9a9a359e2359e7db63dbdd00b899"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fa09bd0730af539e221b0bc8a9b23277e0399922","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"dd084512_8d140ad2","updated":"2023-03-06 19:01:42.000000000","message":"recheck multiple unrelated failures","commit_id":"32f1145b7ddf9a9a359e2359e7db63dbdd00b899"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"da5dc3790b6e2fd9f8bc397cd35e7a1ba4d22c26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4101df16_8c7942d7","updated":"2023-03-17 12:13:00.000000000","message":"recheck tempest change merged","commit_id":"32f1145b7ddf9a9a359e2359e7db63dbdd00b899"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"40c1072d762b42a03bbe6bb64d1adcea692d42f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"410002b8_9482b9be","updated":"2023-03-06 16:25:53.000000000","message":"recheck tempest-integrated-storage-ubuntu-focal failed because volume type was in-use. maybe due to a dependent volume failed to cleanup. This test passed in tempest-integrated-storage so let\u0027s try again.","commit_id":"32f1145b7ddf9a9a359e2359e7db63dbdd00b899"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4cdb457d80f7c9b7919ab05ca7f78d68211efe1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2f2f7fdf_48be0584","updated":"2023-03-07 04:56:34.000000000","message":"recheck tempest-slow-py3 timed out","commit_id":"32f1145b7ddf9a9a359e2359e7db63dbdd00b899"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"eb519ffb2870e143b3b84193e1b9c914883440b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"730915ec_7f497b0d","updated":"2023-03-17 16:46:36.000000000","message":"recheck there is some problem with how global values are used in powermax tests but we can\u0027t fix them all now so hope gate will not encounter it after recheck since it\u0027s random\n","commit_id":"32f1145b7ddf9a9a359e2359e7db63dbdd00b899"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e1c55649d25de4a2bf3f57ac26521d8fe2ddd9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5426945e_126c7184","updated":"2023-03-17 16:31:12.000000000","message":"tempest change is merged https://review.opendev.org/c/openstack/tempest/+/875372/8","commit_id":"32f1145b7ddf9a9a359e2359e7db63dbdd00b899"}],"api-ref/source/v3/volumes-v3-volumes.inc":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"587f7f02b9cdf5b48186d003a9f7d61cb778eec0","unresolved":true,"context_lines":[{"line_number":218,"context_line":"   - availability_zone: availability_zone"},{"line_number":219,"context_line":"   - source_volid: source_volid"},{"line_number":220,"context_line":"   - description: description_vol"},{"line_number":221,"context_line":"   - multiattach: multiattach_req"},{"line_number":222,"context_line":"   - snapshot_id: snapshot_id"},{"line_number":223,"context_line":"   - backup_id: backup_id"},{"line_number":224,"context_line":"   - name: volume_name_optional"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"377ae86c_411ca0af","side":"PARENT","line":221,"updated":"2023-03-03 23:36:42.000000000","message":"Should also remove this from v3/parameters.yaml (I think this was the only place it was used).","commit_id":"a9a2df22d71b57b3e34f6ed00b77ddc94e438712"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5c69f4ba81660d6b4e72205dcae22af5025a0768","unresolved":false,"context_lines":[{"line_number":218,"context_line":"   - availability_zone: availability_zone"},{"line_number":219,"context_line":"   - source_volid: source_volid"},{"line_number":220,"context_line":"   - description: description_vol"},{"line_number":221,"context_line":"   - multiattach: multiattach_req"},{"line_number":222,"context_line":"   - snapshot_id: snapshot_id"},{"line_number":223,"context_line":"   - backup_id: backup_id"},{"line_number":224,"context_line":"   - name: volume_name_optional"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"2907f48d_4fb12d93","side":"PARENT","line":221,"in_reply_to":"377ae86c_411ca0af","updated":"2023-03-06 09:00:11.000000000","message":"Done","commit_id":"a9a2df22d71b57b3e34f6ed00b77ddc94e438712"}],"cinder/api/v2/volumes.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"587f7f02b9cdf5b48186d003a9f7d61cb778eec0","unresolved":true,"context_lines":[{"line_number":259,"context_line":"            kwargs[\u0027image_id\u0027] \u003d image_uuid"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        kwargs[\u0027availability_zone\u0027] \u003d volume.get(\u0027availability_zone\u0027, None)"},{"line_number":262,"context_line":"        kwargs[\u0027scheduler_hints\u0027] \u003d volume.get(\u0027scheduler_hints\u0027, None)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        try:"},{"line_number":265,"context_line":"            new_volume \u003d self.volume_api.create("}],"source_content_type":"text/x-python","patch_set":4,"id":"dc2cb171_dda6e13a","line":262,"updated":"2023-03-03 23:36:42.000000000","message":"I forgot that we still had these v2 REST API classes hanging around.  Maybe we can have a hackfest at the PTG to remove them.  The complicated part is handling the tests, but there aren\u0027t too many classes left in cinder/api/v2.  The way to do it might be to map out the removal strategy at the end of day 1, and then have the hackfest at the end of day 2.","commit_id":"d70da12f0f92f4ca3fc2105d605445f2b2a54881"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5c69f4ba81660d6b4e72205dcae22af5025a0768","unresolved":false,"context_lines":[{"line_number":259,"context_line":"            kwargs[\u0027image_id\u0027] \u003d image_uuid"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        kwargs[\u0027availability_zone\u0027] \u003d volume.get(\u0027availability_zone\u0027, None)"},{"line_number":262,"context_line":"        kwargs[\u0027scheduler_hints\u0027] \u003d volume.get(\u0027scheduler_hints\u0027, None)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        try:"},{"line_number":265,"context_line":"            new_volume \u003d self.volume_api.create("}],"source_content_type":"text/x-python","patch_set":4,"id":"e2047ebb_5cdb1e3a","line":262,"in_reply_to":"dc2cb171_dda6e13a","updated":"2023-03-06 09:00:11.000000000","message":"Ack, sounds good.","commit_id":"d70da12f0f92f4ca3fc2105d605445f2b2a54881"}],"cinder/api/v3/volumes.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"587f7f02b9cdf5b48186d003a9f7d61cb778eec0","unresolved":true,"context_lines":[{"line_number":386,"context_line":""},{"line_number":387,"context_line":"        kwargs[\u0027availability_zone\u0027] \u003d volume.get(\u0027availability_zone\u0027, None)"},{"line_number":388,"context_line":"        kwargs[\u0027scheduler_hints\u0027] \u003d volume.get(\u0027scheduler_hints\u0027, None)"},{"line_number":389,"context_line":"        multiattach \u003d utils.get_bool_param(\u0027multiattach\u0027, volume)"},{"line_number":390,"context_line":"        if multiattach:"},{"line_number":391,"context_line":"            msg \u003d _(\"multiattach parameter has been removed. The default \""},{"line_number":392,"context_line":"                    \"behavior is to use multiattach enabled volume types. \""}],"source_content_type":"text/x-python","patch_set":4,"id":"b6092cec_2167eccd","line":389,"range":{"start_line":389,"start_character":8,"end_line":389,"end_character":65},"updated":"2023-03-03 23:36:42.000000000","message":"If the \u0027multiattach\u0027 element is removed from the volume-create schema, this will become dead code.  Might be worth adding a comment in the schema about why the element is still there even though it\u0027s no longer supported.  On the other hand, maybe I\u0027m underestimating the thoroughness of our reviewers.  In any case, could be done as a followup; the comment only needs to be in the development branch.","commit_id":"d70da12f0f92f4ca3fc2105d605445f2b2a54881"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5c69f4ba81660d6b4e72205dcae22af5025a0768","unresolved":false,"context_lines":[{"line_number":386,"context_line":""},{"line_number":387,"context_line":"        kwargs[\u0027availability_zone\u0027] \u003d volume.get(\u0027availability_zone\u0027, None)"},{"line_number":388,"context_line":"        kwargs[\u0027scheduler_hints\u0027] \u003d volume.get(\u0027scheduler_hints\u0027, None)"},{"line_number":389,"context_line":"        multiattach \u003d utils.get_bool_param(\u0027multiattach\u0027, volume)"},{"line_number":390,"context_line":"        if multiattach:"},{"line_number":391,"context_line":"            msg \u003d _(\"multiattach parameter has been removed. The default \""},{"line_number":392,"context_line":"                    \"behavior is to use multiattach enabled volume types. \""}],"source_content_type":"text/x-python","patch_set":4,"id":"41422799_98111007","line":389,"range":{"start_line":389,"start_character":8,"end_line":389,"end_character":65},"in_reply_to":"b6092cec_2167eccd","updated":"2023-03-06 09:00:11.000000000","message":"Done","commit_id":"d70da12f0f92f4ca3fc2105d605445f2b2a54881"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ef5ffaa9c7ac543514e86091b6a786d995b7aa2f","unresolved":true,"context_lines":[{"line_number":387,"context_line":"        kwargs[\u0027availability_zone\u0027] \u003d volume.get(\u0027availability_zone\u0027, None)"},{"line_number":388,"context_line":"        kwargs[\u0027scheduler_hints\u0027] \u003d volume.get(\u0027scheduler_hints\u0027, None)"},{"line_number":389,"context_line":"        multiattach \u003d utils.get_bool_param(\u0027multiattach\u0027, volume)"},{"line_number":390,"context_line":"        if multiattach:"},{"line_number":391,"context_line":"            msg \u003d _(\"multiattach parameter has been removed. The default \""},{"line_number":392,"context_line":"                    \"behavior is to use multiattach enabled volume types. \""},{"line_number":393,"context_line":"                    \"Contact your administrator to create a multiattach \""}],"source_content_type":"text/x-python","patch_set":5,"id":"0a7e1153_e50ac9e9","line":390,"updated":"2023-03-07 10:48:02.000000000","message":"nit: Maybe we should log a warning if the multiattach parameter is present in the request.","commit_id":"32f1145b7ddf9a9a359e2359e7db63dbdd00b899"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ef5ffaa9c7ac543514e86091b6a786d995b7aa2f","unresolved":true,"context_lines":[{"line_number":388,"context_line":"        kwargs[\u0027scheduler_hints\u0027] \u003d volume.get(\u0027scheduler_hints\u0027, None)"},{"line_number":389,"context_line":"        multiattach \u003d utils.get_bool_param(\u0027multiattach\u0027, volume)"},{"line_number":390,"context_line":"        if multiattach:"},{"line_number":391,"context_line":"            msg \u003d _(\"multiattach parameter has been removed. The default \""},{"line_number":392,"context_line":"                    \"behavior is to use multiattach enabled volume types. \""},{"line_number":393,"context_line":"                    \"Contact your administrator to create a multiattach \""},{"line_number":394,"context_line":"                    \"enabled volume type and use it to create multiattach \""},{"line_number":395,"context_line":"                    \"volumes.\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"67f7351d_4c3221a5","line":392,"range":{"start_line":391,"start_character":61,"end_line":392,"end_character":74},"updated":"2023-03-07 10:48:02.000000000","message":"nit: It\u0027s not the default behavior, it\u0027s the only way of doing it...","commit_id":"32f1145b7ddf9a9a359e2359e7db63dbdd00b899"}],"cinder/scheduler/filter_scheduler.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"587f7f02b9cdf5b48186d003a9f7d61cb778eec0","unresolved":true,"context_lines":[{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        # If multiattach is enabled on a volume, we need to add"},{"line_number":339,"context_line":"        # multiattach to extra specs, so that the capability"},{"line_number":340,"context_line":"        # filtering is enabled."},{"line_number":341,"context_line":"        multiattach \u003d request_spec[\u0027volume_properties\u0027].get(\u0027multiattach\u0027,"},{"line_number":342,"context_line":"                                                            False)"},{"line_number":343,"context_line":"        if multiattach and \u0027multiattach\u0027 not in resource_type.get("}],"source_content_type":"text/x-python","patch_set":4,"id":"6fdc2e1a_66f687e8","side":"PARENT","line":340,"updated":"2023-03-03 23:36:42.000000000","message":"Glad that you noticed this code.  Good to see it go!","commit_id":"a9a2df22d71b57b3e34f6ed00b77ddc94e438712"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5c69f4ba81660d6b4e72205dcae22af5025a0768","unresolved":false,"context_lines":[{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        # If multiattach is enabled on a volume, we need to add"},{"line_number":339,"context_line":"        # multiattach to extra specs, so that the capability"},{"line_number":340,"context_line":"        # filtering is enabled."},{"line_number":341,"context_line":"        multiattach \u003d request_spec[\u0027volume_properties\u0027].get(\u0027multiattach\u0027,"},{"line_number":342,"context_line":"                                                            False)"},{"line_number":343,"context_line":"        if multiattach and \u0027multiattach\u0027 not in resource_type.get("}],"source_content_type":"text/x-python","patch_set":4,"id":"2fe76e3b_4853fad5","side":"PARENT","line":340,"in_reply_to":"6fdc2e1a_66f687e8","updated":"2023-03-06 09:00:11.000000000","message":"Done","commit_id":"a9a2df22d71b57b3e34f6ed00b77ddc94e438712"}],"cinder/volume/flows/api/create_volume.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"587f7f02b9cdf5b48186d003a9f7d61cb778eec0","unresolved":true,"context_lines":[{"line_number":915,"context_line":"        rebind\u003d{\u0027size\u0027: \u0027raw_size\u0027,"},{"line_number":916,"context_line":"                \u0027availability_zone\u0027: \u0027raw_availability_zone\u0027,"},{"line_number":917,"context_line":"                \u0027volume_type\u0027: \u0027raw_volume_type\u0027,"},{"line_number":918,"context_line":"                \u0027multiattach\u0027: \u0027raw_multiattach\u0027}))"},{"line_number":919,"context_line":"    api_flow.add(QuotaReserveTask(),"},{"line_number":920,"context_line":"                 EntryCreateTask(),"},{"line_number":921,"context_line":"                 QuotaCommitTask())"}],"source_content_type":"text/x-python","patch_set":4,"id":"4fae88bb_27dfed3a","side":"PARENT","line":918,"updated":"2023-03-03 23:36:42.000000000","message":"OK, raw_multiattach was removed in cinder/volume/api.py in this patch, so we don\u0027t need it here.","commit_id":"a9a2df22d71b57b3e34f6ed00b77ddc94e438712"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5c69f4ba81660d6b4e72205dcae22af5025a0768","unresolved":false,"context_lines":[{"line_number":915,"context_line":"        rebind\u003d{\u0027size\u0027: \u0027raw_size\u0027,"},{"line_number":916,"context_line":"                \u0027availability_zone\u0027: \u0027raw_availability_zone\u0027,"},{"line_number":917,"context_line":"                \u0027volume_type\u0027: \u0027raw_volume_type\u0027,"},{"line_number":918,"context_line":"                \u0027multiattach\u0027: \u0027raw_multiattach\u0027}))"},{"line_number":919,"context_line":"    api_flow.add(QuotaReserveTask(),"},{"line_number":920,"context_line":"                 EntryCreateTask(),"},{"line_number":921,"context_line":"                 QuotaCommitTask())"}],"source_content_type":"text/x-python","patch_set":4,"id":"184069c7_322302d7","side":"PARENT","line":918,"in_reply_to":"4fae88bb_27dfed3a","updated":"2023-03-06 09:00:11.000000000","message":"Done","commit_id":"a9a2df22d71b57b3e34f6ed00b77ddc94e438712"}],"releasenotes/notes/remove-multiattach-request-param-4444e02533f919da.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"587f7f02b9cdf5b48186d003a9f7d61cb778eec0","unresolved":true,"context_lines":[{"line_number":11,"context_line":"  - |"},{"line_number":12,"context_line":"    Removed the ability to create multiattach volumes by specifying"},{"line_number":13,"context_line":"    `multiattach` parameter in the request body of a volume create"},{"line_number":14,"context_line":"    operation."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"231935ac_e8a5feab","line":14,"updated":"2023-03-03 23:36:42.000000000","message":"Maybe add this sentence to the paragraph:\n\nThis functionality is unsafe, can lead to data loss, and has been deprecated since the Queens release.\n\nThen maybe add another paragraph:\n\nThe recommended method for creating a multiattach volume is to use a volume type that supports multiattach.  By default, volume types can only be created by the operator.  Users who have a need for multiattach volumes should contact their operator if a suitable volume type is not available.","commit_id":"d70da12f0f92f4ca3fc2105d605445f2b2a54881"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5c69f4ba81660d6b4e72205dcae22af5025a0768","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  - |"},{"line_number":12,"context_line":"    Removed the ability to create multiattach volumes by specifying"},{"line_number":13,"context_line":"    `multiattach` parameter in the request body of a volume create"},{"line_number":14,"context_line":"    operation."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5fc235fd_ab20dd73","line":14,"in_reply_to":"231935ac_e8a5feab","updated":"2023-03-06 09:00:11.000000000","message":"Done","commit_id":"d70da12f0f92f4ca3fc2105d605445f2b2a54881"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ef5ffaa9c7ac543514e86091b6a786d995b7aa2f","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    Fixed the volume create functionality where non-admin users were"},{"line_number":6,"context_line":"    able to create multiattach volumes by providing the `multiattach`"},{"line_number":7,"context_line":"    parameter in the request body. Now we can only create multiattach"},{"line_number":8,"context_line":"    volumes using a multiattach volume type, which is also the"},{"line_number":9,"context_line":"    recommended way."},{"line_number":10,"context_line":"other:"},{"line_number":11,"context_line":"  - |"},{"line_number":12,"context_line":"    Removed the ability to create multiattach volumes by specifying"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"cefe9517_fd12bea5","line":9,"range":{"start_line":8,"start_character":51,"end_line":9,"end_character":20},"updated":"2023-03-07 10:48:02.000000000","message":"nit: has been the recommended way for a while.","commit_id":"32f1145b7ddf9a9a359e2359e7db63dbdd00b899"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ef5ffaa9c7ac543514e86091b6a786d995b7aa2f","unresolved":true,"context_lines":[{"line_number":13,"context_line":"    `multiattach` parameter in the request body of a volume create"},{"line_number":14,"context_line":"    operation. This functionality is unsafe, can lead to data loss,"},{"line_number":15,"context_line":"    and has been deprecated since the Queens release."},{"line_number":16,"context_line":"    The recommended method for creating a multiattach volume is to"},{"line_number":17,"context_line":"    use a volume type that supports multiattach.  By default, volume"},{"line_number":18,"context_line":"    types can only be created by the operator.  Users who have a need"},{"line_number":19,"context_line":"    for multiattach volumes should contact their operator if a suitable"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"e1bd0df0_9c5da60d","line":16,"range":{"start_line":16,"start_character":4,"end_line":16,"end_character":27},"updated":"2023-03-07 10:48:02.000000000","message":"now is the only way","commit_id":"32f1145b7ddf9a9a359e2359e7db63dbdd00b899"}]}