)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0725b1467109d49ebf5fa41c577b2cefc94417f9","unresolved":true,"context_lines":[{"line_number":9,"context_line":"If action is None, message event_id"},{"line_number":10,"context_line":"in message_record dict throws NoneType"},{"line_number":11,"context_line":"keyerror."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I41c7487f7b78a3ca43b5b4ede18a0ea75c0e58f7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"704c7195_651e69de","line":12,"updated":"2023-03-06 15:57:22.000000000","message":"Please add\n    Closes-Bug: #2009483\n    \nto the commit message to link this to the Launchpad bug.","commit_id":"d9ca67132565fbe2b219b0046279ec47faa87629"},{"author":{"_account_id":27741,"name":"Abhinav Shrivastava","email":"abshriva@in.ibm.com","username":"abshriva"},"change_message_id":"06bd49b698f3009b6aeb3a309fe1799279bc5adb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If action is None, message event_id"},{"line_number":10,"context_line":"in message_record dict throws NoneType"},{"line_number":11,"context_line":"keyerror."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I41c7487f7b78a3ca43b5b4ede18a0ea75c0e58f7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e9067f16_a690273c","line":12,"in_reply_to":"704c7195_651e69de","updated":"2023-03-06 16:06:35.000000000","message":"Done","commit_id":"d9ca67132565fbe2b219b0046279ec47faa87629"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0725b1467109d49ebf5fa41c577b2cefc94417f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fed2b27a_d0aefaf2","updated":"2023-03-06 15:57:22.000000000","message":"It would be helpful to have unit test coverage for this code path.","commit_id":"d9ca67132565fbe2b219b0046279ec47faa87629"},{"author":{"_account_id":27741,"name":"Abhinav Shrivastava","email":"abshriva@in.ibm.com","username":"abshriva"},"change_message_id":"1c1eeca9d45acc27fabcce5fd35734195909b4da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"73d4d3a8_3e499880","in_reply_to":"fed2b27a_d0aefaf2","updated":"2023-03-06 18:48:40.000000000","message":"added code. waiting for build to pass.","commit_id":"d9ca67132565fbe2b219b0046279ec47faa87629"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"553f76edc0b5142809010bcb5fed24eb04613ea0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4eeaf561_4a80fbca","updated":"2023-03-06 18:58:50.000000000","message":"This may only be masking a problem.  I\u0027m not sure that the action should ever be None, so it would be worth investigating which messages are causing this.  This seems very similar to https://bugs.launchpad.net/cinder/+bug/1978729 , where this same fix was proposed, but was then rejected because the source of the error was entirely different.  Please look more carefully at what is causing this to happen.  Thanks!","commit_id":"5fcb35546069d37763335a8dcbaa3261f2675129"},{"author":{"_account_id":27741,"name":"Abhinav Shrivastava","email":"abshriva@in.ibm.com","username":"abshriva"},"change_message_id":"d47bf5c30771db8ea01edbdae00008b154b634f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3b66463a_b4d57e52","in_reply_to":"4eeaf561_4a80fbca","updated":"2023-03-06 19:18:08.000000000","message":"There were two scenarios on how it is getting recreated:\n\na. Trying to take a backup of a volume which is not having fc-connection. So initialize_connection is resulting into this: https://bugs.launchpad.net/cinder/+bug/2009483\n\nb. 2nd scenario: Trying to take a backup due to invalid chunk size. \n\n\nInvalid backup: Chunk size is not multiple of block size for creating hash.\n\n2023-03-06 12:52:32.884 287210 ERROR oslo_messaging.rpc.server During handling of the above exception, another exception occurred:\n2023-03-06 12:52:32.884 287210 ERROR oslo_messaging.rpc.server\n2023-03-06 12:52:32.884 287210 ERROR oslo_messaging.rpc.server Traceback (most recent call last):\n2023-03-06 12:52:32.884 287210 ERROR oslo_messaging.rpc.server   File \"/usr/lib/python3.9/site-packages/oslo_messaging/rpc/server.py\", line 165, in _process_incoming\n2023-03-06 12:52:32.884 287210 ERROR oslo_messaging.rpc.server     res \u003d self.dispatcher.dispatch(message)\n2023-03-06 12:52:32.884 287210 ERROR oslo_messaging.rpc.server   File \"/usr/lib/python3.9/site-packages/oslo_messaging/rpc/dispatcher.py\", line 309, in dispatch\n2023-03-06 12:52:32.884 287210 ERROR oslo_messaging.rpc.server     return self._do_dispatch(endpoint, method, ctxt, args)\n2023-03-06 12:52:32.884 287210 ERROR oslo_messaging.rpc.server   File \"/usr/lib/python3.9/site-packages/oslo_messaging/rpc/dispatcher.py\", line 229, in _do_dispatch\n2023-03-06 12:52:32.884 287210 ERROR oslo_messaging.rpc.server     result \u003d func(ctxt, **new_args)\n2023-03-06 12:52:32.884 287210 ERROR oslo_messaging.rpc.server   File \"/usr/lib/python3.9/site-packages/cinder/backup/manager.py\", line 542, in continue_backup\n2023-03-06 12:52:32.884 287210 ERROR oslo_messaging.rpc.server     volume_utils.update_backup_error(backup, str(err))\n2023-03-06 12:52:32.884 287210 ERROR oslo_messaging.rpc.server   File \"/usr/lib/python3.9/site-packages/oslo_utils/excutils.py\", line 227, in __exit__\n2023-03-06 12:52:32.884 287210 ERROR oslo_messaging.rpc.server     self.force_reraise()\n2023-03-06 12:52:32.884 287210 ERROR oslo_messaging.rpc.server   File \"/usr/lib/python3.9/site-packages/oslo_utils/excutils.py\", line 200, in force_reraise\n2023-03-06 12:52:32.884 287210 ERROR oslo_messaging.rpc.server     raise self.value\n2023-03-06 12:52:32.884 287210 ERROR oslo_messaging.rpc.server   File \"/usr/lib/python3.9/site-packages/cinder/backup/manager.py\", line 514, in continue_backup\n2023-03-06 12:52:32.884 287210 ERROR oslo_messaging.rpc.server     self.message_api.create_from_request_context(\n2023-03-06 12:52:32.884 287210 ERROR oslo_messaging.rpc.server   File \"/usr/lib/python3.9/site-packages/cinder/message/api.py\", line 140, in create_from_request_context\n2023-03-06 12:52:32.884 287210 ERROR oslo_messaging.rpc.server     self.create(context\u003dcontext,\n2023-03-06 12:52:32.884 287210 ERROR oslo_messaging.rpc.server   File \"/usr/lib/python3.9/site-packages/cinder/message/api.py\", line 104, in create\n2023-03-06 12:52:32.884 287210 ERROR oslo_messaging.rpc.server     action[0],\n2023-03-06 12:52:32.884 287210 ERROR oslo_messaging.rpc.server TypeError: \u0027NoneType\u0027 object is not subscriptable\n\n\nI believe these should be taken care of, anyway\naction being None was already handled\n\nlike this:\n\n\u0027action_id\u0027 : action[0] if action else \u0027\u0027\n\nThrough this code change will just handle \u0027event_id\u0027 portion which will allow the message record to at-least get created. Just a safe check.","commit_id":"5fcb35546069d37763335a8dcbaa3261f2675129"}]}