)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f27987eb1cbb87eb7a424c3f44166cd125d8f110","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Yadro Tatlin Unified FC driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Added support of FC to Tatlin Unified driver"},{"line_number":10,"context_line":"* Removed support of outdated Tatlin storages"},{"line_number":11,"context_line":"* Renamed tatlin_api to tatlin_client in driver"},{"line_number":12,"context_line":"* Simplified code"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint yadro-tatlin-unified-fc"},{"line_number":15,"context_line":"Co-Authored-By: Sergey Karpenkov \u003cs.karpenkov@yadro.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7bac49b5_568ebe04","line":12,"range":{"start_line":10,"start_character":0,"end_line":12,"end_character":17},"updated":"2023-07-03 20:57:59.000000000","message":"These tasks should be done in follow up patches and we should isolate this patch to just adding the FC support for Tatlin driver\n\nIdeally it is a good practice to keep the patches separate for separate tasks so it\u0027s easier to backport or revert any particular change without affecting other changes.","commit_id":"ae6194f976d82d67582543b585243e1373de8d90"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"b03882a169cd2a4a033844b766f046d069899dae","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Yadro Tatlin Unified FC driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Added support of FC to Tatlin Unified driver"},{"line_number":10,"context_line":"* Removed support of outdated Tatlin storages"},{"line_number":11,"context_line":"* Renamed tatlin_api to tatlin_client in driver"},{"line_number":12,"context_line":"* Simplified code"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint yadro-tatlin-unified-fc"},{"line_number":15,"context_line":"Co-Authored-By: Sergey Karpenkov \u003cs.karpenkov@yadro.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7c809436_12331c51","line":12,"range":{"start_line":10,"start_character":0,"end_line":12,"end_character":17},"in_reply_to":"7bac49b5_568ebe04","updated":"2023-07-06 09:57:59.000000000","message":"Done","commit_id":"ae6194f976d82d67582543b585243e1373de8d90"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8037ee746d896fd83e74dde309d0856036f419ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"62f10717_8101380c","updated":"2023-03-22 15:40:05.000000000","message":"Please be informed that the CI account has been inactivated because it has been posting some broken comments in several repos.\n \nexamples:\n https://review.opendev.org/c/openstack/puppet-sahara/+/877952 \n https://review.opendev.org/c/openstack/oslo.db/+/874239\n\nReach out to infra team in #openstack-infra to get the account restored, once the wrong configuration is fixed.","commit_id":"14bcb2303399ce947cfa025b4905aff23ca91cc8"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"a749a202d6cf4bc996284475365d5eb5f34f9227","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"36f29d86_bb8ad02c","updated":"2023-03-07 14:51:29.000000000","message":"run-Yadro Tatlin Unified CI","commit_id":"14bcb2303399ce947cfa025b4905aff23ca91cc8"},{"author":{"_account_id":33746,"name":"YADRO TATLIN CI","email":"tatlin_ci@yadro.com","username":"tatlin-ci"},"change_message_id":"4dd71c81b7076897fe1a6f5f7066cb632ad83e8e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"896aab62_6d153ee1","updated":"2023-03-20 17:56:30.000000000","message":"run-Yadro Tatlin Unified CI","commit_id":"14bcb2303399ce947cfa025b4905aff23ca91cc8"},{"author":{"_account_id":33746,"name":"YADRO TATLIN CI","email":"tatlin_ci@yadro.com","username":"tatlin-ci"},"change_message_id":"55b1e4243045bcd0d733ad55bb06f9a9a63fee66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ce41f7b9_864b2347","updated":"2023-03-20 18:28:17.000000000","message":"run-Yadro Tatlin Unified CI","commit_id":"14bcb2303399ce947cfa025b4905aff23ca91cc8"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"502c8167983deb63fd94c6fd1f4e6231cda08736","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"eeb0dbe3_12b5cb65","in_reply_to":"62f10717_8101380c","updated":"2023-03-23 14:02:25.000000000","message":"thanks Takashi Kajinami! We are fixing it","commit_id":"14bcb2303399ce947cfa025b4905aff23ca91cc8"},{"author":{"_account_id":33746,"name":"YADRO TATLIN CI","email":"tatlin_ci@yadro.com","username":"tatlin-ci"},"change_message_id":"55b1e4243045bcd0d733ad55bb06f9a9a63fee66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cf00979d_17e70db3","in_reply_to":"896aab62_6d153ee1","updated":"2023-03-20 18:28:17.000000000","message":"Done","commit_id":"14bcb2303399ce947cfa025b4905aff23ca91cc8"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"ec183c68da32ce7cd46ed4ab019d2a96333b297b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b760eb07_a504e2ea","in_reply_to":"eeb0dbe3_12b5cb65","updated":"2023-05-22 11:33:00.000000000","message":"Done","commit_id":"14bcb2303399ce947cfa025b4905aff23ca91cc8"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"30f788866005da11e927b583f9c90ea2fc83715d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"19ebeb15_cbda763b","updated":"2023-04-05 07:36:42.000000000","message":"run-Yadro Tatlin Unified CI","commit_id":"4445098e8fcad4cbda1f696151683edb11bd9618"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"4e3f71eeb9e56812949af698d53b5459c541a4a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bf773861_19aaef06","updated":"2023-03-28 07:25:51.000000000","message":"run-Yadro Tatlin Unified CI","commit_id":"4445098e8fcad4cbda1f696151683edb11bd9618"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"a7228d9032fbae27b914f92aceb24b5a4a22ce55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5a90fdd1_e7a1c373","updated":"2023-05-18 06:43:23.000000000","message":"1] Since a feature is added (FC driver), it would require release notes.\n\n2] In this code review (tatlin_common.py) ... tatlin_api is replaced by tatlin_client.\nIt would be great if this is mentioned in commit message.\n\n3] Minor typo in yadro-tatlin-volume-driver.rst file.","commit_id":"6b99ab5f5ecff95075de7b26c3247eda0af7e9a0"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"89622442e957eadd013e21984584a5537e37e482","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1689d19d_369ead16","in_reply_to":"5a90fdd1_e7a1c373","updated":"2023-05-19 08:53:48.000000000","message":"thank you very much for the review,\nI have addressed comments in a new patchset","commit_id":"6b99ab5f5ecff95075de7b26c3247eda0af7e9a0"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"fbfe7b486117a38451b3728be4483be49cd8e633","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7daeaf49_16b157cb","updated":"2023-05-22 04:58:27.000000000","message":"My comments have been addressed. Zuul also passed.\nHopefully CI would pass soon.","commit_id":"ae6194f976d82d67582543b585243e1373de8d90"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f27987eb1cbb87eb7a424c3f44166cd125d8f110","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e3178d0d_6f5d9515","updated":"2023-07-03 20:57:59.000000000","message":"Thanks for the driver, few comments inline.\nAlso we are trying to run unified CI but i can see only iscsi test results, any issue currently faced with FC CI?","commit_id":"ae6194f976d82d67582543b585243e1373de8d90"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"d3bf38ebcbde8a848b7a5c0c03f0d80d79ea9295","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3667abff_e8d59708","updated":"2023-06-22 05:03:29.000000000","message":"hi Vladislav,\nYou may know this; however just FYI:\nThe deadline for merging new driver is 06th July.\nhttps://releases.openstack.org/bobcat/schedule.html#b-cinder-driver-deadline","commit_id":"ae6194f976d82d67582543b585243e1373de8d90"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"27f0e3c85ce74f9452d423adc439924a0a601462","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0e78ffb6_7832cc0d","updated":"2023-06-27 12:26:53.000000000","message":"run-Yadro Tatlin Unified CI","commit_id":"ae6194f976d82d67582543b585243e1373de8d90"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"d0f466b2a27d2c8648e34f0056e437a346aad2e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"41aa8108_43d4cbfa","updated":"2023-05-22 12:04:59.000000000","message":"run-Yadro Tatlin Unified CI","commit_id":"ae6194f976d82d67582543b585243e1373de8d90"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"05d18bdeeb2515b598a92e63d477820882a28204","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7ca0219d_f24abde9","updated":"2023-06-14 07:33:34.000000000","message":"run-Yadro Tatlin Unified CI","commit_id":"ae6194f976d82d67582543b585243e1373de8d90"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"9eeb3bfd8e47703e97892d4cb34c281b33d39173","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8e8a5dfb_438cbc75","updated":"2023-06-16 14:23:17.000000000","message":"run-Yadro Tatlin Unified CI","commit_id":"ae6194f976d82d67582543b585243e1373de8d90"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"c7410d8303f39df474cd92036e62eb6d43ca3ae5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"929d7a75_343cc62f","updated":"2023-06-13 13:53:04.000000000","message":"run-Yadro Tatlin Unified CI","commit_id":"ae6194f976d82d67582543b585243e1373de8d90"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"ec183c68da32ce7cd46ed4ab019d2a96333b297b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"cc675809_5ffe7db6","updated":"2023-05-22 11:33:00.000000000","message":"run-Yadro Tatlin Unified CI","commit_id":"ae6194f976d82d67582543b585243e1373de8d90"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"b03882a169cd2a4a033844b766f046d069899dae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"258e7360_695f7f7d","updated":"2023-07-06 09:57:59.000000000","message":"thanks Rajat for your valuable feedback!","commit_id":"ae6194f976d82d67582543b585243e1373de8d90"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"0e5519937d689868ac7a135011cd4a8ea316dacf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f0cb1b92_1ef2bac3","in_reply_to":"3667abff_e8d59708","updated":"2023-06-27 12:26:33.000000000","message":"Hi Raghavendra, \nthanks a lot for the reminder! \nwe will try our best though there still are a few problems with our CI.","commit_id":"ae6194f976d82d67582543b585243e1373de8d90"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2ef6d730519d0729beeede86f2e761db0fb7c0ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"72e85d36_5cdb6137","updated":"2023-07-13 08:10:46.000000000","message":"-1 for visibility on the last comment","commit_id":"055d431054c39d77664c04d19c3786fc806c3c7f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8cc394dd918ae560ef34cc1067ad0da4c75f59c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"fb1fdaea_b75833c1","updated":"2023-07-13 21:49:13.000000000","message":"Basically looks OK.  Noticed a typo you can fix (see inline).  I do share Rajat\u0027s concern about the lack of FC logs from the Yadro Unified CI.","commit_id":"055d431054c39d77664c04d19c3786fc806c3c7f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e41dcae112d10987da5ebb145adf375ee3e29bf9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6dc2ce9b_0901bc22","updated":"2023-07-13 21:31:07.000000000","message":"Looks like the last CI result with FC logs was 4 April.  Since then, there have been only iSCSI logs.  Looks the same on other patches, for example, https://review.opendev.org/c/openstack/cinder/+/886942","commit_id":"055d431054c39d77664c04d19c3786fc806c3c7f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2372a7ae0a793a3b099c41bc979606e274b123a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c9a55aa5_c52089d4","updated":"2023-07-13 08:10:23.000000000","message":"Thanks for addressing the comments.\n\nOne concern is, I Still don\u0027t see an FC CI reporting for this driver","commit_id":"055d431054c39d77664c04d19c3786fc806c3c7f"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"870a06755c263fb571a7e34345df9030b8383eb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8f03cc78_24b149fb","updated":"2023-07-13 23:49:20.000000000","message":"The code looks good to me - release note is included, support matrix is                                                        \nupdated, refactoring into common looks fine, test coverage looks good.                                                         \nCI for iSCSI passes, so it appears no significant regression was                                                               \nintroduced.  The only thing we need to see is CI results for FC - your                                                         \ncurrent CI is only reporting for iSCSI.  If FC results are added to the                                                        \nreport, I think it\u0027s in good shape.  Ping in IRC or the mailing list and                                                       \nwe should be able to revisit this quickly.  Thanks for the contribution.","commit_id":"055d431054c39d77664c04d19c3786fc806c3c7f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ec636703c431e594a5329205fe20e6d310b97d6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5070c83a_38a049e4","updated":"2023-07-11 07:56:00.000000000","message":"recheck tempest-slow-py3 timed out","commit_id":"055d431054c39d77664c04d19c3786fc806c3c7f"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"66bbda67af055c3840bc86ed54715cfaa480d2ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5f657221_ea6db54d","in_reply_to":"8f03cc78_24b149fb","updated":"2023-07-15 16:42:00.000000000","message":"CI runs now for both iscsi and fc drivers, thanks a lot for the feedback!","commit_id":"055d431054c39d77664c04d19c3786fc806c3c7f"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"168680c38ea95fca897203854a8c6688a7269bd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c9e57b20_ad618c4a","updated":"2023-07-19 12:11:05.000000000","message":"Apologies for not getting to this review yesterday.  I support the other core\u0027s decisions on this.","commit_id":"3f3112f7965ea41b24b17d305b37e42ab6ea0bff"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a14d8071cc080b308abfe2d21d8aad35739d8585","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"fe0a5c65_88e85a77","updated":"2023-07-17 05:56:50.000000000","message":"CI reported success for FC driver.\nAlthough deadline was last week, the only factor holding this driver was the CI run which had passed in the past but due to Infra issues, it took time to be fixed.\nGiven this is a very rare case, I would not like to hold this for the next cycle at this point but would be good to have opinion of other team members.\nNote that this is a very narrow and rare case and we don\u0027t want to set a precedent allowing this to be merged.","commit_id":"3f3112f7965ea41b24b17d305b37e42ab6ea0bff"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"af5b5dc906da02598a043067787156f479367c68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"455553f3_b764c88c","updated":"2023-07-14 14:56:04.000000000","message":"FC build log actually ...","commit_id":"3f3112f7965ea41b24b17d305b37e42ab6ea0bff"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2b57e62a213913e79ccb869099d20a500fb13a81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5c4c1fbe_5a46f0d4","updated":"2023-07-17 12:44:53.000000000","message":"I agree with Rajat.  Not giving a +W so that other members of the cinder-core team can weigh in, but I support merging this driver so that it will be included in the 2023.2 (Bobcat) release.","commit_id":"3f3112f7965ea41b24b17d305b37e42ab6ea0bff"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"4461e16a5092ba662dace8761e77f5ec891216a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c9111892_c7e4525a","updated":"2023-07-17 07:51:46.000000000","message":"I see that all the comments are addressed and the CI for both iSCSI and FC has passed. Release nots and matrix doc is updated as well. LGTM","commit_id":"3f3112f7965ea41b24b17d305b37e42ab6ea0bff"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"ef393e6970f1eb3827fa9a22b236a909a5289907","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"98f7fd9b_2ee71593","updated":"2023-07-17 19:10:57.000000000","message":"No objection from me.","commit_id":"3f3112f7965ea41b24b17d305b37e42ab6ea0bff"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"ec83152bab936dc3072abcedb471f9e97e5693f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f48be7a1_682329be","updated":"2023-07-21 12:53:19.000000000","message":"Thanks a lot, Rajat and Team!","commit_id":"3f3112f7965ea41b24b17d305b37e42ab6ea0bff"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f29a4639e684ff6383dc320779611831c457a095","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5291e685_d5d9b0b2","updated":"2023-07-19 06:30:05.000000000","message":"This patch is ready from last 5 days and enough time is provided for the cinder core team to review and acknowledge the decision. It already has approval from 3 cores so should be good to get this in.","commit_id":"3f3112f7965ea41b24b17d305b37e42ab6ea0bff"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ce878cbf8fa5a1ae33f8ee419a7664568082281a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c05cb038_b039d6c3","updated":"2023-07-14 10:33:31.000000000","message":"Today is the deadline, the driver looks ready. I will keep my negative vote until we see FC CI reporting so we highlight the issue.","commit_id":"3f3112f7965ea41b24b17d305b37e42ab6ea0bff"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"031f49b86f4daa91474be72db09952f89fb8fcd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b62bedb8_c6507d94","updated":"2023-07-15 16:40:25.000000000","message":"ci runs now for both FC and iSCSI","commit_id":"3f3112f7965ea41b24b17d305b37e42ab6ea0bff"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"087182eb9fae545800c40cc471a3b6349e82c755","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8a0f6475_27254f48","updated":"2023-07-21 03:47:58.000000000","message":"recheck cinder-plugin-ceph-tempest tempest-slow-py3 tempest-ipv6-only","commit_id":"3f3112f7965ea41b24b17d305b37e42ab6ea0bff"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1688b8c7af1699b047bc7b7fb40bede0fe3a9868","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8c71401a_234ffd52","updated":"2023-07-20 05:17:32.000000000","message":"recheck cinder-plugin-ceph-tempest timed out","commit_id":"3f3112f7965ea41b24b17d305b37e42ab6ea0bff"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"25c47afa7115ad6346d0e734919a5d39b66fb404","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5fb985eb_4720b693","updated":"2023-07-20 08:49:56.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican","commit_id":"3f3112f7965ea41b24b17d305b37e42ab6ea0bff"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"9cabe0b261925d49e8290234cf9ebe7b63b14db1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"986f42ec_01bfdeee","updated":"2023-07-21 07:39:15.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican tempest-slow-py3","commit_id":"3f3112f7965ea41b24b17d305b37e42ab6ea0bff"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"c46a5f2322512fe8c3173b9b0dd436eba0fdffaa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"bb7a82ac_9f66a999","updated":"2023-07-20 14:10:07.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican tempest-slow-py3","commit_id":"3f3112f7965ea41b24b17d305b37e42ab6ea0bff"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d2dce3a8362f72c5ac05623582ec6adb44196813","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"bda287eb_580856c3","updated":"2023-07-14 10:28:50.000000000","message":"recheck tempest-slow-py3 failed due to a network test\n\ntempest.scenario.test_network_advanced_server_ops.TestNetworkAdvancedServerOps","commit_id":"3f3112f7965ea41b24b17d305b37e42ab6ea0bff"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9c8aca71f35baaebcd021f9b1698759416736ed9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"750144ca_6aa04197","updated":"2023-07-19 12:01:48.000000000","message":"recheck unrelated nova test failure","commit_id":"3f3112f7965ea41b24b17d305b37e42ab6ea0bff"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c37c87d8be65b54137673f03be5f3faee12c5fad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6ce2c1e3_461713a8","updated":"2023-07-14 13:44:30.000000000","message":"run-Yadro Tatlin Unified CI","commit_id":"3f3112f7965ea41b24b17d305b37e42ab6ea0bff"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"688d4037769c7b24448d8346b7ae0e6eb69f1a6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"54221855_f7297f56","updated":"2023-07-14 07:46:21.000000000","message":"thanks for the notice!","commit_id":"3f3112f7965ea41b24b17d305b37e42ab6ea0bff"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"02f0fc9e8cc2e417c7918af5b92aa45ce0e3b633","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2ac131fd_10dabb66","in_reply_to":"455553f3_b764c88c","updated":"2023-07-14 15:06:41.000000000","message":"Rajat\u0027s \u0027run-Yadro..\u0027 still is in queue","commit_id":"3f3112f7965ea41b24b17d305b37e42ab6ea0bff"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"e8c40c6522b9b87a5e1470a819c73064c8866f6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"4c94945a_3d5de573","in_reply_to":"c05cb038_b039d6c3","updated":"2023-07-14 14:42:09.000000000","message":"thanks for reminder, Rajat! We have problem with infrastructure for the testing, if it fails today then it looks like a candidate for 2024.","commit_id":"3f3112f7965ea41b24b17d305b37e42ab6ea0bff"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2b57e62a213913e79ccb869099d20a500fb13a81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3b6ad2b1_fbabf49e","in_reply_to":"fe0a5c65_88e85a77","updated":"2023-07-17 12:44:53.000000000","message":"I agree with Rajat\u0027s analysis.  The code was ready in time and reviewers\u0027 comments were addressed before the deadline, and the holdup was the YADRO Unified CI FC job, which had been responding back in April, so we did have evidence that the FC CI had been set up prior to the new driver freeze.  I don\u0027t see the point of holding this up for next cycle, especially since the FC CI was working within a few hours of the deadline.\n\n\u003e Note that this is a very narrow and rare case and we don\u0027t want to set a precedent allowing this to be merged.\n\nThis is a good point to make explicit.","commit_id":"3f3112f7965ea41b24b17d305b37e42ab6ea0bff"}],"cinder/volume/drivers/yadro/tatlin_fc.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f27987eb1cbb87eb7a424c3f44166cd125d8f110","unresolved":true,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    SUPPORTS_ACTIVE_ACTIVE \u003d True"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    # ThirdPartySystems wiki"},{"line_number":47,"context_line":"    CI_WIKI_NAME \u003d \"Yadro_Tatlin_Unified_CI\""}],"source_content_type":"text/x-python","patch_set":6,"id":"a4d4cbca_01ff70f4","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":33},"updated":"2023-07-03 20:57:59.000000000","message":"Since we don\u0027t have any CI testing for this currently, we need to rely on the vendor\u0027s words that this has been properly tested and it works.","commit_id":"ae6194f976d82d67582543b585243e1373de8d90"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"a8892da301413e650012f62a7a25e8770543be6b","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    SUPPORTS_ACTIVE_ACTIVE \u003d True"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    # ThirdPartySystems wiki"},{"line_number":47,"context_line":"    CI_WIKI_NAME \u003d \"Yadro_Tatlin_Unified_CI\""}],"source_content_type":"text/x-python","patch_set":6,"id":"ce90927a_b4ba90f9","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":33},"in_reply_to":"78767b4c_79ec25f8","updated":"2023-07-06 10:03:21.000000000","message":"yes, thanks, we run internal testing on 3 controllers in A-A usually","commit_id":"ae6194f976d82d67582543b585243e1373de8d90"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"b03882a169cd2a4a033844b766f046d069899dae","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    SUPPORTS_ACTIVE_ACTIVE \u003d True"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    # ThirdPartySystems wiki"},{"line_number":47,"context_line":"    CI_WIKI_NAME \u003d \"Yadro_Tatlin_Unified_CI\""}],"source_content_type":"text/x-python","patch_set":6,"id":"78767b4c_79ec25f8","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":33},"in_reply_to":"a4d4cbca_01ff70f4","updated":"2023-07-06 09:57:59.000000000","message":"Done","commit_id":"ae6194f976d82d67582543b585243e1373de8d90"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f27987eb1cbb87eb7a424c3f44166cd125d8f110","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        super(TatlinFCVolumeDriver, self).__init__(*args, **kwargs)"},{"line_number":51,"context_line":"        self.backend_name \u003d self.configuration.safe_get("},{"line_number":52,"context_line":"            \u0027volume_backend_name\u0027) or \u0027TatlinFC\u0027"},{"line_number":53,"context_line":"        self.DRIVER_VOLUME_TYPE \u003d \u0027FC\u0027"},{"line_number":54,"context_line":"        self._lookup_service \u003d fczm_utils.create_lookup_service()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _create_connection_info(self, volume, connector):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5703cd1a_99bed828","line":53,"range":{"start_line":53,"start_character":34,"end_line":53,"end_character":38},"updated":"2023-07-03 20:57:59.000000000","message":"we should use the constants defined here\n\nhttps://github.com/openstack/cinder/blob/25455c476f2d918d550ddf6f209cdfc05a2cf420/cinder/common/constants.py#L36","commit_id":"ae6194f976d82d67582543b585243e1373de8d90"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"b03882a169cd2a4a033844b766f046d069899dae","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        super(TatlinFCVolumeDriver, self).__init__(*args, **kwargs)"},{"line_number":51,"context_line":"        self.backend_name \u003d self.configuration.safe_get("},{"line_number":52,"context_line":"            \u0027volume_backend_name\u0027) or \u0027TatlinFC\u0027"},{"line_number":53,"context_line":"        self.DRIVER_VOLUME_TYPE \u003d \u0027FC\u0027"},{"line_number":54,"context_line":"        self._lookup_service \u003d fczm_utils.create_lookup_service()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _create_connection_info(self, volume, connector):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fba1c09_8e3322ae","line":53,"range":{"start_line":53,"start_character":34,"end_line":53,"end_character":38},"in_reply_to":"5703cd1a_99bed828","updated":"2023-07-06 09:57:59.000000000","message":"Done","commit_id":"ae6194f976d82d67582543b585243e1373de8d90"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f27987eb1cbb87eb7a424c3f44166cd125d8f110","unresolved":true,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _create_connection_info(self, volume, connector):"},{"line_number":57,"context_line":"        info \u003d {"},{"line_number":58,"context_line":"            \u0027driver_volume_type\u0027: \u0027fibre_channel\u0027,"},{"line_number":59,"context_line":"            \u0027data\u0027: self._create_volume_data(volume, connector)"},{"line_number":60,"context_line":"        }"},{"line_number":61,"context_line":"        return info"}],"source_content_type":"text/x-python","patch_set":6,"id":"2058e2a7_926be753","line":58,"range":{"start_line":58,"start_character":34,"end_line":58,"end_character":50},"updated":"2023-07-03 20:57:59.000000000","message":"this should also be taken from the constants\n\nhttps://github.com/openstack/cinder/blob/25455c476f2d918d550ddf6f209cdfc05a2cf420/cinder/common/constants.py#L37","commit_id":"ae6194f976d82d67582543b585243e1373de8d90"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"b03882a169cd2a4a033844b766f046d069899dae","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _create_connection_info(self, volume, connector):"},{"line_number":57,"context_line":"        info \u003d {"},{"line_number":58,"context_line":"            \u0027driver_volume_type\u0027: \u0027fibre_channel\u0027,"},{"line_number":59,"context_line":"            \u0027data\u0027: self._create_volume_data(volume, connector)"},{"line_number":60,"context_line":"        }"},{"line_number":61,"context_line":"        return info"}],"source_content_type":"text/x-python","patch_set":6,"id":"959bffe0_3a8ee0f3","line":58,"range":{"start_line":58,"start_character":34,"end_line":58,"end_character":50},"in_reply_to":"2058e2a7_926be753","updated":"2023-07-06 09:57:59.000000000","message":"Done","commit_id":"ae6194f976d82d67582543b585243e1373de8d90"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f27987eb1cbb87eb7a424c3f44166cd125d8f110","unresolved":true,"context_lines":[{"line_number":67,"context_line":"            iface \u003d p[\u0027params\u0027][\u0027ifname\u0027]"},{"line_number":68,"context_line":"            if self._export_ports and iface not in self._export_ports:"},{"line_number":69,"context_line":"                continue"},{"line_number":70,"context_line":"            ports.setdefault(iface, []).append(p[\u0027params\u0027][\u0027wwpn\u0027])"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        return ports"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"631862aa_1741fa31","line":70,"range":{"start_line":70,"start_character":29,"end_line":70,"end_character":34},"updated":"2023-07-03 20:57:59.000000000","message":"is it possible that iface is None? then the key will be None here","commit_id":"ae6194f976d82d67582543b585243e1373de8d90"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"b03882a169cd2a4a033844b766f046d069899dae","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            iface \u003d p[\u0027params\u0027][\u0027ifname\u0027]"},{"line_number":68,"context_line":"            if self._export_ports and iface not in self._export_ports:"},{"line_number":69,"context_line":"                continue"},{"line_number":70,"context_line":"            ports.setdefault(iface, []).append(p[\u0027params\u0027][\u0027wwpn\u0027])"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        return ports"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"f8edc626_9c2cff00","line":70,"range":{"start_line":70,"start_character":29,"end_line":70,"end_character":34},"in_reply_to":"631862aa_1741fa31","updated":"2023-07-06 09:57:59.000000000","message":"iface always is non-empty in storage API, the same is for wwpn","commit_id":"ae6194f976d82d67582543b585243e1373de8d90"}],"doc/source/configuration/block-storage/drivers/yadro-tatlin-volume-driver.rst":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"a7228d9032fbae27b914f92aceb24b5a4a22ce55","unresolved":true,"context_lines":[{"line_number":92,"context_line":".. code-block:: ini"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"   [fc-1]"},{"line_number":95,"context_line":"   volume_driver\u003dcinder.volume.drivers.yadro.tatlin_iscsi.TatlinFCVolumeDriver"},{"line_number":96,"context_line":"   san_ip\u003d\u003cmanagement_ip\u003e"},{"line_number":97,"context_line":"   san_login\u003d\u003clogin\u003e"},{"line_number":98,"context_line":"   san_password\u003d\u003cpassword\u003e"}],"source_content_type":"text/x-rst","patch_set":5,"id":"e521b3a2_06d66f09","line":95,"range":{"start_line":95,"start_character":45,"end_line":95,"end_character":57},"updated":"2023-05-18 06:43:23.000000000","message":"tatlin_fc ?","commit_id":"6b99ab5f5ecff95075de7b26c3247eda0af7e9a0"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"ec183c68da32ce7cd46ed4ab019d2a96333b297b","unresolved":false,"context_lines":[{"line_number":92,"context_line":".. code-block:: ini"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"   [fc-1]"},{"line_number":95,"context_line":"   volume_driver\u003dcinder.volume.drivers.yadro.tatlin_iscsi.TatlinFCVolumeDriver"},{"line_number":96,"context_line":"   san_ip\u003d\u003cmanagement_ip\u003e"},{"line_number":97,"context_line":"   san_login\u003d\u003clogin\u003e"},{"line_number":98,"context_line":"   san_password\u003d\u003cpassword\u003e"}],"source_content_type":"text/x-rst","patch_set":5,"id":"90424b85_0060fd7b","line":95,"range":{"start_line":95,"start_character":45,"end_line":95,"end_character":57},"in_reply_to":"e521b3a2_06d66f09","updated":"2023-05-22 11:33:00.000000000","message":"Done","commit_id":"6b99ab5f5ecff95075de7b26c3247eda0af7e9a0"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"fbfe7b486117a38451b3728be4483be49cd8e633","unresolved":false,"context_lines":[{"line_number":92,"context_line":".. code-block:: ini"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"   [fc-1]"},{"line_number":95,"context_line":"   volume_driver\u003dcinder.volume.drivers.yadro.tatlin_iscsi.TatlinFCVolumeDriver"},{"line_number":96,"context_line":"   san_ip\u003d\u003cmanagement_ip\u003e"},{"line_number":97,"context_line":"   san_login\u003d\u003clogin\u003e"},{"line_number":98,"context_line":"   san_password\u003d\u003cpassword\u003e"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9d924469_e09133a3","line":95,"range":{"start_line":95,"start_character":45,"end_line":95,"end_character":57},"in_reply_to":"e521b3a2_06d66f09","updated":"2023-05-22 04:58:27.000000000","message":"Done","commit_id":"6b99ab5f5ecff95075de7b26c3247eda0af7e9a0"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8cc394dd918ae560ef34cc1067ad0da4c75f59c3","unresolved":true,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"#. Ports"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"   Setup data Eth of FC ports you want to export volumes to."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"#. Hosts"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"8a0adf18_a7d73ee6","line":52,"range":{"start_line":52,"start_character":18,"end_line":52,"end_character":20},"updated":"2023-07-13 21:49:13.000000000","message":"or ?","commit_id":"055d431054c39d77664c04d19c3786fc806c3c7f"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"688d4037769c7b24448d8346b7ae0e6eb69f1a6f","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"#. Ports"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"   Setup data Eth of FC ports you want to export volumes to."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"#. Hosts"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"e4d36d54_32954f82","line":52,"range":{"start_line":52,"start_character":18,"end_line":52,"end_character":20},"in_reply_to":"8a0adf18_a7d73ee6","updated":"2023-07-14 07:46:21.000000000","message":"Done","commit_id":"055d431054c39d77664c04d19c3786fc806c3c7f"}]}