)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b8ec3258e5b088d5f927de8c10527c47c7b7aa63","unresolved":false,"context_lines":[{"line_number":23,"context_line":"data for the other backend will not be there."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This patch adds to the driver contributor documentation explicit"},{"line_number":26,"context_line":"guidelines on why this should not be done.  It also adds not comments to"},{"line_number":27,"context_line":"the code of the util methods that currently do this, and moves one"},{"line_number":28,"context_line":"method from cinder/volume/volume_utils.py into solidfire.py to hide it a"},{"line_number":29,"context_line":"bit more from developers."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1c8fc307_d654d765","line":26,"range":{"start_line":26,"start_character":44,"end_line":26,"end_character":72},"updated":"2024-01-12 11:20:19.000000000","message":"Weird phrasing","commit_id":"bdd09574477b996f42f44466059d381d74923820"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b97556b564e005f9ce7905bb1d9d6978b546442d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ede82e6d_6b909a94","updated":"2024-01-12 08:21:35.000000000","message":"LGTM","commit_id":"bdd09574477b996f42f44466059d381d74923820"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7165de0d92c75769128301cf87139fa69a8246e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"966db53f_ed9e9d8b","updated":"2024-01-12 13:31:41.000000000","message":"LGTM thanks!","commit_id":"074ca04f7c1ac608d90be6bb9111a4a903b82f6c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7ed6a87efce4a1fd48bb4cbf96e557de5f12e605","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d0e46b5c_4a9fe21f","updated":"2024-02-06 13:28:27.000000000","message":"Change looks good, but I think you forgot to delete the method from volume_utils.","commit_id":"22fbd617bcee4975eb462d63e54ffe12a4080861"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ebd82645d011b39dfa24f81c5733af8b2d734420","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"19ef4d62_85913779","updated":"2024-01-18 13:53:22.000000000","message":"recheck grenade failed with SSH issue, looks unrelated\n\n2024-01-17 19:19:31.654 | failed to get http://169.254.169.254/2009-04-04/user-data\n2024-01-17 19:19:31.654 | warning: no ec2 metadata for user-data\n2024-01-17 19:19:31.654 | Top of dropbear init script\n2024-01-17 19:19:31.654 | Starting dropbear sshd: OK\n2024-01-17 19:19:31.915 | + /opt/stack/new/grenade/projects/70_cinder/resources.sh:create:199 :   die 199 \u0027SSH to the client did not work, something very wrong\u0027\n2024-01-17 19:19:31.917 | + /opt/stack/new/devstack/functions-common:die:264 :   local exitcode\u003d0\n2024-01-17 19:19:31.920 | [Call Trace]\n2024-01-17 19:19:31.920 | /opt/stack/new/grenade/projects/70_cinder/resources.sh:302:create\n2024-01-17 19:19:31.920 | /opt/stack/new/grenade/projects/70_cinder/resources.sh:199:die\n2024-01-17 19:19:31.925 | [ERROR] /opt/stack/new/grenade/projects/70_cinder/resources.sh:199 SSH to the client did not work, something very wrong","commit_id":"22fbd617bcee4975eb462d63e54ffe12a4080861"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8838d4f17e9eb9af7da278a6fd2bc6c769814338","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"db3f98bd_83df0fc2","updated":"2024-01-25 19:35:32.000000000","message":"recheck py38 job failed on the following test\n\ncinder.tests.unit.volume.drivers.nec.v.test_internal_nec_rest_iscsi.VStorageRESTISCSIDriverTest.test_create_snapshot\n\nTraceback (most recent call last):\n  File \"/home/zuul/src/opendev.org/openstack/cinder/cinder/volume/drivers/hitachi/hbsd_rest_api.py\", line 330, in _request\n    rsp \u003d session.request(method, url,\n  File \"/usr/lib/python3.8/unittest/mock.py\", line 1081, in __call__\n    return self._mock_call(*args, **kwargs)\n  File \"/usr/lib/python3.8/unittest/mock.py\", line 1085, in _mock_call\n    return self._execute_mock_call(*args, **kwargs)\n  File \"/usr/lib/python3.8/unittest/mock.py\", line 1142, in _execute_mock_call\n    result \u003d next(effect)\nStopIteration\n\n\nlooks like the method was expected to have been called 4 times[1] but was called 5 times which erred out\n\n[1] https://github.com/openstack/cinder/blob/2a18843ab928ad104ac9b535f28fe1eea5c1a5c7/cinder/tests/unit/volume/drivers/nec/v/test_internal_nec_rest_iscsi.py#L584-L587\n\nTraceback:\n\n2024-01-18 14:25:35.093794 | ubuntu-focal | Captured traceback:\n2024-01-18 14:25:35.093812 | ubuntu-focal | ~~~~~~~~~~~~~~~~~~~\n2024-01-18 14:25:35.093828 | ubuntu-focal |     Traceback (most recent call last):\n2024-01-18 14:25:35.093843 | ubuntu-focal |\n2024-01-18 14:25:35.093858 | ubuntu-focal |       File \"/home/zuul/src/opendev.org/openstack/cinder/cinder/volume/drivers/hitachi/hbsd_rest_api.py\", line 330, in _request\n2024-01-18 14:25:35.093892 | ubuntu-focal |     rsp \u003d session.request(method, url,\n2024-01-18 14:25:35.093908 | ubuntu-focal |\n2024-01-18 14:25:35.093923 | ubuntu-focal |       File \"/usr/lib/python3.8/unittest/mock.py\", line 1081, in __call__\n2024-01-18 14:25:35.093939 | ubuntu-focal |     return self._mock_call(*args, **kwargs)\n2024-01-18 14:25:35.093954 | ubuntu-focal |\n2024-01-18 14:25:35.093969 | ubuntu-focal |       File \"/usr/lib/python3.8/unittest/mock.py\", line 1085, in _mock_call\n2024-01-18 14:25:35.093983 | ubuntu-focal |     return self._execute_mock_call(*args, **kwargs)\n2024-01-18 14:25:35.093999 | ubuntu-focal |\n2024-01-18 14:25:35.094013 | ubuntu-focal |       File \"/usr/lib/python3.8/unittest/mock.py\", line 1142, in _execute_mock_call\n2024-01-18 14:25:35.094029 | ubuntu-focal |     result \u003d next(effect)\n2024-01-18 14:25:35.094043 | ubuntu-focal |\n2024-01-18 14:25:35.094058 | ubuntu-focal |     StopIteration\n2024-01-18 14:25:35.094072 | ubuntu-focal |\n2024-01-18 14:25:35.094087 | ubuntu-focal |\n2024-01-18 14:25:35.094102 | ubuntu-focal | During handling of the above exception, another exception occurred:\n2024-01-18 14:25:35.094116 | ubuntu-focal |\n2024-01-18 14:25:35.094131 | ubuntu-focal |\n2024-01-18 14:25:35.094145 | ubuntu-focal |     Traceback (most recent call last):\n2024-01-18 14:25:35.094160 | ubuntu-focal |\n2024-01-18 14:25:35.094178 | ubuntu-focal |       File \"/usr/lib/python3.8/unittest/mock.py\", line 1325, in patched\n2024-01-18 14:25:35.094195 | ubuntu-focal |     return func(*newargs, **newkeywargs)\n2024-01-18 14:25:35.094210 | ubuntu-focal |\n2024-01-18 14:25:35.094232 | ubuntu-focal |       File \"/home/zuul/src/opendev.org/openstack/cinder/cinder/tests/unit/volume/drivers/nec/v/test_internal_nec_rest_iscsi.py\", line 591, in test_create_snapshot\n2024-01-18 14:25:35.115641 | ubuntu-focal |     ret \u003d self.driver.create_snapshot(TEST_SNAPSHOT[0])\n2024-01-18 14:25:35.115697 | ubuntu-focal |\n2024-01-18 14:25:35.115716 | ubuntu-focal |       File \"/home/zuul/src/opendev.org/openstack/cinder/cinder/volume/volume_utils.py\", line 1490, in trace_logging_wrapper\n2024-01-18 14:25:35.115733 | ubuntu-focal |     return f(*args, **kwargs)\n2024-01-18 14:25:35.115758 | ubuntu-focal |\n2024-01-18 14:25:35.115776 | ubuntu-focal |       File \"/home/zuul/src/opendev.org/openstack/cinder/cinder/volume/drivers/hitachi/hbsd_iscsi.py\", line 165, in create_snapshot\n2024-01-18 14:25:35.115810 | ubuntu-focal |     return self.common.create_snapshot(snapshot)\n2024-01-18 14:25:35.115842 | ubuntu-focal |\n2024-01-18 14:25:35.115875 | ubuntu-focal |       File \"/home/zuul/src/opendev.org/openstack/cinder/cinder/volume/drivers/hitachi/hbsd_common.py\", line 422, in create_snapshot\n2024-01-18 14:25:35.115903 | ubuntu-focal |     new_ldev \u003d self.copy_on_storage(\n2024-01-18 14:25:35.115923 | ubuntu-focal |\n2024-01-18 14:25:35.115938 | ubuntu-focal |       File \"/home/zuul/src/opendev.org/openstack/cinder/cinder/volume/drivers/hitachi/hbsd_common.py\", line 308, in copy_on_storage\n2024-01-18 14:25:35.115954 | ubuntu-focal |     self.output_log(MSG.DELETE_LDEV_FAILED, ldev\u003dsvol)\n2024-01-18 14:25:35.115969 | ubuntu-focal |\n2024-01-18 14:25:35.115993 | ubuntu-focal |       File \"/home/zuul/src/opendev.org/openstack/cinder/.tox/py38/lib/python3.8/site-packages/oslo_utils/excutils.py\", line 227, in __exit__\n2024-01-18 14:25:35.127516 | ubuntu-focal |     self.force_reraise()\n2024-01-18 14:25:35.127566 | ubuntu-focal |\n2024-01-18 14:25:35.127585 | ubuntu-focal |       File \"/home/zuul/src/opendev.org/openstack/cinder/.tox/py38/lib/python3.8/site-packages/oslo_utils/excutils.py\", line 200, in force_reraise\n2024-01-18 14:25:35.127601 | ubuntu-focal |     raise self.value\n2024-01-18 14:25:35.127617 | ubuntu-focal |\n2024-01-18 14:25:35.127633 | ubuntu-focal |       File \"/home/zuul/src/opendev.org/openstack/cinder/cinder/volume/drivers/hitachi/hbsd_common.py\", line 299, in copy_on_storage\n2024-01-18 14:25:35.127648 | ubuntu-focal |     self.create_pair_on_storage(\n2024-01-18 14:25:35.127664 | ubuntu-focal |\n2024-01-18 14:25:35.127679 | ubuntu-focal |       File \"/home/zuul/src/opendev.org/openstack/cinder/cinder/volume/drivers/hitachi/hbsd_rest.py\", line 520, in create_pair_on_storage\n2024-01-18 14:25:35.127696 | ubuntu-focal |     self._create_snap_pair(pvol, svol)\n2024-01-18 14:25:35.127729 | ubuntu-focal |\n2024-01-18 14:25:35.127764 | ubuntu-focal |       File \"/home/zuul/src/opendev.org/openstack/cinder/cinder/volume/drivers/hitachi/hbsd_rest.py\", line 471, in _create_snap_pair\n2024-01-18 14:25:35.127797 | ubuntu-focal |     self.output_log(\n2024-01-18 14:25:35.127823 | ubuntu-focal |\n2024-01-18 14:25:35.127840 | ubuntu-focal |       File \"/home/zuul/src/opendev.org/openstack/cinder/.tox/py38/lib/python3.8/site-packages/oslo_utils/excutils.py\", line 227, in __exit__\n2024-01-18 14:25:35.127871 | ubuntu-focal |     self.force_reraise()\n2024-01-18 14:25:35.127896 | ubuntu-focal |\n2024-01-18 14:25:35.127929 | ubuntu-focal |       File \"/home/zuul/src/opendev.org/openstack/cinder/.tox/py38/lib/python3.8/site-packages/oslo_utils/excutils.py\", line 200, in force_reraise\n2024-01-18 14:25:35.127966 | ubuntu-focal |     raise self.value\n2024-01-18 14:25:35.139610 | ubuntu-focal |\n2024-01-18 14:25:35.139658 | ubuntu-focal |       File \"/home/zuul/src/opendev.org/openstack/cinder/cinder/volume/drivers/hitachi/hbsd_rest.py\", line 465, in _create_snap_pair\n2024-01-18 14:25:35.139677 | ubuntu-focal |     self._wait_copy_pair_status(svol, PSUS)\n2024-01-18 14:25:35.139694 | ubuntu-focal |\n2024-01-18 14:25:35.139709 | ubuntu-focal |       File \"/home/zuul/src/opendev.org/openstack/cinder/cinder/volume/drivers/hitachi/hbsd_rest.py\", line 434, in _wait_copy_pair_status\n2024-01-18 14:25:35.139724 | ubuntu-focal |     if not loop.start(interval\u003dinterval).wait():\n2024-01-18 14:25:35.139739 | ubuntu-focal |\n2024-01-18 14:25:35.139754 | ubuntu-focal |       File \"/home/zuul/src/opendev.org/openstack/cinder/.tox/py38/lib/python3.8/site-packages/eventlet/event.py\", line 125, in wait\n2024-01-18 14:25:35.139769 | ubuntu-focal |     result \u003d hub.switch()\n2024-01-18 14:25:35.139784 | ubuntu-focal |\n2024-01-18 14:25:35.139799 | ubuntu-focal |       File \"/home/zuul/src/opendev.org/openstack/cinder/.tox/py38/lib/python3.8/site-packages/eventlet/hubs/hub.py\", line 313, in switch\n2024-01-18 14:25:35.139814 | ubuntu-focal |     return self.greenlet.switch()\n2024-01-18 14:25:35.139829 | ubuntu-focal |\n2024-01-18 14:25:35.139844 | ubuntu-focal |       File \"/home/zuul/src/opendev.org/openstack/cinder/.tox/py38/lib/python3.8/site-packages/oslo_service/loopingcall.py\", line 150, in _run_loop\n2024-01-18 14:25:35.139859 | ubuntu-focal |     result \u003d func(*self.args, **self.kw)\n2024-01-18 14:25:35.139874 | ubuntu-focal |\n2024-01-18 14:25:35.139897 | ubuntu-focal |       File \"/home/zuul/src/opendev.org/openstack/cinder/cinder/volume/drivers/hitachi/hbsd_rest.py\", line 426, in _wait_for_copy_pair_status\n2024-01-18 14:25:35.159617 | ubuntu-focal |     if self._get_copy_pair_status(ldev) in status:\n2024-01-18 14:25:35.159666 | ubuntu-focal |\n2024-01-18 14:25:35.159692 | ubuntu-focal |       File \"/home/zuul/src/opendev.org/openstack/cinder/cinder/volume/drivers/hitachi/hbsd_rest.py\", line 405, in _get_copy_pair_status\n2024-01-18 14:25:35.159718 | ubuntu-focal |     result_s \u003d self.client.get_snapshots(params_s)\n2024-01-18 14:25:35.159750 | ubuntu-focal |\n2024-01-18 14:25:35.159783 | ubuntu-focal |       File \"/home/zuul/src/opendev.org/openstack/cinder/cinder/volume/drivers/hitachi/hbsd_rest_api.py\", line 836, in get_snapshots\n2024-01-18 14:25:35.159814 | ubuntu-focal |     return self._get_objects(url, params\u003dparams)\n2024-01-18 14:25:35.159846 | ubuntu-focal |\n2024-01-18 14:25:35.159877 | ubuntu-focal |       File \"/home/zuul/src/opendev.org/openstack/cinder/cinder/volume/drivers/hitachi/hbsd_rest_api.py\", line 606, in _get_objects\n2024-01-18 14:25:35.159908 | ubuntu-focal |     rsp \u003d self._request(\"GET\", url, params\u003dparams, **kwargs)[0]\n2024-01-18 14:25:35.159938 | ubuntu-focal |\n2024-01-18 14:25:35.159969 | ubuntu-focal |       File \"/home/zuul/src/opendev.org/openstack/cinder/cinder/volume/volume_utils.py\", line 1490, in trace_logging_wrapper\n2024-01-18 14:25:35.160000 | ubuntu-focal |     return f(*args, **kwargs)\n2024-01-18 14:25:35.160031 | ubuntu-focal |\n2024-01-18 14:25:35.160061 | ubuntu-focal |       File \"/home/zuul/src/opendev.org/openstack/cinder/cinder/volume/drivers/hitachi/hbsd_rest_api.py\", line 349, in _request\n2024-01-18 14:25:35.160092 | ubuntu-focal |     raise exception.VolumeDriverException(message)\n2024-01-18 14:25:35.160123 | ubuntu-focal |\n2024-01-18 14:25:35.160159 | ubuntu-focal |     cinder.exception.VolumeDriverException: Volume driver reported an error: NEC error occurred. Failed to communicate with the REST API server. (exception: \u003cclass \u0027StopIteration\u0027\u003e, message: , method: GET, url: https://172.16.18.108:23451/ConfigurationManager/v1/objects/storages/886000123456/snapshots, params: {\u0027svolLdevId\u0027: 1}, body: None)\n2024-01-18 14:25:35.171577 | ubuntu-focal |\n2024-01-18 14:25:35.171632 | ubuntu-focal |","commit_id":"22fbd617bcee4975eb462d63e54ffe12a4080861"}],"cinder/volume/drivers/solidfire.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b97556b564e005f9ce7905bb1d9d6978b546442d","unresolved":true,"context_lines":[{"line_number":2406,"context_line":"    #       Any feature that relies on this will only work when a single"},{"line_number":2407,"context_line":"    #       cinder-volume service runs with multi-backends, but won\u0027t work when"},{"line_number":2408,"context_line":"    #       multiple cinder-volume services run with single-backends."},{"line_number":2409,"context_line":"    #       Code is not removed to avoid breaking existing features."},{"line_number":2410,"context_line":"    @staticmethod"},{"line_number":2411,"context_line":"    def get_backend_configuration(backend_name, backend_opts\u003dNone):"},{"line_number":2412,"context_line":"        \"\"\"Get a configuration object for a specific backend.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"b65a2c19_3a2a9df4","line":2409,"range":{"start_line":2409,"start_character":0,"end_line":2409,"end_character":68},"updated":"2024-01-12 08:21:35.000000000","message":"nit: this part is confusing here since this method is correctly added here (and doesn\u0027t need to be removed)","commit_id":"bdd09574477b996f42f44466059d381d74923820"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b8ec3258e5b088d5f927de8c10527c47c7b7aa63","unresolved":false,"context_lines":[{"line_number":2406,"context_line":"    #       Any feature that relies on this will only work when a single"},{"line_number":2407,"context_line":"    #       cinder-volume service runs with multi-backends, but won\u0027t work when"},{"line_number":2408,"context_line":"    #       multiple cinder-volume services run with single-backends."},{"line_number":2409,"context_line":"    #       Code is not removed to avoid breaking existing features."},{"line_number":2410,"context_line":"    @staticmethod"},{"line_number":2411,"context_line":"    def get_backend_configuration(backend_name, backend_opts\u003dNone):"},{"line_number":2412,"context_line":"        \"\"\"Get a configuration object for a specific backend.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"24e84809_a9dd4301","line":2409,"range":{"start_line":2409,"start_character":0,"end_line":2409,"end_character":68},"in_reply_to":"b65a2c19_3a2a9df4","updated":"2024-01-12 11:20:19.000000000","message":"No, this is a bad case of doing this, as it is being used in the `migrate_volume` method.\nAs the commit message mentions this is only OK when there is a non-backend section being read.\nI have reworded it a bit.","commit_id":"bdd09574477b996f42f44466059d381d74923820"}],"cinder/volume/volume_utils.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7ed6a87efce4a1fd48bb4cbf96e557de5f12e605","unresolved":true,"context_lines":[{"line_number":1352,"context_line":"                              base_image_ref\u003dbase_image_ref)"},{"line_number":1353,"context_line":""},{"line_number":1354,"context_line":""},{"line_number":1355,"context_line":"def get_backend_configuration(backend_name, backend_opts\u003dNone):"},{"line_number":1356,"context_line":"    \"\"\"Get a configuration object for a specific backend.\"\"\""},{"line_number":1357,"context_line":""},{"line_number":1358,"context_line":"    config_stanzas \u003d CONF.list_all_sections()"}],"source_content_type":"text/x-python","patch_set":6,"id":"77826d50_291801c0","line":1355,"range":{"start_line":1355,"start_character":0,"end_line":1355,"end_character":63},"updated":"2024-02-06 13:28:27.000000000","message":"You forgot to delete this method that was moved to be local to solidfire.  (You did move the tests, though.)","commit_id":"22fbd617bcee4975eb462d63e54ffe12a4080861"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"77fb15e2a9acfe70b1d0585bd1343f85f890cd8f","unresolved":false,"context_lines":[{"line_number":1352,"context_line":"                              base_image_ref\u003dbase_image_ref)"},{"line_number":1353,"context_line":""},{"line_number":1354,"context_line":""},{"line_number":1355,"context_line":"def get_backend_configuration(backend_name, backend_opts\u003dNone):"},{"line_number":1356,"context_line":"    \"\"\"Get a configuration object for a specific backend.\"\"\""},{"line_number":1357,"context_line":""},{"line_number":1358,"context_line":"    config_stanzas \u003d CONF.list_all_sections()"}],"source_content_type":"text/x-python","patch_set":6,"id":"00c740aa_49bb33aa","line":1355,"range":{"start_line":1355,"start_character":0,"end_line":1355,"end_character":63},"in_reply_to":"77826d50_291801c0","updated":"2024-10-07 15:34:08.000000000","message":"Done!","commit_id":"22fbd617bcee4975eb462d63e54ffe12a4080861"}]}