)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0061a75ad97af9ae4e040ef7e5eb55b3f8b3a516","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The problem manifests itself as an unstable result of"},{"line_number":10,"context_line":"test_check_force. It fails at Zuul once in a while. But this"},{"line_number":11,"context_line":"seems impossible: there is no randomness or timing component."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"But apparently someone forgot a deepcopy()."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8dd4bca3_5dca592a","line":11,"range":{"start_line":11,"start_character":18,"end_line":11,"end_character":61},"updated":"2023-03-17 13:41:59.000000000","message":"Note that we run unit tests w/ \"stestr run --random\" from tox.ini which randomizes the order.","commit_id":"bb3de1db4b1672d03977db667eca448014d5c859"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"5adb899168fd70be2590fac554cbf3fc64b4ecf9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The problem manifests itself as an unstable result of"},{"line_number":10,"context_line":"test_check_force. It fails at Zuul once in a while. But this"},{"line_number":11,"context_line":"seems impossible: there is no randomness or timing component."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"But apparently someone forgot a deepcopy()."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"479b1798_8558cd2d","line":11,"range":{"start_line":11,"start_character":18,"end_line":11,"end_character":61},"in_reply_to":"8dd4bca3_5dca592a","updated":"2023-03-17 15:14:36.000000000","message":"Done\n\nI\u0027m going to refine the explanation a little.","commit_id":"bb3de1db4b1672d03977db667eca448014d5c859"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a1fe874e0050a1b6d9b7d9bf28bf6279f7931468","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1ddb3143_b162acae","updated":"2023-03-17 15:06:32.000000000","message":"LGTM.","commit_id":"bb3de1db4b1672d03977db667eca448014d5c859"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bdb3f1d5a2130a9e66ed81ef71a952394eeb8883","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"43556c06_f6aee067","updated":"2023-03-17 15:13:38.000000000","message":"changes make sense to me, should fix the failure. LGTM.","commit_id":"bb3de1db4b1672d03977db667eca448014d5c859"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5fe840c62de491f4164d69661929817c6376d48d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0b37270f_93cfcde9","updated":"2023-03-17 15:13:57.000000000","message":"for info, this is the failure https://edb974b00619de186ed1-87ebbe2a3fb57e48288a340969a02570.ssl.cf5.rackcdn.com/852654/16/gate/openstack-tox-py39/3745928/testr_results.html","commit_id":"bb3de1db4b1672d03977db667eca448014d5c859"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"3db4177de23a4a5446d01af9cf7b21640a9db530","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3b466b86_58edeaeb","in_reply_to":"0b37270f_93cfcde9","updated":"2023-03-17 15:19:15.000000000","message":"The failing test_check_force is not the only failure, as it turned out. This can happen too:\n\n2023-03-17 13:40:33.815345 | ubuntu-jammy | cinder.tests.unit.volume.drivers.dell_emc.powermax.test_powermax_masking.PowerMaxMaskingTest.test_move_volume_between_storage_groups\n.................\n2023-03-17 13:40:33.815466 | ubuntu-jammy |     AssertionError: expected call not found.\n2023-03-17 13:40:33.815676 | ubuntu-jammy | Expected: modify_storage_group(\u0027000197800123\u0027, \u0027OS-HostX-SRP_1-Diamond-DSS-OS-iscsi-PG\u0027, {\u0027executionOption\u0027: \u0027ASYNCHRONOUS\u0027, \u0027editStorageGroupActionParam\u0027: {\u0027moveVolumeToStorageGroupParam\u0027: {\u0027volumeId\u0027: [\u002700001\u0027], \u0027storageGroupId\u0027: \u0027OS-HostX-SRP_1-DiamondDSS-OS-fibre-PG\u0027, \u0027force\u0027: \u0027false\u0027}}})\n2023-03-17 13:40:33.815724 | ubuntu-jammy | Actual: modify_storage_group(\u0027000197800123\u0027, \u0027OS-HostX-SRP_1-Diamond-DSS-OS-iscsi-PG\u0027, {\u0027executionOption\u0027: \u0027ASYNCHRONOUS\u0027, \u0027editStorageGroupActionParam\u0027: {\u0027moveVolumeToStorageGroupParam\u0027: {\u0027volumeId\u0027: [\u002700001\u0027], \u0027storageGroupId\u0027: \u0027OS-HostX-SRP_1-DiamondDSS-OS-fibre-PG\u0027, \u0027force\u0027: \u0027true\u0027}}})","commit_id":"bb3de1db4b1672d03977db667eca448014d5c859"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d0f3fad53b29c4cacf0b93afeeb3414d0ab6e951","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8e460981_85f42952","in_reply_to":"3b466b86_58edeaeb","updated":"2023-03-17 19:34:50.000000000","message":"yes addressing it here https://review.opendev.org/c/openstack/cinder/+/877826","commit_id":"bb3de1db4b1672d03977db667eca448014d5c859"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2974fce03a1888a424ec02493043c95c033b7bb1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"67e151c9_6e6e6671","updated":"2023-03-17 20:05:54.000000000","message":"I\u0027m ok with the commit message revision.","commit_id":"d7cf4a89abf68404bb32f0798fe590e846a62164"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d0f3fad53b29c4cacf0b93afeeb3414d0ab6e951","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8cf808ae_365be409","updated":"2023-03-17 19:34:50.000000000","message":"commit message change, still LGTM.","commit_id":"d7cf4a89abf68404bb32f0798fe590e846a62164"}],"cinder/tests/unit/volume/drivers/dell_emc/powermax/test_powermax_rest.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bdb3f1d5a2130a9e66ed81ef71a952394eeb8883","unresolved":true,"context_lines":[{"line_number":1279,"context_line":"                self.data.array, \u0027replication\u0027, resource_type,"},{"line_number":1280,"context_line":"                payload, private\u003d\u0027/private\u0027)"},{"line_number":1281,"context_line":""},{"line_number":1282,"context_line":"    def test_modify_volume_snap(self):"},{"line_number":1283,"context_line":"        array \u003d self.data.array"},{"line_number":1284,"context_line":"        source_id \u003d self.data.device_id"},{"line_number":1285,"context_line":"        target_id \u003d self.data.volume_snap_vx["}],"source_content_type":"text/x-python","patch_set":1,"id":"000b3230_598387ad","line":1282,"range":{"start_line":1282,"start_character":8,"end_line":1282,"end_character":31},"updated":"2023-03-17 15:13:38.000000000","message":"this test wasn\u0027t part of the failure but changes make sense","commit_id":"bb3de1db4b1672d03977db667eca448014d5c859"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a1fe874e0050a1b6d9b7d9bf28bf6279f7931468","unresolved":true,"context_lines":[{"line_number":2565,"context_line":"            \u0027false\u0027, self.rest._check_force(extra_specs))"},{"line_number":2566,"context_line":"        self.assertEqual("},{"line_number":2567,"context_line":"            \u0027false\u0027, self.rest._check_force("},{"line_number":2568,"context_line":"                extra_specs, force_flag\u003dFalse))"},{"line_number":2569,"context_line":"        self.assertEqual("},{"line_number":2570,"context_line":"            \u0027true\u0027, self.rest._check_force("},{"line_number":2571,"context_line":"                extra_specs, force_flag\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":1,"id":"062f292d_eadfe005","line":2568,"range":{"start_line":2568,"start_character":16,"end_line":2568,"end_character":27},"updated":"2023-03-17 15:06:32.000000000","message":"The locally defined extra_specs are identical to the self.data.extra_specs except for the value of \u0027array\u0027, so I can\u0027t see a reason why the local ones weren\u0027t used consistently in the first place.  In other words, I think Pete\u0027s change is fine.","commit_id":"bb3de1db4b1672d03977db667eca448014d5c859"}]}