)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"139f8b9b976c7298d3c8367f7de5295ced70aebc","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Simon Dodsley \u003csimon@purestorage.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-03-28 18:07:00 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Pure Storage] Add NVMe-TCP transport type to NVMe driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add NVMe-TCP to the existing NVMe driver, which currently supports RoCE."},{"line_number":10,"context_line":"This change extends the parameter ``pure_nvme_transport`` to allow the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"b2900c19_c1df42ad","line":7,"updated":"2023-04-20 12:56:27.000000000","message":"The first line should be limited to 50 characters.\nSubsequent lines should be wrapped at 72 characters.\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"c3ea7a7dd8d35241954774f348f666b247e798ee","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Simon Dodsley \u003csimon@purestorage.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-03-28 18:07:00 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Pure Storage] Add NVMe-TCP transport type to NVMe driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add NVMe-TCP to the existing NVMe driver, which currently supports RoCE."},{"line_number":10,"context_line":"This change extends the parameter ``pure_nvme_transport`` to allow the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"e9f117c4_ec94a817","line":7,"in_reply_to":"b2900c19_c1df42ad","updated":"2023-04-20 13:25:35.000000000","message":"Ack","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"95150ef2da2e0d026c6319313c6eae3d74672bb8","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Simon Dodsley \u003csimon@purestorage.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-04-20 13:26:01 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Pure Storage] Add TCP transport type to NVMe driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add NVMe-TCP to the existing NVMe driver, which currently supports RoCE."},{"line_number":10,"context_line":"This change extends the parameter ``pure_nvme_transport`` to allow the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9d8c0804_dbcad5c9","line":7,"updated":"2023-04-21 08:43:01.000000000","message":"nit: This line has 53 chars (limit is 50 chars).","commit_id":"dc77207e4c73950f1cacee5c9022586821ea6b59"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"f571a39597024da0bd3a6feaf97a7e3c0313414e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Simon Dodsley \u003csimon@purestorage.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-04-20 13:26:01 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Pure Storage] Add TCP transport type to NVMe driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add NVMe-TCP to the existing NVMe driver, which currently supports RoCE."},{"line_number":10,"context_line":"This change extends the parameter ``pure_nvme_transport`` to allow the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9f5fcbc3_a9ea00ac","line":7,"in_reply_to":"9d8c0804_dbcad5c9","updated":"2023-05-03 14:58:07.000000000","message":"Done","commit_id":"dc77207e4c73950f1cacee5c9022586821ea6b59"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"95150ef2da2e0d026c6319313c6eae3d74672bb8","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Pure Storage] Add TCP transport type to NVMe driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add NVMe-TCP to the existing NVMe driver, which currently supports RoCE."},{"line_number":10,"context_line":"This change extends the parameter ``pure_nvme_transport`` to allow the"},{"line_number":11,"context_line":"option ``tcp``."},{"line_number":12,"context_line":"Additional checks are performed on the backend to ensure that the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"15f2af0b_9feb08b9","line":9,"updated":"2023-04-21 08:43:01.000000000","message":"nit: This line has 73 chars (limit is 72 chars).","commit_id":"dc77207e4c73950f1cacee5c9022586821ea6b59"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"f571a39597024da0bd3a6feaf97a7e3c0313414e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Pure Storage] Add TCP transport type to NVMe driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add NVMe-TCP to the existing NVMe driver, which currently supports RoCE."},{"line_number":10,"context_line":"This change extends the parameter ``pure_nvme_transport`` to allow the"},{"line_number":11,"context_line":"option ``tcp``."},{"line_number":12,"context_line":"Additional checks are performed on the backend to ensure that the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9ff11984_d824d836","line":9,"in_reply_to":"15f2af0b_9feb08b9","updated":"2023-05-03 14:58:07.000000000","message":"Done","commit_id":"dc77207e4c73950f1cacee5c9022586821ea6b59"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"fd089a9f76ac461825022f78ae7b2bfbbd789476","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0ec3f2da_8acd03bd","updated":"2023-03-24 20:32:51.000000000","message":"run Pure Storage CI","commit_id":"3d348ee8b455bb0d9eb88e8baaa8e95099d7a1f3"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"1f776d3381fc2fef1f07a29457fdd9ca15a2e7a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1b818fd2_9f6356a6","updated":"2023-03-25 04:04:09.000000000","message":"run Pure Storage CI","commit_id":"3d348ee8b455bb0d9eb88e8baaa8e95099d7a1f3"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"acd4240b419a259b5041d83b0baf0c10bccd156c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"526f13c2_83da01c2","updated":"2023-03-22 14:43:05.000000000","message":"run Pure Storage CI","commit_id":"3d348ee8b455bb0d9eb88e8baaa8e95099d7a1f3"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"d0d8e39a4c7d38a60fd1b9409e7514422219e15b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5707c8f1_3592f485","updated":"2023-03-24 16:44:18.000000000","message":"run Pure Storage CI","commit_id":"3d348ee8b455bb0d9eb88e8baaa8e95099d7a1f3"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"cb74cd0f120feb227bd47f08272e8da8ce54d214","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a3f9ff10_67f6098b","updated":"2023-03-25 21:11:07.000000000","message":"run Pure Storage CI","commit_id":"3d348ee8b455bb0d9eb88e8baaa8e95099d7a1f3"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"09992575f99d93df8dca90a4ff8ea47c7f1eb6e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"17886e05_18231a13","updated":"2023-03-27 15:25:16.000000000","message":"run Pure Storage CI","commit_id":"3c25426048d6cb634ea62a13f1e4cd0e0935f1cc"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"4b01ed8773ba9e658b70d2c474b57920679261f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"79672792_842b2254","updated":"2023-03-27 19:23:20.000000000","message":"run Pure Storage CI","commit_id":"3c25426048d6cb634ea62a13f1e4cd0e0935f1cc"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"c0c39c7983adbd8e36928010a3db1f7851cd217c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ff1dc452_24baab1f","updated":"2023-03-27 15:55:36.000000000","message":"run Pure Storage CI","commit_id":"3c25426048d6cb634ea62a13f1e4cd0e0935f1cc"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"139f8b9b976c7298d3c8367f7de5295ced70aebc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"39154912_bd967e9e","updated":"2023-04-20 12:56:27.000000000","message":"Few comments/queries inline","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"6a0619746507b134278872af9995c726402c0598","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c265e565_046f23af","updated":"2023-04-20 12:57:40.000000000","message":"Forgot to put my vote in previous message.","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"2a2c62da45f3af70558dff36ef50294db484cece","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"67bbd091_5fb3c6ae","updated":"2023-04-19 17:31:41.000000000","message":"Hi, Simon. Overall, patch looks good to me, just added one question inline.","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"659ab312b17516dd948e387406ecd88a48e8f124","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"54e28c45_782d69ae","updated":"2023-04-19 18:03:21.000000000","message":"LGTM.","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"f958dacecc70638669a5aec06b4ba579b03cf268","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6e7c3af2_af04fa13","updated":"2023-03-31 01:10:09.000000000","message":"recheck","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"11f6a60d4e357e6aee168a8e85f6878a3fb514c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8554b5a4_2ef22ee7","updated":"2023-03-31 21:51:10.000000000","message":"recheck","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"386c6ef364ebe79fc6f2530c1cd5f45a50822237","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"94444210_ff4ecad7","updated":"2023-03-30 20:47:40.000000000","message":"recheck","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"37e3e593ff01b800d14c710c51f102ff08d5e537","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"98107011_47b47274","updated":"2023-03-31 03:51:54.000000000","message":"recheck","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"014ae2e31f3b76af3c128c0cd807c1c48e556649","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a825258a_9dfa505c","updated":"2023-03-30 13:01:37.000000000","message":"recheck","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"8c7ca15b93c14f113d718637e0318583741420c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a8e616de_d94608fd","updated":"2023-03-31 13:19:38.000000000","message":"recheck","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"6fb08f530854ddd009abde4d3aa1f30d189b9cf9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"af4366a9_3550ee45","updated":"2023-03-30 19:00:01.000000000","message":"recheck","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"870450d76d02fc51adb683dfb3ea0a6bd085f875","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e9d2f09f_7206b22b","updated":"2023-03-29 16:25:32.000000000","message":"recheck","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"c7029717945fa1ddf2a6bc25971770a6301b1947","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e4e00eaf_6c3782e7","updated":"2023-04-01 04:24:08.000000000","message":"run Pure Storage CI","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"95150ef2da2e0d026c6319313c6eae3d74672bb8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1ce87d46_5eb67bac","updated":"2023-04-21 08:43:01.000000000","message":"Overall code changes look good.\nFew minor comments inline.","commit_id":"dc77207e4c73950f1cacee5c9022586821ea6b59"},{"author":{"_account_id":28801,"name":"Cisco Cinder CI","email":"cisco-cinder-ci@cisco.com","username":"cisco-cinder-ci"},"change_message_id":"debd8fc58d14ad344b8331a9ad3bf280ac99504b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"abcf82aa_d77dc74c","updated":"2023-04-21 17:43:40.000000000","message":"cisco-cinder-ci","commit_id":"dc77207e4c73950f1cacee5c9022586821ea6b59"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bc66de92ebadeb5d1273f665fc634d72d7534a90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3ceeba45_4c6d8d0e","updated":"2023-05-03 14:55:36.000000000","message":"code, tests and releasenote LGTM. Pure storage nvme-tcp CI is passing.\n\npure-devstack-cinder-tempest-nvme-tcp-aio-jammy http://openstack-logs.purestorage.com/18/877918/8/thirdparty-check/pure-devstack-cinder-tempest-nvme-tcp-aio-jammy/39a5ceb/ : SUCCESS in 1h 45m 33s (non-voting)","commit_id":"dc77207e4c73950f1cacee5c9022586821ea6b59"}],"cinder/tests/unit/volume/drivers/test_pure.py":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"139f8b9b976c7298d3c8367f7de5295ced70aebc","unresolved":true,"context_lines":[{"line_number":4977,"context_line":"        ret \u003d self.driver._get_target_nvme_ports(self.array)"},{"line_number":4978,"context_line":"        self.assertEqual([ports[2]], ret)"},{"line_number":4979,"context_line":"        # Test for empty dict if only nvme-fc port"},{"line_number":4980,"context_line":"        self.driver.configuration.pure_nvme_transport \u003d \"roce\""},{"line_number":4981,"context_line":"        self.array.get_network_interface.return_value \u003d interfaces[3]"},{"line_number":4982,"context_line":"        self.array.list_ports.return_value \u003d [ports[3]]"},{"line_number":4983,"context_line":"        ret \u003d self.driver._get_target_nvme_ports(self.array)"}],"source_content_type":"text/x-python","patch_set":6,"id":"feb0f609_79a5905f","line":4980,"range":{"start_line":4980,"start_character":56,"end_line":4980,"end_character":62},"updated":"2023-04-20 12:56:27.000000000","message":"should this be \"nvme-fc\" ?","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"6b042bdeace54b44ef87815e14d477859cf214f8","unresolved":false,"context_lines":[{"line_number":4977,"context_line":"        ret \u003d self.driver._get_target_nvme_ports(self.array)"},{"line_number":4978,"context_line":"        self.assertEqual([ports[2]], ret)"},{"line_number":4979,"context_line":"        # Test for empty dict if only nvme-fc port"},{"line_number":4980,"context_line":"        self.driver.configuration.pure_nvme_transport \u003d \"roce\""},{"line_number":4981,"context_line":"        self.array.get_network_interface.return_value \u003d interfaces[3]"},{"line_number":4982,"context_line":"        self.array.list_ports.return_value \u003d [ports[3]]"},{"line_number":4983,"context_line":"        ret \u003d self.driver._get_target_nvme_ports(self.array)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fec21b7d_609c667d","line":4980,"range":{"start_line":4980,"start_character":56,"end_line":4980,"end_character":62},"in_reply_to":"b6c04c2f_6ddb4b7f","updated":"2023-04-20 13:26:09.000000000","message":"Done","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"c3ea7a7dd8d35241954774f348f666b247e798ee","unresolved":true,"context_lines":[{"line_number":4977,"context_line":"        ret \u003d self.driver._get_target_nvme_ports(self.array)"},{"line_number":4978,"context_line":"        self.assertEqual([ports[2]], ret)"},{"line_number":4979,"context_line":"        # Test for empty dict if only nvme-fc port"},{"line_number":4980,"context_line":"        self.driver.configuration.pure_nvme_transport \u003d \"roce\""},{"line_number":4981,"context_line":"        self.array.get_network_interface.return_value \u003d interfaces[3]"},{"line_number":4982,"context_line":"        self.array.list_ports.return_value \u003d [ports[3]]"},{"line_number":4983,"context_line":"        ret \u003d self.driver._get_target_nvme_ports(self.array)"}],"source_content_type":"text/x-python","patch_set":6,"id":"b6c04c2f_6ddb4b7f","line":4980,"range":{"start_line":4980,"start_character":56,"end_line":4980,"end_character":62},"in_reply_to":"feb0f609_79a5905f","updated":"2023-04-20 13:25:35.000000000","message":"NVMe is the protocol. roce, tcp and fc are transport types. We have selected roce as the default type, given it was the first supported.\nThere is currently no support in os-brick for nvme-fc","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bc66de92ebadeb5d1273f665fc634d72d7534a90","unresolved":true,"context_lines":[{"line_number":4977,"context_line":"        ret \u003d self.driver._get_target_nvme_ports(self.array)"},{"line_number":4978,"context_line":"        self.assertEqual([ports[2]], ret)"},{"line_number":4979,"context_line":"        # Test for empty dict if only nvme-fc port"},{"line_number":4980,"context_line":"        self.driver.configuration.pure_nvme_transport \u003d \"roce\""},{"line_number":4981,"context_line":"        self.array.get_network_interface.return_value \u003d interfaces[3]"},{"line_number":4982,"context_line":"        self.array.list_ports.return_value \u003d [ports[3]]"},{"line_number":4983,"context_line":"        ret \u003d self.driver._get_target_nvme_ports(self.array)"}],"source_content_type":"text/x-python","patch_set":8,"id":"605dcca8_d6ad0d63","line":4980,"range":{"start_line":4980,"start_character":57,"end_line":4980,"end_character":61},"updated":"2023-05-03 14:55:36.000000000","message":"should this be roce or fc?","commit_id":"dc77207e4c73950f1cacee5c9022586821ea6b59"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"618a3628106a9f401e5d9cd8a18d9c21e7b22c33","unresolved":true,"context_lines":[{"line_number":4977,"context_line":"        ret \u003d self.driver._get_target_nvme_ports(self.array)"},{"line_number":4978,"context_line":"        self.assertEqual([ports[2]], ret)"},{"line_number":4979,"context_line":"        # Test for empty dict if only nvme-fc port"},{"line_number":4980,"context_line":"        self.driver.configuration.pure_nvme_transport \u003d \"roce\""},{"line_number":4981,"context_line":"        self.array.get_network_interface.return_value \u003d interfaces[3]"},{"line_number":4982,"context_line":"        self.array.list_ports.return_value \u003d [ports[3]]"},{"line_number":4983,"context_line":"        ret \u003d self.driver._get_target_nvme_ports(self.array)"}],"source_content_type":"text/x-python","patch_set":8,"id":"56557707_2cb9cd3f","line":4980,"range":{"start_line":4980,"start_character":57,"end_line":4980,"end_character":61},"in_reply_to":"605dcca8_d6ad0d63","updated":"2023-05-03 15:02:33.000000000","message":"I think this is validating that no ports are returned because we asked for a roce port and it only has an nvme-fc port.","commit_id":"dc77207e4c73950f1cacee5c9022586821ea6b59"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"f571a39597024da0bd3a6feaf97a7e3c0313414e","unresolved":true,"context_lines":[{"line_number":4977,"context_line":"        ret \u003d self.driver._get_target_nvme_ports(self.array)"},{"line_number":4978,"context_line":"        self.assertEqual([ports[2]], ret)"},{"line_number":4979,"context_line":"        # Test for empty dict if only nvme-fc port"},{"line_number":4980,"context_line":"        self.driver.configuration.pure_nvme_transport \u003d \"roce\""},{"line_number":4981,"context_line":"        self.array.get_network_interface.return_value \u003d interfaces[3]"},{"line_number":4982,"context_line":"        self.array.list_ports.return_value \u003d [ports[3]]"},{"line_number":4983,"context_line":"        ret \u003d self.driver._get_target_nvme_ports(self.array)"}],"source_content_type":"text/x-python","patch_set":8,"id":"909a6629_71893f82","line":4980,"range":{"start_line":4980,"start_character":57,"end_line":4980,"end_character":61},"in_reply_to":"605dcca8_d6ad0d63","updated":"2023-05-03 14:58:07.000000000","message":"There is no support in os-brick for nvme-fc yet, so yes, this should be roce","commit_id":"dc77207e4c73950f1cacee5c9022586821ea6b59"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"c2e3ba3c937ed3e919e4f1b185d90c70717b1571","unresolved":false,"context_lines":[{"line_number":4977,"context_line":"        ret \u003d self.driver._get_target_nvme_ports(self.array)"},{"line_number":4978,"context_line":"        self.assertEqual([ports[2]], ret)"},{"line_number":4979,"context_line":"        # Test for empty dict if only nvme-fc port"},{"line_number":4980,"context_line":"        self.driver.configuration.pure_nvme_transport \u003d \"roce\""},{"line_number":4981,"context_line":"        self.array.get_network_interface.return_value \u003d interfaces[3]"},{"line_number":4982,"context_line":"        self.array.list_ports.return_value \u003d [ports[3]]"},{"line_number":4983,"context_line":"        ret \u003d self.driver._get_target_nvme_ports(self.array)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a9f0d1a_8f0037a1","line":4980,"range":{"start_line":4980,"start_character":57,"end_line":4980,"end_character":61},"in_reply_to":"909a6629_71893f82","updated":"2023-05-03 14:58:18.000000000","message":"Done","commit_id":"dc77207e4c73950f1cacee5c9022586821ea6b59"}],"cinder/volume/drivers/pure.py":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"139f8b9b976c7298d3c8367f7de5295ced70aebc","unresolved":true,"context_lines":[{"line_number":399,"context_line":""},{"line_number":400,"context_line":"            array_info \u003d self._array.get()"},{"line_number":401,"context_line":"            if version.parse(array_info[\"version\"]) \u003c version.parse("},{"line_number":402,"context_line":"                \u00275.3.0\u0027"},{"line_number":403,"context_line":"            ):"},{"line_number":404,"context_line":"                msg \u003d _(\"FlashArray Purity version less than 5.3.0 \""},{"line_number":405,"context_line":"                        \"unsupported. Please upgrade your backend to \""}],"source_content_type":"text/x-python","patch_set":6,"id":"fe5653f4_304a15ea","line":402,"updated":"2023-04-20 12:56:27.000000000","message":"Since min required version is 6.4.2 [line 409],\ncan this code block [lines 401 to 407] be removed ?\nbecause its checking for min version 5.3.0.","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"b70bc872f8cdb02c800bb02da99eb4e75e5001f9","unresolved":false,"context_lines":[{"line_number":399,"context_line":""},{"line_number":400,"context_line":"            array_info \u003d self._array.get()"},{"line_number":401,"context_line":"            if version.parse(array_info[\"version\"]) \u003c version.parse("},{"line_number":402,"context_line":"                \u00275.3.0\u0027"},{"line_number":403,"context_line":"            ):"},{"line_number":404,"context_line":"                msg \u003d _(\"FlashArray Purity version less than 5.3.0 \""},{"line_number":405,"context_line":"                        \"unsupported. Please upgrade your backend to \""}],"source_content_type":"text/x-python","patch_set":6,"id":"e479c8d3_0a933beb","line":402,"in_reply_to":"52be88a2_66c70276","updated":"2023-04-20 13:26:51.000000000","message":"Done","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"c3ea7a7dd8d35241954774f348f666b247e798ee","unresolved":true,"context_lines":[{"line_number":399,"context_line":""},{"line_number":400,"context_line":"            array_info \u003d self._array.get()"},{"line_number":401,"context_line":"            if version.parse(array_info[\"version\"]) \u003c version.parse("},{"line_number":402,"context_line":"                \u00275.3.0\u0027"},{"line_number":403,"context_line":"            ):"},{"line_number":404,"context_line":"                msg \u003d _(\"FlashArray Purity version less than 5.3.0 \""},{"line_number":405,"context_line":"                        \"unsupported. Please upgrade your backend to \""}],"source_content_type":"text/x-python","patch_set":6,"id":"52be88a2_66c70276","line":402,"in_reply_to":"fe5653f4_304a15ea","updated":"2023-04-20 13:25:35.000000000","message":"The minimum version for all protocols, including NVMe-RoCE is 5.3.0. 6.4.2 is the minimum required for NVMe-TCP therefore it has to be check ed independently if that prototocl and transport type is selected for the driver.","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"139f8b9b976c7298d3c8367f7de5295ced70aebc","unresolved":true,"context_lines":[{"line_number":3214,"context_line":"    FlashArray."},{"line_number":3215,"context_line":"    \"\"\""},{"line_number":3216,"context_line":""},{"line_number":3217,"context_line":"    VERSION \u003d \"17.0.nvme\""},{"line_number":3218,"context_line":""},{"line_number":3219,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":3220,"context_line":"        execute \u003d kwargs.pop(\"execute\", utils.execute)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7c6e5fa0_3bf95d70","line":3217,"updated":"2023-04-20 12:56:27.000000000","message":"nit: if it helps, the VERSION can be incremented.","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"6b042bdeace54b44ef87815e14d477859cf214f8","unresolved":false,"context_lines":[{"line_number":3214,"context_line":"    FlashArray."},{"line_number":3215,"context_line":"    \"\"\""},{"line_number":3216,"context_line":""},{"line_number":3217,"context_line":"    VERSION \u003d \"17.0.nvme\""},{"line_number":3218,"context_line":""},{"line_number":3219,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":3220,"context_line":"        execute \u003d kwargs.pop(\"execute\", utils.execute)"}],"source_content_type":"text/x-python","patch_set":6,"id":"547bafe8_36bcb15d","line":3217,"in_reply_to":"4a1f2148_4509c5cb","updated":"2023-04-20 13:26:09.000000000","message":"Done","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"95150ef2da2e0d026c6319313c6eae3d74672bb8","unresolved":false,"context_lines":[{"line_number":3214,"context_line":"    FlashArray."},{"line_number":3215,"context_line":"    \"\"\""},{"line_number":3216,"context_line":""},{"line_number":3217,"context_line":"    VERSION \u003d \"17.0.nvme\""},{"line_number":3218,"context_line":""},{"line_number":3219,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":3220,"context_line":"        execute \u003d kwargs.pop(\"execute\", utils.execute)"}],"source_content_type":"text/x-python","patch_set":6,"id":"eb0c8076_e621c4b9","line":3217,"in_reply_to":"547bafe8_36bcb15d","updated":"2023-04-21 08:43:01.000000000","message":"nit: rebase was done as PS7. Still the VERSION is same.","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"c3ea7a7dd8d35241954774f348f666b247e798ee","unresolved":true,"context_lines":[{"line_number":3214,"context_line":"    FlashArray."},{"line_number":3215,"context_line":"    \"\"\""},{"line_number":3216,"context_line":""},{"line_number":3217,"context_line":"    VERSION \u003d \"17.0.nvme\""},{"line_number":3218,"context_line":""},{"line_number":3219,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":3220,"context_line":"        execute \u003d kwargs.pop(\"execute\", utils.execute)"}],"source_content_type":"text/x-python","patch_set":6,"id":"4a1f2148_4509c5cb","line":3217,"in_reply_to":"7c6e5fa0_3bf95d70","updated":"2023-04-20 13:25:35.000000000","message":"Already done. A rebase will fix this.","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"2a2c62da45f3af70558dff36ef50294db484cece","unresolved":true,"context_lines":[{"line_number":3349,"context_line":"                port_detail \u003d array.get_network_interface("},{"line_number":3350,"context_line":"                    interface\u003dnvme_ports[port][\"name\"]"},{"line_number":3351,"context_line":"                )"},{"line_number":3352,"context_line":"                if port_detail[\"services\"][0] \u003d\u003d \"nvme-\" + \\"},{"line_number":3353,"context_line":"                        self.configuration.pure_nvme_transport:"},{"line_number":3354,"context_line":"                    valid_nvme_ports.append(nvme_ports[port])"},{"line_number":3355,"context_line":"        if not nvme_ports:"}],"source_content_type":"text/x-python","patch_set":6,"id":"775c7332_55c96906","line":3352,"range":{"start_line":3352,"start_character":19,"end_line":3352,"end_character":45},"updated":"2023-04-19 17:31:41.000000000","message":"I\u0027m wondering if there might be a case where the array contains more than one service... if not, why use a list instead of a string?","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"e48fd241790bad89a49fd1d73bfa099a0acf03ee","unresolved":true,"context_lines":[{"line_number":3349,"context_line":"                port_detail \u003d array.get_network_interface("},{"line_number":3350,"context_line":"                    interface\u003dnvme_ports[port][\"name\"]"},{"line_number":3351,"context_line":"                )"},{"line_number":3352,"context_line":"                if port_detail[\"services\"][0] \u003d\u003d \"nvme-\" + \\"},{"line_number":3353,"context_line":"                        self.configuration.pure_nvme_transport:"},{"line_number":3354,"context_line":"                    valid_nvme_ports.append(nvme_ports[port])"},{"line_number":3355,"context_line":"        if not nvme_ports:"}],"source_content_type":"text/x-python","patch_set":6,"id":"d8bd3bfd_e33ac663","line":3352,"range":{"start_line":3352,"start_character":19,"end_line":3352,"end_character":45},"in_reply_to":"775c7332_55c96906","updated":"2023-04-19 17:37:24.000000000","message":"I\u0027m limited by the SDK/API response and the engineers in their wisdom created this as a list, even though multiple NVMe transport types are not possible on an interface.","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"659ab312b17516dd948e387406ecd88a48e8f124","unresolved":false,"context_lines":[{"line_number":3349,"context_line":"                port_detail \u003d array.get_network_interface("},{"line_number":3350,"context_line":"                    interface\u003dnvme_ports[port][\"name\"]"},{"line_number":3351,"context_line":"                )"},{"line_number":3352,"context_line":"                if port_detail[\"services\"][0] \u003d\u003d \"nvme-\" + \\"},{"line_number":3353,"context_line":"                        self.configuration.pure_nvme_transport:"},{"line_number":3354,"context_line":"                    valid_nvme_ports.append(nvme_ports[port])"},{"line_number":3355,"context_line":"        if not nvme_ports:"}],"source_content_type":"text/x-python","patch_set":6,"id":"98e459f9_d631d984","line":3352,"range":{"start_line":3352,"start_character":19,"end_line":3352,"end_character":45},"in_reply_to":"d8bd3bfd_e33ac663","updated":"2023-04-19 18:03:21.000000000","message":"Ok, I see your point. Thanks for the quick response.","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"}],"doc/source/configuration/block-storage/drivers/pure-storage-driver.rst":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"139f8b9b976c7298d3c8367f7de5295ced70aebc","unresolved":true,"context_lines":[{"line_number":13,"context_line":"iSCSI, Fibre Channel and NVMe-RoCE drivers are compatible with FlashArrays"},{"line_number":14,"context_line":"that support the REST API version 1.16 and higher (Purity 5.2.0 and newer)."},{"line_number":15,"context_line":"The NVMe-TCP driver is compatible with FlashArrays"},{"line_number":16,"context_line":"that are running Purity 6.4.2 and higher."},{"line_number":17,"context_line":"Some features may require newer versions of Purity."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Limitations and known issues"}],"source_content_type":"text/x-rst","patch_set":6,"id":"c6099fae_e008e036","line":16,"updated":"2023-04-20 12:56:27.000000000","message":"query: can we specify REST API version also ?","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"95150ef2da2e0d026c6319313c6eae3d74672bb8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"iSCSI, Fibre Channel and NVMe-RoCE drivers are compatible with FlashArrays"},{"line_number":14,"context_line":"that support the REST API version 1.16 and higher (Purity 5.2.0 and newer)."},{"line_number":15,"context_line":"The NVMe-TCP driver is compatible with FlashArrays"},{"line_number":16,"context_line":"that are running Purity 6.4.2 and higher."},{"line_number":17,"context_line":"Some features may require newer versions of Purity."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Limitations and known issues"}],"source_content_type":"text/x-rst","patch_set":6,"id":"28a40ab0_eab71279","line":16,"in_reply_to":"3cd43e26_14c2334b","updated":"2023-04-21 08:43:01.000000000","message":"Ok. Then by same logic... can the REST API version specified at line 14 be removed ?","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"6b042bdeace54b44ef87815e14d477859cf214f8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"iSCSI, Fibre Channel and NVMe-RoCE drivers are compatible with FlashArrays"},{"line_number":14,"context_line":"that support the REST API version 1.16 and higher (Purity 5.2.0 and newer)."},{"line_number":15,"context_line":"The NVMe-TCP driver is compatible with FlashArrays"},{"line_number":16,"context_line":"that are running Purity 6.4.2 and higher."},{"line_number":17,"context_line":"Some features may require newer versions of Purity."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Limitations and known issues"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3cd43e26_14c2334b","line":16,"in_reply_to":"5fd93346_cc75ce14","updated":"2023-04-20 13:26:09.000000000","message":"Done","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"c3ea7a7dd8d35241954774f348f666b247e798ee","unresolved":true,"context_lines":[{"line_number":13,"context_line":"iSCSI, Fibre Channel and NVMe-RoCE drivers are compatible with FlashArrays"},{"line_number":14,"context_line":"that support the REST API version 1.16 and higher (Purity 5.2.0 and newer)."},{"line_number":15,"context_line":"The NVMe-TCP driver is compatible with FlashArrays"},{"line_number":16,"context_line":"that are running Purity 6.4.2 and higher."},{"line_number":17,"context_line":"Some features may require newer versions of Purity."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Limitations and known issues"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5fd93346_cc75ce14","line":16,"in_reply_to":"c6099fae_e008e036","updated":"2023-04-20 13:25:35.000000000","message":"The REST version doesn\u0027t mean anything to customers as they have no frame of reference for the REST version supported by the backend, only the Purity version.","commit_id":"4f955360f4ef5d9533e4d2a521275574ca2dc022"}]}