)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2fe3ab6e1999a4fe0f1036bcb09cacf382840339","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ec09d4b1_32f5ab57","updated":"2024-02-16 16:13:14.000000000","message":"I wonder whether this bug is a duplicate of https://bugs.launchpad.net/cinder/+bug/1978729 , which was already fixed by https://review.opendev.org/c/openstack/cinder/+/846303\n\nI really don\u0027t like the idea of introducing an unknown action because the action should always be populated at the time a message is created.  Maybe mypy can help here?","commit_id":"4b6bf105657fa8777baf96f10cf40ef04898b42e"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"67dad7063c87e937e505a70bd22a6eb0ba81dc80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"67aa1a97_764c88d7","updated":"2023-05-19 14:53:20.000000000","message":"LGTM","commit_id":"4b6bf105657fa8777baf96f10cf40ef04898b42e"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"4103df5a68769f55ddae7b36b2079499b8c56908","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9183910f_9b49d397","updated":"2023-07-05 03:45:43.000000000","message":"LGTM","commit_id":"4b6bf105657fa8777baf96f10cf40ef04898b42e"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"3c8430a4a4fce590761c8e0e0e69c7d843975cf8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e723b621_7d0834e3","updated":"2024-02-16 15:50:48.000000000","message":"Let\u0027s get a sense if we are okay with raising here.\n\nIf the plugging of None is required here, then use \u00270\u0027 instead of \u0027\u0027 consistently.","commit_id":"4b6bf105657fa8777baf96f10cf40ef04898b42e"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"6564f67cd0678dcfeae82341c3286aca2bee91a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c21a4b3a_f19684b3","updated":"2023-05-19 14:39:08.000000000","message":"Looks good to me - thanks!","commit_id":"4b6bf105657fa8777baf96f10cf40ef04898b42e"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"5f6fe732eb381695a0529f276e74dd02d8e7067d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"70c5995e_116ce42e","updated":"2024-02-16 16:14:08.000000000","message":"Rajat, Brian, and I looked at the bug 2009483 and the problem is even worse that this patch suggests. While a process exits, it de-serializes something wrong, and then invokes continue_backup from a half-baked context that has no message.Action. It\u0027s very likely that this fix papers over a real problem.","commit_id":"4b6bf105657fa8777baf96f10cf40ef04898b42e"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"5ff46bb04081e77ff1c2846bd34e9f3341229376","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8d5cb7e1_365b743b","updated":"2023-07-21 14:56:48.000000000","message":"Seems OK to me","commit_id":"4b6bf105657fa8777baf96f10cf40ef04898b42e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"bf7fa0036060cdb5fe53920febf35cd6ec0e4128","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"aa53af8f_76070917","updated":"2024-02-21 16:01:17.000000000","message":"https://review.opendev.org/c/openstack/cinder/+/909688\n\nprovides a fix for this bug.\n\nHowever, it doesn\u0027t fix the fact that this API is tricky to use correctly and we\u0027ll probably hit this problem again without a fix like this one.  (You have to ensure that the context object has had message fields added to it before calling message_api.create anywhere during that operation.)","commit_id":"4b6bf105657fa8777baf96f10cf40ef04898b42e"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"778521293a3013028d207225c5032d2aaf7cf3c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6a49a8f7_f135c08d","updated":"2023-07-05 09:51:22.000000000","message":"run-TOYOU TYDS CI","commit_id":"4b6bf105657fa8777baf96f10cf40ef04898b42e"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"98847034c39d8c17655b4cc8811752faa8e191f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8faae7d6_b2f2f017","updated":"2023-07-05 09:30:01.000000000","message":"run-TOYOU TYDS CI","commit_id":"4b6bf105657fa8777baf96f10cf40ef04898b42e"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"17801f9e00f8a6f8cc7a1bed395545d6ae787d1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e760f4e4_4aef2ff5","updated":"2023-07-05 09:32:50.000000000","message":"run-TOYOU TYDS CI","commit_id":"4b6bf105657fa8777baf96f10cf40ef04898b42e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"bf7fa0036060cdb5fe53920febf35cd6ec0e4128","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ba443802_17768484","in_reply_to":"70c5995e_116ce42e","updated":"2024-02-21 16:01:17.000000000","message":"The problem is that something called message.api.create_from_request_context() with something that hadn\u0027t yet embedded an action in the context.\n\nI think we can fix this by adding that to the backup manager\u0027s continue_backup() method like it is in other *_backup() methods.","commit_id":"4b6bf105657fa8777baf96f10cf40ef04898b42e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"467a962ddf0508f651f1de097852535c5acfec7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f09c9199_4872ad2d","in_reply_to":"ec09d4b1_32f5ab57","updated":"2024-02-21 16:09:50.000000000","message":"https://review.opendev.org/c/openstack/cinder/+/909689\n\nexposes this problem with mypy.  (It doesn\u0027t yet fix it.)","commit_id":"4b6bf105657fa8777baf96f10cf40ef04898b42e"}],"cinder/message/api.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e149cc47b06885f7912732c7bd58b6d3e19cd753","unresolved":true,"context_lines":[{"line_number":102,"context_line":"                          \u0027message_level\u0027: level,"},{"line_number":103,"context_line":"                          \u0027event_id\u0027: \"VOLUME_%s_%s_%s\" % ("},{"line_number":104,"context_line":"                              resource_type,"},{"line_number":105,"context_line":"                              action[0] if action else \u0027000\u0027,"},{"line_number":106,"context_line":"                              detail_id),"},{"line_number":107,"context_line":"                          \u0027detail_id\u0027: detail_id,"},{"line_number":108,"context_line":"                          \u0027expires_at\u0027: expires_at}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7b1fc4f7_8f4e364b","line":105,"range":{"start_line":105,"start_character":55,"end_line":105,"end_character":60},"updated":"2023-07-21 15:15:53.000000000","message":"I\u0027m not sure if we want to have a action defined for this and if we do, we need to do same change in action_id field else it would be inconsistent with this","commit_id":"4b6bf105657fa8777baf96f10cf40ef04898b42e"}]}