)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"6da7ae7dd1a6200d6a6cca2d5325383e1a2f369d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8c97fd53_96af5390","updated":"2023-03-29 13:12:39.000000000","message":"I agree that we should fix this.","commit_id":"bfadbecf3ac20ff475f8e118e640e67350eedfab"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a005d688710c703347b938c08524917ea7b93192","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"73ad5e8f_2b56ec8b","updated":"2023-03-27 13:27:21.000000000","message":"recheck\n\nlook for unit test failures in check jobs","commit_id":"bfadbecf3ac20ff475f8e118e640e67350eedfab"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d04dcd4a22ca9ceadf27370c6f5289530c1b4fd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9f0bb74d_a6a7f8bd","updated":"2023-03-27 17:11:27.000000000","message":"recheck\n\nlook for unit test failures in check jobs","commit_id":"bfadbecf3ac20ff475f8e118e640e67350eedfab"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"04f92f4cc3079084fdfa3ea801231b722196dd4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5561a521_56e56c74","updated":"2023-04-20 14:06:42.000000000","message":"LGTM.","commit_id":"b261fa205b7f956a8eecbcffe6703c8d7de4e418"}],"cinder/db/sqlalchemy/models.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"6da7ae7dd1a6200d6a6cca2d5325383e1a2f369d","unresolved":false,"context_lines":[{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    __tablename__ \u003d \u0027volumes\u0027"},{"line_number":316,"context_line":"    __table_args__ \u003d ("},{"line_number":317,"context_line":"        sa.Index(\u0027volumes_service_uuid_idx\u0027, \u0027service_uuid\u0027, \u0027deleted\u0027),"},{"line_number":318,"context_line":"        # Speed up normal listings"},{"line_number":319,"context_line":"        sa.Index(\u0027volumes_deleted_project_id_idx\u0027, \u0027deleted\u0027, \u0027project_id\u0027),"},{"line_number":320,"context_line":"        # Speed up service start, create volume from image when using direct"}],"source_content_type":"text/x-python","patch_set":1,"id":"45863657_97b4defc","line":317,"updated":"2023-03-29 13:12:39.000000000","message":"This change makes things right, since that\u0027s what we have in the legacy [1] and new migrations [2].\n\nMy only concern is not with this patch, but with our test, because it should be failing 100% of the time since it is meant to catch precisely this.\n\n[1]: https://github.com/openstack/cinder/blob/3fc37548042fcdc745d35a0a902213482fc4422c/cinder/db/legacy_migrations/versions/135_cinder_init.py#L212\n[2]: https://github.com/openstack/cinder/blob/3fc37548042fcdc745d35a0a902213482fc4422c/cinder/db/migrations/versions/921e1a36b076_initial.py#L232","commit_id":"bfadbecf3ac20ff475f8e118e640e67350eedfab"}]}
