)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"change_message_id":"09f3cf802d13e65c812ac3bf574c0c7a6f9df5a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5a4e18ec_30e2df85","updated":"2023-06-19 18:08:36.000000000","message":"LGTM","commit_id":"bfac2eed1057f57d56a8ae3d780a0b48fbd405aa"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"170ab27cc05b0b6425b230770030e92b82935464","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"16ee5422_4bd3b9c1","updated":"2023-06-28 12:30:39.000000000","message":"Looks good to me - thank you!","commit_id":"bfac2eed1057f57d56a8ae3d780a0b48fbd405aa"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"45279ac84ba1721971210b8a1358b2528213a6fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9d608a8c_80d2e332","updated":"2023-09-04 16:31:18.000000000","message":"hitachi CI is passing, LGTM.","commit_id":"bfac2eed1057f57d56a8ae3d780a0b48fbd405aa"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"f58911dfd23aceb7fca2b7f0426b1d3e657762d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e2433407_c66c4e00","updated":"2023-07-05 03:51:36.000000000","message":"looks good","commit_id":"bfac2eed1057f57d56a8ae3d780a0b48fbd405aa"},{"author":{"_account_id":34148,"name":"Aboubacar Diare","display_name":"abdi","email":"diare@hpe.com","username":"abdi"},"change_message_id":"a22fe6ac7e362daa1129415d8b60e92335501757","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"14bc6abd_425be5dd","updated":"2023-07-01 01:13:44.000000000","message":"run-HPE XP Storage CI","commit_id":"bfac2eed1057f57d56a8ae3d780a0b48fbd405aa"},{"author":{"_account_id":34148,"name":"Aboubacar Diare","display_name":"abdi","email":"diare@hpe.com","username":"abdi"},"change_message_id":"747e9787d7bbf4220c860001921161d12927d546","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4554ffbb_2f70df25","updated":"2023-04-12 02:01:38.000000000","message":"run-HPE XP Storage CI","commit_id":"bfac2eed1057f57d56a8ae3d780a0b48fbd405aa"},{"author":{"_account_id":34148,"name":"Aboubacar Diare","display_name":"abdi","email":"diare@hpe.com","username":"abdi"},"change_message_id":"f3d7e48eb9ce55e24d6a90506de6a1b8ed4cca39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"55096975_e705115b","updated":"2023-04-12 02:06:36.000000000","message":"run-HPE XP Storage CI","commit_id":"bfac2eed1057f57d56a8ae3d780a0b48fbd405aa"},{"author":{"_account_id":34148,"name":"Aboubacar Diare","display_name":"abdi","email":"diare@hpe.com","username":"abdi"},"change_message_id":"da31887ac70d2854f8e3af7ea4ac75a46836527d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"757e0a47_7509bd70","updated":"2023-04-11 03:25:29.000000000","message":"run-HPE XP Storage CI","commit_id":"bfac2eed1057f57d56a8ae3d780a0b48fbd405aa"},{"author":{"_account_id":34148,"name":"Aboubacar Diare","display_name":"abdi","email":"diare@hpe.com","username":"abdi"},"change_message_id":"018add6a42249bbe5869f2a4f454eaa89754074a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a5d4b082_ca7d5d37","updated":"2023-06-22 18:07:51.000000000","message":"run-HPE XP Storage CI","commit_id":"bfac2eed1057f57d56a8ae3d780a0b48fbd405aa"},{"author":{"_account_id":34148,"name":"Aboubacar Diare","display_name":"abdi","email":"diare@hpe.com","username":"abdi"},"change_message_id":"3df45cf40ef4f588bd63303febda225a906afdb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fabd058f_505672e4","updated":"2023-06-28 17:04:13.000000000","message":"run-HPE XP Storage CI","commit_id":"bfac2eed1057f57d56a8ae3d780a0b48fbd405aa"},{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"8a7a556978432f7e6c98860db94ad3644c8f85cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"dd8cbde5_4ad6ff37","updated":"2023-04-27 08:11:52.000000000","message":"run-NEC V Cinder CI","commit_id":"bfac2eed1057f57d56a8ae3d780a0b48fbd405aa"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"7b04d0e37174b5ebe55e1bbcb04c7114712f0a3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"650252fd_c9977e2d","updated":"2023-09-11 06:47:31.000000000","message":"recheck InvocationError in cinder-plugin-ceph-tempest","commit_id":"8a971c5b07936b107f8345bca230013981326319"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"b98adafac91d8c625d8983317233e35e0229031e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"36f7c388_464a4110","updated":"2023-09-11 10:00:15.000000000","message":"recheck cinder-plugin-ceph-tempest failure","commit_id":"8a971c5b07936b107f8345bca230013981326319"},{"author":{"_account_id":34148,"name":"Aboubacar Diare","display_name":"abdi","email":"diare@hpe.com","username":"abdi"},"change_message_id":"29a5155ca9a729f1c38c9f340f4e34ec5ddd8a85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"de08eaea_8a67ea4a","updated":"2023-09-08 17:29:20.000000000","message":"run-HPE XP Storage CI","commit_id":"8a971c5b07936b107f8345bca230013981326319"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"dbf1de34c0501e1d6931d7493ac145debe10b814","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f4b8ae4b_f4332c9e","updated":"2023-11-10 18:35:32.000000000","message":"-1 for the UT point below.\n\nThe explanation of the patch was not straightforward to me so i will add it here for other reviewers (or for my future reference)\n\nfor the host group, the prefix should be the target driver name i.e.\nHSBD for hitachi\nHPEXP for hpe\nNEC for nec\n\nThe hitachi driver set the prefix to HSBD[1]\nThe HPEXP and NEC drivers inherit from the hitachi driver.\nSo this became a problem because NEC and HPEXP drivers were also using HSBD prefix for host groups.\n\nOne question i still have is in the UTs, we are still not asserting the target prefix value. i expected this change in all affected drivers i.e. HPE and NEC (since the prefix used is hitachi one HSBD)\n\n[1] https://github.com/openstack/cinder/blob/bd786113ce7a0e6e05584c09e8f366aa1de8179f/cinder/volume/drivers/hitachi/hbsd_utils.py#L35","commit_id":"61e7d1f83c0ca6bd821da0d8f398e4154868cdd7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"89a0e35670d752674cf87dc4a706c552f80ae682","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"247ae3d0_b43b6156","updated":"2023-11-16 07:57:05.000000000","message":"All my concerns and comments are addressed.\nHitachi driver is tested for host group and test case exists for HPEXP, I won\u0027t emphasize too much on the NEC one though it would have been good to be added.\nLGTM.","commit_id":"61e7d1f83c0ca6bd821da0d8f398e4154868cdd7"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"cda705f1595e1b56522a32cdb0165257f0692f33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"828da448_b05d456a","updated":"2023-11-15 06:44:05.000000000","message":"Except the UT issue raised by Rajat, it looks good to me. Thank you.","commit_id":"61e7d1f83c0ca6bd821da0d8f398e4154868cdd7"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"01282cabd8eb4c70a2dabc69681658a9cabc1525","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"cc46024e_8882ef64","updated":"2023-11-17 16:02:05.000000000","message":"Not having a fall-through or \"else\" is okay, I think. Also... if a new type gets adopted, previously was a KeyError. Now it\u0027s going to traceback just a couple of lines down. So, not any worse.","commit_id":"61e7d1f83c0ca6bd821da0d8f398e4154868cdd7"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"55234ab114774dd6d7cf8a4f880e74baf38c9ba7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a8530927_66e3a7cb","updated":"2023-11-21 15:34:23.000000000","message":"recheck\n\ngrenade test failed","commit_id":"61e7d1f83c0ca6bd821da0d8f398e4154868cdd7"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"921d4b68cc6c7417e50135f7c09cb024767838a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0a2de97e_cc65b965","updated":"2023-11-08 08:03:14.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican by Timeout","commit_id":"61e7d1f83c0ca6bd821da0d8f398e4154868cdd7"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"87623adf3636830c44659baa8e8bb1c0fb0d559c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5572620a_177d1a2d","updated":"2023-11-08 13:55:42.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican by object not found","commit_id":"61e7d1f83c0ca6bd821da0d8f398e4154868cdd7"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"6346244cdc8d028a0dae85045c4794c0399c8409","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3a388a19_825e41bb","updated":"2023-11-08 05:37:45.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican by timeout error","commit_id":"61e7d1f83c0ca6bd821da0d8f398e4154868cdd7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cdcb9757b2e669c9efdc33756255e7df43a0e4df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"95f296e6_d24a2acc","updated":"2023-11-17 06:28:25.000000000","message":"recheck unrelated failure in tempest-integrated-storage","commit_id":"61e7d1f83c0ca6bd821da0d8f398e4154868cdd7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"445f1336f648c1174a80cab41de423a2f3a0e2d4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"945c3f6e_e3037612","in_reply_to":"769d172c_3f7709ea","updated":"2023-11-15 06:16:01.000000000","message":"Yes, I don\u0027t think any tests exist currently in the NEC and HPEXP driver that assert the target prefix value hence verifying that the right value is used to create the host group.\nIf we had a similar test in the original patch, it would have caught this issue.\nBut we can add a test to the NEC and HPEXP unit tests in this patch.","commit_id":"61e7d1f83c0ca6bd821da0d8f398e4154868cdd7"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"67c036202c70a29ebd4a61f794257a1b4bda0927","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f153e415_688b8b3e","in_reply_to":"945c3f6e_e3037612","updated":"2023-11-16 02:57:06.000000000","message":"For Hitachi driver, we\u0027ve tested on devstack environment with Hitachi storage and confirmed host group name which is created by the real storage.\nFor HPE XP driver, we\u0027ve confirmed host group name format by UT is added in this patch as following, because we could not use HPE XP storage:\n\thttps://review.opendev.org/c/openstack/cinder/+/879830/6/cinder/tests/unit/volume/drivers/hpe/xp/test_hpe_xp_rest_fc.py#581\n\thttps://review.opendev.org/c/openstack/cinder/+/879830/6/cinder/tests/unit/volume/drivers/hpe/xp/test_hpe_xp_rest_iscsi.py#493\n\nUT case for NEC V driver is omitted because structure of both driver NEC V  and HPE XP  are same.","commit_id":"61e7d1f83c0ca6bd821da0d8f398e4154868cdd7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"89a0e35670d752674cf87dc4a706c552f80ae682","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5c9707d7_ee9ef8ba","in_reply_to":"f153e415_688b8b3e","updated":"2023-11-16 07:57:05.000000000","message":"Ack","commit_id":"61e7d1f83c0ca6bd821da0d8f398e4154868cdd7"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"3d2edb2d994b72e2ecbd4cf9ae27cbf12385952d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"769d172c_3f7709ea","in_reply_to":"f4b8ae4b_f4332c9e","updated":"2023-11-13 13:19:46.000000000","message":"\u003efor the host group, the prefix should be the target driver name i.e.\n\u003eHSBD for hitachi\n\u003eHPEXP for hpe\n\u003eNEC for nec\n\u003eThe hitachi driver set the prefix to HSBD[1]\n\u003eThe HPEXP and NEC drivers inherit from the hitachi driver.\n\nYes, what you said above is correct.\n\n\u003eSo this became a problem because NEC and HPEXP drivers were also using HSBD prefix for host groups.\n\nIt\u0027s almost correct, I would additionally said:\nThe bug is embeded in the merged patch https://review.opendev.org/c/openstack/cinder/+/866526 .\n\n\u003eOne question i still have is in the UTs, we are still not asserting the target prefix value. i expected this change in all affected drivers i.e. HPE and NEC (since the prefix used is hitachi one HSBD)\n\nDoes your question means which test cases verify the prefix?","commit_id":"61e7d1f83c0ca6bd821da0d8f398e4154868cdd7"}],"cinder/volume/drivers/hitachi/hbsd_common.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"45279ac84ba1721971210b8a1358b2528213a6fc","unresolved":true,"context_lines":[{"line_number":716,"context_line":"                    MSG.INVALID_PARAMETER,"},{"line_number":717,"context_line":"                    param\u003dself.driver_info[\u0027param_prefix\u0027] +"},{"line_number":718,"context_line":"                    \u0027_group_name_format\u0027)"},{"line_number":719,"context_line":"                self.raise_error(msg)"},{"line_number":720,"context_line":"            self.format_info[\u0027group_name_format\u0027] \u003d ("},{"line_number":721,"context_line":"                self.conf.hitachi_group_name_format)"},{"line_number":722,"context_line":"            self.format_info[\u0027group_name_format_without_var_len\u0027] \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"e7e8768d_67bfbbe3","line":719,"range":{"start_line":719,"start_character":16,"end_line":719,"end_character":37},"updated":"2023-09-04 16:31:18.000000000","message":"change is correct but unrelated to the patch","commit_id":"bfac2eed1057f57d56a8ae3d780a0b48fbd405aa"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"0a304fb11ada85dd2fc658ab949b35d4e5e5fa3b","unresolved":false,"context_lines":[{"line_number":716,"context_line":"                    MSG.INVALID_PARAMETER,"},{"line_number":717,"context_line":"                    param\u003dself.driver_info[\u0027param_prefix\u0027] +"},{"line_number":718,"context_line":"                    \u0027_group_name_format\u0027)"},{"line_number":719,"context_line":"                self.raise_error(msg)"},{"line_number":720,"context_line":"            self.format_info[\u0027group_name_format\u0027] \u003d ("},{"line_number":721,"context_line":"                self.conf.hitachi_group_name_format)"},{"line_number":722,"context_line":"            self.format_info[\u0027group_name_format_without_var_len\u0027] \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"ab9fa518_78f63a8f","line":719,"range":{"start_line":719,"start_character":16,"end_line":719,"end_character":37},"in_reply_to":"e7e8768d_67bfbbe3","updated":"2023-09-11 05:05:23.000000000","message":"The change is to feedback the following merged patch:\n\n875977: Hitachi HBSD: Fix invalid \"raise None\" | https://review.opendev.org/c/openstack/cinder/+/875977","commit_id":"bfac2eed1057f57d56a8ae3d780a0b48fbd405aa"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"dbf1de34c0501e1d6931d7493ac145debe10b814","unresolved":true,"context_lines":[{"line_number":202,"context_line":"                    GROUP_NAME_VAR_IP: [0],"},{"line_number":203,"context_line":"                    GROUP_NAME_VAR_HOST: [0, 1],"},{"line_number":204,"context_line":"                },"},{"line_number":205,"context_line":"                \u0027group_name_format_default\u0027: self.driver_info["},{"line_number":206,"context_line":"                    \u0027target_prefix\u0027] + \u0027{wwn}\u0027,"},{"line_number":207,"context_line":"            }"},{"line_number":208,"context_line":"        if self.storage_info[\u0027protocol\u0027] \u003d\u003d \u0027iSCSI\u0027:"},{"line_number":209,"context_line":"            self.group_name_format \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"65b7a80d_8fbd21a4","line":206,"range":{"start_line":205,"start_character":45,"end_line":206,"end_character":46},"updated":"2023-11-10 18:35:32.000000000","message":"In my understanding, this is the only change needed to fix the issue.\nSo why are we rewriting the whole dict again here? I\u0027m not against the approach if it makes the code more readable and maintainable but I\u0027m curious to know if there is another issue that I\u0027m missing that is fixed with this approach?","commit_id":"61e7d1f83c0ca6bd821da0d8f398e4154868cdd7"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"9fd902b9322894f6c96827bfc922c64e686620c5","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                    GROUP_NAME_VAR_IP: [0],"},{"line_number":203,"context_line":"                    GROUP_NAME_VAR_HOST: [0, 1],"},{"line_number":204,"context_line":"                },"},{"line_number":205,"context_line":"                \u0027group_name_format_default\u0027: self.driver_info["},{"line_number":206,"context_line":"                    \u0027target_prefix\u0027] + \u0027{wwn}\u0027,"},{"line_number":207,"context_line":"            }"},{"line_number":208,"context_line":"        if self.storage_info[\u0027protocol\u0027] \u003d\u003d \u0027iSCSI\u0027:"},{"line_number":209,"context_line":"            self.group_name_format \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"7003a288_7b8f6636","line":206,"range":{"start_line":205,"start_character":45,"end_line":206,"end_character":46},"in_reply_to":"65b7a80d_8fbd21a4","updated":"2023-11-15 02:43:25.000000000","message":"Although the issue can be fixed to only rewrite the correct prefix value for ``group_name_format_default`` here, \nwe choose rewriting whole dict. for just increasing readability and maintainability, not for fixing any other issues in this patch.","commit_id":"61e7d1f83c0ca6bd821da0d8f398e4154868cdd7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"445f1336f648c1174a80cab41de423a2f3a0e2d4","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                    GROUP_NAME_VAR_IP: [0],"},{"line_number":203,"context_line":"                    GROUP_NAME_VAR_HOST: [0, 1],"},{"line_number":204,"context_line":"                },"},{"line_number":205,"context_line":"                \u0027group_name_format_default\u0027: self.driver_info["},{"line_number":206,"context_line":"                    \u0027target_prefix\u0027] + \u0027{wwn}\u0027,"},{"line_number":207,"context_line":"            }"},{"line_number":208,"context_line":"        if self.storage_info[\u0027protocol\u0027] \u003d\u003d \u0027iSCSI\u0027:"},{"line_number":209,"context_line":"            self.group_name_format \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"21aec3d4_6e4ebbc9","line":206,"range":{"start_line":205,"start_character":45,"end_line":206,"end_character":46},"in_reply_to":"7003a288_7b8f6636","updated":"2023-11-15 06:16:01.000000000","message":"Ack","commit_id":"61e7d1f83c0ca6bd821da0d8f398e4154868cdd7"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"93610089828e2eaa5d536fbf82d3cfe99357ac52","unresolved":true,"context_lines":[{"line_number":205,"context_line":"                \u0027group_name_format_default\u0027: self.driver_info["},{"line_number":206,"context_line":"                    \u0027target_prefix\u0027] + \u0027{wwn}\u0027,"},{"line_number":207,"context_line":"            }"},{"line_number":208,"context_line":"        if self.storage_info[\u0027protocol\u0027] \u003d\u003d \u0027iSCSI\u0027:"},{"line_number":209,"context_line":"            self.group_name_format \u003d {"},{"line_number":210,"context_line":"                \u0027group_name_max_len\u0027: _GROUP_NAME_MAX_LEN_ISCSI,"},{"line_number":211,"context_line":"                \u0027group_name_var_cnt\u0027: {"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f03eb84_cb4a8930","line":208,"range":{"start_line":208,"start_character":8,"end_line":208,"end_character":10},"updated":"2023-11-16 15:14:24.000000000","message":"\"elif\" here would help readability","commit_id":"61e7d1f83c0ca6bd821da0d8f398e4154868cdd7"}]}